> Lucas De Marchi wrote on 23.06.2015
19:02:03:
> > > > On Tue, Jun 23, 2015 at 1:45 PM,
wrote:
> > > > > Hello,
> > > > >
> > > > > Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16:
> > > > [...]
> > > >
Dear Lucas,
Lucas De Marchi wrote on 23.06.2015 19:02:03:
> On Tue, Jun 23, 2015 at 1:45 PM, wrote:
> > Hello,
> >
> > Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16:
> [...]
> > The result is not very encouraging: Out of five (identical) designware
Hello,
Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16:
> Mika Westerberg wrote on 10.06.
> 2015 09:07:22:
> > On Tue, Jun 09, 2015 at 03:29:01PM -0300, Lucas De Marchi wrote:
> > > Hi Mika,
> > >
> > > On Tue, Jun 9, 2015 at 5:51 AM, Mika Weste
Alexey Brodkin wrote on 03/09/2015 10:03:12
AM:
> From: Alexey Brodkin
> To: linux-i2c@vger.kernel.org,
> Cc: linux-ker...@vger.kernel.org, Alexey Brodkin
> , Vineet Gupta
> , Christian Ruppert
> , Mika Westerberg
> , Wolfram Sang ,
> Andy Shevchenko
> Date:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 2015-03-03 18:21, Wolfram Sang wrote:
>
>> which omit this type of messages completely. Andy's proposal of
>> centralising this looks like a very good solution here (and on
>> top of that removes many useless strings from the kernel
>> binary).
>
Hello Alexey,
Alexey Brodkin wrote on 03/03/2015 05:37:31
PM:
> From:
>
> Alexey Brodkin
>
> To:
>
> "christian.rupp...@alitech.com" ,
>
> Cc:
>
> "mika.westerb...@linux.intel.com" ,
> "linux-ker...@vger.kernel.org" ,
> "vineet.gup...@synopsys.com" , "wsa@the-
> dreams.de" , "andriy.she
DEFER.
>
> Signed-off-by: Alexey Brodkin
> Cc: Vineet Gupta
> Cc: Christian Ruppert
> Cc: Mika Westerberg
> Cc: Wolfram Sang
> ---
> drivers/i2c/busses/i2c-designware-platdrv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/driver
On Tue, Oct 07, 2014 at 12:35:29PM +, Vineet Gupta wrote:
> +CC Guenter Roeck
> [...]
> > However, the kernel-doc comment for init_machine in
> > mach_desc.h is now slightly confusing (still mentioning device tree).
>
> A platform of future can still call of_platform_populate() etc to reparse
Hi Vineet,
On Fri, Sep 26, 2014 at 09:20:20AM +0530, Vineet Gupta wrote:
> Hi Chrisitian,
>
> On Monday 22 September 2014 10:53 PM, Christian Ruppert wrote:
> > If there is no designware i2c in any of your platforms, simply ignore
> > my message. From my point of view the
ware i2c.
I checked that we're fine for TB10x (we need COMMON_CLK anyway) but
since you weren't in copy I just wanted to make sure that none of the
other ARC platforms (which don't seem to select COMMON_CLK) use
designware i2c and thus run into trouble.
If there is no designware i2c
t; > > config I2C_DESIGNWARE_PLATFORM
> > > tristate "Synopsys DesignWare Platform"
> > > + depends on COMMON_CLK
> >
> > ... do all previous users have COMMON_CLK?
>
> The driver is being used on x86, ARM and ARC it seems. For x86 and ARM
> w
On Sat, Aug 24, 2013 at 01:58:47PM +0900, Shinya Kuribayashi wrote:
> On 8/21/13 11:39 PM, Christian Ruppert wrote:
> >On Fri, Aug 16, 2013 at 11:15:12AM +0900, Shinya Kuribayashi wrote:
> >>On 8/5/13 6:31 PM, Christian Ruppert wrote:
> >>>On Wed, Jul 24, 20
On Fri, Aug 16, 2013 at 11:15:12AM +0900, Shinya Kuribayashi wrote:
> Hi,
>
> On 8/5/13 6:31 PM, Christian Ruppert wrote:> On Wed, Jul 24, 2013 at
> 11:31:44PM +0900, Shinya Kuribayashi wrote:
> >>As said before, all t_SCL things should go away. Please forget
> >&
On Mon, Aug 05, 2013 at 12:02:26PM +0200, Wolfram Sang wrote:
>
> > > >Would it make sense to add generic I2C device tree properties for those
> > > >parameters? These parameters are independent of the actual bus driver,
> > > >rather a PCB property... And as such the correct place would be device
On Wed, Jul 24, 2013 at 11:31:44PM +0900, Shinya Kuribayashi wrote:
> On 7/22/13 10:17 PM, Christian Ruppert wrote:> On Wed, Jul 17, 2013 at
> 11:39:58PM +0900, Shinya Kuribayashi wrote:
> >>On 7/16/13 8:16 PM, Christian Ruppert wrote:> On Sat, Jul 13, 2013 at
> &g
On Wed, Jul 17, 2013 at 11:39:58PM +0900, Shinya Kuribayashi wrote:
> On 7/16/13 8:16 PM, Christian Ruppert wrote:> On Sat, Jul 13, 2013 at
> 02:36:43PM +0900, Shinya Kuribayashi wrote:
> >>Basically, DW I2C core provides a good enough (and quite direct) way
> >>to co
rolled by SCL_HCNT whereas (2) is controlled by SDA_HOLD_TIME.
_
scl \__ ...
___ __
sda \_/ ...
|-|---|
(1) (2)
> On Wed, Jul 10, 2013 at 06:56:35PM +0200, Christian Ruppert wrote:
> >>I
On Wed, Jul 10, 2013 at 01:52:15PM +0300, Mika Westerberg wrote:
> On Tue, Jul 09, 2013 at 06:19:28PM +0200, Christian Ruppert wrote:
> > What I meant is the following: The clock cycle time Tc is composed of
> > the four components
> >
> > Tc = Th + Tf + Tl + Tr
&g
On Tue, Jul 09, 2013 at 11:44:02AM +0300, Mika Westerberg wrote:
> On Mon, Jul 08, 2013 at 03:42:17PM +0200, Christian Ruppert wrote:
> > On Mon, Jul 08, 2013 at 02:45:26PM +0300, Mika Westerberg wrote:
> > > The DesignWare I2C controller has high count (HCNT) and low count (LCN
*/
> struct dw_i2c_dev {
> struct device *dev;
> @@ -91,6 +99,10 @@ struct dw_i2c_dev {
> unsigned intrx_fifo_depth;
> int rx_outstanding;
> u32 sda_hold_time;
> + u16 ss_hcnt;
&g
On Wed, Jul 03, 2013 at 04:44:09PM +0200, Arnd Bergmann wrote:
> On Wednesday 03 July 2013, Christian Ruppert wrote:
> > On Wed, Jul 03, 2013 at 04:20:03PM +0200, Arnd Bergmann wrote:
> > > On Wednesday 03 July 2013, Christian Ruppert wrote:
> > > > On Wed, Jul 03,
On Wed, Jul 03, 2013 at 04:20:03PM +0200, Arnd Bergmann wrote:
> On Wednesday 03 July 2013, Christian Ruppert wrote:
> > On Wed, Jul 03, 2013 at 01:43:11PM +0200, Arnd Bergmann wrote:
> > > On Wednesday 26 June 2013, Wolfram Sang wrote:
> > > > On Wed, Jun 26, 2013
On Wed, Jul 03, 2013 at 01:43:11PM +0200, Arnd Bergmann wrote:
> On Wednesday 26 June 2013, Wolfram Sang wrote:
> > On Wed, Jun 26, 2013 at 10:55:06AM +0200, Christian Ruppert wrote:
> > > This patch makes the SDA hold time configurable through device tree.
> > >
>
good. I also tested it on our ARC based platform, no issues with
compilation or functionality. Thanks for pointing this out.
Reviewed-by: Christian Ruppert
> Signed-off-by: Vincent Stehlé
> Cc: Wolfram Sang
> Cc: Christian Ruppert
> Cc: Pierrick Hascoet
> ---
>
>
>
This patch makes the SDA hold time configurable through device tree.
Signed-off-by: Christian Ruppert
Signed-off-by: Pierrick Hascoet
---
.../devicetree/bindings/i2c/i2c-designware.txt | 15 +++
arch/arc/boot/dts/abilis_tb100_dvk.dts | 10 +-
arch/arc
This patch makes the SDA hold time configurable through device tree.
Signed-off-by: Christian Ruppert
Signed-off-by: Pierrick Hascoet
---
.../devicetree/bindings/i2c/i2c-designware.txt | 14 ++
arch/arc/boot/dts/abilis_tb100_dvk.dts | 10 +-
arch/arc
tion
of three factors:
. Drive strength
. Bus load (Fan out)
. Internal timings of all devices on the bus (setup/hold times etc.)
This applies to ASIC internal timing. My PCB experience is quite limited
and I'm not sure if this can be applied as such. That said, the I2C
specification does
On Wed, Jun 19, 2013 at 11:45:40AM +0200, Wolfram Sang wrote:
> Hi,
>
> On Wed, Jun 12, 2013 at 04:47:45PM +0200, Christian Ruppert wrote:
> > On Mon, Jun 10, 2013 at 05:29:55PM +0200, Wolfram Sang wrote:
> > > On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert w
This patch makes the SDA hold time configurable through device tree.
Signed-off-by: Christian Ruppert
Signed-off-by: Pierrick Hascoet
---
.../devicetree/bindings/i2c/i2c-designware.txt | 14 ++
arch/arc/boot/dts/abilis_tb100_dvk.dts | 10 +-
arch/arc
On Mon, Jun 17, 2013 at 10:33:36AM +0200, Jean Delvare wrote:
> On Mon, 17 Jun 2013 10:19:33 +0200, Christian Ruppert wrote:
> > On Fri, Jun 14, 2013 at 04:37:41PM +0200, Wolfram Sang wrote:
> > > BTW since I am currently here: i2c-designware-core should be in the
> >
On Fri, Jun 14, 2013 at 04:37:41PM +0200, Wolfram Sang wrote:
> On Fri, Jun 07, 2013 at 10:51:23AM +0200, Christian Ruppert wrote:
> [...]
> > + /*
> > +* We must disable the adapter before unlocking the &dev->lock mutex
> > +* below. Otherwise the har
On Thu, Jun 13, 2013 at 11:33:56AM +0300, Andy Shevchenko wrote:
> On Thu, 2013-06-13 at 10:16 +0200, Christian Ruppert wrote:
> > As promised, I gave this one some over-night stress testing and I can
> > confirm what I said previously:
> >
> > - The patch does _no
Mika's patch). Under this condition you can assume
Tested-By: Christian Ruppert
I still think the code is more logical with this patch than without it
and I am in favour of applying both (if Andy agrees that is). We must
keep in mind, however, that http://patchwork.ozlabs.org/patch/249622
does
On Mon, Jun 10, 2013 at 05:29:55PM +0200, Wolfram Sang wrote:
> On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert wrote:
> > This patch makes the SDA hold time configurable through device tree.
> >
> > [rebased to i2c-current/i2c-next/mainline-3.10-rc1]
> >
&
On Tue, Jun 11, 2013 at 08:40:37PM +0200, Wolfram Sang wrote:
> On Fri, Jun 07, 2013 at 03:01:34PM +0200, Christian Ruppert wrote:
> > Hi Andy,
> >
> > I like your patch and I just did some testing on it. Unluckily, it
> > doesn't solve the lock-up problem.
>
= 0;
> dev->rx_outstanding = 0;
>
> - ret = i2c_dw_wait_bus_not_busy(dev);
> - if (ret < 0)
> - goto done;
> -
> /* start the transfers */
> i2c_dw_xfer_init(dev);
>
> --
> 1.8.2.rc0.22.gb3600c3
>
--
Christian
_timeout() in the designware I2C driver.
>
> Signed-off-by: Mika Westerberg
Reviewed-by: Christian Ruppert
>
> ---
> drivers/i2c/busses/i2c-designware-core.c |5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designw
601241/ to be
applied first.
Signed-off-by: Christian Ruppert
---
drivers/i2c/busses/i2c-designware-core.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-core.c
b/drivers/i2c/busses/i2c-designware-core.c
index b75d292..55a9991
On Fri, Jun 07, 2013 at 08:23:53AM +0300, Mika Westerberg wrote:
> Hi Christian,
>
> On Thu, Jun 06, 2013 at 03:43:35PM +0200, Christian Ruppert wrote:
> > The designware block is not always properly disabled in the case of
> > transfer errors. Interrupts from aborted trans
On Fri, Jun 07, 2013 at 08:25:55AM +0300, Mika Westerberg wrote:
> On Thu, Jun 06, 2013 at 03:43:36PM +0200, Christian Ruppert wrote:
> > When the process at the source of an i2c transfer is killed in the
> > middle of the transfer, the transfer is interrupted. Interrupted
>
initiating process is killed.
Signed-off-by: Christian Ruppert
---
drivers/i2c/busses/i2c-designware-core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-core.c
b/drivers/i2c/busses/i2c-designware-core.c
index 65c0c7a..d903368 100644
--- a
the system is stuck in an infinite interrupt loop (where
FIFOs are never emptied).
This patch cleanly disables the designware-i2c hardware at the end of
every transfer, successful or not.
Signed-off-by: Christian Ruppert
---
drivers/i2c/busses/i2c-designware-core.c | 14 +++---
1 files
This patch makes the SDA hold time configurable through device tree.
[rebased to i2c-current/i2c-next/mainline-3.10-rc1]
Signed-off-by: Christian Ruppert
Signed-off-by: Pierrick Hascoet
---
.../devicetree/bindings/i2c/i2c-designware.txt | 14 ++
drivers/i2c/busses/i2c
Looks like this was eaten by the spam filter last time so i'm resending
it to the lists only:
This patch makes the SDA hold time configurable through device tree.
Signed-off-by: Christian Ruppert
Signed-off-by: Pierrick Hascoet
---
.../devicetree/bindings/i2c/i2c-designware.txt |
by i2c/next.
Signed-off-by: Christian Ruppert
Signed-off-by: Pierrick Hascoet
---
.../devicetree/bindings/i2c/i2c-designware.txt | 15 +++
drivers/i2c/busses/i2c-designware-core.c |5 +
drivers/i2c/busses/i2c-designware-core.h |1 +
drivers/i2c
by i2c/next.
Signed-off-by: Christian Ruppert
Signed-off-by: Pierrick Hascoet
---
.../devicetree/bindings/i2c/i2c-designware.txt | 15 +++
drivers/i2c/busses/i2c-designware-core.c |5 +
drivers/i2c/busses/i2c-designware-core.h |1 +
drivers/i2c
On Fri, Feb 15, 2013 at 01:50:37PM +0200, Mika Westerberg wrote:
> On Fri, Feb 15, 2013 at 11:11:50AM +0100, Christian Ruppert wrote:
> > This patch implements interrupt sharing and SDA hold time configuration in
> > the designware i2c driver. Both functions are enabled throug
-baseline).
Signed-off-by: Christian Ruppert
Signed-off-by: Pierrick Hascoet
---
.../devicetree/bindings/i2c/i2c-designware.txt | 18 ++
drivers/i2c/busses/i2c-designware-core.c |6 +++
drivers/i2c/busses/i2c-designware-core.h |2 +
drivers/i2c/busses/i2c
48 matches
Mail list logo
