Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-08-18 Thread Wolfram Sang
On Mon, Aug 06, 2012 at 05:28:44PM -0700, Kevin Hilman wrote: > Hi Wolfram, > > Kevin Hilman writes: > > > In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on > > failure. > > > > Without this, after a failed xfer, the runtime PM usecount will have > > been incremented, but not decrem

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-08-06 Thread Kevin Hilman
Hi Wolfram, Kevin Hilman writes: > In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on > failure. > > Without this, after a failed xfer, the runtime PM usecount will have > been incremented, but not decremented causing the usecount to never > reach zero after a failure. This keeps th

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-06-28 Thread Shubhrajyoti
On Friday 29 June 2012 03:25 AM, Kevin Hilman wrote: > Hi Shubhrajyoti, > > Shubhrajyoti Datta writes: > >> Hi Kevin, >> Thanks for the patch , >> a doubt below > Thanks for the review. > >> On Wed, Jun 27, 2012 at 7:15 AM, Kevin Hilman wrote: >>> In omap_i2c_xfer(), ensure pm_runtime_put() is ca

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-06-28 Thread Kevin Hilman
Hi Shubhrajyoti, Shubhrajyoti Datta writes: > Hi Kevin, > Thanks for the patch , > a doubt below Thanks for the review. > On Wed, Jun 27, 2012 at 7:15 AM, Kevin Hilman wrote: >> In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on >> failure. > So the failure means that the usecount

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-06-26 Thread Shubhrajyoti Datta
Hi Kevin, Thanks for the patch , a doubt below On Wed, Jun 27, 2012 at 7:15 AM, Kevin Hilman wrote: > In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on > failure. So the failure means that the usecount is incremented. However the device was not enabled. In that case could we consider

[PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-06-26 Thread Kevin Hilman
In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on failure. Without this, after a failed xfer, the runtime PM usecount will have been incremented, but not decremented causing the usecount to never reach zero after a failure. This keeps the device always runtime PM enabled which keeps