Re: [PATCH] i2c: boilerplate function for byte swapped smbus_write/read_word_data

2011-10-21 Thread Jonathan Cameron
On 10/11/11 16:21, Jonathan Cameron wrote: On 10/11/11 12:49, Jean Delvare wrote: On Mon, 10 Oct 2011 13:50:14 +0200, Jean Delvare wrote: On Mon, 10 Oct 2011 10:07:43 +0100, Jonathan Cameron wrote: Reimplemented at least 17 times discounting error mangling cases where it could be used.

Re: [PATCH] i2c: boilerplate function for byte swapped smbus_write/read_word_data

2011-10-11 Thread Jean Delvare
On Mon, 10 Oct 2011 13:50:14 +0200, Jean Delvare wrote: On Mon, 10 Oct 2011 10:07:43 +0100, Jonathan Cameron wrote: Reimplemented at least 17 times discounting error mangling cases where it could be used. Signed-off-by: Jonathan Cameron ji...@cam.ac.uk ---

Re: [PATCH] i2c: boilerplate function for byte swapped smbus_write/read_word_data

2011-10-11 Thread Jonathan Cameron
On 10/11/11 12:49, Jean Delvare wrote: On Mon, 10 Oct 2011 13:50:14 +0200, Jean Delvare wrote: On Mon, 10 Oct 2011 10:07:43 +0100, Jonathan Cameron wrote: Reimplemented at least 17 times discounting error mangling cases where it could be used. Signed-off-by: Jonathan Cameron ji...@cam.ac.uk

[PATCH] i2c: boilerplate function for byte swapped smbus_write/read_word_data

2011-10-10 Thread Jonathan Cameron
Reimplemented at least 17 times discounting error mangling cases where it could be used. Signed-off-by: Jonathan Cameron ji...@cam.ac.uk --- Documentation/i2c/smbus-protocol |8 include/linux/i2c.h | 17 + 2 files changed, 25 insertions(+), 0

Re: [PATCH] i2c: boilerplate function for byte swapped smbus_write/read_word_data

2011-10-10 Thread Jean Delvare
On Mon, 10 Oct 2011 10:07:43 +0100, Jonathan Cameron wrote: Reimplemented at least 17 times discounting error mangling cases where it could be used. Signed-off-by: Jonathan Cameron ji...@cam.ac.uk --- Documentation/i2c/smbus-protocol |8 include/linux/i2c.h |

Re: [PATCH] i2c: boilerplate function for byte swapped smbus_write/read_word_data

2011-10-09 Thread Jean Delvare
On Sat, 8 Oct 2011 23:10:05 +0200, Jean Delvare wrote: On Thu, 22 Sep 2011 14:48:14 +0100, Jonathan Cameron wrote: @@ -88,6 +89,23 @@ extern s32 i2c_smbus_read_word_data(const struct i2c_client *client, u8 command); extern s32

Re: [PATCH] i2c: boilerplate function for byte swapped smbus_write/read_word_data

2011-10-08 Thread Jean Delvare
Hi Jonathan, On Thu, 22 Sep 2011 14:48:14 +0100, Jonathan Cameron wrote: Reimplemented at least 17 times discounting error mangling cases where it could be used. Signed-off-by: Jonathan Cameron ji...@cam.ac.uk --- Hi All, Quite a number of devices rather unhelpfully handle smbus

Re: [PATCH] i2c: boilerplate function for byte swapped smbus_write/read_word_data

2011-10-04 Thread Jonathan Cameron
On 09/22/11 14:48, Jonathan Cameron wrote: Reimplemented at least 17 times discounting error mangling cases where it could be used. Anyone care to comment? Signed-off-by: Jonathan Cameron ji...@cam.ac.uk --- Hi All, Quite a number of devices rather unhelpfully handle smbus read/write

Re: [PATCH] i2c: boilerplate function for byte swapped smbus_write/read_word_data

2011-10-04 Thread Jean Delvare
Hi Jonathan, On Tue, 04 Oct 2011 17:37:11 +0100, Jonathan Cameron wrote: On 09/22/11 14:48, Jonathan Cameron wrote: Reimplemented at least 17 times discounting error mangling cases where it could be used. Anyone care to comment? I will. I started reviewing your patch and pondering its

[PATCH] i2c: boilerplate function for byte swapped smbus_write/read_word_data

2011-09-22 Thread Jonathan Cameron
Reimplemented at least 17 times discounting error mangling cases where it could be used. Signed-off-by: Jonathan Cameron ji...@cam.ac.uk --- Hi All, Quite a number of devices rather unhelpfully handle smbus read/write word commands but return the result byte swapped. Hence drivers swap it back