Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-05-11 Thread Jarkko Nikula
On Tue, 11 May 2010 10:01:22 +0300 Mika Westerberg wrote: > I believe this is already in mainline: > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7c6bd2010fced38444c9fd658f4c6ce61bd185bf > Ah, yeah. I was using the sound-2.6.git tree which is not yet updated any

Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-05-11 Thread Mika Westerberg
On Tue, May 11, 2010 at 08:54:07AM +0200, ext Jarkko Nikula wrote: > On Fri, 16 Apr 2010 12:47:50 +0300 > Grazvydas Ignotas wrote: > > > >> Tested-by: Paul Walmsley > > Uhm why does this patch (or Tony's version) doesn't reach mainline for > > so long? It's critical for all OMAPs except the very

Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-05-10 Thread Jarkko Nikula
On Fri, 16 Apr 2010 12:47:50 +0300 Grazvydas Ignotas wrote: > >> Tested-by: Paul Walmsley > Uhm why does this patch (or Tony's version) doesn't reach mainline for > so long? It's critical for all OMAPs except the very old ones. > > If it helps: > Tested-by: Grazvydas Ignotas > > > Tested-by:

Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-04-16 Thread Grazvydas Ignotas
On Wed, Mar 31, 2010 at 3:27 PM, Jarkko Nikula wrote: > On Wed, 31 Mar 2010 04:27:41 -0600 (MDT) > Paul Walmsley wrote: > >> > This patch moves register shift setting before any register accesses are >> > done. >> > >> > Signed-off-by: Mika Westerberg >> > Cc: Cory Maccarrone >> >> Tested-by:

Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-03-31 Thread Jarkko Nikula
On Wed, 31 Mar 2010 04:27:41 -0600 (MDT) Paul Walmsley wrote: > > This patch moves register shift setting before any register accesses are > > done. > > > > Signed-off-by: Mika Westerberg > > Cc: Cory Maccarrone > > Tested-by: Paul Walmsley > BTW, Tony had the same fix buried in an another

Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-03-31 Thread Paul Walmsley
Hi Mika, Ben, On Tue, 23 Mar 2010, Mika Westerberg wrote: > Commit d84d3ea317ce0db89ce0903b4037f800c5d4c477 added register shift to allow > also 16-bit register access. However, omap_i2c_unidle() is called before these > are set which causes the following OOPS: > > Unhandled fault: alignment

[PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-03-23 Thread Mika Westerberg
Commit d84d3ea317ce0db89ce0903b4037f800c5d4c477 added register shift to allow also 16-bit register access. However, omap_i2c_unidle() is called before these are set which causes the following OOPS: Unhandled fault: alignment exception (0x801) at 0xfa070009 Internal error: : 801 [#1] la