Re: [PATCH] i2c: sirf: get the i2c pin group by pinctrl api

2013-03-27 Thread Linus Walleij
On Wed, Mar 27, 2013 at 11:36 AM, Barry Song <21cn...@gmail.com> wrote: > 2013/3/27 Linus Walleij : >> You only need to fetch pinctrl handles in drivers if you're >> using anything else than the default state. > > well. missed this recent commit. > it should mean we hould drop all devm_pinctrl_get

Re: [PATCH] i2c: sirf: get the i2c pin group by pinctrl api

2013-03-27 Thread Barry Song
2013/3/27 Linus Walleij : > On Mon, Mar 18, 2013 at 8:22 AM, Barry Song wrote: > >> From: Barry Song >> >> hardcode set i2c pin group to i2c function before, here we >> move to use standard pinctrl API to get pins of the group. >> >> Signed-off-by: Barry Song >> Cc: Linus Walleij > > NAK. > > T

Re: [PATCH] i2c: sirf: get the i2c pin group by pinctrl api

2013-03-27 Thread Linus Walleij
On Mon, Mar 18, 2013 at 8:22 AM, Barry Song wrote: > From: Barry Song > > hardcode set i2c pin group to i2c function before, here we > move to use standard pinctrl API to get pins of the group. > > Signed-off-by: Barry Song > Cc: Linus Walleij NAK. This is done by the device core as of commi

Re: [PATCH] i2c: sirf: get the i2c pin group by pinctrl api

2013-03-18 Thread Barry Song
2013/3/18 Sourav Poddar : > Hi, > > On Monday 18 March 2013 01:53 PM, Barry Song wrote: >> >> 2013/3/18 Sourav Poddar: >>> >>> Hi, >>> >>> On Monday 18 March 2013 12:52 PM, Barry Song wrote: From: Barry Song hardcode set i2c pin group to i2c function before, here we move to

Re: [PATCH] i2c: sirf: get the i2c pin group by pinctrl api

2013-03-18 Thread Sourav Poddar
Hi, On Monday 18 March 2013 01:53 PM, Barry Song wrote: 2013/3/18 Sourav Poddar: Hi, On Monday 18 March 2013 12:52 PM, Barry Song wrote: From: Barry Song hardcode set i2c pin group to i2c function before, here we move to use standard pinctrl API to get pins of the group. Signed-off-by: Barry

Re: [PATCH] i2c: sirf: get the i2c pin group by pinctrl api

2013-03-18 Thread Barry Song
2013/3/18 Sourav Poddar : > Hi, > > On Monday 18 March 2013 12:52 PM, Barry Song wrote: >> >> From: Barry Song >> >> hardcode set i2c pin group to i2c function before, here we >> move to use standard pinctrl API to get pins of the group. >> >> Signed-off-by: Barry Song >> Cc: Linus Walleij >> --- >

Re: [PATCH] i2c: sirf: get the i2c pin group by pinctrl api

2013-03-18 Thread Sourav Poddar
Hi, On Monday 18 March 2013 12:52 PM, Barry Song wrote: From: Barry Song hardcode set i2c pin group to i2c function before, here we move to use standard pinctrl API to get pins of the group. Signed-off-by: Barry Song Cc: Linus Walleij --- drivers/i2c/busses/i2c-sirf.c |9 + 1 fil

[PATCH] i2c: sirf: get the i2c pin group by pinctrl api

2013-03-18 Thread Barry Song
From: Barry Song hardcode set i2c pin group to i2c function before, here we move to use standard pinctrl API to get pins of the group. Signed-off-by: Barry Song Cc: Linus Walleij --- drivers/i2c/busses/i2c-sirf.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a