Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-13 Thread Ulf Hansson
On 10 February 2014 11:14, Ulf Hansson ulf.hans...@linaro.org wrote: On 5 February 2014 15:34, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson ulf.hans...@linaro.org wrote: Since the device is active while a successful probe has been completed, the

Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-10 Thread Ulf Hansson
On 5 February 2014 15:34, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson ulf.hans...@linaro.org wrote: Since the device is active while a successful probe has been completed, the reference counting for the clock will be screwed up and never reach

Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-10 Thread Ulf Hansson
On 5 February 2014 15:45, Fabio Estevam feste...@gmail.com wrote: On Tue, Feb 4, 2014 at 1:58 PM, Ulf Hansson ulf.hans...@linaro.org wrote: +static int nmk_i2c_runtime_resume(struct device *dev) +{ + struct amba_device *adev = to_amba_device(dev);, + struct nmk_i2c_dev *nmk_i2c =

Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-05 Thread Linus Walleij
On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson ulf.hans...@linaro.org wrote: Since the device is active while a successful probe has been completed, the reference counting for the clock will be screwed up and never reach zero. The issue is resolved by implementing runtime PM callbacks and let

Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-05 Thread Fabio Estevam
On Tue, Feb 4, 2014 at 1:58 PM, Ulf Hansson ulf.hans...@linaro.org wrote: +static int nmk_i2c_runtime_resume(struct device *dev) +{ + struct amba_device *adev = to_amba_device(dev);, + struct nmk_i2c_dev *nmk_i2c = amba_get_drvdata(adev); + +

[PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-04 Thread Ulf Hansson
Since the device is active while a successful probe has been completed, the reference counting for the clock will be screwed up and never reach zero. The issue is resolved by implementing runtime PM callbacks and let them handle the resources accordingly, including the clock. Cc: Alessandro