Re: [RFC] i2c-algo-bit: Disable interrupts while SCL is high

2011-11-03 Thread Jean Delvare
Hi Michael, Ben, On Fri, 17 Dec 2010 13:09:54 +0100, Michael Lawnick wrote: Jean Delvare said the following: Hi Ben, On Thu, 16 Dec 2010 16:00:46 +, Ben Dooks wrote: On Thu, Dec 16, 2010 at 03:06:38PM +0100, Jean Delvare wrote: Add a spinlock to every user of i2c-algo-bit, which

Antw: Re: [RFC] i2c-algo-bit: Disable interrupts while SCL is high

2011-01-11 Thread Matthias Zacharias
Hi Jean, Sorry for the late answer I was in christmas holidays. Jean Delvare kh...@linux-fr.org schrieb am Samstag, 18. Dezember 2010 um 00:09 in Nachricht 20101218000924.546ad...@endymion.delvare: Hi Michael, On Fri, 17 Dec 2010 13:09:54 +0100, Michael Lawnick wrote: Jean Delvare said the

Re: [RFC] i2c-algo-bit: Disable interrupts while SCL is high

2010-12-20 Thread Jean Delvare
Michael, On Mon, 20 Dec 2010 08:24:07 +0100, Michael Lawnick wrote: Jean Delvare said the following: Hi Michael, On Fri, 17 Dec 2010 13:09:54 +0100, Michael Lawnick wrote: Sorry to disturb, but MANTRA Disabling interrupts may be done only for a few instructions./MANTRA Even

Re: [RFC] i2c-algo-bit: Disable interrupts while SCL is high

2010-12-19 Thread Michael Lawnick
Jean Delvare said the following: Hi Michael, On Fri, 17 Dec 2010 13:09:54 +0100, Michael Lawnick wrote: Sorry to disturb, but MANTRA Disabling interrupts may be done only for a few instructions./MANTRA Even 1 us is an eternity on modern systems. Don't be sorry, this is exactly

Re: [RFC] i2c-algo-bit: Disable interrupts while SCL is high

2010-12-17 Thread Michael Lawnick
Jean Delvare said the following: Hi Ben, On Thu, 16 Dec 2010 16:00:46 +, Ben Dooks wrote: On Thu, Dec 16, 2010 at 03:06:38PM +0100, Jean Delvare wrote: Add a spinlock to every user of i2c-algo-bit, which is taken before raising SCL and released after lowering SCL. We don't really need

Re: [RFC] i2c-algo-bit: Disable interrupts while SCL is high

2010-12-17 Thread Jean Delvare
Hi Michael, On Fri, 17 Dec 2010 13:09:54 +0100, Michael Lawnick wrote: Jean Delvare said the following: Hi Ben, On Thu, 16 Dec 2010 16:00:46 +, Ben Dooks wrote: On Thu, Dec 16, 2010 at 03:06:38PM +0100, Jean Delvare wrote: Add a spinlock to every user of i2c-algo-bit, which is

[RFC] i2c-algo-bit: Disable interrupts while SCL is high

2010-12-16 Thread Jean Delvare
Add a spinlock to every user of i2c-algo-bit, which is taken before raising SCL and released after lowering SCL. We don't really need the exclusion functionality, but we have to disable local interrupts. This is needed to comply with SMBus requirements that SCL shouldn't be high for longer than 50

Re: [RFC] i2c-algo-bit: Disable interrupts while SCL is high

2010-12-16 Thread Ben Dooks
On Thu, Dec 16, 2010 at 03:06:38PM +0100, Jean Delvare wrote: Add a spinlock to every user of i2c-algo-bit, which is taken before raising SCL and released after lowering SCL. We don't really need the exclusion functionality, but we have to disable local interrupts. This is needed to comply