On Saturday 02 February 2008, Jeff Garzik wrote:
> Linux Kernel Mailing List wrote:
> > Commit: 0948391641918b95d8d96c15089eb5ac156850b3
>
> > PCI: Remove users of pci_enable_device_bars()
> >
> > This patch converts users of pci_enable_device_bars() to the new
> > pci_enable_
Cc: Borislav Petkov <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
goes before "ide-tape: remove IDETAPE_DEBUG_INFO" patch in IDE quilt tree
drivers/ide/ide-tape.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
SELECT_DRIVE() is called by IDE core code in start_request() before device
driver's ->do_request method. In ide-scsi case ->do_request is implemented
by idescsi_do_request() which is also the only user of idescsi_issue_pc().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTEC
in ->io_ports[IDE_IRQ_OFFSET]).
q40ide.c:
* Fix q40_ide_setup_ports() comments.
ide.c:
* Remove no longer needed ide_setup_ports().
Cc: Mikael Starvik <[EMAIL PROTECTED]>
Cc: Geert Uytterhoeven <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
dri
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-cd.c |2 +-
drivers/ide/ide-floppy.c |2 +-
drivers/ide/ide-io.c |4 ++--
drivers/ide/ide-iops.c |4 +++-
drivers/ide/ide-lib.c |2 +-
drivers/ide/ide-tape.c
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/arm/icside.c |2 -
drivers/ide/ide-cd.c |7 +++---
drivers/ide/ide-dma.c |3 +-
drivers/ide/ide-floppy.c |4 +--
drivers/ide/ide-io.c | 12 +--
drivers/ide/ide-
* Remove write-only ->sata_misc[] from ide_hwif_t.
* Remove no longer used SATA_{MISC,PHY,IEN}_OFFSET defines.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/siimage.c |3 ---
include/linux/ide.h |5 -
2 files changed, 8 deletions(
Same BUG_ON() is present inside ide_set_handler().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-iops.c |2 --
1 file changed, 2 deletions(-)
Index: b/drivers/ide/ide-iops.c
===
--- a/d
Hi,
On Friday 25 January 2008, Anton Salnikov wrote:
> This is Palmchip BK3710 IDE controller support for kernel version 2.6.24.
> The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes.
> Supports interface to compact Flash (CF) configured in True-IDE mode.
Unfortunately some
Hi,
On Monday 28 January 2008, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Remove 'struct pci_dev *dev' argument from ide_hwif_setup_dma().
>
> > * Un-static ide_hwif_setup_dma() and add CONFIG_BLK_DEV_IDEDMA_PCI=n
&g
On Wednesday 30 January 2008, Adrian Bunk wrote:
> This patch fixes the following section mismatch:
>
> <-- snip -->
>
> ...
> WARNING: vmlinux.o(.text+0x3b641c): Section mismatch in reference from the
> function .pmac_ide_setup_device() to the function
> .init.text:.pmac_ide_setup_dma()
> ..
On Monday 28 January 2008, Adrian Bunk wrote:
> After commit 7267c3377443322588cddaf457cf106839a60463
> wait_drive_not_busy() can become static again.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of
On Thursday 31 January 2008, Jens Axboe wrote:
> On Thu, Jan 31 2008, Florian Lohoff wrote:
> > On Thu, Jan 31, 2008 at 02:05:58PM +0100, Jens Axboe wrote:
> > > The below fix should be enough. It's perfectly legal to have leftover
> > > byte counts when the drive signals completion, happens all th
On Sunday 27 January 2008, Frans Pop wrote:
> On Saturday 26 January 2008, Bartlomiej Zolnierkiewicz wrote:
> > On Saturday 26 January 2008, Jan Engelhardt wrote:
> > > On Jan 26 2008 21:31, Frans Pop wrote:
> > > >> config BLK_DEV_IDE_PMAC
> > > >
On Monday 28 January 2008, Adrian Bunk wrote:
> - ide_scan_pcibus() can become static
> - instead of ide_scan_pci() we can use ide_scan_pcibus() directly
> in module_init()
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe lin
On Monday 28 January 2008, Adrian Bunk wrote:
> ide_dma_on can be unexported.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.
On Feb 1, 2008 6:28 PM, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Tejun Heo wrote:
> > This patch implements libata.force module parameter which can
> > selectively override ATA port, link and device configurations
> > including cable type, SATA PHY SPD limit, transfer mode and NCQ.
> >
> > For exam
On Monday 28 January 2008, Borislav Petkov wrote:
> Hi Bart,
>
> [...]
>
> > > the BKL in idetape_write_release() with finer-grained locking etc,
> > > probably also
> > > some pipeline improvements, removal of OnStream support, etc. but that'll
> > > come
> > > later.
> >
> > On-Stream suppor
On Sunday 27 January 2008, Bartlomiej Zolnierkiewicz wrote:
> BTW what happend to patch #23?
my bad, the patch got eaten by gmail's spam filter...
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More major
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <[EMAIL PROTECTED]>
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
> ---
> drivers/ide/ide-tape.c | 60 ---
> 1 files changed, 31 insertions(+), 29 deletions(-)
>
> dif
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <[EMAIL PROTECTED]>
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
> ---
> drivers/ide/ide-tape.c | 88 ---
> 1 files changed, 45 insertions(+), 43 deletions(-)
>
> dif
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <[EMAIL PROTECTED]>
>
> tape->speed_ctl is set to 1 in idetape_setup(), but, in calculate_speeds() its
> value is tested for being 0, 1, or 2. Remove the if-branches where
> tape->speed_ctl != 1 since they are never executed
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <[EMAIL PROTECTED]>
>
> There should be no functional changes resulting from this patch.
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
> ---
> drivers/ide/ide-tape.c | 49 +---
Hi,
On Sunday 27 January 2008, Borislav Petkov wrote:
> Hi Bart,
>
> after a lot of hammering ide-tape got pimped pretty considerably (ca. 600
> lines
> shorter and slicker :)). I'm sure there's more to be done like, e.g. replacing
Good work. :)
> the BKL in idetape_write_release() with finer
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <[EMAIL PROTECTED]>
>
> ... by adding a new typedef function pointer idetape_io_buf in order to call
> the proper buffer i/o handler depending on the data direction.
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
>
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <[EMAIL PROTECTED]>
>
> Since this is used only in idetape_blkdev_ioctl(), remove the typedef and make
> the struct function-local.
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
applied
> ---
> drivers/ide/ide-t
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <[EMAIL PROTECTED]>
>
> All those 2-byte values denoting the different capabilities are being written
> to
> the local copy of the caps buffer without being converted to big endian for
> simplicity of usage and shorter code
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <[EMAIL PROTECTED]>
>
> Those are already in mtio.h.
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
applied
> ---
> drivers/ide/ide-tape.c | 96 +++
> 1 files changed
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <[EMAIL PROTECTED]>
>
> Teach the debug logging macro to differentiate different log levels based on
> the
> type of debug level enabled specifically instead of a threshold-based one.
> Thus, convert tape->debug_level to a
On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <[EMAIL PROTECTED]>
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
applied
> ---
> drivers/ide/ide-tape.c | 42 ++
> 1 files changed, 2 insertions(+), 40 deletions(-)
>
>
On Sunday 27 January 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
applied with some changes
> ---
> drivers/ide/ide-tape.c | 40 +++-
> 1 files changed, 15 insertions(+), 25 deletions(-)
[...]
> @@ -3977,7 +3968,8 @@ st
On Sunday 27 January 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
> ---
> drivers/ide/ide-tape.c | 83 +++
> 1 files changed, 27 insertions(+), 56 deletions(-)
applied with minor changes
> diff --git a/drivers/ide
On Sunday 27 January 2008, Borislav Petkov wrote:
> Also, cleanup whitespace and update comments.
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
applied with some changes
> ---
> Documentation/ide/ChangeLog.ide-tape.1995-2002 | 405 +++
> drivers/ide/ide-tape.c
On Saturday 26 January 2008, Jan Engelhardt wrote:
>
> On Jan 26 2008 21:31, Frans Pop wrote:
> >> config BLK_DEV_IDE_PMAC
> >> - bool "Builtin PowerMac IDE support"
> >> + tristate "Builtin PowerMac IDE support"
this change is no-op at the moment because the next Kconfig line is:
Hi,
On Friday 04 January 2008, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Make remaining built-in only IDE host drivers modular, add ide-scan-pci.c
> > file for probing PCI host drivers registered with IDE core (special case
> >
On Thursday 24 January 2008, Aristeu Rozanski wrote:
> Currently it's possible to ide-cd to set an incorrect blocksize by
> reading garbage if the drive is dead:
>
> ide_cd_probe()
> -> cdrom_read_toc()
> -> cdrom_read_capacity()
> -> cdrom_queue_packet_command()
> -> i
On Wednesday 23 January 2008, Benjamin Herrenschmidt wrote:
>
> On Wed, 2008-01-23 at 01:58 +0100, Bartlomiej Zolnierkiewicz wrote:
> > I'm more worried about breaking automatic build checking (make randconfig)
> > than a few extra bytes so if you remove all #ifdefs you
Hi,
On Wednesday 23 January 2008, Benjamin Herrenschmidt wrote:
>
> On Wed, 2008-01-23 at 00:12 +0100, Bartlomiej Zolnierkiewicz wrote:
> > * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef in
> > check_media_bay() by CONFIG_MAC_FLOPPY one.
> >
> > * Replace incorre
is defined.
* check_media_bay_by_base() and media_bay_set_ide_infos()
are used only by drivers/ide/ppc/pmac.c so so make these
functions available only if CONFIG_MAC_FLOPPY is defined.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
Ben, IMO this patch is safe for
No reason to use ide_init_hwif_ports() in ide-cs (as a nice side-effect
this makes ide-cs work on archs that don't define IDE_ARCH_OBSOLETE_INIT).
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/legacy/ide-cs.c |2 +-
1 file changed, 1 insertion(+),
On Monday 21 January 2008, Tejun Heo wrote:
[...]
> > Old IDE says it works for PATA. For SATA I can see it might need more
> > care and you might simply not be able to get the info.
>
> Old IDE often locks up the machine hard after timeouts. I'm all for
Could you point me to some bugreports?
* Move check_dma_crc() to ide-dma.c and add inline version for
CONFIG_BLK_DEV_IDEDMA=n case.
* Rename check_dma_crc() to ide_check_dma_crc().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-dma.c | 20
drivers/ide/ide-iops.c
While at it:
* Remove needless '!drive->crc_count' check.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-iops.c | 41 +
1 file changed, 13 insertions(+), 28 deletions(-)
Index: b/dri
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-iops.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
Index: b/drivers/ide/ide-iops.c
===
--- a/drivers/i
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-iops.c | 18 --
drivers/ide/ide-taskfile.c |6 +-
include/linux/ide.h|1 -
3 files changed, 5 insertions(+), 20 deletions(-)
Index: b/drivers/ide/ide-
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-iops.c | 15 ---
drivers/ide/ide-taskfile.c |5 -
include/linux/ide.h|1 -
3 files changed, 4 insertions(+), 17 deletions(-)
Index: b/drivers/ide/ide-
* Use __ide_set_handler() in ide_execute_command().
While at it:
* Fix whitespace damage in ide_execute_command().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-iops.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
In
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-iops.c |2 --
1 file changed, 2 deletions(-)
Index: b/drivers/ide/ide-iops.c
===
--- a/drivers/ide/ide-iops.c
+++ b/drivers/ide/ide-
* siimage.c: use hwif->sata_scr[SATA_{ERROR,STATUS}_OFFSET] instead of
SATA_{ERROR,STATUS}_REG macros.
* Remove no longer needed SATA_*_REG macros.
While at it:
* Remove needless SATA Status register read from sil_sata_reset_poll().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PRO
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
include/linux/ide.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/include/linux/ide.h
===
--- a/include/linux/ide.h
+++ b/include/linux
* ->nice0 and ->nice2 ide_drive_t fields are always zero so remove them.
* IDE_NICE_0 and IDE_NICE_2 defines from are no longer
used by any kernel code so cover them with #ifndef/#endif __KERNEL__.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide.
* Cache value read from the Status register in 'stat' variable in do_probe()
and enable_nest(), then remove remove needless Status register reads.
While at it:
* Add proper KERN_* levels to printk() calls.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
include/linux/ide.h |1 -
1 file changed, 1 deletion(-)
Index: b/include/linux/ide.h
===
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -607,7
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/cris/ide-cris.c |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
Index: b/drivers/ide/cris/ide-cris.c
===
--- a/drivers/ide/cris/ide-
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/scsi/ide-scsi.c |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
Index: b/drivers/scsi/ide-scsi.c
===
--- a/drivers/scsi/ide-scsi.c
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/trm290.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
Index: b/drivers/ide/pci/trm290.c
===
--- a/drivers/ide/pci/trm290.c
Easy stuff done as relax from more hard-core changes...
diffstat:
drivers/ide/cris/ide-cris.c |6 -
drivers/ide/ide-dma.c | 20 ++
drivers/ide/ide-iops.c | 145 ++--
drivers/ide/ide-probe.c | 35 ++
drivers/ide/ide-tape
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-tape.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: b/drivers/ide/ide-tape.c
===
--- a/drivers/ide/ide-tape.c
+++ b/drive
On Saturday 19 January 2008, Alan Cox wrote:
> On Sat, 19 Jan 2008 19:54:03 +0300
> Sergei Shtylyov <[EMAIL PROTECTED]> wrote:
>
> > Hello.
> >
> > Alan Cox wrote:
> >
> > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
> >
> > > diff -u --new-file --recursive --exclude-from /usr/src/exclude
> >
.
* Remove incorrect comment about do_rw_taskfile() from .
There should be no functionality changes caused by this patch.
v2:
* Add missing blk_fs_request() check to task_dma_ok() (for VDMA).
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL
Hi Borislav,
On Sunday 20 January 2008, Borislav Petkov wrote:
> On Mon, Jan 14, 2008 at 10:38:17PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > > By the way, I have an Iomega ZIP 100 drive somewhere in my hardware pile
> > > and
> > > will do some testing with th
On Saturday 19 January 2008, Alan Cox wrote:
>
> Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
applied with:
- s/pdc2026x/pdc202xx_old/ in patch summary
- drive-by CodingStyle fixups
> diff -u --new-file --recursive --exclude-from /usr/src/exclude
> linux.vanilla-2.6.24-rc8-mm1/drivers/ide/pci/
On Friday 18 January 2008, Sergei Shtylyov wrote:
> Alan Cox wrote:
>
> >>It won't -- we can *not* call ide_setup_dma() which fills them out as
> >> this
> >>is not a PCI chip.
>
> > Gak.
>
> Or maybe we still can -- with hwif->mmio set?
> AFAIR (from the 2006 discussion) Bart sai
Hi,
On Thursday 17 January 2008, Anton Salnikov wrote:
> This is Palmchip BK3710 IDE controller support for kernel version 2.6.24-rc8.
> The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes.
> Supports interface to compact Flash (CF) configured in True-IDE mode.
Thanks, overa
* Un-static create_proc_ide_drives() and call it from ide_device_add_all().
While at it:
* Rename create_proc_ide_drives() to ide_proc_port_register_devices().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c |4 +++-
drivers/ide/ide-proc.c
These pointers are always setup in ide_acpi_init().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-acpi.c | 10 --
1 file changed, 10 deletions(-)
Index: b/drivers/ide/ide-
this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-acpi.c | 49 +++-
drivers/ide/ide-probe.c |1
include/linux/ide.h |2 +
3 files changed, 23 insertions(+), 29 deletions(-)
Index: b/driver
Move hwif->present check out from ide_proc_register_port() to
ide_device_add_all().
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c |9 +++--
drivers/ide/ide-proc.c |
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-acpi.c |4
1 file changed, 4 deletions(-)
Index: b/drivers/ide/ide-acpi.c
===
--- a/drivers/ide/ide-acpi.c
+++ b/drivers/ide/ide-
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: b/drivers/ide/ide-p
Factor out adding drive to hwgroup from init_irq() to
ide_add_drive_to_hwgroup().
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c | 29 ++---
1 file chang
* Factor out devices setup from init_irq() to ide_port_setup_devices().
While at it:
* Do devices setup after printing port information.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c | 44
1 file c
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c | 44
1 file changed, 16 insertions(+), 28 deletions(-)
Index: b/drivers/ide/ide-p
Move hwif->rqsize init from ide_init_queue() to init_irq().
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/ide-p
No need to initialize drive->gendev and waste memory on IDE settings
for not present devices.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c |4
1 file changed, 4 insertions(+)
Index: b/drivers/ide/id
Move blk_register_region() call out from init_gendisk() to hwif_init().
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
In
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c |6 --
1 file changed, 6 deletions(-)
Index: b/drivers/ide/ide-probe.c
===
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-p
000
host drivers to use it.
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c |4 +++-
drivers/ide/legacy/dtc2278.c | 10 +++---
drivers/ide/mips/au1xxx-ide.c |3 +--
dr
caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-probe.c |3 ++
drivers/ide/legacy/ht6560b.c | 26 +
drivers/ide/legacy/qd65xx.c | 44 ---
drivers/ide/p
* Factor out code initializing devices from ide_init_port() to
ide_port_init_devices().
* Call the new function from ide_device_add_all().
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-p
_all_ IDE interfaces if useable ide_hwifs[] slot
cannot be find).
This patch leaves us with only two ide_register_hw() users:
- drivers/macintosh/mediabay.c
- drivers/ide/ide.c
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/arm/ba
e_unregister() when
removing interface.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/arm/bast-ide.c|2 +-
drivers/ide/arm/rapide.c |2 +-
drivers/ide/ide-pnp.c |2 +-
drivers/ide/legacy/ide-cs.c |4 ++--
driver
ide_init_port_hw() call overrides setup done by init_hwif_default().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: b/drivers/ide
' flag in ide_register_hw() if the setup done
by init_hwif_default() is going to be overridden by ide_init_port_hw().
* No need to set 'init_default' and 'restore' flags in cleanup_module().
There should be no functionality changes caused by this patch.
Signed-off-
We check earlier for hwif->present and call ide_unregister() if necessary
(after ide_unregister() hwif->present will be always cleared).
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide.c |2 --
1 file changed, 2 deletions(-)
Index: b/drive
Just another bunch of small fixes/cleanups...
diffstat:
drivers/ide/arm/bast-ide.c| 22 +++-
drivers/ide/arm/rapide.c |4
drivers/ide/ide-acpi.c| 60 +++
drivers/ide/ide-pnp.c |9 -
drivers/ide/ide-probe.c | 204 +++
On Tuesday 15 January 2008, Borislav Petkov wrote:
> ... and finally the last one. Whew! I think we're done here for now. :)
>
> --
> From: Borislav Petkov <[EMAIL PROTECTED]>
> Date: Tue, 15 Jan 2008 21:01:04 +0100
> Subject: ide-floppy: fix most of the remaining checkpatch.pl issues-v2
>
> such
On Tuesday 15 January 2008, Borislav Petkov wrote:
[...]
> .. this is the second one...
>
>
> From: Borislav Petkov <[EMAIL PROTECTED]>
> Date: Tue, 15 Jan 2008 20:49:18 +0100
> Subject: [PATCH 16/18] ide-floppy: remove atomic test_*bit macros
>
> ..and replace them with flag enums.
>
> Signe
On Tuesday 15 January 2008, Borislav Petkov wrote:
> On Mon, Jan 14, 2008 at 11:32:58PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > On Monday 14 January 2008, Bartlomiej Zolnierkiewicz wrote:
> > > On Sunday 13 January 2008, Borislav Petkov wrote:
> > > > ..an
On Monday 14 January 2008, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 13 January 2008, Borislav Petkov wrote:
> > ..and replace them with flag enums.
> >
> > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
small update:
PC_ABORT is never set and may as well be
On Sunday 13 January 2008, Borislav Petkov wrote:
> ..and replace them with flag enums.
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
> ---
> drivers/ide/ide-floppy.c | 132 +
> 1 files changed, 73 insertions(+), 59 deletions(-)
[...]
> @@ -
On Sunday 13 January 2008, Borislav Petkov wrote:
[...]
> - printk(KERN_ERR "ide-floppy: Packet size is not 12 bytes
> long\n");
> + printk(KERN_ERR "ide-floppy: Packet size is not 12 bytes "
> + "long\n");
I added dumping 'gcw.packet_size' fo
Hi,
On Sunday 13 January 2008, Borislav Petkov wrote:
> Hi Bart,
>
> here are the remaining patches which had issues to be worked out. I decided
> to keep the Flexible Disk Page and Capacity Descriptor in
> idefloppy_floppy_t for the sake of the two printk calls for which they are
> used. Otherw
On Sunday 13 January 2008, Borislav Petkov wrote:
> We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by
> introducing a 4th arg. called direction. According to its value
> we atapi_input_bytes() or atapi_output_bytes(). Also, this simplifies the
> interrupt handler logic a bi
On Saturday 12 January 2008, Borislav Petkov wrote:
[...]
> > > set_disk_ro(floppy->disk, floppy->wp);
> > > - page = (idefloppy_flexible_disk_page_t *) (header + 1);
> > > -
> > > - page->transfer_rate = be16_to_cpu(page->transfer_rate);
> > > - page->sector_size = be16_to_cpu(page->sector_siz
On Friday 11 January 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
> ---
> drivers/ide/ide-floppy.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
> index 89b26ea..0729df5 1006
On Friday 11 January 2008, Borislav Petkov wrote:
> i.e.,
> ERROR: switch and case should be at the same indent
> ERROR: need spaces around that '=' (ctx:VxV)
> ERROR: trailing statements should be on next line
> WARNING: no space between function name and open parenthesis '('
> WARNING: printk() s
On Friday 11 January 2008, Borislav Petkov wrote:
> In addition to shortening the function name, move the printk-call into the
> function thereby saving some code lines. Also, make the function out_of_line
> since it is not on a performance critical path.
>
> Signed-off-by: Borislav Petkov <[EMAIL
On Friday 11 January 2008, Borislav Petkov wrote:
> This change is temporary and after unification of the IDE subsystem proper
> bit setting and testing macros will be introduced.
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
> ---
> drivers/ide/ide-floppy.c | 82
> +++
201 - 300 of 1690 matches
Mail list logo
