Re: [PATCH] printk: use console_trylock() in console_cpu_notify()

2017-03-23 Thread Petr Mladek
On Wed 2017-01-25 16:02:36, Petr Mladek wrote: > On Sat 2017-01-21 19:47:29, Sergey Senozhatsky wrote: > > There is no need to always call blocking console_lock() in > > console_cpu_notify(), it's quite possible that console_sem can > > be locked by other CPU on the system, either already printing

Re: [PATCH v3 02/12] irqchip: mtk-sysirq: extend intpol base to arbitrary number

2017-03-23 Thread Marc Zyngier
On 19/03/17 15:26, Mars Cheng wrote: > Originally driver only supports one base. However, MT6797 has > more than one bases to configure interrupt polarity. To support > possible design change, here comes a solution to use arbitrary > number of bases. > > Signed-off-by: Mars Cheng Acked-by: Marc

Re: [PATCH v1] KVM: kvm_io_bus_unregister_dev() should never fail

2017-03-23 Thread David Hildenbrand
> As this may set kvm->buses[bus_idx] to NULL, don't you also need to > guard for bus == NULL in kvm_io_bus_destroy()? (I looked at the code on > kvm/queue.) very right, so something like this? diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index e1be4b4..ef1aa7f 100644 --- a/virt/kvm/kv

Re: next build: 208 builds: 9 failed, 199 passed, 857 errors, 444 warnings (next-20170323)

2017-03-23 Thread Arnd Bergmann
On Thu, Mar 23, 2017 at 6:46 AM, kernelci.org bot wrote: > acs5k_defconfig (arm) — PASS, 0 errors, 2 warnings, 0 section mismatches > > Warnings: > :1328:2: warning: #warning syscall arch_prctl not implemented [-Wcpp] > :1328:2: warning: #warning syscall arch_prctl not implemented [-Wcpp] patch

Re: [PATCH v2 4/7] arm: dts: r7s72100: Add pin controller node

2017-03-23 Thread jacopo
Hi Geert, On Wed, Mar 22, 2017 at 02:12:04PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi > wrote: > > Add pin controller node with 12 gpio controller sub-nodes to > > r7s72100 dtsi. > > > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Geert

Re: [PATCH v3 03/12] irqchip: mtk-sysirq: prevent unnecessary visibility when set_type

2017-03-23 Thread Marc Zyngier
On 19/03/17 15:26, Mars Cheng wrote: > This prevent unnecessary visibility when configuring trigger type > > Signed-off-by: Mars Cheng Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny...

Re: [PATCH] arm64: kconfig: allow support for memory failure handling

2017-03-23 Thread Punit Agrawal
On 23/03/17 14:33, James Morse wrote: Hi Punit, On 01/02/17 21:38, Tyler Baicar wrote: From: "Jonathan (Zhixiong) Zhang" If ACPI_APEI and MEMORY_FAILURE is configured, select ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery when such memory failure is reported through ACPI APE

Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking

2017-03-23 Thread Julia Cartwright
Hello John- One quick question below. Apologies if this has been covered, but just want to be sure. On Thu, Mar 23, 2017 at 10:59:28AM +, John Keeping wrote: > regmap_update_bits does its own locking and everything else accessed > here is a local variable so there is no need to lock around i

[PATCH] drivers/misc: aspeed-lpc-ctrl: fix printk format warning again

2017-03-23 Thread Arnd Bergmann
The format string is still broken after the first attempt to fix it: drivers/misc/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe': drivers/misc/aspeed-lpc-ctrl.c:232:17: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long uns

[PATCH] bna: avoid writing uninitialized data into hw registers

2017-03-23 Thread Arnd Bergmann
The latest gcc-7 snapshot warns about bfa_ioc_send_enable/bfa_ioc_send_disable writing undefined values into the hardware registers: drivers/net/ethernet/brocade/bna/bfa_ioc.c: In function 'bfa_iocpf_sm_disabling_entry': arch/arm/include/asm/io.h:109:22: error: '*((void *)&disable_req+4)' is used

Hello,

2017-03-23 Thread simpore rachidi
Dear Friend, Can you be able to assist in handling this transaction? More details will be sent to you as soon as i receive your response. An approval will be granted to you as soon as you apply for the release of the fund to you. I need your urgent assistance in transferring the sum of US$5 M

net/sched: GPF in qdisc_hash_add

2017-03-23 Thread Dmitry Vyukov
Hello, I've hit the following GPF while running syzkaller on commit 093b995e3b55a0ae0670226ddfcb05bfbf0099ae. Note the preceding injected kmalloc failure, most likely it's the root cause. FAULT_INJECTION: forcing a failure. name failslab, interval 1, probability 0, space 0, times 0 CPU: 2 PID: 1

Re: [RFC] Add option to mount only a pids subset

2017-03-23 Thread Oleg Nesterov
Again, I can't really review this, I know nothing about vfs, but since nobody else replied... On 03/20, Alexey Gladkov wrote: > > @@ -97,7 +169,23 @@ static struct dentry *proc_mount(struct file_system_type > *fs_type, > ns = task_active_pid_ns(current); > } > > - return m

Re: [PATCH v1] KVM: kvm_io_bus_unregister_dev() should never fail

2017-03-23 Thread Cornelia Huck
On Thu, 23 Mar 2017 15:34:41 +0100 David Hildenbrand wrote: > No caller currently checks the return value of > kvm_io_bus_unregister_dev(). This is evil, as all callers silently go on > freeing their device. A stale reference will remain in the io_bus, > getting at least used again, when the iobu

Re: [RFC] Add option to mount only a pids subset

2017-03-23 Thread Djalal Harouni
Hi Alexey, On Mon, Mar 20, 2017 at 1:58 PM, Alexey Gladkov wrote: > > > Al Viro, this patch looks better ? > > == Overview == > > Some of the container virtualization systems are mounted /proc inside > the container. This is done in most cases to operate with information > about the processes. Kn

Re: [PATCH v2] HV: properly delay KVP packets when negotiation is in progress

2017-03-23 Thread Vitaly Kuznetsov
Long Li writes: > The host may send multiple negotiation packets (due to timeout) before > the KVP user-mode daemon is connected. We need to defer processing > those packets until the daemon is negotiated and connected. It's okay > for guest to respond to all negotiation packets. > > In additi

[PATCH V2] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

2017-03-23 Thread Sinan Kaya
ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces. IPMI_SSIF is an alternative BMC communication method. It allows BMC to be accessed over an I2C bus instead of a standard interface. Enabling ACP

Re: loop: WARNING in sysfs_remove_group

2017-03-23 Thread Ming Lei
On Thu, Mar 23, 2017 at 03:09:44PM +0100, Dmitry Vyukov wrote: > Hello, > > I've got the following WARNING while running syzkaller on > 093b995e3b55a0ae0670226ddfcb05bfbf0099ae. Note the preceding injected > kmalloc failure, most likely it's the root cause. > > FAULT_INJECTION: forcing a failure.

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

2017-03-23 Thread jacopo
Hi Geert, thanks for review On Wed, Mar 22, 2017 at 11:33:50AM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi > wrote: > > Add device tree bindings documentation for Renesas RZ/A1 gpio and pin > > for the Renesas ... > > > controller. > > >

Re: [RFC v3 1/5] sched/core: add capacity constraints to CPU controller

2017-03-23 Thread Tejun Heo
Hello, On Thu, Mar 23, 2017 at 10:32:54AM +, Patrick Bellasi wrote: > > But then we would lose out on being able to attach capacity > > constraints to specific tasks or groups of tasks? > > Yes, right. If CGroups are not available than you cannot specify > per-task constraints. This is just a

Re: netlink: NULL timer crash

2017-03-23 Thread Eric Dumazet
On Thu, 2017-03-23 at 07:53 -0700, Eric Dumazet wrote: > Nice ! > > Looks like neigh->ops->solicit is NULL Apparently we allow admins to do really stupid things with neighbours on tunnels. Following patch should avoid the crash. Anyone has better ideas ? net/ipv4/arp.c |5 + net/i

[PATCH v3] extcon: intel-cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

2017-03-23 Thread Hans de Goede
Add a driver for charger detection / control on the Intel Cherrytrail Whiskey Cove PMIC. Signed-off-by: Hans de Goede --- Changes in v2: -Improve wait for charger detection loop, use jiffies to get an accurate timeout -Sort registers by address, remove duplicate definition -Return IRQ_NONE on int

Re: [PATCH] staging: media: atomisp: fix build error

2017-03-23 Thread Alan Cox
On Thu, 2017-03-23 at 21:12 +0800, Geliang Tang wrote: > Fix the following build error: > >   CC  drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.o > drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: >  error: excess elements in array initializer [-Werror] >   "i", /* ion */ >   ^~

[PATCH] proc: allow to change proc mount options per mount

2017-03-23 Thread Djalal Harouni
As per the discussion with Andy, and following what Al Viro suggested maybe this can work ? the patch is still buggy on top of Linus' tree 093b995e3b Currently hidepid mount option is propagated to all proc mounts that are in the same pid namespace. This patch make it possible to have proc mounts

Re: [PATCH 4/4] drm/amdgpu: resize VRAM BAR for CPU access

2017-03-23 Thread Christian König
- Are we going to support resizing BAR when kernel modesetting is not enabled and we are running in console under VBIOS control (VESA/VGA)? No, initial I've tried to resize the PCI BAR during probing without the help of the driver at all. But the VESA/EFI/VBIOS don't seem to be able to handle a

Re: [tpmdd-devel] [PATCH v2 4/7] tpm: infrastructure for TPM spaces

2017-03-23 Thread Jarkko Sakkinen
On Wed, Mar 22, 2017 at 04:09:21PM -0400, Ken Goldman wrote: > On 2/22/2017 12:39 PM, James Bottomley wrote: > > > > Right at the moment the kernel use of tpm2 looks like > > > > acquire chip->tpm_mutex > > load key > > process key > > unload key > > release chip->tpm_mutex > > > > While it does

Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

2017-03-23 Thread Timur Tabi
On 03/23/2017 10:53 AM, Sinan Kaya wrote: > + depends on IPMI_SI||IPMI_SSIF Blank spaces around ||. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Pro

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-23 Thread Dmitry Torokhov
On Thu, Mar 23, 2017 at 12:11:06PM +0100, Uwe Kleine-König wrote: > Hello, > > On Thu, Mar 23, 2017 at 11:20:39AM +0100, Geert Uytterhoeven wrote: > > But having the error breaks setups where the GPIO is optional and does > > not exist. > > so the right way forward is to check harder in the situa

Re: [PATCH] checkpatch: Allow space leading blank lines in email headers

2017-03-23 Thread Darren Hart
On Wed, Mar 22, 2017 at 11:28:40PM -0700, Joe Perches wrote: > On Wed, 2017-03-22 at 23:20 -0700, Darren Hart wrote: > > I do have an open question regarding how we're going about testing for the > > end > > of the header lines. Since we're not just testing for an empty line to > > separate > > h

Re: [PATCH v4 1/5] crash: move crashkernel parsing and vmcore related code under CONFIG_CRASH_CORE

2017-03-23 Thread Hari Bathini
Hi Michael, It's been a while since this patchset is Ack'ed. Should this go through powerpc-tree or some other? Thanks Hari On Thursday 05 January 2017 10:59 PM, Hari Bathini wrote: Traditionally, kdump is used to save vmcore in case of a crash. Some architectures like powerpc can save vmcore

[ANNOUNCE] elkdat: an easy linux kernel development and test tool

2017-03-23 Thread Satoru Takeuchi
elkdat is a tool to ease linux kernel development/test. It automatically setups linux kernel source repository and a VM for linux kernel development and test. In addition, It runs the following kinds of tests automatically just by one command. - build, install, boot you own kernel - run your own t

Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error

2017-03-23 Thread Jarkko Sakkinen
On Wed, Mar 22, 2017 at 04:12:49PM +0300, Dan Carpenter wrote: > On Wed, Mar 22, 2017 at 11:45:37AM +, Colin Ian King wrote: > > On 22/03/17 11:42, Jarkko Sakkinen wrote: > > > On Mon, Mar 20, 2017 at 02:23:36PM +, Colin King wrote: > > >> From: Colin Ian King > > >> > > >> The comparison

[PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

2017-03-23 Thread Sinan Kaya
ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces. IPMI_SSIF is an alternative BMC communication method. It allows BMC to be accessed over an I2C bus instead of a standard interface. Enabling ACP

Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error

2017-03-23 Thread Jarkko Sakkinen
On Wed, Mar 22, 2017 at 11:45:37AM +, Colin Ian King wrote: > On 22/03/17 11:42, Jarkko Sakkinen wrote: > > On Mon, Mar 20, 2017 at 02:23:36PM +, Colin King wrote: > >> From: Colin Ian King > >> > >> The comparison of an out of range index into space->context_tbl is > >> off-by-one and sho

Re: [tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume functions

2017-03-23 Thread Jarkko Sakkinen
On Tue, Mar 21, 2017 at 10:05:36PM +, Winkler, Tomas wrote: > > On Thu, Mar 16, 2017 at 09:51:33PM -0400, Jérémy Lefaure wrote: > > > When PM_SLEEP is disabled crb_pm_suspend and crb_pm_resume are not > > > used by SET_SYSTEM_SLEEP_PM_OPS even if PM is enabled: > > > > > > drvers/char/tpm/tpm_c

sg: random memory corruptions

2017-03-23 Thread Dmitry Vyukov
Hello, The following program causes random assorted memory corruptions: https://gist.githubusercontent.com/dvyukov/da3463af2d1ff8c7d3624891b5d7427f/raw/09cf0f4af529f4506f9e0a9fa6bdb066a8777b9d/gistfile1.txt It does some ioctl's on /dev/sg0. general protection fault: [#1] SMP KASAN Modules

Re: deadlock in synchronize_srcu() in debugfs?

2017-03-23 Thread Johannes Berg
Hi, > Not yet. How reproducible is this? Apparently quite. I haven't tried myself - it happens during some automated test that I need to analyse further. > > We're observing that with our (backported, but very recent) driver > > against 4.9 (and 4.10, I think), > > Do I understand it correctly

Re: deadlock in synchronize_srcu() in debugfs?

2017-03-23 Thread Johannes Berg
On Thu, 2017-03-23 at 08:37 -0700, Paul E. McKenney wrote: > I have not seen this, but my usual question for __synchronize_srcu() > is if some other task is blocked holding srcu_read_lock() for that > same srcu_struct. > Not as far as I can see - but that was the scenario I was outlining in my s

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-23 Thread Dmitry Torokhov
On Thu, Mar 23, 2017 at 07:43:25AM -0700, Dmitry Torokhov wrote: > On Thu, Mar 23, 2017 at 02:41:53PM +0100, Linus Walleij wrote: > > On Thu, Mar 23, 2017 at 1:34 PM, Uwe Kleine-König > > wrote: > > > > > Maybe we can make gpiod_get_optional look like this: > > > > > > if (!dev->of_node &

[PATCH v3] kasan: report only the first error by default

2017-03-23 Thread Andrey Ryabinin
From: Mark Rutland Disable kasan after the first report. There are several reasons for this: * Single bug quite often has multiple invalid memory accesses causing storm in the dmesg. * Write OOB access might corrupt metadata so the next report will print bogus alloc/free stacktraces. *

Re: [PATCH v2 1/2] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration

2017-03-23 Thread Vaidyanathan Srinivasan
* Rafael J. Wysocki [2017-03-23 16:28:31]: > On Thu, Mar 23, 2017 at 4:22 PM, Vaidyanathan Srinivasan > wrote: > > drv->cpumask defaults to cpu_possible_mask in __cpuidle_driver_init(). > > On PowerNV platform cpu_present could be less than cpu_possible in cases > > where firmware detects the cp

Re: [PATCH v2 2/2] cpuidle: Validate cpu_dev in cpuidle_add_sysfs

2017-03-23 Thread Vaidyanathan Srinivasan
* Rafael J. Wysocki [2017-03-23 16:27:31]: > On Thu, Mar 23, 2017 at 4:22 PM, Vaidyanathan Srinivasan > wrote: > > If a given cpu is not in cpu_present and cpu hotplug > > is disabled, arch can skip setting up the cpu_dev. > > > > Arch cpuidle driver should pass correct cpu mask > > for registra

Re: [PATCH v4 1/4] syscalls: Restore address limit after a syscall

2017-03-23 Thread Thomas Garnier
On Thu, Mar 23, 2017 at 8:32 AM, Borislav Petkov wrote: > On Thu, Mar 23, 2017 at 08:14:44AM -0700, Thomas Garnier wrote: >> Okay well then people are fine with a BUG_ON approach. I will do a >> next iteration tailored to that. I will also try to add the static >> inline suggestion from Peter. > >

Re: [PATCH] x86/boot: Support uncompressed kernel

2017-03-23 Thread Sergey Senozhatsky
On (03/23/17 08:07), Yinghai Lu wrote: > On Thu, Mar 23, 2017 at 5:51 AM, Chao Peng > wrote: > > Compressed kernel has its own drawback: uncompressing takes time. Even > > though the time is short enough to ignore for most cases but for cases that > > time is critical this is still a big number.

Re: [PATCH v5] KVM: VMX: Fix enable VPID conditions

2017-03-23 Thread Jim Mattson
On Thu, Mar 23, 2017 at 5:30 AM, Wanpeng Li wrote: > From: Wanpeng Li > > This can be reproduced by running L2 on L1, and disable VPID on L0 > if w/o commit "KVM: nVMX: Fix nested VPID vmx exec control", the L2 > crash as below: > > KVM: entry failed, hardware error 0x7 > EAX= EBX=000

Re: [PATCH v2 3/5] mm: use a dedicated workqueue for the free workers

2017-03-23 Thread Dave Hansen
On 03/22/2017 01:41 AM, Aaron Lu wrote: > On Wed, Mar 22, 2017 at 03:33:35PM +0900, Minchan Kim wrote: >> On Wed, Mar 15, 2017 at 05:00:02PM +0800, Aaron Lu wrote: >>> Introduce a workqueue for all the free workers so that user can fine >>> tune how many workers can be active through sysfs interfac

Re: deadlock in synchronize_srcu() in debugfs?

2017-03-23 Thread Paul E. McKenney
On Thu, Mar 23, 2017 at 03:54:46PM +0100, Johannes Berg wrote: > Hi, > > Before I go hunting - has anyone seen a deadlock in synchronize_srcu() > in debugfs_remove() before? We're observing that with our (backported, > but very recent) driver against 4.9 (and 4.10, I think), but there are > no bac

Re: deadlock in synchronize_srcu() in debugfs?

2017-03-23 Thread Nicolai Stange
Hi Johannes, On Thu, Mar 23 2017, Johannes Berg wrote: > Before I go hunting - has anyone seen a deadlock in synchronize_srcu() > in debugfs_remove() before? Not yet. How reproducible is this? > We're observing that with our (backported, but very recent) driver > against 4.9 (and 4.10, I think

Re: [PATCH V4] perf: qcom: Add L3 cache PMU driver

2017-03-23 Thread Mark Rutland
Hi Agustin, Structurally, this looks good to me. I have a few minor comments below; with those fixed up I think this is ready to merge. On Fri, Mar 17, 2017 at 10:24:17AM -0400, Agustin Vega-Frias wrote: > +/* > + * General constants > + */ > + > +/* Number of counters on each PMU */ > +#define

[PATCH] ACPI / IPMI: change warning to debug on timeout

2017-03-23 Thread Sinan Kaya
Getting timeout message from BMC when trying to read from a non-existent FRU. This is expected but warning is not. Let's reduce the warning to debug. Signed-off-by: Sinan Kaya --- drivers/acpi/acpi_ipmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/acpi/acpi_ip

Re: [PATCH] hwmon: asus_atk0110.c fix uninitialized data access

2017-03-23 Thread Luca Tettamanti
On 23 March 2017 at 16:03, Arnd Bergmann wrote: > The latest gcc-7 snapshot adds a warning to point out that when > atk_read_value_old or atk_read_value_new fails, we copy > uninitialized data into sensor->cached_value: > > drivers/hwmon/asus_atk0110.c: In function 'atk_input_show': > drivers/hwmo

Re: [PATCH v4 1/4] syscalls: Restore address limit after a syscall

2017-03-23 Thread Borislav Petkov
On Thu, Mar 23, 2017 at 08:14:44AM -0700, Thomas Garnier wrote: > Okay well then people are fine with a BUG_ON approach. I will do a > next iteration tailored to that. I will also try to add the static > inline suggestion from Peter. Would it be possible, please, to refrain from top-posting when r

Re: [PATCH] virtio_balloon: prevent uninitialized variable use

2017-03-23 Thread Denis V. Lunev
On 03/23/2017 06:17 PM, Arnd Bergmann wrote: > The latest gcc-7.0.1 snapshot reports a new warning: > > virtio/virtio_balloon.c: In function 'update_balloon_stats': > virtio/virtio_balloon.c:258:26: error: 'events[2]' is used uninitialized in > this function [-Werror=uninitialized] > virtio/virtio

Re: [PATCH v3 00/12] Add Basic SoC support for MT6797

2017-03-23 Thread Marc Zyngier
Hi Mars, On 23/03/17 00:46, Mars Cheng wrote: > Hi Matthias, Rob, Marc, Stephen > > gentle ping for this patch set. I appreciate that you're eager to see this reviewed, but less than 4 days between a posting and a reminder is a bit too eager. We're not machines! ;-) Thanks, M. -- Jazz

Re: deadlock in synchronize_srcu() in debugfs?

2017-03-23 Thread Johannes Berg
On Thu, 2017-03-23 at 15:54 +0100, Johannes Berg wrote: > Before I go hunting - has anyone seen a deadlock in > synchronize_srcu() in debugfs_remove() before? Isn't it possible for the following to happen? CPU1CPU2 mutex_lock(&M);

Re: [PATCH] hibernation: on 32-bit x86, disabled in favor of KASLR

2017-03-23 Thread Rafael J. Wysocki
On Thu, Mar 23, 2017 at 2:23 PM, Evgenii Shatokhin wrote: > On 23.03.2017 03:27, Kees Cook wrote: >> >> This is a modified revert of commit 65fe935dd238 ("x86/KASLR, x86/power: >> Remove x86 hibernation restrictions"), since it appears that 32-bit >> hibernation still can't support KASLR. 64-bit i

Re: [PATCH v2 1/2] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration

2017-03-23 Thread Rafael J. Wysocki
On Thu, Mar 23, 2017 at 4:22 PM, Vaidyanathan Srinivasan wrote: > drv->cpumask defaults to cpu_possible_mask in __cpuidle_driver_init(). > On PowerNV platform cpu_present could be less than cpu_possible in cases > where firmware detects the cpu, but it is not available to the OS. When > CONFIG_HO

Re: [PATCH v2 2/2] cpuidle: Validate cpu_dev in cpuidle_add_sysfs

2017-03-23 Thread Rafael J. Wysocki
On Thu, Mar 23, 2017 at 4:22 PM, Vaidyanathan Srinivasan wrote: > If a given cpu is not in cpu_present and cpu hotplug > is disabled, arch can skip setting up the cpu_dev. > > Arch cpuidle driver should pass correct cpu mask > for registration, but failing to do so by the driver > causes error to

Re: [PATCH] EDAC, pnd2_edac: fix build error without CONFIG_EDAC_DEBUG

2017-03-23 Thread Borislav Petkov
On Thu, Mar 23, 2017 at 04:16:35PM +0100, Arnd Bergmann wrote: > Calling into functions inside of the #ifdef causes an obvious compile error: > > drivers/edac/pnd2_edac.c: In function 'pnd2_init': > drivers/edac/pnd2_edac.c:1521:2: error: implicit declaration of function > 'setup_pnd2_debug'; did

[PATCH v2 2/2] cpuidle: Validate cpu_dev in cpuidle_add_sysfs

2017-03-23 Thread Vaidyanathan Srinivasan
If a given cpu is not in cpu_present and cpu hotplug is disabled, arch can skip setting up the cpu_dev. Arch cpuidle driver should pass correct cpu mask for registration, but failing to do so by the driver causes error to propagate and crash like this: [ 30.076045] Unable to handle kernel pagin

[PATCH v2 1/2] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration

2017-03-23 Thread Vaidyanathan Srinivasan
drv->cpumask defaults to cpu_possible_mask in __cpuidle_driver_init(). On PowerNV platform cpu_present could be less than cpu_possible in cases where firmware detects the cpu, but it is not available to the OS. When CONFIG_HOTPLUG_CPU=n, such cpus are not hotplugable at runtime and hence we skip c

[PATCH v1 0/2] cpuidle: Fixes in cpuidle driver

2017-03-23 Thread Vaidyanathan Srinivasan
When CONFIG_HOTPLUG_CPU=n and cpu_present is less than cpu_possible, then cpuidle-powernv not passing an explicit drv->cpu_mask allows generic cpuidle driver to try create sysfs objects for cpus that does not have cpu_devices created by calling register_cpu(). This caused kernel to access incorrec

Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector

2017-03-23 Thread Borislav Petkov
On Wed, Mar 22, 2017 at 07:03:39PM +0100, Borislav Petkov wrote: > Lemme try to write a small script exercising exactly that scenario to > see whether I'm actually not talking crap here :-) Ok, here's a snapshot from the CEC after letting it run for a couple of hours in a guest with a script runni

Re: usb: use-after-free write in usb_hcd_link_urb_to_ep

2017-03-23 Thread Dmitry Vyukov
On Thu, Mar 23, 2017 at 4:04 PM, Alan Stern wrote: > On Thu, 23 Mar 2017, Dmitry Vyukov wrote: > >> > Putting these together: >> > >> > The memory was allocated in usb_internal_control_msg() line 93. >> > The later events occurred within the call in line 100 to >> > usb_sta

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

2017-03-23 Thread Hans de Goede
Hi, On 21-03-17 06:16, Chanwoo Choi wrote: Hi, On 2017년 03월 21일 04:57, Hans de Goede wrote: Hi, On 20-03-17 02:33, Chanwoo Choi wrote: Hi, On 2017년 03월 17일 18:55, Hans de Goede wrote: Add a driver for charger detection / control on the Intel Cherrytrail Whiskey Cove PMIC. Signed-off-by: H

[PATCH v3 1/7] pinctrl: dt-bindings: Add documentation for Armada 37xx pin controllers

2017-03-23 Thread Gregory CLEMENT
Document the device tree binding for the pin controllers found on the Armada 37xx SoCs. Update the binding documention of the xtal clk which is a subnode of this syscon node. Signed-off-by: Gregory CLEMENT --- Documentation/devicetree/bindings/clock/armada3700-xtal-clock.txt | 7 +--

Re: [RFC v0 1/2] interconnect: Add generic interconnect controller API

2017-03-23 Thread Georgi Djakov
On 03/23/2017 03:21 AM, Michael Turquette wrote: Hi Georgi, Quoting Georgi Djakov (2017-03-01 10:22:34) diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt new file mode 100644 index ..c62d86

[PATCH v3 0/7] Add support for pinctrl/gpio on Armada 37xx

2017-03-23 Thread Gregory CLEMENT
Hi, In this third version I finally managed to use gpio-ranges from the device tree. For the record, this series adds support for the pin and gpio controllers present on the Armada 37xx SoCs. Each Armada 37xx SoC comes with 2 pin controllers: one on the south bridge (managing 28 pins) and one on

[PATCH v3 2/7] arm64: marvell: enable the Armada 37xx pinctrl driver

2017-03-23 Thread Gregory CLEMENT
This commit makes sure the driver for the Armada 37xx pin controller is enabled. Signed-off-by: Gregory CLEMENT --- arch/arm64/Kconfig.platforms | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 129cc5ae4091..f2bb1691264f 1006

Re: [REGRESSION] 07ec51480b5e ("virtio_pci: use shared interrupts for virtqueues") causes crashes in guest

2017-03-23 Thread Richard W.M. Jones
On Thu, Mar 23, 2017 at 01:13:50PM +0800, Jason Wang wrote: > >From 312859b596e83a2164a8430343d31fce2a5ad808 Mon Sep 17 00:00:00 2001 > From: Jason Wang > Date: Thu, 23 Mar 2017 13:07:16 +0800 > Subject: [PATCH] virtio_pci: fix out of bound access for msix_names > > Signed-off-by: Jason Wang I

[PATCH v3 4/7] pinctrl: armada-37xx: Add gpio support

2017-03-23 Thread Gregory CLEMENT
GPIO management is pretty simple and is part of the same IP than the pin controller for the Armada 37xx SoCs. This patch adds the GPIO support to the pinctrl-armada-37xx.c file, it also allows sharing common functions between the gpiolib and the pinctrl drivers. Signed-off-by: Gregory CLEMENT --

[PATCH v3 3/7] pinctrl: armada-37xx: Add pin controller support for Armada 37xx

2017-03-23 Thread Gregory CLEMENT
The Armada 37xx SoC come with 2 pin controllers: one on the south bridge (managing 28 pins) and one on the north bridge (managing 36 pins). At the hardware level the controller configure the pins by group and not pin by pin. This constraint is reflected in the design of the driver: only the group

Re: [PATCH] kasan: avoid -Wmaybe-uninitialized warning

2017-03-23 Thread Dmitry Vyukov
On Thu, Mar 23, 2017 at 4:04 PM, Arnd Bergmann wrote: > gcc-7 produces this warning: > > mm/kasan/report.c: In function 'kasan_report': > mm/kasan/report.c:351:3: error: 'info.first_bad_addr' may be used > uninitialized in this function [-Werror=maybe-uninitialized] >print_shadow_for_address(

Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues")

2017-03-23 Thread Richard W.M. Jones
On Thu, Mar 23, 2017 at 03:56:22PM +0100, Christoph Hellwig wrote: > Does the patch from Jason in the > > "[REGRESSION] 07ec51480b5e ("virtio_pci: use shared interrupts for > virtqueues") causes crashes in guest" > > thread fix the issue for you? In brief, yes it does. I followed up on that th

[PATCH v3 7/7] ARM64: dts: marvell: armada37xx: add pinctrl definition

2017-03-23 Thread Gregory CLEMENT
Start to populate the device tree of the Armada 37xx with the pincontrol configuration used on the board providing a dts. Signed-off-by: Gregory CLEMENT --- arch/arm64/boot/dts/marvell/armada-3720-db.dts | 8 +- arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 31 +++- 2 fil

[PATCH] x86/syscalls/32: ignore arch_prctl for other architectures

2017-03-23 Thread Arnd Bergmann
sys_arch_prctl is only provided on x86, and there is no reason to add it elsewhere. However, including it on the 32-bit syscall table caused a warning for most configurations on non-x86: :1328:2: warning: #warning syscall arch_prctl not implemented [-Wcpp] This adds an exception to the syscall ta

[PATCH v3 6/7] ARM64: dts: marvell: Add pinctrl nodes for Armada 3700

2017-03-23 Thread Gregory CLEMENT
Add the nodes for the two pin controller present in the Armada 37xx SoCs. Initially the node was named gpio1 using the same name that for the register range in the datasheet. However renaming it pinctr_nb (nb for North Bridge) makes more sens. Signed-off-by: Gregory CLEMENT --- arch/arm64/boot/

[PATCH v3 5/7] pinctrl: aramda-37xx: Add irqchip support

2017-03-23 Thread Gregory CLEMENT
The Armada 37xx SoCs can handle interrupt through GPIO. However it can only manage the edge ones. The way the interrupt are managed are classical so we can use the generic interrupt chip model. The only unusual "feature" is that many interrupts are connected to the parent interrupt controller. Bu

[PATCH] virtio_balloon: prevent uninitialized variable use

2017-03-23 Thread Arnd Bergmann
The latest gcc-7.0.1 snapshot reports a new warning: virtio/virtio_balloon.c: In function 'update_balloon_stats': virtio/virtio_balloon.c:258:26: error: 'events[2]' is used uninitialized in this function [-Werror=uninitialized] virtio/virtio_balloon.c:260:26: error: 'events[3]' is used uninitiali

[PATCH] EDAC, pnd2_edac: fix build error without CONFIG_EDAC_DEBUG

2017-03-23 Thread Arnd Bergmann
Calling into functions inside of the #ifdef causes an obvious compile error: drivers/edac/pnd2_edac.c: In function 'pnd2_init': drivers/edac/pnd2_edac.c:1521:2: error: implicit declaration of function 'setup_pnd2_debug'; did you mean 'setup_log_buf'? [-Werror=implicit-function-declaration] drive

[PATCH] ALSA: au88x0: avoid theoretical uninitialized access

2017-03-23 Thread Arnd Bergmann
The latest gcc-7.0.1 snapshot points out that we if nr_ch is zero, we never initialize some variables: sound/pci/au88x0/au88x0_core.c: In function 'vortex_adb_allocroute': sound/pci/au88x0/au88x0_core.c:2304:68: error: 'mix[0]' may be used uninitialized in this function [-Werror=maybe-uninitializ

Re: [PATCH v4 1/4] syscalls: Restore address limit after a syscall

2017-03-23 Thread Thomas Garnier
Okay well then people are fine with a BUG_ON approach. I will do a next iteration tailored to that. I will also try to add the static inline suggestion from Peter. On Wed, Mar 22, 2017 at 1:54 PM, H. Peter Anvin wrote: > On 03/22/17 13:49, Thomas Garnier wrote: >> >> We can default to BUGging. I

Re: [PATCH 00/23] hisi_sas: error handling and other misc fixes and improvements

2017-03-23 Thread Martin K. Petersen
John Garry writes: John, > This patchset introduces a range of error handling > and other misc improvements for the HiSilicon SAS > controller, including: > - controller reset function > - softreset for SATA error handling > - fixes for slot free'ing > - v2 hw error handling improvements > - and

Re: [PATCH] ARM: dts: at91: add envelope detector mux to the Axentia TSE-850

2017-03-23 Thread Alexandre Belloni
On 17/03/2017 at 23:24:46 +0100, Peter Rosin wrote: > The envelope detector can analyze 6 different signals, selectable with a > mux controlled by three gpio pins. > > Signed-off-by: Peter Rosin > --- > > Hi! > > This patch makes use of the mux subsystem and a couple of drivers > available in l

[GIT PULL] sound fixes for 4.11-rc4

2017-03-23 Thread Takashi Iwai
Linus, please pull sound fixes for v4.11-rc4 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-4.11-rc4 The topmost commit is 3f307834e695f59dac4337a40316bdecfb9d0508 sound fixes for 4.11-rc4 This

[GIT PULL] Btrfs

2017-03-23 Thread Chris Mason
Hi Linus We have a small set of fixes for the next RC: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 Zygo tracked down a very old bug with inline compressed extents. I didn't tag this one for stable because I want to do individual tested backports. It's a

Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues")

2017-03-23 Thread Thorsten Leemhuis
Hi Christoph! Hi Michael! (Mail roughly based on text from https://bugzilla.kernel.org/show_bug.cgi?id=194911 ) I'm seeing random crashes during boot every few boot attempts when running Linux 4.11-rc/mainline in a Fedora 26 guest under a CentOS7 host (CPU: Intel(R) Pentium(R) CPU G3220) using KV

[PATCH -v3 6/8] sched,tracing: Update trace_sched_pi_setprio()

2017-03-23 Thread Peter Zijlstra
Pass the PI donor task, instead of a numerical priority. Numerical priorities are not sufficient to describe state ever since SCHED_DEADLINE. Annotate all sched tracepoints that are currently broken; fixing them will bork userspace. *hate*. Reviewed-by: Steven Rostedt Signed-off-by: Peter Zijls

Re: [PATCH] x86/boot: Support uncompressed kernel

2017-03-23 Thread Yinghai Lu
On Thu, Mar 23, 2017 at 5:51 AM, Chao Peng wrote: > Compressed kernel has its own drawback: uncompressing takes time. Even > though the time is short enough to ignore for most cases but for cases that > time is critical this is still a big number. In our on-going optimization > for kernel boot tim

Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues")

2017-03-23 Thread Thorsten Leemhuis
On 23.03.2017 15:56, Christoph Hellwig wrote: > Does the patch from Jason in the > "[REGRESSION] 07ec51480b5e ("virtio_pci: use shared interrupts for > virtqueues") causes crashes in guest" > thread fix the issue for you? Ha, sorry, I'm travelling and wasn't aware that Laura earlier today did wha

Re: [PATCH] arm/arm64: KVM: send SIGBUS error to qemu

2017-03-23 Thread James Morse
Hi Dongjiu Geng, On 23/03/17 13:01, Dongjiu Geng wrote: > when the pfn is KVM_PFN_ERR_HWPOISON, it indicates to send > SIGBUS signal from KVM's fault-handling code to qemu, qemu > can handle this signal according to the fault address. I'm afraid I beat you to it on this one: https://www.spinics.n

[PATCH] reiserfs: avoid a -Wmaybe-uninitialized warning

2017-03-23 Thread Arnd Bergmann
The latest gcc-7.0.1 snapshot warns about an unintialized variable use: In file included from fs/reiserfs/lbalance.c:8:0: fs/reiserfs/lbalance.c: In function 'leaf_item_bottle.isra.3': fs/reiserfs/reiserfs.h:1279:13: error: '*((void *)&n_ih+8).v' may be used uninitialized in this function [-Werro

[PATCH -v3 2/8] sched/rtmutex/deadline: Fix a PI crash for deadline tasks

2017-03-23 Thread Peter Zijlstra
From: Xunlei Pang A crash happened while I was playing with deadline PI rtmutex. BUG: unable to handle kernel NULL pointer dereference at 0018 IP: [] rt_mutex_get_top_task+0x1f/0x30 PGD 232a75067 PUD 230947067 PMD 0 Oops: [#1] SMP CPU: 1 PID: 10994 Comm: a.ou

[PATCH -v3 0/8] PI vs SCHED_DEADLINE fixes

2017-03-23 Thread Peter Zijlstra
Now that this pesky little problem with futexes is (hopefully) dealt with; https://lkml.kernel.org/r/20170322103547.756091...@infradead.org We can get on with fixing the actual bug this all started out with. These patches, started by Xunlei Pang, rework the PI infrastructure a bit fixing vario

[PATCH -v3 1/8] rtmutex: Deboost before waking up the top waiter

2017-03-23 Thread Peter Zijlstra
From: Xunlei Pang We should deboost before waking the high-priority task, such that we don't run two tasks with the same "state" (priority, deadline, sched_class, etc). In order to make sure the boosting task doesn't start running between unlock and deboost (due to 'spurious' wakeup), we move th

[PATCH -v3 4/8] rtmutex: Clean up

2017-03-23 Thread Peter Zijlstra
Previous patches changed the meaning of the return value of rt_mutex_slowunlock(); update comments and code to reflect this. Signed-off-by: Peter Zijlstra (Intel) --- kernel/futex.c |7 --- kernel/locking/rtmutex.c| 28 +--- kernel/locki

[PATCH -v3 7/8] rtmutex: Fix PI chain order integrity

2017-03-23 Thread Peter Zijlstra
rt_mutex_waiter::prio is a copy of task_struct::prio which is updated during the PI chain walk, such that the PI chain order isn't messed up by (asynchronous) task state updates. Currently rt_mutex_waiter_less() uses task state for deadline tasks; this is broken, since the task state can, as said

[PATCH -v3 5/8] sched/rtmutex: Refactor rt_mutex_setprio()

2017-03-23 Thread Peter Zijlstra
With the introduction of SCHED_DEADLINE the whole notion that priority is a single number is gone, therefore the @prio argument to rt_mutex_setprio() doesn't make sense anymore. So rework the code to pass a pi_task instead. Note this also fixes a problem with pi_top_task caching; previously we wo

[PATCH -v3 8/8] rtmutex: Fix more prio comparisons

2017-03-23 Thread Peter Zijlstra
There was a pure ->prio comparison left in try_to_wake_rt_mutex(), convert it to use rt_mutex_waiter_less(), noting that greater-or-equal is not-less (both in kernel priority view). This necessitated the introduction of cmp_task() which creates a pointer to an unnamed stack variable of struct rt_m

[PATCH -v3 3/8] sched/deadline/rtmutex: Dont miss the dl_runtime/dl_period update

2017-03-23 Thread Peter Zijlstra
From: Xunlei Pang Currently dl tasks will actually return at the very beginning of rt_mutex_adjust_prio_chain() in !detect_deadlock cases: if (waiter->prio == task->prio) { if (!detect_deadlock) goto out_unlock_pi; // out here else requeue = false;

<    1   2   3   4   5   6   7   8   9   10   >