Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-25 Thread Florian Fainelli
On 04/25/2017 01:26 PM, David Miller wrote: > From: Alexandre Belloni > Date: Tue, 25 Apr 2017 22:09:11 +0200 > >> Hi, >> >> On 25/04/2017 at 18:25:30 +0300, Alexander Kochetkov wrote: >>> Hello David! >>> 25 апр. 2017 г., в 17:36, David Miller написал(а): So... what are we doing

[PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c

2017-04-25 Thread Ilia Sergachev
This is a patch to the ks_wlan_net.c file that fixes up the following warning found by the checkpatch.pl tool: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Ilia Sergachev --- drivers/staging/ks7010/ks_wlan_net.c | 43 ++-- 1 file cha

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Guenter Roeck
On Tue, Apr 25, 2017 at 01:34:18PM -0700, Moritz Fischer wrote: > On Tue, Apr 25, 2017 at 01:22:10PM -0700, Guenter Roeck wrote: > > On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > > > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > > > > > Ah, I missed the "

Re: [PATCH V2 0/2] correct ids for clk_testout

2017-04-25 Thread Heiko Stübner
Hi Eddie, Am Dienstag, 25. April 2017, 14:41:08 CEST schrieb Eddie Cai: > we use clk_testout1 and clk_testout2 for camera. e.g. mipi 24M mclk. the ids > of clk_testout1 and clk_testout2 is wrong. it's time to correct it. Just to say, patches look good - thanks for explaining what the clocks are

RE: Performance of low-cpu utilisation benchmark regressed severely since 4.6

2017-04-25 Thread Doug Smythies
Hi Rafael, Apologies, I reversed reported a couple of data points last night: On 2017.04.25 00:13 Doug wrote: > On 2017.04.24 07:25 Doug wrote: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next >> Plus that patch is in progress. > >3387.76 Seconds. > Idle power 3.

Re: [PATCH v3 tip/core/rcu 05/40] rcu: Semicolon inside RCU_TRACE() for rcu.h

2017-04-25 Thread Paul E. McKenney
On Wed, Apr 19, 2017 at 10:41:23AM -0700, Joe Perches wrote: > On Wed, 2017-04-19 at 09:58 -0700, Paul E. McKenney wrote: > > The current use of "RCU_TRACE(statement);" can cause odd bugs, especially > > where "statement" is a local-variable declaration, as it can leave a > > misplaced ";" in the s

Re: [PATCH] lockd: remove redundant check on block

2017-04-25 Thread J . Bruce Fields
On Sat, Apr 08, 2017 at 06:09:59PM +0100, Colin King wrote: > From: Colin Ian King > > A null check followed by a return is being performed already, so block > is always non-null at the second check on block, hence we can remove > this redundant null-check (Detected by PVS-Studio). Also re-work

[GIT PULL] ARC fixes for 4.11-final

2017-04-25 Thread Vineet Gupta
Hi Linus, Couple of late fixes for ARC, better for them to go now then request backports. Please pull. Thx, -Vineet --> The following changes since commit 39da7c509acff13fc8cb12ec1bb20337c988ed36: Linux 4.11-rc6 (2017-04-09 09:49:44 -0700) are available in the git repository at: git:

Re: [PATCH] Fix returns of some CLK API calls, if !CONFIG_HAVE_CLOCK

2017-04-25 Thread Tom Bogendoerfer
On Tue, Apr 25, 2017 at 05:31:37PM +0100, Russell King - ARM Linux wrote: > On Tue, Apr 25, 2017 at 02:30:07PM +0200, Thomas Bogendoerfer wrote: > > If CONFIG_HAVE_CLOCK is not set, return values of clk_get(), > > devm_clk_get(), devm_get_clk_from_child(), clk_get_parent() > > and clk_get_sys() are

[PATCH 1/2] thermal: broadcom: Allow for NSP to use ns-thermal driver

2017-04-25 Thread Jon Mason
Change the iProc Kconfig to select THERMAL and THERMAL_OF, which allows the ns-thermal driver to be selected via menuconfig. Also, change the ns-thermal driver to work on any iProc based SoC. Finally, tweak the Kconfig description to mention support for NSP and make the default on for iProc based

[PATCH 2/2] ARM: dts: NSP: Add Thermal Support

2017-04-25 Thread Jon Mason
Add thermal support via the ns-thermal driver and create a single thermal zone for the entire SoC. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm-nsp.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-ns

[PATCH 0/2] thermal: broadcom: Add NSP Thermal Support

2017-04-25 Thread Jon Mason
This adds support for NSP to the existing Northstar thermal driver. This code is based on patches currently in the Linux SoC Thermal git tree. Specfically, https://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git/commit/?h=linus&id=a94cb7eeecc4104a6874339f90c5d0647359c102 J

Re: [PATCH 2/2] sched/fair: Always propagate runnable_load_avg

2017-04-25 Thread Tejun Heo
On Tue, Apr 25, 2017 at 11:49:41AM -0700, Tejun Heo wrote: > Will try that too. I can't see why HT would change it because I see > single CPU queues misevaluated. Just in case, you need to tune the > test params so that it doesn't load the machine too much and that > there are some non-CPU intens

[PATCH v8 2/4] mtd: m25p80: add support of SPI 1-2-2 and 1-4-4 protocols

2017-04-25 Thread Cyrille Pitchen
From: Cyrille Pitchen Before this patch, m25p80_read() supported few SPI protocols: - regular SPI 1-1-1 - SPI Dual Output 1-1-2 - SPI Quad Output 1-1-4 On the other hand, m25p80_write() only supported SPI 1-1-1. This patch updates both m25p80_read() and m25p80_write() functions to let them suppo

Re: [PATCH 1/1 linux-next] nfs: kmap can't fail

2017-04-25 Thread Anna Schumaker
Hi Fabian, On 04/25/2017 02:10 PM, Fabian Frederick wrote: > Remove NULL test on kmap() > > Signed-off-by: Fabian Frederick > --- > fs/nfs/dir.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c > index 3a188cb..f89e54c 100644 > --- a/fs/nfs/dir.c > +++ b/fs

Re: [PATCH v2] gpio: omap: return error if requested debounce time is not possible

2017-04-25 Thread Grygorii Strashko
On 04/24/2017 05:56 PM, David Rivshin wrote: From: David Rivshin omap_gpio_debounce() does not validate that the requested debounce is within a range it can handle. Instead it lets the register value wrap silently, and always returns success. This can lead to all sorts of unexpected behavior

Re: [Y2038] [PATCH v5 2/5] vfs: Add checks for filesystem timestamp limits

2017-04-25 Thread Linus Torvalds
On Tue, Apr 25, 2017 at 1:31 PM, Arnd Bergmann wrote: > > Would it be ok to have a simple way of removing the time_t definition (e.g. > by passing '-DREQUIRE_TIME64' to the compiler, but without the Kconfig > option? That way, someone who wants to ship a product can at least > find the obvious dep

Re: [PATCH v2] macsec: dynamically allocate space for sglist

2017-04-25 Thread Sabrina Dubroca
2017-04-25, 19:08:18 +0200, Jason A. Donenfeld wrote: > We call skb_cow_data, which is good anyway to ensure we can actually > modify the skb as such (another error from prior). Now that we have the > number of fragments required, we can safely allocate exactly that amount > of memory. > > Signed-

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
On Tue, Apr 25, 2017 at 01:22:10PM -0700, Guenter Roeck wrote: > On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > > > Ah, I missed the "n" in various #ifndef statements. > > > > > > I can't really comment on ho

Re: [Y2038] [PATCH v5 2/5] vfs: Add checks for filesystem timestamp limits

2017-04-25 Thread Arnd Bergmann
On Tue, Apr 25, 2017 at 10:02 PM, Linus Torvalds wrote: > On Tue, Apr 25, 2017 at 12:47 PM, Arnd Bergmann wrote: >> >> There is one global option that I want to see, and that is for completely >> disabling all components that are known to be broken in y2038. > > I really don't see the point. > >

[PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler()

2017-04-25 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 25 Apr 2017 22:00:05 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement here. Signed-off-by: Markus Elfring --- drivers/scsi/ufs/ufshcd.c |

Re: kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!!

2017-04-25 Thread Paul E. McKenney
On Tue, Apr 25, 2017 at 02:13:45PM -0600, Ross Zwisler wrote: > I hit this RCU warning while running mkfs.ext4 on a PMEM namespace with > an unmodified v4.11-rc8 (passed through kasan_symbolize.py): > > === > [ ERR: suspicious RCU usage. ] > 4.11.0-rc8 #1 Not tainted >

[PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

2017-04-25 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 25 Apr 2017 21:50:43 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such a statement here. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Re

Get back to me

2017-04-25 Thread Ashraf Basit
Good day. Did you receive the business proposal I sent to you yesterday? I was waiting for your reply but I am not sure if you receive the message. If for some reason you did not receive my previous email, I can resend the message to you. Please confirm as this is very urgent and important. Re

Re: [Xen-devel] [PATCH] x86/amd: don't set X86_BUG_SYSRET_SS_ATTRS if forced to zero

2017-04-25 Thread Borislav Petkov
On Tue, Apr 25, 2017 at 09:17:13PM +0100, Andrew Cooper wrote: > The problem (for all ring-deprivileged virtuailsation; not just Xen PV), > is that I know what that that bug flag is for. I'm asking whether the xen guest boot sets a flag early - like XENPV, for example - which can differentiate be

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-25 Thread David Miller
From: Alexandre Belloni Date: Tue, 25 Apr 2017 22:09:11 +0200 > Hi, > > On 25/04/2017 at 18:25:30 +0300, Alexander Kochetkov wrote: >> Hello David! >> >> > 25 апр. 2017 г., в 17:36, David Miller написал(а): >> > >> > So... what are we doing here? >> > >> > My understanding is that this shoul

[PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc()

2017-04-25 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 25 Apr 2017 21:45:25 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". * Replace the specification of a data structure by a

Re: [PATCH v8 3/4] mtd: spi-nor: introduce Double Transfer Rate (DTR) SPI protocols

2017-04-25 Thread Marek Vasut
On 04/25/2017 10:08 PM, Cyrille Pitchen wrote: > From: Cyrille Pitchen > > This patch introduces support to Double Transfer Rate (DTR) SPI protocols. > DTR is used only for Fast Read operations. > > According to manufacturer datasheets, whatever the number of I/O lines > used during instruction

Re: [PATCH v8 1/4] mtd: spi-nor: introduce SPI 1-2-2 and SPI 1-4-4 protocols

2017-04-25 Thread Marek Vasut
On 04/25/2017 10:08 PM, Cyrille Pitchen wrote: > From: Cyrille Pitchen > > This patch changes the prototype of spi_nor_scan(): its 3rd parameter > is replaced by a 'struct spi_nor_hwcaps' pointer, which tells the spi-nor > framework about the actual hardware capabilities supported by the SPI > co

Re: [v4.9-rt PATCH v2] ARM: mm: remove tasklist locking from update_sections_early()

2017-04-25 Thread Grygorii Strashko
On 04/21/2017 06:11 PM, Kees Cook wrote: On Wed, Apr 19, 2017 at 5:36 PM, Laura Abbott wrote: On 04/19/2017 01:10 PM, Grygorii Strashko wrote: The below backtrace can be observed on -rt kernel with CONFIG_DEBUG_RODATA option enabled: BUG: sleeping function called from invalid context at

[PATCH 0/3] SCSI-UFSHCD: Fine-tuning for two function implementations

2017-04-25 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 25 Apr 2017 22:20:02 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use devm_kcalloc() in ufshcd_memory_alloc() Delete an error message for a failed memory allocation in ufshcd_memory_alloc() Del

[PATCH v3] libnvdimm, region: sysfs trigger for nvdimm_flush()

2017-04-25 Thread Dan Williams
The nvdimm_flush() mechanism helps to reduce the impact of an ADR (asynchronous-dimm-refresh) failure. The ADR mechanism handles flushing platform WPQ (write-pending-queue) buffers when power is removed. The nvdimm_flush() mechanism performs that same function on-demand. When a pmem namespace is a

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Guenter Roeck
On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > Ah, I missed the "n" in various #ifndef statements. > > > > I can't really comment on how to solve that; I simply don't know. > > Also, even with a dt property, it

Re: [Xen-devel] [PATCH] x86/amd: don't set X86_BUG_SYSRET_SS_ATTRS if forced to zero

2017-04-25 Thread Andrew Cooper
On 25/04/17 20:18, Borislav Petkov wrote: > On Tue, Apr 25, 2017 at 08:34:34PM +0200, Juergen Gross wrote: >> And what happens when there is a scheduling event right here? >> __switch_to() will see X86_BUG_SYSRET_SS_ATTRS set and take a wrong >> path. > So the whole thing we're doing right now is w

Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer

2017-04-25 Thread Jacek Anaszewski
Hi David, On 04/25/2017 05:05 AM, David Lin wrote: > Hi Jacek, > > On Mon, Apr 24, 2017 at 12:59 PM, Jacek Anaszewski > wrote: >> >> Hi David, >> >> Thanks for the patch. >> >> Unfortunately we cannot switch to using hr timers just like that >> without introducing side effects for many devices.

[PATCH v8 1/4] mtd: spi-nor: introduce SPI 1-2-2 and SPI 1-4-4 protocols

2017-04-25 Thread Cyrille Pitchen
From: Cyrille Pitchen This patch changes the prototype of spi_nor_scan(): its 3rd parameter is replaced by a 'struct spi_nor_hwcaps' pointer, which tells the spi-nor framework about the actual hardware capabilities supported by the SPI controller and its driver. Besides, this patch also introduc

[PATCH v8 0/4] mtd: spi-nor: parse SFDP tables to setup (Q)SPI memories

2017-04-25 Thread Cyrille Pitchen
Hi all, based on git-hub/spi-nor. The 4 patches have passed the checkpatch test. DISCLAIMER: despite what the subjet claims, I've removed the SFDP patches from this version since they are still RFC/WIP. However I've chosen not to change the subjet line so it's easier to make the link between th

kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!!

2017-04-25 Thread Ross Zwisler
I hit this RCU warning while running mkfs.ext4 on a PMEM namespace with an unmodified v4.11-rc8 (passed through kasan_symbolize.py): === [ ERR: suspicious RCU usage. ] 4.11.0-rc8 #1 Not tainted --- kernel/rcu/tree.c:1031 rcu_irq_enter() invo

[PATCH v8 4/4] mtd: spi-nor: introduce Octo SPI protocols

2017-04-25 Thread Cyrille Pitchen
From: Cyrille Pitchen This patch starts adding support to Octo SPI protocols (SPI x-y-8). Op codes for Fast Read and/or Page Program operations using Octo SPI protocols are not known yet (no JEDEC specification has defined them yet) but we'd rather introduce the Octo SPI protocols now so it's do

Re: [PATCH v2] fscrypt: Add support for AES-128-CBC

2017-04-25 Thread Eric Biggers
Hi Daniel and David, On Tue, Apr 25, 2017 at 04:41:00PM +0200, David Gstir wrote: > @@ -147,17 +148,28 @@ int fscrypt_do_page_crypto(const struct inode *inode, > fscrypt_direction_t rw, > { > struct { > __le64 index; > - u8 padding[FS_XTS_TWEAK_SIZE - sizeof(__le6

[PATCH v8 3/4] mtd: spi-nor: introduce Double Transfer Rate (DTR) SPI protocols

2017-04-25 Thread Cyrille Pitchen
From: Cyrille Pitchen This patch introduces support to Double Transfer Rate (DTR) SPI protocols. DTR is used only for Fast Read operations. According to manufacturer datasheets, whatever the number of I/O lines used during instruction (x) and address/mode/dummy (y) clock cycles, DTR is used only

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-25 Thread Alexandre Belloni
Hi, On 25/04/2017 at 18:25:30 +0300, Alexander Kochetkov wrote: > Hello David! > > > 25 апр. 2017 г., в 17:36, David Miller написал(а): > > > > So... what are we doing here? > > > > My understanding is that this should fix the same problem that commit > > 99f81afc139c6edd14d77a91ee91685a414a1c

Re: [PATCH v2] tags: honor COMPILED_SOURCE with apart output directory

2017-04-25 Thread Robert Jarzmik
Masahiro Yamada writes: > Hi Robert, >> diff --git a/scripts/tags.sh b/scripts/tags.sh >> index a2ff3388e5ea..35cb64d5211c 100755 >> --- a/scripts/tags.sh >> +++ b/scripts/tags.sh >> @@ -106,7 +106,8 @@ all_compiled_sources() >> case "$i" in >> *.[cS]) >>

Re: [PATCH v5 0/2] security: tty: make TIOCSTI ioctl require CAP_SYS_ADMIN

2017-04-25 Thread Jann Horn
On Tue, Apr 25, 2017 at 9:30 PM, One Thousand Gnomes wrote: > On Tue, 25 Apr 2017 15:56:32 +0200 > Jann Horn wrote: > >> On Tue, Apr 25, 2017 at 3:47 PM, Alan Cox wrote: >> >> There could be a few user programs that would be effected by this >> >> change. >> >> See:

Re: Revised statx(2) man page for review

2017-04-25 Thread Dmitry V. Levin
On Tue, Apr 25, 2017 at 01:14:26PM +0200, Michael Kerrisk (man-pages) wrote: [...] >The file timestamps are structures of the following type: > >struct statx_timestamp { >__s64 tv_sec;/* Seconds since the Epoch (UNIX time) */ >__s32 tv_nsec;

[PATCH] usb: musb: don't mark of_dev_auxdata as initdata

2017-04-25 Thread Arnd Bergmann
The probe function is not __init since it can be called for deferred probing or when unbinding/rebinding the device, and therefore it must not reference objects in __initdata, as pointed out by this link time warning: WARNING: drivers/usb/musb/da8xx.o(.text+0x9d4): Section mismatch in reference f

Re: next build: 1 warnings 1 failures (next/next-20170424)

2017-04-25 Thread Arnd Bergmann
On Mon, Apr 24, 2017 at 11:58 AM, Olof's autobuilder wrote: > --- > > Errors: > > arm.allmodconfig: > ERROR: "__aeabi_uldivmod" [drivers/gpu/drm/arm/mali-dp.ko] undefined! patch sent. > > Warnings: > > 1 dr

Re: [PATCH 0/4] MMC support for Octeon platforms.

2017-04-25 Thread Ulf Hansson
On 25 April 2017 at 21:54, Ralf Baechle wrote: > On Mon, Apr 24, 2017 at 09:56:42PM +0200, Ulf Hansson wrote: > >> Thanks, applied patch 1->3. Patch 4 is for the MIPS SoC maintainer, >> unless I get an ack for it. > > Here's the Ack for patch 4: > > Acked-by: Ralf Baechle > > Ralf Thanks, appl

[PATCH v2] acpi: fix acpi_get_table() leak / acpi-sysfs denial of service

2017-04-25 Thread Dan Williams
Reading an ACPI table through the /sys/firmware/acpi/tables interface more than 65,536 times leads to the following log message: ACPI Error: Table 88033595eaa8, Validation count is zero after increment (20170119/tbutils-423) ...and the table being unavailable until the next reboot. Add the

Re: [Intel-gfx] GPU hangs and X shot down with 4.11-rc6

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 06:41:20PM +0200, Michal Hocko wrote: > Hi, > I have just experienced X being shut down once with 4.11-rc2 and 2 times > with 4.11-rc6 kernel. I do not remember seeing something like this > before but it is quite possible I was just lucky to not trigger this > issue before.

Re: [PATCH 00/16] Intel FPGA Device Drivers

2017-04-25 Thread One Thousand Gnomes
> That is where we disagree. I do not see bitstream as firmware. For instance > now you can run OpenCL on some FPGA, so this is exactly like GPU we should > request open source stack from OpenCL down to bitstream. It's an accelerator with a bunch of firmwares where you load the right one. We've go

Re: [PATCH v5 2/5] vfs: Add checks for filesystem timestamp limits

2017-04-25 Thread Linus Torvalds
On Tue, Apr 25, 2017 at 12:47 PM, Arnd Bergmann wrote: > > There is one global option that I want to see, and that is for completely > disabling all components that are known to be broken in y2038. I really don't see the point. Don't do it. Make it some local hack, I'm not taking crazy patches.

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > Ah, I missed the "n" in various #ifndef statements. > > I can't really comment on how to solve that; I simply don't know. > Also, even with a dt property, it still would be necessary to have > a non-DT means to configure one or the o

Re: next-20170424 build: 1 failures 0 warnings (next-20170424)

2017-04-25 Thread Arnd Bergmann
On Mon, Apr 24, 2017 at 1:54 PM, Build bot for Mark Brown wrote: > Tree/Branch: next-20170424 > Git describe: next-20170424 > Commit: ee91aaf669 Add linux-next specific files for 20170424 > > Build Time: 116 min 41 sec > > Passed:9 / 10 ( 90.00 %) > Failed:1 / 10 ( 10.00 %) > > Errors:

[PATCH] drm: mali-dp: use div_u64 for expensive 64-bit divisions

2017-04-25 Thread Arnd Bergmann
On 32-bit machines, we can't divide 64-bit integers: drivers/gpu/drm/arm/malidp_crtc.o: In function `malidp_crtc_atomic_check': malidp_crtc.c:(.text.malidp_crtc_atomic_check+0x3c0): undefined reference to `__aeabi_uldivmod' malidp_crtc.c:(.text.malidp_crtc_atomic_check+0x3dc): undefined reference

Re: [PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c

2017-04-25 Thread Dan Carpenter
On Tue, Apr 25, 2017 at 09:02:48PM +0200, Ilia Sergachev wrote: > Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c You're going to have to split this into multiple patches. > > Signed-off-by: Ilia Sergachev > Ugh... What kind of email address is that? > Cc: de...@driver

Re: [PATCH 0/4] MMC support for Octeon platforms.

2017-04-25 Thread Ralf Baechle
On Mon, Apr 24, 2017 at 09:56:42PM +0200, Ulf Hansson wrote: > Thanks, applied patch 1->3. Patch 4 is for the MIPS SoC maintainer, > unless I get an ack for it. Here's the Ack for patch 4: Acked-by: Ralf Baechle Ralf

[PATCH v3] usb: misc: legousbtower: Fix buffers on stack

2017-04-25 Thread Maksim Salau
Allocate buffers on HEAP instead of STACK for local structures that are to be received using usb_control_msg(). Signed-off-by: Maksim Salau --- Changes in v3: * rebased against usb-next; * removed Tested-by: Alfredo Rafael Vicente Boix ; * removed Cc: sta...@vger.kernel.org since

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Brendan Higgins
On Tue, Apr 25, 2017 at 2:47 AM, Ryan Chen wrote: > Thanks Ryan. Can you shed some light on the meaning of the high-speed bit as > well please ? > > About ASPEED_I2CD_M_HIGH_SPEED_EN, it is support for I2C specification "High > speed transfer". And also device need support it. > If you just spee

Re: [PATCH 1/2] x86/mm/ident_map: Add PUD level 1GB page support

2017-04-25 Thread Yinghai Lu
On Tue, Apr 25, 2017 at 2:13 AM, Xunlei Pang wrote: > The current kernel_ident_mapping_init() creates the identity > mapping using 2MB page(PMD level), this patch adds the 1GB > page(PUD level) support. > > This is useful on large machines to save some reserved memory > (as paging structures) in t

Re: [PATCH v5 2/5] vfs: Add checks for filesystem timestamp limits

2017-04-25 Thread Arnd Bergmann
On Sun, Apr 9, 2017 at 4:58 AM, Deepa Dinamani wrote: >>> Allow read only mounts for filesystems that do not >>> have maximum timestamps beyond the y2038 expiry >>> timestamp. >> >> This option seems arbitrary and pointless. >> >> Nobody sane should ever enable it except for testing, but for testi

[PATCH] acpi: fix acpi_get_table() leak / acpi-sysfs denial of service

2017-04-25 Thread Dan Williams
Reading an ACPI table through the /sys/firmware/acpi/tables interface more than 65,536 times leads to the following log message: ACPI Error: Table 88033595eaa8, Validation count is zero after increment (20170119/tbutils-423) ...and the table being unavailable until the next reboot. Add the

Re: [PATCH] RFC: serial: core: Dynamic minor support

2017-04-25 Thread Alan Cox
> Furthermore some other drivers rely upon the usage of a dynamic major > e.g. the tegra serial port driver. However as there is only a block of > 20 major numbers reserved for dynamic assignment that isn't going to > scale either for multiplatform kernels (I can already easily build 18 > different

Re: Revised statx(2) man page for review

2017-04-25 Thread Michael Kerrisk (man-pages)
Hello Silvan, On 04/25/2017 08:50 PM, Silvan Jegen wrote: > Hi Michael > > On Tue, Apr 25, 2017 at 01:14:26PM +0200, Michael Kerrisk (man-pages) wrote: >> >> [...] >> >> Could you please carefully review the text below, in case >> I added any errors. > > Just a few comments below. > > >> [..

Re: [PATCH 5/7] IB/hfi1: use pcie_flr instead of duplicating it

2017-04-25 Thread Bjorn Helgaas
On Mon, Apr 24, 2017 at 04:35:07PM +0200, Christoph Hellwig wrote: > On Mon, Apr 24, 2017 at 02:16:31PM +, Byczkowski, Jakub wrote: > > Tested-by: Jakub Byczkowski > > Are you (and Doug) ok with queueing this up in the PCI tree? Applied this with Jakub's tested-by and Doug's ack to pci/virtu

Re: [PATCH] arm64: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-04-25 Thread Laura Abbott
On 04/25/2017 11:22 AM, Catalin Marinas wrote: > The dma_common_pages_remap() function allocates a vm_struct object and > initialises the pages pointer to value passed as argument. However, when > this function is called dma_common_contiguous_remap(), the pages array > is only temporarily allocated

Re: [patch 2/2] MM: allow per-cpu vmstat_threshold and vmstat_worker configuration

2017-04-25 Thread Marcelo Tosatti
On Tue, Apr 25, 2017 at 03:29:06PM -0400, Rik van Riel wrote: > On Tue, 2017-04-25 at 10:57 -0300, Marcelo Tosatti wrote: > > The per-CPU vmstat worker is a problem on -RT workloads (because > > ideally the CPU is entirely reserved for the -RT app, without > > interference). The worker transfers ac

Re: [RFC PATCH 0/4] PM / Domains: Add support for explicit control of PM domains

2017-04-25 Thread Ulf Hansson
On 25 April 2017 at 13:13, Jon Hunter wrote: > > On 28/03/17 15:13, Jon Hunter wrote: >> The current generic PM domain framework (GenDP) only allows a single >> PM domain to be associated with a given device. There are several >> use-cases for various system-on-chip devices where it is necessary f

[PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c

2017-04-25 Thread Ilia Sergachev
Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c Signed-off-by: Ilia Sergachev Cc: de...@driverdev.osuosl.org,linux-kernel@vger.kernel.org --- drivers/staging/ks7010/ks_wlan_net.c | 81 ++-- 1 file changed, 49 insertions(+), 32 deletions(-)

Re: [PATCH 1/1 linux-next] scripts/coccinelle/misc: Warn about NULL check on kmap()

2017-04-25 Thread Julia Lawall
On Tue, 25 Apr 2017, Fabian Frederick wrote: > This script removes NULL check on kmap() and all process involved > (OOM message ...) > > Thanks to Jan Kara for explanations. > > Signed-off-by: Fabian Frederick Acked-by: Julia Lawall > --- > scripts/coccinelle/misc/kmap.cocci | 43 > +++

Re: [PATCH v5 0/2] security: tty: make TIOCSTI ioctl require CAP_SYS_ADMIN

2017-04-25 Thread One Thousand Gnomes
On Tue, 25 Apr 2017 15:56:32 +0200 Jann Horn wrote: > On Tue, Apr 25, 2017 at 3:47 PM, Alan Cox wrote: > >> There could be a few user programs that would be effected by this > >> change. > >> See: > >> notable programs are: agetty, cs

Re: [PATCH 1/1] PCI: check return value of pci_find_ext_capability

2017-04-25 Thread Bjorn Helgaas
On Mon, Apr 24, 2017 at 01:36:58PM +0300, Mika Westerberg wrote: > On Sun, Apr 23, 2017 at 10:00:20PM +0800, Pan Bian wrote: > > From: Pan Bian > > > > Function pci_find_ext_capability() will returns 0 on failure, and its > > return value should be checked before it is used. However, in function

Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors

2017-04-25 Thread Markus Mayer
Hi Rob, On 18 April 2017 at 13:17, Markus Mayer wrote: > From: Markus Mayer > > Provide bindings for the Broadcom STB DDR PHY Front End (DPFE). Would you be able to have a look at this binding? The driver won't be upstreamed as hwmon driver (as per Guenter's comments). I am currently converting

Re: [patch 2/2] MM: allow per-cpu vmstat_threshold and vmstat_worker configuration

2017-04-25 Thread Rik van Riel
On Tue, 2017-04-25 at 10:57 -0300, Marcelo Tosatti wrote: > The per-CPU vmstat worker is a problem on -RT workloads (because > ideally the CPU is entirely reserved for the -RT app, without > interference). The worker transfers accumulated per-CPU  > vmstat counters to global counters. > > To resol

Re: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"

2017-04-25 Thread Joe Perches
On Tue, 2017-04-25 at 14:04 -0500, Bjorn Helgaas wrote: > On Fri, Apr 21, 2017 at 08:02:30AM +0100, Colin King wrote: > > From: Colin Ian King > > > > trivial fix to spelling mistake in dev_err message > > > > Signed-off-by: Colin Ian King > > Applied with Richard's ack to pci/host-imx6 for v4

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-25 Thread Matthias Kaehlcke
El Tue, Apr 25, 2017 at 07:06:30PM +0100 Ard Biesheuvel ha dit: > On 25 April 2017 at 18:39, Matthias Kaehlcke wrote: > > Hi, > > > > El Tue, Apr 18, 2017 at 04:35:02PM +0100 Ard Biesheuvel ha dit: > > > >> On 18 April 2017 at 15:47, Paul Gortmaker > >> wrote: > >> > On Wed, Apr 5, 2017 at 2:34

Re: [PATCH v2 09/23] MAINTAINERS: Add file patterns for infiniband device tree bindings

2017-04-25 Thread Doug Ledford
On Sun, 2017-03-26 at 10:45 +0200, Geert Uytterhoeven wrote: > Hi Doug, > > On Sat, Mar 25, 2017 at 3:40 AM, Doug Ledford > wrote: > > > > On Sun, 2017-03-12 at 14:16 +0100, Geert Uytterhoeven wrote: > > > > > > Submitters of device tree binding documentation may forget to CC > > > the subsyste

Re: [RESEND PATCH 3/3] infiniband: hns: avoid gcc-7.0.1 warning for uninitialized data

2017-04-25 Thread Doug Ledford
On Fri, 2017-03-24 at 23:02 +0100, Arnd Bergmann wrote: > hns_roce_v1_cq_set_ci() calls roce_set_bit() on an uninitialized > field, > which will then change only a few of its bits, causing a warning with > the latest gcc: > > infiniband/hw/hns/hns_roce_hw_v1.c: In function > 'hns_roce_v1_cq_set_ci

[GIT PULL rcu/urgent] Make SRCU be built by default

2017-04-25 Thread Paul E. McKenney
Hello, Ingo, This commit causes SRCU to be built by default. This handles the surprisingly common case where include/linux/srcu.h is included into files being built with CONFIG_SRCU=n. The fact that there is now a Tiny SRCU means that this should be OK from a Linux-kernel tinification perspectiv

Re: [PATCH] x86/amd: don't set X86_BUG_SYSRET_SS_ATTRS if forced to zero

2017-04-25 Thread Borislav Petkov
On Tue, Apr 25, 2017 at 08:34:34PM +0200, Juergen Gross wrote: > And what happens when there is a scheduling event right here? > __switch_to() will see X86_BUG_SYSRET_SS_ATTRS set and take a wrong > path. So the whole thing we're doing right now is wrong: set bit and then clear bit. We should not

[PATCH v3 2/2] x86/mce/AMD: Carve out SMCA bank configuration

2017-04-25 Thread Yazen Ghannam
From: Yazen Ghannam Scalable MCA systems have a new MCA_CONFIG register that we use to configure each bank. We currently use this when we set up thresholding. However, this is logically separate. Group all SMCA-related initialization into a single, separate function. This includes setting MCA_CO

[PATCH v3 1/2] x86/mce/AMD: Redo logging of errors from APIC LVT interrupts

2017-04-25 Thread Yazen Ghannam
From: Yazen Ghannam We have support for the new SMCA MCA_DE{STAT,ADDR} registers in Linux. So we've used these registers in place of MCA_{STATUS,ADDR} on SMCA systems. However, the guidance for current implementations of SMCA is to continue using MCA_{STATUS,ADDR} and to use MCA_DE{STAT,ADDR} onl

Re: [PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

2017-04-25 Thread Jacek Anaszewski
Hi Alexandre, Thanks for the patch. On 04/25/2017 08:19 AM, Alexandre Courbot wrote: > v4l2_m2m_job_finish(), which is called from the interrupt handler with > slock acquired, can call the device_run() hook immediately if another > context was in the queue. This hook also acquires slock, resultin

Re: [PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c

2017-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 25, 2017 at 09:02:48PM +0200, Ilia Sergachev wrote: > Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c What type of warnings? What checks? It builds just fine for me here. You need to be very specific. And only do one type of thing per patch, a big "fixes all t

Re: [PATCH] ARM: dts: bcm-cygnus: Add 911360's V3D device.

2017-04-25 Thread Florian Fainelli
On Tue, 18 Apr 2017 16:32:34 -0700, Eric Anholt wrote: > This loads the VC4 driver on the 911360_entphn platform (with the > corresponding series sent to dri-devel), which is supported by master > of the Mesa tree. > > Signed-off-by: Eric Anholt > --- Applied, thanks! -- Florian

Re: [PATCH v3] soc: brcmstb: enable drivers for ARM64 and BMIPS

2017-04-25 Thread Florian Fainelli
On 04/20/2017 09:55 AM, Markus Mayer wrote: > From: Markus Mayer > > We enable the BRCMSTB SoC drivers not only for ARM, but also ARM64 and > BMIPS. > > Signed-off-by: Markus Mayer Applied, thanks! -- Florian

Re: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"

2017-04-25 Thread Bjorn Helgaas
On Fri, Apr 21, 2017 at 08:02:30AM +0100, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in dev_err message > > Signed-off-by: Colin Ian King Applied with Richard's ack to pci/host-imx6 for v4.12, thanks. FWIW, there are about 25 other occurrences of "contol" in

Re: [PATCH] x86/mm/64: Fix crash in remove_pagetable()

2017-04-25 Thread Dan Williams
On Tue, Apr 25, 2017 at 11:53 AM, Ingo Molnar wrote: > > * Dan Williams wrote: > >> On Tue, Apr 25, 2017 at 2:25 AM, Kirill A. Shutemov >> wrote: >> > remove_pagetable() does page walk using p*d_page_vaddr() plus cast. >> > It's not canonical approach -- we usually use p*d_offset() for that. >>

Re: [PATCH] staging: android: ion: fix coding style issue

2017-04-25 Thread Greg KH
On Sun, Apr 23, 2017 at 03:37:29PM +0530, Adheer Chandravanshi wrote: > Use tab instead of spaces for indentation, as reported by checkpatch.pl > > Signed-off-by: Adheer Chandravanshi > --- > drivers/staging/android/ion/ion_cma_heap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [RFC 0/6] optimize ctx switch with rb-tree

2017-04-25 Thread David Carrillo-Cisneros
> > If I disable traversing in the per-process case then the overhead disappears. > > For the system-wide case the ctx->pinned_groups and ctx->flexible_groups > lists are parts of per-cpu perf_cpu_context object and count of iterations is > small (#events == 29). Yes, seems like it would benefi

Re: [PATCH] net: ipv6: check route protocol when deleting routes

2017-04-25 Thread David Ahern
On 4/24/17 3:48 AM, Lorenzo Colitti wrote: > For non-stable kernels, it seems that the proper fix would be: > > 1. Ensure that when an RA creates a route, it properly sets > rtm_protocol at time of route creation. > 2. When we dump routes to userspace, we don't overwrite the rtm_protocol. +1

Re: [PATCH] x86/mm/64: Fix crash in remove_pagetable()

2017-04-25 Thread Ingo Molnar
* Dan Williams wrote: > On Tue, Apr 25, 2017 at 2:25 AM, Kirill A. Shutemov > wrote: > > remove_pagetable() does page walk using p*d_page_vaddr() plus cast. > > It's not canonical approach -- we usually use p*d_offset() for that. > > > > It works fine as long as all page table levels are presen

Re: Revised statx(2) man page for review

2017-04-25 Thread Silvan Jegen
Hi Michael On Tue, Apr 25, 2017 at 01:14:26PM +0200, Michael Kerrisk (man-pages) wrote: > > [...] > > Could you please carefully review the text below, in case > I added any errors. Just a few comments below. > [...] > >Invoking statx(): >To access a file's status, no permissio

Re: [PATCH 2/2] sched/fair: Always propagate runnable_load_avg

2017-04-25 Thread Tejun Heo
Hello, On Tue, Apr 25, 2017 at 02:59:18PM +0200, Vincent Guittot wrote: > >> So you are changing the purpose of propagate_entity_load_avg which > >> aims to propagate load_avg/util_avg changes only when a task migrate > >> and you also want to propagate the enqueue/dequeue in the parent > >> cfs_r

Re: [PATCH 1/2] kvm: Fix mmu_notifier release race

2017-04-25 Thread Radim Krčmář
2017-04-24 11:10+0100, Suzuki K Poulose: > The KVM uses mmu_notifier (wherever available) to keep track > of the changes to the mm of the guest. The guest shadow page > tables are released when the VM exits via mmu_notifier->ops.release(). > There is a rare chance that the mmu_notifier->release cou

[PATCH v6 3/5] rxrpc: check return value of skb_to_sgvec always

2017-04-25 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld --- net/rxrpc/rxkad.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index 4374e7b9c7bf..dcf46c9c3ece 100644 --- a/net/rxrpc/rxkad.c +++ b/net/rxrpc/rxkad.c @@ -229,7 +229,9 @@ static int rxkad

[PATCH v6 2/5] ipsec: check return value of skb_to_sgvec always

2017-04-25 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld --- net/ipv4/ah4.c | 8 ++-- net/ipv4/esp4.c | 30 -- net/ipv6/ah6.c | 8 ++-- net/ipv6/esp6.c | 31 +-- 4 files changed, 53 insertions(+), 24 deletions(-) diff --git a/net/ipv4/ah4.c b/net/ipv4

[PATCH v6 5/5] virtio_net: check return value of skb_to_sgvec always

2017-04-25 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld --- drivers/net/virtio_net.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index f36584616e7d..1709fd0b4bf7 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1081,

[PATCH v6 4/5] macsec: check return value of skb_to_sgvec always

2017-04-25 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld --- drivers/net/macsec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index dbab05afcdbe..d846f42b99ec 100644 --- a/drivers/net/macsec.c +++ b/drivers/net/macsec.c @@ -733,7 +733,12

[PATCH v6 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow

2017-04-25 Thread Jason A. Donenfeld
This is a defense-in-depth measure in response to bugs like 4d6fa57b4dab ("macsec: avoid heap overflow in skb_to_sgvec"). While we're at it, we also limit the amount of recursion this function is allowed to do. Not actually providing a bounded base case is a future diaster that we can easily avoid

<    1   2   3   4   5   6   7   8   9   10   >