Re: [PATCH] mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it

2018-12-02 Thread Frank Lee
On Sun, Dec 2, 2018 at 4:40 PM Boris Brezillon wrote: > > Should be [PATCH v4] > > On Sun, 2 Dec 2018 03:33:58 -0500 > Yangtao Li wrote: > > > DEFINE_SHOW_ATTRIBUTE macro can help us simplify the code,so change > > to it.And change the DEBUGFS_RO_ATTR macro defined in some file to a > > standard

Re: [PATCH] mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it

2018-12-02 Thread Boris Brezillon
Should be [PATCH v4] On Sun, 2 Dec 2018 03:33:58 -0500 Yangtao Li wrote: > DEFINE_SHOW_ATTRIBUTE macro can help us simplify the code,so change > to it.And change the DEBUGFS_RO_ATTR macro defined in some file to a > standard macro. You still don't put spaces after commas or periods > > Signe

Re: [PATCH 1/1] stackleak: Register the 'stackleak_cleanup' pass before the 'mach' pass

2018-12-02 Thread kbuild test robot
Hi Alexander, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20-rc4 next-20181130] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu

Re: [PATCH v3] mtd: remove DEBUGFS_RO_ATTR()

2018-12-02 Thread Frank Lee
On Sun, Dec 2, 2018 at 4:15 PM Boris Brezillon wrote: > > Looks like getting rid of DEBUGFS_RO_ATTR() is just one of the change > you do. I think you should change the subject line: > > "mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it" > > This way it covers all of your changes. > > On

[PATCH] mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it

2018-12-02 Thread Yangtao Li
DEFINE_SHOW_ATTRIBUTE macro can help us simplify the code,so change to it.And change the DEBUGFS_RO_ATTR macro defined in some file to a standard macro. Signed-off-by: Yangtao Li --- drivers/mtd/devices/docg3.c| 16 drivers/mtd/devices/docg3.h| 11 --- drivers/mt

Re: [PATCH v3] mtd: remove DEBUGFS_RO_ATTR()

2018-12-02 Thread Boris Brezillon
Looks like getting rid of DEBUGFS_RO_ATTR() is just one of the change you do. I think you should change the subject line: "mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it" This way it covers all of your changes. On Sun, 2 Dec 2018 02:32:02 -0500 Yangtao Li wrote: > We already have

[PATCH] perf beauty mmap_flags: Fixed syntax error Fixed missing ']' error Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Sihyeon Jang

2018-12-02 Thread Sihyeon Jang
--- tools/perf/trace/beauty/mmap_flags.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/trace/beauty/mmap_flags.sh b/tools/perf/trace/beauty/mmap_flags.sh index cd41023107d7..32bac9c0d694 100755 --- a/tools/perf/trace/beauty/mmap_flags.sh +++ b/tools/perf/trac

<    1   2   3   4