Re: [PATCH v2 9/9] rtc: Add support for the MediaTek MT6358 RTC

2019-03-10 Thread Eddie Huang
if (rtc->irq < 0) > return rtc->irq; > @@ -420,6 +431,7 @@ static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, > mt6397_rtc_suspend, > mt6397_rtc_resume); > > static const struct of_device_id mt6397_rtc_of_match[] = { > + { .compatible = "mediatek,mt6358-rtc", }, > { .compatible = "mediatek,mt6397-rtc", }, > { } > }; Without the log, you can my get Acked-by: Eddie Huang

Re: [PATCH v2 8/9] rtc: mt6397: fix alarm register overwrite

2019-03-10 Thread Eddie Huang
("rtc: mediatek: Add MT6397 RTC driver") > > Signed-off-by: Ran Bi > --- > drivers/rtc/rtc-mt6397.c | 47 +-- > 1 file changed, 33 insertions(+), 14 deletions(-) > Thanks your interrupt and race condition fix Acked-by: Eddie Huang

Re: [PATCH 1/3] rtc: mt6397: fix possible race condition

2018-09-11 Thread Eddie Huang
ice to allocate the rtc > before requesting the IRQ. > > Cc: Eddie Huang > Cc: Sean Wang > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-mt6397.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/rtc/rt

Re: [PATCH 3/4] rtc: mediatek: enhance the description for MediaTek PMIC based RTC

2017-09-22 Thread Eddie Huang
Hi Sean, On Fri, 2017-09-22 at 11:33 +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Give a better description for original MediaTek RTC driver as PMIC based > RTC in order to distinguish SoC based RTC. Also turning all words with > Mediatek to MediaTek here. >

Re: [PATCH v4 1/3] cpufreq: mediatek: Add support of cpufreq to MT2701/MT7623 SoC

2017-07-12 Thread Eddie Huang
On Thu, 2017-07-13 at 08:46 +0530, Viresh Kumar wrote: > On 12-07-17, 16:50, Matthias Brugger wrote: > > Hi Eddie, > > > > On 07/11/2017 04:49 AM, Eddie Huang wrote: > > >Hi Sean, > > > > > >On Mon, 2017-07-10 at 22:23 +0800, sea

Re: [PATCH v4 1/3] cpufreq: mediatek: Add support of cpufreq to MT2701/MT7623 SoC

2017-07-10 Thread Eddie Huang
Hi Sean, On Mon, 2017-07-10 at 22:23 +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > MT2701/MT7623 is a 32-bit ARMv7 based quad-core (4 * Cortex-A7) with > single cluster and this hardware is also compatible with the existing > driver through enabling CPU frequency feature with operat

Re: [PATCH v6 3/3] arm: dts: mt2701: Add node for Mediatek JPEG Decoder

2017-01-09 Thread Eddie Huang
Hi Matthias, On Mon, 2017-01-09 at 19:45 +0100, Matthias Brugger wrote: > > On 09/01/17 12:29, Hans Verkuil wrote: > > Hi Rick, > > > > On 01/06/2017 03:34 AM, Rick Chang wrote: > >> Hi Hans, > >> > >> The dependence on [1] has been merged in 4.10, but [2] has not.Do you have > >> any idea about

Re: [PATCH v4 5/5] ARM: dts: mt2701: add iommu/smi dtsi node for mt2701

2016-06-21 Thread Eddie Huang
On Tue, 2016-06-21 at 17:57 +0800, Joerg Roedel wrote: > On Wed, Jun 08, 2016 at 05:51:01PM +0800, honghui.zh...@mediatek.com wrote: > > From: Honghui Zhang > > > > Add the dtsi node of iommu and smi for mt2701. > > > > Signed-off-by: Honghui Zhang > > --- > > arch/arm/boot/dts/mt2701.dtsi | 5

Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver

2016-04-21 Thread Eddie Huang
Hi Matthias, On Thu, 2016-04-21 at 12:58 +0200, Matthias Brugger wrote: > > On 21/04/16 12:26, Matthias Brugger wrote: > > > > > > On 02/09/15 19:23, Matthias Brugger wrote: > >> > >> > >> On 02/09/15 08:45, Daniel Kurtz wrote: > >>> Matthias, > >>> > >>> On Fri, Aug 28, 2015 at 10:06 PM, Rafael

NVMEM usage question

2016-03-14 Thread Eddie Huang
Hi, Mediatek PMIC chip have some spare registers used to store information. The value of these registers will exist until user unplug battery or battery depletion. One of our usage example is store battery utilization in these spare registers. We want to implement NVMEM driver to read/write sparse

[PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue

2016-02-18 Thread Eddie Huang
power, so add pwrapper using USB power domain to keep USB power domain not to zero and disabled. Signed-off-by: Eddie Huang --- Sascha sent similar patch before[0], but MMC support runtime-pm, vcore power domain still be disabled after MMC and USB suspend. This silicon bug already fix in MT8173

Re: [PATCH] rtc: mt6397: Add platform device ID table

2016-02-16 Thread Eddie Huang
On Tue, 2016-02-16 at 12:37 +0100, Arnd Bergmann wrote: > On Monday 15 February 2016 11:50:48 Javier Martinez Canillas wrote: > > > > On 02/14/2016 10:58 PM, Eddie Huang wrote: > > > > [snip] > > > > >> @@ -412,6 +418,7 @@

Re: [PATCH] rtc: mt6397: Add platform device ID table

2016-02-14 Thread Eddie Huang
On Tue, 2016-02-09 at 08:08 -0300, Javier Martinez Canillas wrote: > The platform bus_type .match callback attempts to match the platform device > name with an entry on the .id_table if provided and fallbacks to match with > the driver's name if a table is not provided. > > Using a platform device

Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

2016-01-31 Thread Eddie Huang
On Tue, 2016-01-19 at 15:29 +0800, Sascha Hauer wrote: > Eduardo, > > On Mon, Jan 04, 2016 at 03:19:40PM +0100, Sascha Hauer wrote: > > Hi Eduardo, > > > > > > > > That should remove the policy of computing the maximum from this driver. > > > Please have a look on the work being done [1] to add

Re: [PATCH] rtc: mt6397: add IRQ domain dependency

2016-01-25 Thread Eddie Huang
mp; IRQ_DOMAIN) > help > This selects the Mediatek(R) RTC driver. RTC is part of Mediatek > MT6397 PMIC. You should enable MT6397 PMIC MFD before select Hi Arnd, Thanks your correction. Acked-by: Eddie Huang Regards, Eddie

Re: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135

2015-11-13 Thread Eddie Huang
On Thu, 2015-11-12 at 15:56 -0800, Kevin Hilman wrote: > Eddie Huang writes: > > > On Wed, 2015-11-11 at 20:54 -0800, Kevin Hilman wrote: > >> Hi Eddie, > >> > >> Kevin Hilman writes: > >> > >> > Eddie Huang writes: > >

[PATCH] soc: Mediatek: Enable SCPSYS power domain driver by default

2015-11-13 Thread Eddie Huang
If enable Mediatek 8173 SoC, it should also enable power domain driver. Otherwise access clk subsystem register will fail. Signed-off-by: Eddie Huang --- MT8173 clk driver is enabled by default, but power domain driver is not. If MM subsystem power on, mm_sel topckgen mux is off, then access

Re: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135

2015-11-12 Thread Eddie Huang
On Wed, 2015-11-11 at 20:54 -0800, Kevin Hilman wrote: > Hi Eddie, > > Kevin Hilman writes: > > > Eddie Huang writes: > > > >> On Tue, 2015-11-10 at 17:16 -0800, Kevin Hilman wrote: > >>> Hi Eddie, > >>> > >>> [...] >

Re: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135

2015-11-10 Thread Eddie Huang
Hi Kevin, On Tue, 2015-11-10 at 17:16 -0800, Kevin Hilman wrote: > Hi Eddie, > > [...] > > > I check the log [0], > > Thanks for checking into this boot failure. > > > it seems first time mt8135-evbp1 boot to kernel > > shell successfully, then boot again. In the second time, mt8135 stay in >

Re: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135

2015-11-09 Thread Eddie Huang
On Mon, 2015-11-09 at 09:59 -0800, Kevin Hilman wrote: > On Mon, Oct 26, 2015 at 4:40 AM, Eddie Huang wrote: > > Hi Kevin, > > > > On Mon, 2015-10-26 at 17:06 +0900, Kevin Hilman wrote: > >> On Mon, Oct 26, 2015 at 4:15 PM, Yingjoe Chen > >> wrote: &

Re: [PATCH 0/2] Mediatek I2C driver fixup

2015-11-01 Thread Eddie Huang
On Tue, 2015-10-27 at 16:59 +0800, Liguo Zhang wrote: > This series contain two patches, first is to optimize Mediatek I2C driver to > use WRRD > if hardware support auto restart. Because auto restart will issue auto restart > interrupt, change to use WRRD can reduce interrupt latency. The second

Re: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135

2015-10-29 Thread Eddie Huang
On Thu, 2015-10-29 at 02:12 -0700, Kevin Hilman wrote: > Eddie Huang writes: > > > Hi Kevin, > > > > On Mon, 2015-10-26 at 17:06 +0900, Kevin Hilman wrote: > >> On Mon, Oct 26, 2015 at 4:15 PM, Yingjoe Chen > >> wrote: > >> > On Mon, 2015-1

Re: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135

2015-10-26 Thread Eddie Huang
Hi Kevin, On Mon, 2015-10-26 at 17:06 +0900, Kevin Hilman wrote: > On Mon, Oct 26, 2015 at 4:15 PM, Yingjoe Chen > wrote: > > On Mon, 2015-10-26 at 09:56 +0900, Kevin Hilman wrote: > >> Hello, > >> > >> On Sat, Oct 3, 2015 at 12:19 AM, Yingjoe Chen > >> wrote: > >> > Add arch timer node to ena

[PATCH] i2c: mediatek: add i2c resume support

2015-10-06 Thread Eddie Huang
From: Liguo Zhang mt65xx i2c controller initial setting will be cleared after system suspend, so we should init mt65xx i2c controller again when system resume. Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang --- drivers/i2c/busses/i2c-mt65xx.c | 16 1 file changed, 16

Re: [GIT PULL] clk: mediatek: New clocks support and fixes

2015-10-01 Thread Eddie Huang
On Thu, 2015-10-01 at 12:29 -0700, Stephen Boyd wrote: > On 09/30, Daniel Kurtz wrote: > > Hi Mike, > > > > On Tue, Sep 22, 2015 at 5:53 PM, James Liao > > wrote: > > > This is a collection of new Mediatek clocks support and fixes. These > > > patches come from Joe [1], Pi-cheng [2] and me [3],

[PATCH v3] soc: mediatek: add scpsys support active_wakeup

2015-08-26 Thread Eddie Huang
Register gpd_dev_ops.active_wakeup function to support keep power during suspend state. And add flag to each power domain to decide whether keep power during suspend or not. Signed-off-by: Chunfeng Yun Signed-off-by: Eddie Huang Acked-by: Sascha Hauer Reviewed-by: Daniel Kurtz --- Change in

Re: [PATCH v2] soc: mediatek: add scpsys support active_wakeup

2015-08-25 Thread Eddie Huang
On Wed, 2015-08-26 at 05:11 +0800, Daniel Kurtz wrote: > Hi Eddie, > > On Tue, Aug 25, 2015 at 2:00 PM, Eddie Huang wrote: > > Register gpd_dev_ops.active_wakeup function to support keep power > > during suspend state. And add flag to each power domain to > > decid

[PATCH v2] soc: mediatek: add scpsys support active_wakeup

2015-08-24 Thread Eddie Huang
Register gpd_dev_ops.active_wakeup function to support keep power during suspend state. And add flag to each power domain to decide whether keep power during suspend or not. Signed-off-by: Chunfeng Yun Signed-off-by: Eddie Huang Acked-by: Sascha Hauer --- Change in v2: Drop .active_wakeup

Re: [PATCH] soc: mediatek: add scpsys support active_wakeup

2015-08-23 Thread Eddie Huang
On Thu, 2015-07-23 at 14:00 +0800, Eddie Huang wrote: > Register gpd_dev_ops.active_wakeup function to support keep power > during suspend state. And add flag to each power domain to > decide whether keep power during suspend or not. > > Signed-off-by: Chunfeng Yun > Signed-o

[PATCH v2 2/2] i2c: mediatek: Fixup i2c ack error interrupt handling

2015-08-06 Thread Eddie Huang
When occur i2c ack error, i2c controller generate two interrupts, first is the ack error interrupt, then the complete interrupt. i2c interrupt handler should keep the two interrupt value, and only call complete() for the complete interrupt. Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang

[PATCH v2 1/2] i2c: mediatek: Reset DMA engine in hardware init function

2015-08-06 Thread Eddie Huang
Reset DMA in hardware init function to avoid unknown hardware state before do any I2C operation. Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang --- drivers/i2c/busses/i2c-mt65xx.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c

[PATCH v2 0/2] Mediatek I2C fixup

2015-08-06 Thread Eddie Huang
bug - in mtk_i2c_irq(), call complete() if get I2C_RS_TRANSFER interrupt Eddie Huang (2): i2c: mediatek: Reset DMA engine in hardware init function i2c: mediatek: Fixup i2c ack error interrupt handling drivers/i2c/busses/i2c-mt65xx.c | 21 + 1 file changed, 17 insertions

[PATCH 1/2] i2c: mediatek: Reset DMA engine in hardware init function

2015-08-04 Thread Eddie Huang
Reset DMA in hardware init function to avoid unknown hardware state before do any I2C operation. Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang --- drivers/i2c/busses/i2c-mt65xx.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c

[PATCH 2/2] i2c: mediatek: Fixup i2c ack error interrupt handling

2015-08-04 Thread Eddie Huang
When occur i2c ack error, mtk_i2c_irq is called twice, first is the ack error interrupt, then the complete interrupt. i2c interrupt handler should keep the two interrupt value, and only call complete() for the complete interrupt. Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang

[PATCH 0/2] Mediatek I2C fixup

2015-08-04 Thread Eddie Huang
This series provide two patches to optimize mediatek i2c driver. The first patch will reset dma hardware in init function to make sure hardware work in good state. The second patch fix i2c interrupt handling for ACK error. All these patches base on v4.2-rc1. Eddie Huang (2): i2c: mediatek

Re: [PATCH] i2c: mediatek: fix transfer error handling

2015-08-03 Thread Eddie Huang
On Fri, 2015-07-31 at 13:00 +0200, Wolfram Sang wrote: > On Tue, Jul 28, 2015 at 11:38:05AM +0800, Eddie Huang wrote: > > From: Liguo Zhang > > > > Reset i2c dma engine in hw init function. > > When occur i2c ack error, mtk_i2c_irq may is twice, > > first is

Re: [PATCH] rtc: mt6397: implement suspend/resume function in rtc-mt6397 driver

2015-07-30 Thread Eddie Huang
ic struct platform_driver mtk_rtc_driver = { > .driver = { > .name = "mt6397-rtc", > .of_match_table = mt6397_rtc_of_match, > + .pm = &mt6397_pm_ops, > }, > .probe = mtk_rtc_probe, > .remove = mtk_rtc_remove, It look

[PATCH] i2c: mediatek: fix transfer error handling

2015-07-27 Thread Eddie Huang
-by: Liguo Zhang Signed-off-by: Eddie Huang --- drivers/i2c/busses/i2c-mt65xx.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c index 9920eef..57d11b7 100644 --- a/drivers/i2c/busses/

[PATCH v3 2/2] watchdog: mtk_wdt: add wdt shutdown callback to disable wdt if enabled

2015-07-24 Thread Eddie Huang
ff-by: Greta Zhang Signed-off-by: Eddie Huang Acked-by: Matthias Brugger Reviewed-by: Guenter Roeck --- drivers/watchdog/mtk_wdt.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c index 056412c..6ad9df9 100644 --- a/drivers/wat

[PATCH v3 1/2] watchdog: mtk_wdt: add suspend/resume support

2015-07-24 Thread Eddie Huang
From: Greta Zhang add mediatek watchdog driver suspend/resume support Signed-off-by: Greta Zhang Signed-off-by: Roger Lu Signed-off-by: Eddie Huang Acked-by: Matthias Brugger Reviewed-by: Guenter Roeck --- drivers/watchdog/mtk_wdt.c | 30 ++ 1 file changed, 30

[PATCH v3 0/2] Add Mediatek watchdog suspend resume and shutdown

2015-07-24 Thread Eddie Huang
This series add Mediatek watchdog suspend, resume and shutdown support. These patches are based on v4.2-rc1 Change in v3: Add mtk_wdt in subject line Change in v2: Use watchdog_active() to check whether watchdog been active. Change to register suspend,resume function to dev_pm_ops -- To unsubscr

[PATCH] soc: mediatek: add scpsys support active_wakeup

2015-07-22 Thread Eddie Huang
Register gpd_dev_ops.active_wakeup function to support keep power during suspend state. And add flag to each power domain to decide whether keep power during suspend or not. Signed-off-by: Chunfeng Yun Signed-off-by: Eddie Huang --- drivers/soc/mediatek/mtk-scpsys.c | 28

[PATCH v2 0/2] Add Mediatek watchdog suspend resume and shutdown

2015-07-22 Thread Eddie Huang
This series add Mediatek watchdog suspend, resume and shutdown support. These patches are based on v4.2-rc1 Change in v2: Use watchdog_active() to check whether watchdog been active. Change to register suspend,resume function to dev_pm_ops Greta Zhang (2): watchdog: add wdt suspend/resume suppo

[PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled

2015-07-22 Thread Eddie Huang
ff-by: Greta Zhang Signed-off-by: Eddie Huang --- drivers/watchdog/mtk_wdt.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c index 056412c..6ad9df9 100644 --- a/drivers/watchdog/mtk_wdt.c +++ b/drivers/watchdog/mtk_wdt.c @@ -

[PATCH v2 1/2] watchdog: add wdt suspend/resume support

2015-07-22 Thread Eddie Huang
From: Greta Zhang add wdt driver suspend/resume support Signed-off-by: Greta Zhang Signed-off-by: Roger Lu Signed-off-by: Eddie Huang --- drivers/watchdog/mtk_wdt.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/watchdog/mtk_wdt.c b/drivers

Re: [PATCH 1/2] watchdog: add wdt suspend/resume support

2015-07-22 Thread Eddie Huang
On Tue, 2015-07-21 at 20:45 -0700, Guenter Roeck wrote: > On 07/21/2015 08:26 PM, Eddie Huang wrote: > > From: Greta Zhang > > > > add wdt driver suspend/resume support > > > > Signed-off-by: Greta Zhang > > Signed-off-by: Roger Lu > > Signed-off-by

[PATCH 1/2] watchdog: add wdt suspend/resume support

2015-07-21 Thread Eddie Huang
From: Greta Zhang add wdt driver suspend/resume support Signed-off-by: Greta Zhang Signed-off-by: Roger Lu Signed-off-by: Eddie Huang --- drivers/watchdog/mtk_wdt.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/watchdog/mtk_wdt.c b

[PATCH 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled

2015-07-21 Thread Eddie Huang
ff-by: Greta Zhang Signed-off-by: Eddie Huang --- drivers/watchdog/mtk_wdt.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c index 5ef3910..c6741a5 100644 --- a/drivers/watchdog/mtk_wdt.c +++ b/drivers/watchdog/mtk_wdt.c @@ -

[PATCH 0/2] Add Mediatek watchdog suspend resume and shutdown

2015-07-21 Thread Eddie Huang
This series add Mediatek watchdog suspend, resume and shutdown support. These patches are based on v4.2-rc1 Greta Zhang (2): watchdog: add wdt suspend/resume support watchdog: add wdt shutdown callback to disable wdt if enabled drivers/watchdog/mtk_wdt.c | 47

Re: [PATCH] arm64: dts: mt8173: add clock_null

2015-07-10 Thread Eddie Huang
On Fri, 2015-07-10 at 16:11 +0800, Daniel Kurtz wrote: > On Fri, Jul 10, 2015 at 3:27 PM, Eddie Huang wrote: > > Hi all, > > > > On Wed, 2015-07-08 at 13:44 +0800, Sascha Hauer wrote: > >> On Wed, Jul 08, 2015 at 10:37:21AM +0800, Eddie Huang wrote: > >&

Re: [PATCH] arm64: dts: mt8173: add clock_null

2015-07-10 Thread Eddie Huang
Hi all, On Wed, 2015-07-08 at 13:44 +0800, Sascha Hauer wrote: > On Wed, Jul 08, 2015 at 10:37:21AM +0800, Eddie Huang wrote: > > On Tue, 2015-07-07 at 23:10 +0800, Daniel Kurtz wrote: > > > On Tue, Jul 7, 2015 at 10:36 PM, Sascha Hauer > > > wrote: > > >

Re: [PATCH] arm64: dts: mt8173: add clock_null

2015-07-07 Thread Eddie Huang
Jun 18, 2015 at 01:29:11PM +0800, Eddie Huang wrote: > >> >> Add clk_null, which represents clocks that can not / need not > >> >> controlled by software. > >> >> There are many clocks' parent set to clk_null. > >> >> &g

Re: [PATCH] arm64: dts: mt8173-evb: Add PMIC support

2015-07-06 Thread Eddie Huang
On Mon, 2015-07-06 at 18:39 +0200, Matthias Brugger wrote: > On Monday, July 06, 2015 03:43:57 PM Eddie Huang wrote: > > On Mon, 2015-06-22 at 21:19 +0800, Henry Chen wrote: > > > From: Eddie Huang > > > [...] > > > diff --git a/arch/arm64/boot/dts/mediatek/mt

Re: [PATCH] arm64: dts: mt8173-evb: Add PMIC support

2015-07-06 Thread Eddie Huang
Hi Matthias, On Mon, 2015-06-22 at 21:19 +0800, Henry Chen wrote: > From: Eddie Huang > > The MT8173 eval board contains a MT6397 PMIC. This adds the > corresponding device node to the dts file. > > Signed-off-by: Henry Chen > Signed-off-by: Eddie Huang > --- > Ba

Re: [PATCH] dts: mt8173-oak: Add da9211 to i2c1

2015-07-02 Thread Eddie Huang
Hi Henry, You have wrong mail title. Your patch modify mt8173-evb.dts, so your title should use mt8173-evb instead mt8173-oak. Also, remember remove change-id next time.Please resend this patch. On Fri, 2015-07-03 at 09:29 +0800, Henry Chen wrote: > Add a DA9211 dual-channel BUCK regulator to i2c

Re: [PATCH] rtc-mt6397: enable wakeup before registering rtc device

2015-07-02 Thread Eddie Huang
&mtk_rtc_ops, THIS_MODULE); > if (IS_ERR(rtc->rtc_dev)) { > @@ -351,8 +353,6 @@ static int mtk_rtc_probe(struct platform_device *pdev) > goto out_free_irq; > } > > - device_init_wakeup(&pdev->dev, 1); > - > r

Re: [PATCH v4 2/2] arm64: dts: mt8173: Add I2C device node

2015-06-21 Thread Eddie Huang
Hi Dan, On Thu, 2015-06-18 at 23:16 +0800, Daniel Kurtz wrote: > On Wed, Jun 17, 2015 at 11:08 PM, Eddie Huang > wrote: > > Add MT8173 I2C device nodes, include I2C controllers and pins. > > MT8173 has six I2C controllers, from i2c0 to i2c6, exclude i2c5. > > The 6th

Re: [PATCH 2/3] spi: mediatek: Add spi bus for Mediatek MT8173

2015-06-18 Thread Eddie Huang
On Wed, 2015-06-17 at 17:35 +0100, Mark Brown wrote: > On Wed, Jun 17, 2015 at 10:10:51PM +0800, Eddie Huang wrote: > > > Our hardware limitation is: we don't have separate dma tx, rx channel > > with transfer finish interrupt, only have spi trigger operation.So the &g

[PATCH] arm64: dts: mt8173: add clock_null

2015-06-17 Thread Eddie Huang
Add clk_null, which represents clocks that can not / need not controlled by software. There are many clocks' parent set to clk_null. Signed-off-by: James Liao Signed-off-by: Eddie Huang --- Base on 4.1-rc1 Change-Id: I4db9b40d07e28f54f7bae9b676316cbd6a962124 --- arch/arm64/boot/dts/med

[PATCH v4 1/2] arm64: dts: mt8173: Add watchdog device node

2015-06-17 Thread Eddie Huang
Add MT8173 watchdog device node. Signed-off-by: Eddie Huang Reviewed-by: Daniel Kurtz --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 30ac8dd

[PATCH v4 2/2] arm64: dts: mt8173: Add I2C device node

2015-06-17 Thread Eddie Huang
"i2c6", not "i2c5". Signed-off-by: Eddie Huang --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 144 +++ 1 file changed, 144 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index b52ec43..

[PATCH v4 0/2] arm64: dts: Mediatek: MT8173 updtes

2015-06-17 Thread Eddie Huang
not clock-frequency because it is optional. (default value is 100) Change in v3: Move I2C pin from SoC dtsi to board dts file. Change in v2: Modify I2C device node accroding register address order. Eddie Huang (2): arm64: dts: mt8173: Add watchdog device node arm64: dts: mt8173: Add I2C

Re: [PATCH 2/3] spi: mediatek: Add spi bus for Mediatek MT8173

2015-06-17 Thread Eddie Huang
On Wed, 2015-06-17 at 13:47 +0100, Mark Brown wrote: > On Wed, Jun 17, 2015 at 05:08:03PM +0800, Eddie Huang wrote: > > > Here comes the problem, although total length of tx, rx is the same, > > each entry in rx and tx scatterlist may not be the same (in the case > > d

Re: [PATCH 2/3] spi: mediatek: Add spi bus for Mediatek MT8173

2015-06-17 Thread Eddie Huang
Hi Mark, On Wed, 2015-06-10 at 16:06 +0800, Eddie Huang wrote: > On Tue, 2015-06-09 at 11:39 +0100, Mark Brown wrote: > > On Tue, Jun 09, 2015 at 06:05:21PM +0800, Eddie Huang wrote: > > > > > --- a/drivers/spi/spi.c > > > +++ b/drivers/spi/spi.c >

Re: [PATCH v3 2/2] arm64: dts: mt8173: Add I2C device node

2015-06-15 Thread Eddie Huang
Hi Sascha, On Mon, 2015-06-15 at 08:12 +0200, Sascha Hauer wrote: > On Fri, Jun 12, 2015 at 08:28:51PM +0800, Daniel Kurtz wrote: > > On Fri, Jun 12, 2015 at 5:27 PM, Eddie Huang > > wrote: > > > > > > Add MT8173 I2C device nodes, include I2C controllers a

Re: [PATCH v3 2/2] arm64: dts: mt8173: Add I2C device node

2015-06-15 Thread Eddie Huang
Hi Dan, On Fri, 2015-06-12 at 20:28 +0800, Daniel Kurtz wrote: > On Fri, Jun 12, 2015 at 5:27 PM, Eddie Huang wrote: > > > > Add MT8173 I2C device nodes, include I2C controllers and pins. > > MT8173 has six I2C controllers, from i2c0 to i2c6, exclude i2c5. > > The

[PATCH v3 1/2] arm64: dts: mt8173: Add watchdog device node

2015-06-12 Thread Eddie Huang
Add MT8173 watchdog device node. Signed-off-by: Eddie Huang --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 30ac8dd..b52ec43 100644 --- a/arch/arm64

[PATCH v3 0/2] arm64: dts: Mediatek: MT8173 updtes

2015-06-12 Thread Eddie Huang
[2] ARM64: dts: mt8173: Add clock controller device nodes http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344753.html Change in v3: Move I2C pin from SoC dtsi to board dts file. Change in v2: Modify I2C device node accroding register address order. Eddie Huang (2): arm64: dts

[PATCH v3 2/2] arm64: dts: mt8173: Add I2C device node

2015-06-12 Thread Eddie Huang
"i2c6", not "i2c5". Signed-off-by: Eddie Huang --- arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 50 arch/arm64/boot/dts/mediatek/mt8173.dtsi| 72 + 2 files changed, 122 insertions(+) diff --git a/arch/arm64/boot/dts/mediat

Re: [PATCH 2/3] spi: mediatek: Add spi bus for Mediatek MT8173

2015-06-10 Thread Eddie Huang
Hi Mark, On Tue, 2015-06-09 at 11:39 +0100, Mark Brown wrote: > On Tue, Jun 09, 2015 at 06:05:21PM +0800, Eddie Huang wrote: > > > --- a/drivers/spi/spi.c > > +++ b/drivers/spi/spi.c > > @@ -539,8 +539,8 @@ static int __spi_map_msg(struct spi_master *master, >

Re: [PATCH 2/3] spi: mediatek: Add spi bus for Mediatek MT8173

2015-06-09 Thread Eddie Huang
Hi Mark, On Mon, 2015-06-08 at 18:59 +0100, Mark Brown wrote: > On Mon, Jun 08, 2015 at 06:15:46PM +0800, Eddie Huang wrote: > > On Fri, 2015-05-15 at 17:25 +0800, Mark Brown wrote: > > > > That's how a very large proportion of devices that work with DMA are >

Re: [PATCH v2 2/2] arm64: dts: mt8173: Add I2C device node

2015-06-08 Thread Eddie Huang
Hi Sascha, On Mon, 2015-06-08 at 09:27 +0200, Sascha Hauer wrote: > Hi Eddie, > > On Mon, Jun 01, 2015 at 09:08:27PM +0800, Eddie Huang wrote: > > Add MT8173 I2C device nodes, include I2C controllers and pins. > > MT8173 has six I2C controllers, from i2c0 to i2c6, exclude

Re: [PATCH 2/3] spi: mediatek: Add spi bus for Mediatek MT8173

2015-06-08 Thread Eddie Huang
Hi Mark, On Fri, 2015-05-15 at 17:25 +0800, Mark Brown wrote: > On Fri, May 15, 2015 at 03:38:42PM +0800, leilk liu wrote: > > On Tue, 2015-05-12 at 17:05 +0100, Mark Brown wrote: > > > > Implement can_dma() - look for drivers providing that for examples. > > > MTK spi hardware uses the dmaengin

[PATCH v2 0/2] arm64: dts: Mediatek: MT8173 updtes

2015-06-01 Thread Eddie Huang
[2] ARM64: dts: mt8173: Add clock controller device nodes http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344753.html Change in v2: Modify I2C device node accroding register address order. Eddie Huang (2): arm64: dts: mt8173: Add watchdog device node arm64: dts: mt8173: Add

[PATCH v2 2/2] arm64: dts: mt8173: Add I2C device node

2015-06-01 Thread Eddie Huang
"i2c6", not "i2c5". Signed-off-by: Eddie Huang --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 119 +++ 1 file changed, 119 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index b52ec43..

[PATCH v2 1/2] arm64: dts: mt8173: Add watchdog device node

2015-06-01 Thread Eddie Huang
Add MT8173 watchdog device node. Signed-off-by: Eddie Huang --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 30ac8dd..b52ec43 100644 --- a/arch/arm64

[PATCH 1/2] arm64: dts: mt8173: Add watchdog device node

2015-05-31 Thread Eddie Huang
Add MT8173 watchdog device node. Signed-off-by: Eddie Huang --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 30ac8dd..b52ec43 100644 --- a/arch/arm64

[PATCH 0/2] arm64: dts: Mediatek: MT8173 updtes

2015-05-31 Thread Eddie Huang
[2] ARM64: dts: mt8173: Add clock controller device nodes http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344753.html Eddie Huang (2): arm64: dts: mt8173: Add watchdog device node arm64: dts: mt8173: Add I2C device node arch/arm64/boot/dts/mediatek/mt8173.dtsi | 125

[PATCH 2/2] arm64: dts: mt8173: Add I2C device node

2015-05-31 Thread Eddie Huang
"i2c6", not "i2c5". Signed-off-by: Eddie Huang --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 119 +++ 1 file changed, 119 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index b52ec43..

Re: [PATCH v9 0/3] ARM: mediatek: Add driver for Mediatek I2C

2015-05-24 Thread Eddie Huang
Hi Dan, On Thu, 2015-05-21 at 22:39 +0800, Daniel Kurtz wrote: > On Thu, May 21, 2015 at 4:53 PM, Eddie Huang wrote: > > This series is for Mediatek SoCs I2C controller common bus driver. > > > > Earlier MTK SoC (for example, MT6589, MT8135) I2C HW has some limitations. &

[PATCH v9 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-21 Thread Eddie Huang
From: Xudong Chen The mediatek SoCs have I2C controller that handle I2C transfer. This patch include common I2C bus driver. This driver is compatible with I2C controller on mt65xx/mt81xx. Signed-off-by: Xudong Chen Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang Acked-by: Sascha Hauer

[PATCH v9 3/3] I2C: mediatek: Add driver for MediaTek MT8173 I2C controller

2015-05-21 Thread Eddie Huang
Add mediatek MT8173 I2C controller driver. Compare to I2C controller of earlier mediatek SoC, MT8173 fix write-then-read limitation, and also increase message size to 64kb. Signed-off-by: Xudong Chen Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang Acked-by: Sascha Hauer --- drivers/i2c

[PATCH v9 0/3] ARM: mediatek: Add driver for Mediatek I2C

2015-05-21 Thread Eddie Huang
code. Instead, fill quirk property and let i2c_check_for_quirks to do the filter. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/314804.html [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-February/325744.html Eddie Huang (1): I2C: mediatek: Add driver for Media

[PATCH v9 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx.

2015-05-21 Thread Eddie Huang
From: Xudong Chen Add devicetree bindings for Mediatek Soc I2C driver. Signed-off-by: Xudong Chen Signed-off-by: Eddie Huang Acked-by: Sascha Hauer --- .../devicetree/bindings/i2c/i2c-mt6577.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-21 Thread Eddie Huang
Hi, Please see my reply below (I skip comments that already reply in another mail). On Wed, 2015-05-20 at 10:57 +0200, Uwe Kleine-König wrote: > Hello, > > now that I understood the formula some more comments to the calculation. > > On Tue, May 19, 2015 at 12:40:08AM +0800, Ed

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-20 Thread Eddie Huang
Hi Uwe, On Wed, 2015-05-20 at 09:11 +0200, Uwe Kleine-König wrote: > Hello Eddie, > > On Wed, May 20, 2015 at 10:40:11AM +0800, Eddie Huang wrote: > > On Mon, 2015-05-18 at 20:43 +0200, Uwe Kleine-König wrote: > > > On Tue, May 19, 2015 at 12:40:08AM

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-19 Thread Eddie Huang
Hi Uwe, On Tue, 2015-05-19 at 21:49 +0200, Uwe Kleine-König wrote: > Hello Matthias, > > On Tue, May 19, 2015 at 04:48:23PM +0200, Matthias Brugger wrote: > > 2015-05-18 20:43 GMT+02:00 Uwe Kleine-König > > : > > > On Tue, May 19, 2015 at 12:40

Re: [PATCH v8 3/3] I2C: mediatek: Add driver for MediaTek MT8173 I2C controller

2015-05-19 Thread Eddie Huang
Hi Matthias, On Tue, 2015-05-19 at 16:45 +0200, Matthias Brugger wrote: > 2015-05-18 18:40 GMT+02:00 Eddie Huang : > > Add mediatek MT8173 I2C controller driver. Compare to I2C controller > > of earlier mediatek SoC, MT8173 fix write-then-read limitation, and > > also inc

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-19 Thread Eddie Huang
Hi Uwe, On Mon, 2015-05-18 at 20:43 +0200, Uwe Kleine-König wrote: > Hello, > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > > From: Xudong Chen > > > > The mediatek SoCs have I2C controller that handle I2C transfer. > > This patch includ

Re: [PATCH] tty: serial/8250: remove console dependency for mediatek

2015-05-19 Thread Eddie Huang
har *options) > { > @@ -317,6 +318,7 @@ static int __init early_mtk8250_setup(struct > earlycon_device *device, > } > > OF_EARLYCON_DECLARE(mtk8250, "mediatek,mt6577-uart", early_mtk8250_setup); > +#endif > > MODULE_AUTHOR("Matthias Brugger"); >

[PATCH v8 3/3] I2C: mediatek: Add driver for MediaTek MT8173 I2C controller

2015-05-18 Thread Eddie Huang
Add mediatek MT8173 I2C controller driver. Compare to I2C controller of earlier mediatek SoC, MT8173 fix write-then-read limitation, and also increase message size to 64kb. Signed-off-by: Xudong Chen Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang Acked-by: Sascha Hauer --- drivers/i2c

[PATCH v8 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx.

2015-05-18 Thread Eddie Huang
From: Xudong Chen Add devicetree bindings for Mediatek Soc I2C driver. Signed-off-by: Xudong Chen Signed-off-by: Eddie Huang Acked-by: Sascha Hauer --- .../devicetree/bindings/i2c/i2c-mt6577.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644

[PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-18 Thread Eddie Huang
From: Xudong Chen The mediatek SoCs have I2C controller that handle I2C transfer. This patch include common I2C bus driver. This driver is compatible with I2C controller on mt65xx/mt81xx. Signed-off-by: Xudong Chen Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang Acked-by: Sascha Hauer

[PATCH v8 0/3] ARM: mediatek: Add driver for Mediatek I2C

2015-05-18 Thread Eddie Huang
ary/314804.html [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-February/325744.html Eddie Huang (1): I2C: mediatek: Add driver for MediaTek MT8173 I2C controller Xudong Chen (2): dt-bindings: Add I2C bindings for mt65xx/mt81xx. I2C: mediatek: Add driver for MediaTek I2C controller .../de

Re: [PATCH v7 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-18 Thread Eddie Huang
Hi Wolfram, On Mon, 2015-05-18 at 08:37 +0200, Wolfram Sang wrote: > > > > + rpaddr = dma_map_single(i2c->adap.dev.parent, msgs->buf, > > > > + msgs->len, > > > > DMA_FROM_DEVICE); > > > > > > I think you shouldn't use the adapter devic

Re: [PATCH v7 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-17 Thread Eddie Huang
Hi Wolfram, Narrow down CC-list. Please see my reply below. On Tue, 2015-05-12 at 14:58 +0200, w...@the-dreams.de wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#inclu

Re: [rtc-linux] [PATCH] rtc: mt6397: fix build on some 32bits platforms

2015-05-17 Thread Eddie Huang
On Thu, 2015-05-14 at 23:55 +0200, Alexandre Belloni wrote: > Hi, > > On 14/05/2015 at 22:51:18 +0200, Alexandre Belloni wrote : > > On some !ARM 32bits platforms, the following compilation error happens > > because of the division on a 64bits value in mtk_rtc_read_time(): > > > > drivers/built-i

Re: [PATCH] rtc: mt6397: fix build on some 32bits platforms

2015-05-17 Thread Eddie Huang
me / 86400 + 4) % 7; > + days = div_s64(time, 86400); > + tm->tm_wday = (days + 4) % 7; > > exit: > return ret; Acked-by: Eddie Huang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver

2015-05-07 Thread Eddie Huang
Hi Alexandre, On Thu, 2015-05-07 at 14:06 +0200, Alexandre Belloni wrote: > On 06/05/2015 at 00:44:59 -0700, Joe Perches wrote : > > On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote: > > > From: Tianping Fang > > > > trivia: no need to resend now, maybe in a

Re: [PATCH v7 0/3] ARM: mediatek: Add driver for Mediatek I2C

2015-05-07 Thread Eddie Huang
Hi Lee, On Thu, 2015-05-07 at 08:39 +0100, Lee Jones wrote: > On Wed, 06 May 2015, Eddie Huang wrote: > > > > > Eddie Huang (1): > > I2C: mediatek: Add driver for MediaTek MT8173 I2C controller > > > > Xudong Chen (2): > > dt-bindings: Add

  1   2   >