a6a0 ("tpm: Remove useless priv field in struct
tpm_vendor_specific")
Cc:
Signed-off-by: Hon Ching(Vicky) Lo
---
drivers/char/tpm/tpm_ibmvtpm.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibm
On Wed, 2017-03-08 at 13:52 -0700, Jason Gunthorpe wrote:
> On Wed, Mar 08, 2017 at 03:28:11PM -0500, Hon Ching(Vicky) Lo wrote:
> > On Wed, 2017-03-08 at 10:17 -0700, Jason Gunthorpe wrote:
> > > On Tue, Mar 07, 2017 at 11:12:43PM -0500, Hon Ching(Vicky) Lo wrote:
> > >
On Wed, 2017-03-08 at 10:17 -0700, Jason Gunthorpe wrote:
> On Tue, Mar 07, 2017 at 11:12:43PM -0500, Hon Ching(Vicky) Lo wrote:
> > On Mon, 2017-03-06 at 16:19 -0700, Jason Gunthorpe wrote:
>
> > > Also, how does locking work here? Does the vio core prevent
> > > t
On Mon, 2017-03-06 at 16:19 -0700, Jason Gunthorpe wrote:
> On Mon, Mar 06, 2017 at 05:32:15PM -0500, Hon Ching(Vicky) Lo wrote:
> > The current code passes the address of tpm_chip as the argument to
> > dev_get_drvdata() without prior NULL check in
> > tpm_ibmvtpm_get_desire
a6a0 ("tpm: Remove useless priv field in struct
tpm_vendor_specific")
Cc:
Signed-off-by: Hon Ching(Vicky) Lo
---
drivers/char/tpm/tpm_ibmvtpm.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
in
H_CLOSED.
Signed-off-by: Hon Ching(Vicky) Lo
---
drivers/char/tpm/tpm_ibmvtpm.c | 43 ---
drivers/char/tpm/tpm_ibmvtpm.h |7 ++
2 files changed, 46 insertions(+), 4 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
ibmvtpm_send_crq in tpm_ibmvtpm_suspend returns errors in a more
granular level than what the existing code does. This patch adds
the missing CRQ transport event code checks to ensure appropriate
action taken, in the case that ibmvtpm_send_crq returns H_CLOSED.
Signed-off-by: Hon Ching(Vicky) Lo
> > > + } else if (crq.msg == (u8) PARTNER_PARTITION_FAILED) {
> > > + dev_err(ibmvtpm->dev,
> > > + "vtpm has terminated fatally; reboot to
> > > reinstate a trusted state.\n");
> > > + } else if (crq.msg == (u8) PARTNER_PARTITION_DEREG_CRQ)
On Fri, 2016-03-04 at 18:55 +0200, Jarkko Sakkinen wrote:
> On Wed, Mar 02, 2016 at 01:23:47AM -0500, Hon Ching(Vicky) Lo wrote:
> > ibmvtpm_send_crq in tpm_ibmvtpm_suspend returns errors in a more
> > granular level than what the existing code does. This patch adds
> > the
ibmvtpm_send_crq in tpm_ibmvtpm_suspend returns errors in a more
granular level than what the existing code does. This patch adds
the missing CRQ transport event code checks to ensure appropriate
action taken, in the case that ibmvtpm_send_crq returns H_CLOSED.
Signed-off-by: Hon Ching(Vicky) Lo
On Tue, 2015-10-13 at 13:43 -0500, Ashley Lai wrote:
>
> On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote:
> > The event log generated by OpenFirmware in PowerPC is 4-byte aligned.
> > This patch reformats the log to be byte-aligned for the Linux client.
> >
> >
The event log generated by OpenFirmware in PowerPC is 4-byte aligned.
This patch reformats the log to be byte-aligned for the Linux client.
Signed-off-by: Hon Ching(Vicky) Lo
---
arch/powerpc/kernel/prom_init.c | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git
Replace all occurrences of '/ibm,vtpm' with '/vdevice/vtpm',
as only the latter is ganranteed to be available for the client OS.
The '/ibm,vtpm' node should only be used by Open Firmware, which
is susceptible to changes.
Signed-off-by: Hon Ching(Vicky) Lo
---
a
The OS should ask Power Firmware (PFW) for the size of the buffer
allocated for the event log, instead of the size of the actual
event log. It then passes the buffer adddress and size to PFW in
the handover process, into which PFW copies the log.
Signed-off-by: Hon Ching(Vicky) Lo
---
arch
p.c. This patch uses 'GFP_ATOMIC' instead so that the
allocation is high-priority and does not sleep.
Signed-off-by: Hon Ching(Vicky) Lo
---
drivers/char/tpm/tpm_ibmvtpm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/ch
Replace all occurrences of '/ibm,vtpm' with '/vdevice/vtpm',
as only the latter is ganranteed to be available for the client OS.
The '/ibm,vtpm' node should only be used by Open Firmware, which
is susceptible to changes.
Signed-off-by: Hon Ching(Vicky) Lo
---
a
The OS should ask Power Firmware (PFW) for the size of the buffer
allocated for the event log, instead of the size of the actual
event log. It then passes the buffer adddress and size to PFW in
the handover process, into which PFW copies the log.
Signed-off-by: Hon Ching(Vicky) Lo
---
arch
p.c. This patch uses 'GFP_ATOMIC' instead so that the
allocation is high-priority and does not sleep.
Signed-off-by: Hon Ching(Vicky) Lo
---
drivers/char/tpm/tpm_ibmvtpm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/ch
The event log generated by OpenFirmware in PowerPC is 4-byte aligned.
This patch reformats the log to be byte-aligned for the Linux client.
Signed-off-by: Hon Ching(Vicky) Lo
---
arch/powerpc/kernel/prom_init.c | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git
Hi Peter,
Did you the explanations in the following reply make sense to you?
If you needed more clarifications, please advice. Thanks!
Forwarded Message
From: Hon Ching(Vicky) Lo
To: Peter Hüwe
Cc: tpmdd-de...@lists.sourceforge.net, Ashley Lai
, Vicky Lo ,
linux-kernel
On Thu, 2015-07-16 at 20:43 +0200, Peter Hüwe wrote:
> Hi Vicky,
> Am Donnerstag, 16. Juli 2015, 19:54:15 schrieb Hon Ching(Vicky) Lo:
> > Hi Peter,
> >
> > On Mon, 2015-07-13 at 23:08 +0200, Peter Hüwe wrote:
> > > Hi Vicky,
> > >
> > > sorry
vent entries so that they will be displayed properly.
> > tpm_binary_bios_measurements_show() is modified for the display.
> >
> > Signed-off-by: Hon Ching(Vicky) Lo
> > Signed-off-by: Joy Latten
>
> > b/drivers/char/tpm/tpm_eventlog.h index e7da086..267bfbd 100644
&g
Hi Peter,
Please also commit this patch, if you accept it as well.
Thanks,
Vicky
Forwarded Message
From: Ashley Lai
To: Hon Ching(Vicky) Lo
Cc: tpmdd-de...@lists.sourceforge.net, Peter Huewe ,
Ashley Lai , Vicky Lo ,
linux-kernel@vger.kernel.org, Joy Latten
>Subject:
Hi Peter,
Can you please commit the patch in the next open window,
if you accept it as well? Thanks!
Regards,
Vicky
Forwarded Message
From: Ashley Lai
To: Hon Ching(Vicky) Lo
Cc: tpmdd-de...@lists.sourceforge.net, Peter Huewe ,
Ashley Lai , Vicky Lo ,
linux-kernel
8:17 -0400, Hon Ching(Vicky) Lo wrote:
> This patch makes the code endianness independent. We defined a
> macro do_endian_conversion to apply endianness to raw integers
> in the event entries so that they will be displayed properly.
> tpm_binary_bios_measurements_show() is modified for the
This patch makes the code endianness independent. We defined a
macro do_endian_conversion to apply endianness to raw integers
in the event entries so that they will be displayed properly.
tpm_binary_bios_measurements_show() is modified for the display.
Signed-off-by: Hon Ching(Vicky) Lo
Signed
ures that it is correctly
implemented.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
---
drivers/char/tpm/tpm_of.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
index c002d1b..62a22ce 100644
--- a/d
rwise it looks good.
>
> On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote:
> > case NONHOST_INFO:
> > - name = tcpa_event_type_strings[event->event_type];
> > + name =
> > + tcpa_event_type_strings[do_endian_conversion
> >
Hi Peter,
Yes, it's a fix to a kernel dump caused by enabling both vtpm and kdump.
On Tue, 2015-06-16 at 22:37 +0200, Peter Hüwe wrote:
> Hey,
>
> Am Freitag, 22. Mai 2015, 19:23:02 schrieb Hon Ching(Vicky) Lo:
> > tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) withou
ures that it is correctly
implemented.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
---
drivers/char/tpm/tpm_of.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
index c002d1b..62a22ce 100644
--- a/d
This patch makes the code endianness independent. We defined a
macro do_endian_conversion to apply endianness to raw integers
in the event entries so that they will be displayed properly.
tpm_binary_bios_measurements_show() is modified for the display.
Signed-off-by: Hon Ching(Vicky) Lo
Signed
Hi Peter,
Would it be possible for you to review and commit the following patch
at your earliest convenience? Thanks in advance!
Forwarded Message
From: Ashley Lai
To: Hon Ching(Vicky) Lo
Cc: tpmdd-de...@lists.sourceforge.net, Peter Huewe ,
Ashley Lai , Vicky Lo ,
linux
tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet
set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq,
the phype call contains empty unit addresses, ibmvtpm->vdev->unit_address.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
---
d
On Tue, 2015-05-19 at 16:08 -0500, Ashley Lai wrote:
> Thank you Vicky and Joy for the clarification. This patch mainly
> converts the fields in the tcpa_event structure. I see the code converts
> everytime it accesses the event fields. Would it be more efficient if you
> do the conversion on
Thanks Ashley!
> > The event log in ppc64 arch is always in big endian format. PowerPC
> > supports both little endian and big endian guests. This patch converts
> > the event log entries to guest format.
>
> I'm a little confused here. If this patch is to convert the event log
> entries why ar
prom_instantiate_sml() already converted the base pointer to little
endian. This patch removes this unnecessary additional conversion.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
---
drivers/char/tpm/tpm_of.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff
Do not skip the last entry of the event log.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
Changelog:
- remove redundant code
---
drivers/char/tpm/tpm_eventlog.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/char/tpm/tpm_eventlog.c b
Hi,
The patch set converts big endian event log entries to guest format
in PowerPC, which supports both little endian and big endian guests.
It also contains a fix to make sure the last event entry wasn't skipped.
Hon Ching(Vicky) Lo (3):
vTPM: fixed the limit checking
TPM: r
the event
and print each field individually.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
---
drivers/char/tpm/tpm_eventlog.c | 92 +++
1 files changed, 73 insertions(+), 19 deletions(-)
diff --git a/drivers/char/tpm/tpm_eventlog.c b/drivers
Hi Anton,
vio_bus_probe now calls vio_cmo_bus_probe before calling probe.
This results in calling get_desired_dma to get rtce buf size
before we have called probe which initializes vtpm driver and
sets up the tpm data, i.e. rtce buf size.
ibmvtpm_get_data returns NULL in get_desired_dma is a s
40 matches
Mail list logo