On Thu, 07 Feb 2008 21:24:47 +0100
Peter Zijlstra <[EMAIL PROTECTED]> wrote:
>
> On Thu, 2008-02-07 at 20:49 +0100, Peter Zijlstra wrote:
> > On Wed, 2008-02-06 at 18:23 -0800, Andrew Morton wrote:
> > > On Wed, 06 Feb 2008 20:10:50 -0600 "J. K. Cliburn"
> > > <[EMAIL PROTECTED]> wrote:
> > >
>
In preparation for a future atl2 driver for the Atheros L2 10/100 chip,
we propose to move the existing atl1 driver to a new directory
(drivers/net/atlx), then split out functions and definitions that both
atl1 and atl2 can share. The final structure will look like this:
drivers/net/atl1
Make needlessly global functions static. In a couple of cases this
requires removing forward declarations and reordering functions.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/a
Use netif_msg_* for console messages emitted by the driver. Add a
parameter to allow control of messaging at driver startup, and also
add the ability to control it with ethtool.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net
Rearrange functions to allow removal of some forward declarations.
Make certain global functions static along the way.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/a
Use skb->csum_start for tx checksum offload preparation. Also swap
the variables css and cso so they hold the intended values of csum
start and offset, respectively.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atl
. Finally, shorten some variable names in the transmit
processing path to reduce line lengths, rename some variables to better
describe their purpose (e.g., nseg versus m), and add a comment or two
to better describe what the code is doing.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by:
Add some debug printks if we encounter a potentially bad receive
return descriptor.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 26 ++
1 files changed, 22 insertions(+), 4 deleti
In preparation for a future Atheros L2 NIC driver (called atl2), relocate
the atl1 driver into a new /drivers/net/atlx directory that will ultimately
be shared with the future atl2 driver.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Add the ethtool register dump option to the atl1 driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 53 +++
drivers/net/atlx/atl1.h |1 +
2 files changed, 5
tpd.
Also, some of our bit assignments are made to the wrong tpd words. Change
those to the correct words.
Finally, since all this fixes TSO, enable TSO by default.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/a
>From de0e1eddb6a4dd7673f84c472812b062aaea2f39 Mon Sep 17 00:00:00 2001
From: Jay Cliburn <[EMAIL PROTECTED]>
Date: Wed, 30 Jan 2008 19:21:10 -0600
Subject: [PATCH] atl1: fix frame length bug
Upstream commit: 2a49128f0a6edee337174ea341c1d6d7565be350
The driver sets up the hardware to
On Tue, 22 Jan 2008 18:31:09 -0600
Jay Cliburn <[EMAIL PROTECTED]> wrote:
> On Tue, 22 Jan 2008 04:58:17 -0500
> Jeff Garzik <[EMAIL PROTECTED]> wrote:
>
[...]
> > for such a huge patch, this description is very tiny. [describe]
> > what is refactored, and why.
On Tue, 22 Jan 2008 04:56:11 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
> > From: Jay Cliburn <[EMAIL PROTECTED]>
> >
> > Update initialization parameters to match the current vendor driver
> > version 1.2.40.2.
[...]
> A
On Tue, 22 Jan 2008 04:58:17 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
> > From: Jay Cliburn <[EMAIL PROTECTED]>
> >
> > Refactor tx processing to use a less convoluted tx packet
> > descriptor and to conform generally with th
Thanks for your comments Stephen and Joonwoo. Here's the revised
version of the atl1 NAPI patch.
>From 9c3a8944220287671f983557099bc329f02fda9b Mon Sep 17 00:00:00 2001
From: Jay Cliburn <[EMAIL PROTECTED]>
Date: Tue, 1 Jan 2008 11:55:24 -0600
Subject: [PATCH 25/26] atl1: add NAP
On Sat, 8 Dec 2007 21:14:09 +0100
Sam Ravnborg <[EMAIL PROTECTED]> wrote:
> Jay - can I ask you to try out following patch.
Hello Sam,
Yes, your patch works for me.
Thank you very much.
> diff --git a/Makefile b/Makefile
> index a5252f4..7fb1a2c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1
On Thu, 6 Dec 2007 15:57:38 +0100 (CET)
Jan Engelhardt <[EMAIL PROTECTED]> wrote:
>
> On Dec 4 2007 21:04, Jay Cliburn wrote:
> >
> >This piece of the top-level Makefile in current git causes an
> >out-of-tree driver Makefile to fail.
> >
> >101 ifde
On Wed, 5 Dec 2007 22:00:03 +0100
Sam Ravnborg <[EMAIL PROTECTED]> wrote:
> On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote:
> > Sam,
> >
> > This piece of the top-level Makefile in current git causes an
> > out-of-tree driver Makefile to fail.
&g
Sam,
This piece of the top-level Makefile in current git causes an
out-of-tree driver Makefile to fail.
101 ifdef O
102 ifeq ("$(origin O)", "command line")
103 KBUILD_OUTPUT := $(O)
104 endif
105 endif
The out-of-tree driver Makefile contains an O=... directive that
(correctly) does _no
be used at a time.
As a result, we need to confine the driver to a 32-bit DMA mask, otherwise
we see occasional data corruption errors in systems containing 4 or more
gigabytes of RAM.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Cc: Luca Tettamanti <[EMAIL PROTECTED]>
Cc: Chris S
From: Ingo Molnar <[EMAIL PROTECTED]>
use the simpler spin_trylock_irqsave() API to get the adapter lock.
[ this is also a fix for -rt where adapter->lock is a sleeping lock. ]
Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Use constants already provided by the kernel for ethernet related lengths.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.h |5 -
drivers/net/atl1/atl1_main.c | 13 +++--
2 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/drive
s/dam/dma
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_hw.h b/drivers/net/atl1/atl1_hw.h
index 100c09c..f0d7e82 100644
--- a/drivers/net/atl1/atl1_hw.h
+++ b/d
The DMA engine setup contains a typo that can result in an incorrect
dmaw_block setting.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/ne
: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
index 3b8f633..6aa2dc3 100644
--- a/drivers/net/atl1/atl1_main.c
+++ b/drivers/ne
Please accept the following patches for the atl1 driver. Thanks.
atl1: use kernel provided ethernet length constants
atl1: fix typo in dma_req_block
atl1: change cmb write threshold
atl1: fix typo in DMA engine setup
atl1: change tpd_avail function name
drivers/net/atl1/atl1_hw.h |9 ++---
Change tpd_avail() to atl1_tpd_avail().
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
index fd1e156..79d60e1 100644
Fix indentation, remove dead code, improve some comments, change dev_dbg to
dev_printk.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c | 278 +-
1 files changed, 137 insertions(+), 141 deletions(-)
diff --git a/d
Remove unused structure members, improve comments, break long comment lines,
rename a constant to be consistent with others in the file.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1.h | 155 ++
drivers/net/atl1/atl1_
Remove unnecessary irq_sem code.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1.h |1 -
drivers/net/atl1/atl1_main.c |6 ++
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/driv
Move excessively indented code to separate functions. Also move ring
pointer initialization to its own function.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c | 86 -
1 files changed, 50 insertions(+), 36 del
Please accept the following patches for the atl1 driver.
atl1: remove irq_sem
atl1: header file cleanup
atl1: cleanup atl1_main
atl1: fix excessively indented code
atl1: reorder atl1_main functions
drivers/net/atl1/atl1.h | 156 ++--
drivers/net/atl1/atl1_main.c | 2176
How do I turn on dev_dbg messaging in the kernel? I can get
printk(KERN_DEBUG ...) to work just fine, but I don't know how to
enable dev_dbg.
Thanks,
Jay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Mon, 25 Jun 2007 23:18:55 +0200
Luca Tettamanti <[EMAIL PROTECTED]> wrote:
> Il Mon, Jun 25, 2007 at 07:42:44AM -0500, Jay Cliburn ha scritto:
> > Jay L. T. Cornwall wrote:
> > >Jay Cliburn wrote:
> > >
> > >>For reasons not yet clear to me, it
On Mon, 25 Jun 2007 17:57:20 -0400
Chris Snook <[EMAIL PROTECTED]> wrote:
> Jay L. T. Cornwall wrote:
> > Chris Snook wrote:
> >
> >> What boards have we seen this on? It's quite possible this is:
> >
> > I can reproduce on an Asus P5K with a Core 2 Duo E6600.
> >
> > lspci identifies the cont
Jay L. T. Cornwall wrote:
Jay Cliburn wrote:
For reasons not yet clear to me, it appears the L1 driver has a bug or
the device itself has trouble with DMA in high memory. This patch,
drafted by Luca Tettamanti, is being explored as a workaround. I'd be
interested to know if it fixes
On Sun, 24 Jun 2007 21:31:36 +0100
"Jay L. T. Cornwall" <[EMAIL PROTECTED]> wrote:
> Jay Cliburn wrote:
>
> >> The common factor here seems to be the buffer_head circular list
> >> leading to invalid pointers in bh->b_this_page.
> >>
> >&
On Sat, 23 Jun 2007 13:14:40 +0100
"Jay L. T. Cornwall" <[EMAIL PROTECTED]> wrote:
> The common factor here seems to be the buffer_head circular list
> leading to invalid pointers in bh->b_this_page.
>
> I'm beginning to suspect the Attansic L1 Gigabit Etherner driver
> (marked as EXPERIMENTAL i
On Wed, 30 May 2007 15:07:39 -0700
Greg KH <[EMAIL PROTECTED]> wrote:
> Sorry, I'm catching up on PCI stuff right now (am traveling in Tokyo
> right now, gotta love jet lag...)
>
> thanks for your patience.
Thanks a lot for the note, Greg. I appreciate it. I'll be patient.
Jay
-
To unsubscrib
On Wed, 30 May 2007 02:00:25 +0200
Jose Alberto Reguero <[EMAIL PROTECTED]> wrote:
> I have problems with a M2V motherboard and atl1 driver with msi and
> kernel 2.6.22-rc3. With kernel 2.6.21 I had no problems.
> I must add in drivers/pci/quirks.c (line 1723):
>
> DECLARE_PCI_FIXUP_FINAL(PCI_VE
On Sun, 27 May 2007 02:20:52 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Sat, May 26, 2007 at 05:01:04PM -0500, Jay Cliburn wrote:
> >
> > The Via VT3351 APIC does not play well with MSI and unleashes a
> > flood of APIC errors when MSI is used to deliver inter
VT3351.
See http://bugzilla.kernel.org/show_bug.cgi?id=8472 for additional
details on this bug.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/pci/quirks.c|1 +
include/linux/pci_ids.h |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/qu
Can someone (Greg K-H?) tell me the status of the below patch? Is it
planned for 2.6.22? It looks like a useful generic "let's disable msi
on board x" that I might want to use for the atl1 network driver.
Thanks,
Jay
On Wed, 09 May 2007 14:23:02 +0200
Tejun Heo <[EMAIL PROTECTED]> wrote:
> MSI
Thank you very much for looking at this, Len.
On Fri, 11 May 2007 23:28:58 -0400
Len Brown <[EMAIL PROTECTED]> wrote:
> > > [ 94.754852] APIC error on CPU0: 08(40)
> > > [ 94.806045] APIC error on CPU0: 40(08)
>
> /* Here is what the APIC error bits mean:
>0: Send CS err
Jeff Garzik wrote:
Chuck Ebbert wrote:
Tejun Heo wrote:
FWIW several distros have turned off MSI by default and added
a "pci=msi" option to enable it.
Yeah, it seem to cause a lot of problems on certain chips but I think
the correct path is to add PCI quirks for those. Most MSI problems I've
Use dev_printk macros for PCI related errors, warnings, debug and info
console messages.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_ethtool.c | 19 +++--
drivers/net/atl1/atl1_hw.c | 22 +--
drivers/net/atl1/atl1_main.c
Please accept the following trivial patches to the atl1 driver.
- use dev_printk macros
- fix whitespace damage
drivers/net/atl1/atl1_ethtool.c | 19 +++--
drivers/net/atl1/atl1_hw.c | 44 ++---
drivers/net/atl1/atl1_main.c| 83 +---
Remove trailing whitespace and spaces preceding tabs.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.c | 22 +++---
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c
Chuck Ebbert wrote:
Where is the text of the oops?
In one of the files on the website I referenced. Here's the text...
[ 173.584000] APIC error on CPU1: 08(08)
[ 173.665000] APIC error on CPU0: 08(08)
[ 173.665000] APIC error on CPU1: 08(08)
[ 173.746000] APIC error on CPU0: 08(08)
[ 17
[Adding linux-kernel to the cc list, hoping for wider exposure.]
On Fri, 23 Mar 2007 20:08:17 -0500
Jay Cliburn <[EMAIL PROTECTED]> wrote:
> We're trying to track down the source of a problem that occurs
> whenever the atl1 network driver is activated on a 32-bit 2.6.21-rc
On Wed, 28 Mar 2007 01:00:24 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> Subject: atl1 net driver: problem with sockets
> References : http://lkml.org/lkml/2007/3/21/248
> Submitter : Jose Alberto Reguero <[EMAIL PROTECTED]>
> Patch : http://marc.info/?l=linux-netdev&m=117502041808665
From: Jay Cliburn <[EMAIL PROTECTED]>
The original vendor driver contained a private ether_crc_le() function
that produced an inverted crc. When we changed to the kernel version of
ether_crc_le(), we neglected to undo the inversion. Let's do it now.
Discovered by and patch proffe
From: Jay Cliburn <[EMAIL PROTECTED]>
Bump the version number.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
i
From: Chris Snook <[EMAIL PROTECTED]>
Add device id for the Attansic L1 chip to pci_ids.h, then use it.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |2 +-
include/linux/pci_ids.h
From: Chris Snook <[EMAIL PROTECTED]>
Remove unused define from atl1_main.c.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git
From: Jay Cliburn <[EMAIL PROTECTED]>
On some Asus motherboards containing the L1 NIC, the MAC address is
written by the BIOS directly to the MAC register during POST, and is
not stored in eeprom. If we don't succeed in fetching the MAC address
from eeprom or spi, try reading it di
From: Al Viro <[EMAIL PROTECTED]>
An ioread32 statement reads the wrong address. Fix it.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.c |
From: Jay Cliburn <[EMAIL PROTECTED]>
The atl1 driver doesn't need NET_PCI. Remove it from Kconfig.
Noticed by Chad Sprouse.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |2 +-
1 files chan
Jeff,
Please accept the following patchset for the atl1 network device driver.
* Drop unnecessary NET_PCI config
* Fix incorrect hash table address
* Read MAC address from register
* Remove unused define
* Add Attansic L1 device id to pci_ids
* Bump version number
This patchset contains changes
From: Jay Cliburn <[EMAIL PROTECTED]>
atl1: move extern to header file; make some global code static
Move an extern declaration to a header file. Make needlessly global
functions static. Noticed by Adrian Bunk.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net
On Tue, 6 Feb 2007 23:12:29 +0100
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 29, 2007 at 08:45:28PM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.20-rc6-mm2:
> >...
> > git-netdev-all.patch
> >...
> > git trees
> >...
>
>
> This patch contains the following possible cleanu
From: Jay Cliburn <[EMAIL PROTECTED]>
pci_ids: add Attansic vendor id
Add Attansic to pci_ids and use the ID in the driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |2 +-
include/linux/pci_ids.h |2 ++
2 files changed, 3 inse
From: Jay Cliburn <[EMAIL PROTECTED]>
MAINTAINERS: add atl1 maintainers
Add a maintainers entry for atl1.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
MAINTAINERS | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
i
From: Jay Cliburn <[EMAIL PROTECTED]>
atl1: fix whitespace damage
Remove trailing whitespace and spaces preceding tabs.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1.h |8 +-
drivers/net/atl1/atl1_ethtool.c | 42 ++--
drivers/net/at
This set of patches completes the final bit of tidying up in the Attansic
ethernet driver. Sorry for nickel-and-diming you, Jeff, but this really
should be the end of it for awhile.
Summary:
1. Clean up whitespace damage.
2. Add a maintainers entry.
3. Add a pci_ids entry.
---
MAINTAINERS
From: Jay Cliburn <[EMAIL PROTECTED]>
Fix up some constants relating to max and min ring descriptor counts.
Also add functionality to enable ethtool to set tx and rx ring parameters.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1.h |4 +-
driv
From: Jay Cliburn <[EMAIL PROTECTED]>
pci_module_init is deprecated. Use pci_register_driver instead.
Discovered by and modification suggested by Alan Cox.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |5 +
1 files changed, 1 inse
Alan wrote:
Perhaps Adrian would care to simply delete the pci_module_init ancient compat
code so nobody else can inadvertently merge a driver that uses it.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.20-rc6-mm3/
The subject line on all four of the current crop of atl1 patches is
incorrect; they were generated against *2.6.20-rc6*, not rc5. I apologize
for the error.
Jay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo
From: Jay Cliburn <[EMAIL PROTECTED]>
Fix power management by properly using ifdef CONFIG_PM. Discovered by
and modification suggested by Andrew Morton.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |7 +--
1 files changed, 5 inse
From: Jay Cliburn <[EMAIL PROTECTED]>
Incorporate reviewer comments from:
Randy Dunlap, http://lkml.org/lkml/2007/1/21/157
Arjan van de Ven, http://lkml.org/lkml/2007/1/22/21
Francois Romieu, http://lkml.org/lkml/2007/1/22/49
Fixup to follow coding standards, remove MII defines already fo
From: Jay Cliburn <[EMAIL PROTECTED]>
Include dma-mapphing.h to provide DMA_32BIT_MASK and DMA_64BIT_MASK.
Discovered by and modification suggested by Andrew Morton.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |1 +
1 files changed, 1 inse
From: Luca Tettamanti <[EMAIL PROTECTED]>
Unconditionally enable MSI in atl1 driver. Also remove some useless
#ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not
configured in.
Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[
Jeff Garzik wrote:
As a driver maintainer, you need to patch sets, and submit them in a
timely fashion to me. Note I said patch set, not patch, in following
with Rule #3 from Documentation/SubmittingPatches. Also make sure to
review http://linux.yyz.us/patch-format.html
Understood. Both re
Luca Tettamanti wrote:
[snip]
Anyway...
Unconditionally enable MSI in atl1 driver. Also remove some useless
#ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not
configured in.
Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]>
Acked-by: Jay Cliburn <[EMAIL PROTE
Jeff Garzik wrote:
OK, I have merged the monolithic patch into jgarzik/netdev-2.6.git#atl1.
Once I'm done merging patches tonight, I will merge this new 'atl1'
branch into the 'ALL' meta-branch, which will auto-propagate this driver
into Andrew Morton's -mm for testing.
For future driver up
Arjan, thank you very much for reviewing the driver.
Arjan van de Ven wrote:
On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote:
[snip]
+void atl1_irq_disable(struct atl1_adapter *adapter)
+{
+ atomic_inc(&adapter->irq_sem);
+ iowrite32(0, adapter->hw.hw_addr
Randy Dunlap wrote:
On Sun, 21 Jan 2007 15:07:37 -0600 Jay Cliburn wrote:
[snip]
+ value = ioread16(hw->hw_addr + REG_PCIE_CAP_LIST);
+ return ((value & 0xFF00) == 0x6C00) ? 0 : 1;
Are there defines or enums for these?
Fewer magic numbers would be nice/helpful/readable.
From: Jay Cliburn <[EMAIL PROTECTED]>
From: Chris Snook <[EMAIL PROTECTED]>
This patch contains auxiliary C files for the Attansic L1 gigabit ethernet
adapter driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
---
From: Jay Cliburn <[EMAIL PROTECTED]>
From: Chris Snook <[EMAIL PROTECTED]>
This patch contains the header files needed by the Attansic L1 gigabit
ethernet adapter driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
From: Jay Cliburn <[EMAIL PROTECTED]>
From: Chris Snook <[EMAIL PROTECTED]>
This patch contains the build files for the Attansic L1 gigabit ethernet
adapter driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
--
This is the latest submittal of the patchset providing support for the
Attansic L1 gigabit ethernet adapter. This patchset is built against
kernel version 2.6.20-rc5.
This version incorporates all comments from:
Christoph Hellwig:
http://lkml.org/lkml/2007/1/11/43
http://lkml.org/lkml/2007/1/
Francois Romieu wrote:
Jay Cliburn <[EMAIL PROTECTED]> :
[...]
I welcome any comments on the rationality of this approach.
An URL for the current version of the patch would be welcome too :o)
Sorry. Forgot to do that. The current version may be found here:
ftp://hogchain.net/pub
Christoph Hellwig wrote:
On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote:
+struct csum_param {
+ unsigned buf_len:14;
+ unsigned dma_int:1;
+ unsigned pkt_int:1;
+ u16 valan_tag;
+ unsigned eop:1;
+ /* command */
+ unsigned coalese:1
:03.0 +0100
@@ -49,7 +49,7 @@
[snip]
Works-for-me: Jay Cliburn <[EMAIL PROTECTED]>
The following dmesg snippet after applying the patch shows life from the
hitherto unsupported device: (I connected an unpartitioned SATA HDD to it.)
==
[ 39.789326] PCI: Setting latency ti
On Thu, Jan 11, 2007 at 09:27:04AM +, Christoph Hellwig wrote:
> On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote:
> > +/**
> > + * atl1.h - atl1 main header
>
> Please remove these kind of comments, they get out of date far too soon
> and don't
This is the latest submittal of the patchset providing support for the
Attansic L1 gigabit ethernet adapter. This patchset is built against
kernel version 2.6.20-rc4 current git as of 20070109.
The monolithic version of this patchset may be found at:
ftp://hogchain.net/pub/linux/m2v/attansic/k
From: Jay Cliburn <[EMAIL PROTECTED]>
From: Chris Snook <[EMAIL PROTECTED]>
This patch contains auxiliary C files for the Attansic L1 gigabit ethernet
adapter driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
---
From: Jay Cliburn <[EMAIL PROTECTED]>
From: Chris Snook <[EMAIL PROTECTED]>
This patch contains the build files for the Attansic L1 gigabit ethernet
adapter driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
--
From: Jay Cliburn <[EMAIL PROTECTED]>
From: Chris Snook <[EMAIL PROTECTED]>
This patch contains the header files needed by the Attansic L1 gigabit
ethernet adapter driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Christoph Lameter wrote:
Ahh. Fallback_alloc() does not do the check for GFP_WAIT as done in
cache_grow(). Thus interrupts are disabled when we call kmem_getpages()
which results in the failure.
Duplicate the handling of GFP_WAIT in cache_grow().
Jay could you try this patch?
The patch seem
Luca Tettamanti wrote:
Got the board, done some basic testing: so far so good :)
The controller also supports MSI and (at least with my chipset - G965)
it works fine:
218: 80649 0 PCI-MSI-edge eth1
which is nice, otherwise it ends up sharing the IRQ with SATA and USB.
I
From: Jay Cliburn <[EMAIL PROTECTED]>
This patch contains auxiliary C files for the Attansic L1 gigabit ethernet
adapter driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
atl1_ethtool.c | 530 +++
atl1_hw.c
From: Jay Cliburn <[EMAIL PROTECTED]>
This patch contains the build files for the Attansic L1 gigabit ethernet
adapter driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
Kconfig | 12
Makefile |1 +
atl1/Makefile | 30 +
Based upon feedback from Stephen Hemminger and Francois Romieu, please
consider this resubmitted patchset that provides support for the Attansic
L1 gigabit ethernet adapter. This patchset is built against 2.6.19-rc6.
The original patchset was submitted 20060927.
The monolithic version of this
From: Jay Cliburn <[EMAIL PROTECTED]>
This patch contains the header files needed by the Attansic L1 gigabit
ethernet adapter driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
atl1.h | 251 ++
atl1_hw
97 matches
Mail list logo
