From: Luis Chamberlain
When UMH_WAIT_PROC is used we call kernel_wait4(). This is
the *only* place in the kernel where we actually inspect the
error code. Prior to this patch we returned the value from the
wait call, and that technically requires us to use wrappers
such as WEXITSTATUS(). We eithe
From: Tiezhu Yang
There exists redundant "be an" in the comment, remove it.
Acked-by: Luis Chamberlain
Signed-off-by: Tiezhu Yang
Signed-off-by: Luis Chamberlain
---
kernel/kmod.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/kmod.c b/kernel/kmod.c
index 37c
From: Tiezhu Yang
Reset the member "test_fs" of the test configuration after a call
of the function "kfree_const" to a null pointer so that a double
memory release will not be performed.
Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
Acked-by: Luis Chamberlain
Si
From: Luis Chamberlain
Tiezhu Yang had sent out a patch set with a slew of kmod selftest
fixes, and one patch which modified kmod to return 254 when a module
was not found. This opened up pandora's box about why that was being
used for and low and behold its because when UMH_WAIT_PROC is used
we
From: Luis Chamberlain
The "odd" 256 value was just an issue with the umh never
wrapping it around with WEXITSTATUS() for us. Now that it
does that, we can use a sane value / name for the selftest,
and this is no longer a oddity.
We add a way to detect this for older kernels, and support
the old
From: Tiezhu Yang
Use the variable NAME instead of "\000" directly in kmod_test_0001().
Acked-by: Luis Chamberlain
Signed-off-by: Tiezhu Yang
Signed-off-by: Luis Chamberlain
---
tools/testing/selftests/kmod/kmod.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools
From: Luis Chamberlain
This reverts commit f70b472e937bb659a7b7a14e64f07308e230888c.
This breaks testing on Debian, and this patch was NACKed anyway.
The proper way to address this is a quirk for busybox as that is
where the issue is present.
Signed-off-by: Luis Chamberlain
---
tools/testing/
From: Luis Chamberlain
This reverts commit 7492902e8d22b568463897fa967c0886764cf034.
The commit tried to address an issue discovered by Dan where he got
a message saying:
'usermode helper disabled so ignoring test'.
Dans's commit is forcing CONFIG_FW_LOADER_USER_HELPER_FALLBACK but just
having
From: Luis Chamberlain
commit a6a9be9270c87 ("selftests: firmware: return Kselftest Skip code
for skipped tests") by Shuah modified failures to return the special
error code of $ksft_skip (4). We have a corner case issue where we
*do* want to verify_reqs().
Cc: # >= 4.18
Fixes: a6a9be9270c87 ("
From: Luis Chamberlain
Greg,
I've found that Dan's patches really broke firmware testing. I've
identified a proper fix for the issue he found, its the last patch. This
series reverts his two patches which break testing, and fixes the issue
he was running into. I leave it to him as exercise to ad
WIRELESS DRIVER
M: Jiri Slaby
M: Nick Kossifidis
-M: "Luis R. Rodriguez"
+M: Luis Chamberlain
L: linux-wirel...@vger.kernel.org
W: http://wireless.kernel.org/en/users/Drivers/ath5k
S: Maintained
@@ -5784,7 +5784,7 @@ F:include/uapi/linux/fire
On Thu, Jun 28, 2018 at 05:45:14PM +0200, Vincent Guittot wrote:
> /proc/sys/kernel/sched_time_avg_ms entry is not used anywhere.
> Remove it
>
> Cc: Ingo Molnar
> Cc: Peter Zijlstra
> Cc: Kees Cook
> Cc: "Luis R. Rodriguez"
> Signed-off-by: Vincent Guitto
On Fri, Jun 22, 2018 at 04:49:49PM +0200, Sebastian Reichel wrote:
> Subject: Avoid firmware warning in imx-sdma
>
> Hi,
>
> I grabbed the first patch from patchwork from an 2017 patch series. As far as
> I
> could see, their usecase vanished due to switching to sync FW API (that
> already
> su
On Thu, Jun 07, 2018 at 09:07:01AM -0700, Alexei Starovoitov wrote:
> On Thu, Jun 07, 2018 at 02:19:16PM +0200, Dmitry Vyukov wrote:
> > On Mon, Jun 4, 2018 at 10:21 PM, syzbot
> > wrote:
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
> > > HEAD commit:69b450789136 Merge b
On Wed, Jun 06, 2018 at 08:39:15PM +0200, Hans de Goede wrote:
> On 05-06-18 23:07, Luis R. Rodriguez wrote:
> > > +To make request_firmware() fallback to trying EFI embedded firmwares
> > > after this,
> > > +the driver must set a boolean "efi-embedded-firm
The firmware loader has a fallback mechanism, and it now has some proper
kdoc, but we forgot to update the Documentation to use the new kdoc. Fix
that.
Signed-off-by: Luis R. Rodriguez
---
Documentation/driver-api/firmware/fallback-mechanisms.rst | 7 ++-
1 file changed, 6 insertions(+), 1
On Fri, Jun 01, 2018 at 02:53:27PM +0200, Hans de Goede wrote:
> Just like with PCI options ROMs, which we save in the setup_efi_pci*
> functions from arch/x86/boot/compressed/eboot.c, the EFI code / ROM itself
> sometimes may contain data which is useful/necessary for peripheral drivers
> to have
are.
>
> Signed-off-by: Mimi Zohar
> Cc: Luis R. Rodriguez
> Cc: David Howells
> Cc: Matthew Garrett
> ---
> security/integrity/ima/ima_main.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/security/integrity/ima/ima_main.c
On Wed, May 30, 2018 at 10:06:08PM +0200, Greg KH wrote:
> On Wed, May 30, 2018 at 09:55:00PM +0200, Luis R. Rodriguez wrote:
> > On Wed, May 23, 2018 at 11:35:51PM +0200, Luis R. Rodriguez wrote:
> > > On Wed, May 16, 2018 at 06:44:03PM +0200, Luis R. Rodriguez wrote:
> >
On Wed, May 23, 2018 at 11:35:51PM +0200, Luis R. Rodriguez wrote:
> On Wed, May 16, 2018 at 06:44:03PM +0200, Luis R. Rodriguez wrote:
> > On Thu, May 10, 2018 at 11:55:05AM -0700, Luis R. Rodriguez wrote:
> > > This is the 3rd iteration for moving PAGE_KERNEL_* fallback
>
On Wed, May 30, 2018 at 02:22:14AM +0300, Andy Shevchenko wrote:
> On Wed, May 30, 2018 at 2:12 AM, Luis R. Rodriguez wrote:
> > It would seem I did follow up with a v3 patch and Rusty noted that although
> > I may be right, its hard to care [0]. But of relevance here is again if
It would seem I did follow up with a v3 patch and Rusty noted that although
I may be right, its hard to care [0]. But of relevance here is again if one
of the MODULE_LICENSE() dual tags should be used or the GPL tag. I'll
continue to side recommending with the MODULE_LICENSE("GPL") tag even on
file
On Tue, May 29, 2018 at 05:00:25PM -0400, Kent Overstreet wrote:
> On Tue, May 29, 2018 at 04:51:44PM -0400, Theodore Y. Ts'o wrote:
> > On Tue, May 29, 2018 at 03:26:43PM -0400, Kent Overstreet wrote:
> > > > That seems to indicate that we've had already PostgreSQL licensed code
> > > > on
> > >
On Tue, May 29, 2018 at 03:26:43PM -0400, Kent Overstreet wrote:
> On Tue, May 29, 2018 at 12:14:01PM -0700, Luis R. Rodriguez wrote:
> > The question over future possible PostgreSQL licensed code on Linux came up
> > to me recently. While doing some quick of digging arou
The question over future possible PostgreSQL licensed code on Linux came up
to me recently. While doing some quick of digging around I found code
already under such license it seems:
The file drivers/md/bcache/util.c has:
cafe563591446 (Kent Overstreet 2013-03-23 16:11:31 -0700 318) /*
cafe563591
On Wed, May 16, 2018 at 06:44:03PM +0200, Luis R. Rodriguez wrote:
> On Thu, May 10, 2018 at 11:55:05AM -0700, Luis R. Rodriguez wrote:
> > This is the 3rd iteration for moving PAGE_KERNEL_* fallback
> > definitions into asm-generic headers. Greg asked for a Changelog
> >
On Thu, May 10, 2018 at 11:55:05AM -0700, Luis R. Rodriguez wrote:
> This is the 3rd iteration for moving PAGE_KERNEL_* fallback
> definitions into asm-generic headers. Greg asked for a Changelog
> for patch iteration changes, its below.
>
> All these patches have been
On Mon, May 14, 2018 at 07:35:03AM -0300, Mauro Carvalho Chehab wrote:
> Hi Fabien,
>
> Em Mon, 14 May 2018 08:00:37 +
> Fabien DESSENNE escreveu:
>
> > On 07/05/18 17:19, Mauro Carvalho Chehab wrote:
> > > Em Mon, 07 May 2018 16:26:08 +0300
> > > Laurent Pinchart escreveu:
> > >
> > >> H
On Mon, May 14, 2018 at 10:02:31PM -0400, Mimi Zohar wrote:
> On Mon, 2018-05-14 at 19:28 +0000, Luis R. Rodriguez wrote:
> > > - CONFIG_IMA_APPRAISE is not fine enough grained.
> > >
> > > The CONFIG_IMA_APPRAISE_FIRMWARE will be a Kconfig option. Similar
>
On Mon, May 14, 2018 at 08:58:12AM -0400, Mimi Zohar wrote:
> On Fri, 2018-05-11 at 21:52 +0000, Luis R. Rodriguez wrote:
> > diff --git a/drivers/base/firmware_loader/main.c
> > b/drivers/base/firmware_loader/main.c
> > index eb34089e4299..d7cdf04a8681 100644
&
On Sat, May 12, 2018 at 11:03:52AM +0300, Kalle Valo wrote:
> (sorry for the delay, this got buried in my inbox)
>
> "Luis R. Rodriguez" writes:
>
> > On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote:
> >> Previously, one could assume
On Fri, May 11, 2018 at 01:00:26AM -0400, Mimi Zohar wrote:
> On Thu, 2018-05-10 at 23:26 +0000, Luis R. Rodriguez wrote:
> > On Wed, May 09, 2018 at 10:00:58PM -0400, Mimi Zohar wrote:
> > > On Wed, 2018-05-09 at 23:48 +, Luis R. Rodriguez wrote:
> > > > On W
On Fri, May 11, 2018 at 03:48:51AM +0100, Al Viro wrote:
> On Thu, May 10, 2018 at 11:32:47PM +0000, Luis R. Rodriguez wrote:
>
> > I think net-next makes sense if Al Viro is OK with that. This way it could
> > go
> > in regardless of the state of your series, but it
On Thu, May 10, 2018 at 04:19:09PM -0700, Alexei Starovoitov wrote:
> On Mon, May 07, 2018 at 04:30:02PM -0700, Luis R. Rodriguez wrote:
> > This makes it clearer this code is part of the coredump code, and
> > is not an exported generic helper from kernel/umh.c.
> >
>
On Wed, May 09, 2018 at 10:00:58PM -0400, Mimi Zohar wrote:
> On Wed, 2018-05-09 at 23:48 +0000, Luis R. Rodriguez wrote:
> > On Wed, May 09, 2018 at 06:06:57PM -0400, Mimi Zohar wrote:
>
> > > > > Yes, writing regdb as a micro/mini LSM sounds reasonable. The LSM
&g
The Linux VFS does not allow a way to set append/immuttable attributes
to symlinks, this is just not possible. If this is detected we can
correct this with xfs_repair, so inform the user.
Signed-off-by: Luis R. Rodriguez
---
fs/xfs/libxfs/xfs_symlink_remote.c | 5 +
1 file changed, 5
s and inform the users of
corruption. These filesystems should have their respective filesystem
checker tools updated to correct this as well.
v1:
Sent out a single patch just to ignore the append/immutable attributes
set on symlinks.
Luis R. Rodriguez (4):
vfs: skip extra attributes check on remova
The Linux VFS does not allow a way to set append/immuttable
attributes to symlinks, this is just not possible. If this is
detected inform the user as the filesystem must be corrupted.
Signed-off-by: Luis R. Rodriguez
---
fs/ext4/inode.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a
The Linux VFS does not allow a way to set append/immuttable
attributes to symlinks, this is just not possible. If this is
detected inform the user as the filesystem must be corrupted.
Signed-off-by: Luis R. Rodriguez
---
fs/btrfs/inode.c | 9 +
1 file changed, 9 insertions(+)
diff
e this varies by
filesystem for special files, only make a special rule to respect
the immutable and append attribute on symlinks.
[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=152029
Signed-off-by: Luis R. Rodriguez
---
fs/namei.c | 24 ++--
1 file changed, 22 insertio
On Thu, May 10, 2018 at 09:48:07PM +0100, Al Viro wrote:
> On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wrote:
>
> > Since we cannot set these attributes we should special-case the
> > immutable/append on delete for symlinks, this would be consistent with
> &g
From: Andres Rodriguez
This should let us associate enum kdoc to these values.
While at it, kdocify the fw_opt.
Signed-off-by: Andres Rodriguez
Reviewed-by: Kees Cook
Acked-by: Luis R. Rodriguez
[mcgrof: coding style fixes, merge kdoc with enum move]
Signed-off-by: Luis R. Rodriguez
From: Andres Rodriguez
This is done since this call is now exposed through kernel-doc,
and since this also paves the way for different future types of
fallback mechanims.
Signed-off-by: Andres Rodriguez
Reviewed-by: Kees Cook
Acked-by: Luis R. Rodriguez
[mcgrof: small coding style changes
From: Andres Rodriguez
The kernel-doc spec dictates a function name ends in ().
Signed-off-by: Andres Rodriguez
Reviewed-by: Kees Cook
Acked-by: Randy Dunlap
Acked-by: Luis R. Rodriguez
[mcgrof: adjust since the wide API rename is not yet merged]
Signed-off-by: Luis R. Rodriguez
igned-off-by: Luis R. Rodriguez
---
drivers/base/Kconfig | 165 ++-
1 file changed, 131 insertions(+), 34 deletions(-)
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 29b0eb452b3a..db2bbe483927 100644
--- a/drivers/base/Kconfig
+++ b/drivers
This also sets the expecations for future fallback interfaces, even
if they are not exported.
Reviewed-by: Kees Cook
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_loader/fallback.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/base
This will make it easier to track and easier to understand
what components and features are part of the FW_LOADER. There
are some components related to firmware which have *nothing* to
do with the FW_LOADER, souch as PREVENT_FIRMWARE_BUILD.
Reviewed-by: Kees Cook
Signed-off-by: Luis R. Rodriguez
RN when
dealing with the fallback mechanism, we will soon, so just respect
its use consistently.
And even if you *don't* want to print always on failure, you may
want to print when debugging so enable dynamic debug print when
FW_OPT_NO_WARN is used.
Reviewed-by: Kees Cook
Signed-off-b
As per checkpatch using help is preferred over ---help---.
Signed-off-by: Luis R. Rodriguez
---
drivers/base/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index db2bbe483927..0c38df32c7fe 100644
--- a/drivers/base/Kconfig
From: Andres Rodriguez
This reduces the unnecessary spew when trying to load optional firmware:
"Direct firmware load for ... failed with error -2"
Signed-off-by: Andres Rodriguez
Reviewed-by: Kees Cook
Acked-by: Kalle Valo
Signed-off-by: Luis R. Rodriguez
---
drivers/net/wi
Clarify the provenance of the firmware loader firmware_class module name
and why we cannot rename the module in the future.
Reviewed-by: Mauro Carvalho Chehab
Reviewed-by: Kees Cook
Signed-off-by: Luis R. Rodriguez
---
.../driver-api/firmware/fallback-mechanisms.rst | 9 ++---
1
enabled. So use that instead.
Signed-off-by: Andres Rodriguez
Reviewed-by: Kees Cook
Acked-by: Kalle Valo
Signed-off-by: Luis R. Rodriguez
---
drivers/net/wireless/ath/ath10k/testmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/testmode.c
It refers to a pending patch, but this was merged eons ago.
Reviewed-by: Mauro Carvalho Chehab
Reviewed-by: Kees Cook
Signed-off-by: Luis R. Rodriguez
---
Documentation/dell_rbu.txt | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/Documentation/dell_rbu.txt b
k: re-enable the firmware fallback mechanism for testmode
Luis R. Rodriguez (8):
firmware_loader: document firmware_sysfs_fallback()
firmware_loader: enhance Kconfig documentation over FW_LOADER
firmware_loader: replace ---help--- with help
firmware_loader: move kconfig FW_LOADER entries to its o
Cook
Acked-by: Luis R. Rodriguez
[mcgrof: used the old API calls as the full rename is not done yet, and
add the caller for when FW_LOADER is disabled, enhance documentation ]
Signed-off-by: Luis R. Rodriguez
---
.../driver-api/firmware/request_firmware.rst | 5
drivers/base
Fix a few typos, and clarify a few sentences.
Reviewed-by: Kees Cook
Signed-off-by: Luis R. Rodriguez
---
Documentation/driver-api/firmware/fallback-mechanisms.rst | 5 +++--
Documentation/driver-api/firmware/firmware_cache.rst | 4 ++--
2 files changed, 5 insertions(+), 4 deletions
Some architectures just don't have PAGE_KERNEL_EXEC. The mm/nommu.c
and mm/vmalloc.c code have been using PAGE_KERNEL as a fallback for
years. Move this fallback to asm-generic.
Suggested-by: Matthew Wilcox
Signed-off-by: Luis R. Rodriguez
---
include/asm-generic/pgtable.h | 4
mm/no
-generic header.
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_loader/fallback.c | 5 -
include/asm-generic/pgtable.h | 14 ++
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/base/firmware_loader/fallback.c
b/drivers/base/firmware_loader
witht he fallback mechanism for
PAGE_KERNEL_RO.
Luis R. Rodriguez (2):
mm: provide a fallback for PAGE_KERNEL_RO for architectures
mm: provide a fallback for PAGE_KERNEL_EXEC for architectures
drivers/base/firmware_loader/fallback.c | 5 -
include/asm-generic/pgtable.h
On Thu, May 10, 2018 at 08:07:33AM +0200, Greg KH wrote:
> On Wed, May 09, 2018 at 06:44:45PM -0700, Luis R. Rodriguez wrote:
> > While dusting out the firmware loader closet I spotted a PAGE_KERNEL_*
> > fallback hack. This hurts my eyes, and it should also be blinding
> >
On Thu, May 10, 2018 at 03:33:55PM +, Luis R. Rodriguez wrote:
> On Thu, May 10, 2018 at 09:45:56AM +0200, Geert Uytterhoeven wrote:
> > Hi Luis,
> >
> > On Thu, May 10, 2018 at 3:44 AM, Luis R. Rodriguez
> > wrote:
> > > Some architectures just don
On Thu, May 10, 2018 at 09:45:56AM +0200, Geert Uytterhoeven wrote:
> Hi Luis,
>
> On Thu, May 10, 2018 at 3:44 AM, Luis R. Rodriguez wrote:
> > Some architectures just don't have PAGE_KERNEL_EXEC. The mm/nommu.c
> > and mm/vmalloc.c code have been using PAGE_KERN
ed-by: Matthew Wilcox
Signed-off-by: Luis R. Rodriguez
---
include/asm-generic/pgtable.h | 12
mm/nommu.c| 4
mm/vmalloc.c | 4
3 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/include/asm-generic/pgtable.h b/include/asm-ge
love or review. At least 0-day was happy with the changes.
Matthew Wilcox did put together a PAGE_KERNEL_RO patch for ia64, that
needs review and testing, and if it goes well it should be merged.
Luis R. Rodriguez (2):
mm: provide a fallback for PAGE_KERNEL_RO for architectures
mm: provide a
place on the firmware loader for years. Move the fallback
into the respective asm-generic header.
Architectures which don't define this yet:
o alpha
o ia64
o m68k
o mips
o sparc64
o sparc
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_loader/fallback.c | 5 -
in
On Wed, May 02, 2018 at 03:11:13PM +, Luis R. Rodriguez wrote:
> On Wed, May 02, 2018 at 12:08:57PM +0200, Geert Uytterhoeven wrote:
> > Hi Luis,
> >
> > On Sat, Apr 28, 2018 at 2:15 AM, Luis R. Rodriguez
> > wrote:
> > > Some architectures do not d
On Tue, May 08, 2018 at 06:39:35PM -0700, Matthew Wilcox wrote:
> On Wed, May 09, 2018 at 01:04:38AM +0000, Luis R. Rodriguez wrote:
> > On Fri, Apr 27, 2018 at 08:18:10PM -0700, Matthew Wilcox wrote:
> > > ia64: Add PAGE_KERNEL_RO and PAGE_KERNEL_EXEC
> > >
>
On Wed, May 09, 2018 at 06:06:57PM -0400, Mimi Zohar wrote:
> On Wed, 2018-05-09 at 21:22 +0000, Luis R. Rodriguez wrote:
> >
> > OK, its still not clear to what it will do. If it does not touch the
> > firmware
> > loader code, and it just sets and configur
On Wed, May 09, 2018 at 03:57:18PM -0400, Mimi Zohar wrote:
> On Wed, 2018-05-09 at 19:15 +0000, Luis R. Rodriguez wrote:
>
> > > > > If both are enabled, do we require both signatures or is one enough.
> > > >
> > > > Good question. Considering
On Tue, May 08, 2018 at 03:42:33PM -0700, Kees Cook wrote:
> On Tue, May 8, 2018 at 11:12 AM, Luis R. Rodriguez wrote:
> > + This used to be the default firmware loading facility, and udev
> > used
> > + to listen for uvents to load firmware for the
On Wed, May 09, 2018 at 12:12:09PM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 8 May 2018 11:12:46 -0700
> "Luis R. Rodriguez" escreveu:
>
> > It refers to a pending patch, but this was merged eons ago.
>
> Didn't know that such patch was already
On Mon, May 07, 2018 at 07:57:12PM -0400, Waiman Long wrote:
> On 05/07/2018 06:39 PM, Luis R. Rodriguez wrote:
> > On Mon, May 07, 2018 at 04:59:09PM -0400, Waiman Long wrote:
> >> A user can write arbitrary integer values to msgmni and shmmni sysctl
> >> parameters wit
amework SKIP code is 4 and the framework prints appropriate
> messages to indicate that the test is skipped.
>
> Signed-off-by: Shuah Khan (Samsung OSG)
Reviewed-by: Luis R. Rodriguez
Luis
ped.
>
> Signed-off-by: Shuah Khan (Samsung OSG)
Reviewed-by: Luis R. Rodriguez
Luis
> ---
> tools/testing/selftests/firmware/fw_fallback.sh | 4 ++--
> tools/testing/selftests/firmware/fw_filesystem.sh | 4 +++-
> tools/testing/selftests/firmware/fw_lib.sh| 7
On Wed, May 09, 2018 at 07:30:28AM -0400, Mimi Zohar wrote:
> On Tue, 2018-05-08 at 17:34 +0000, Luis R. Rodriguez wrote:
> > On Thu, May 03, 2018 at 08:24:26PM -0400, Mimi Zohar wrote:
> > > On Fri, 2018-05-04 at 00:07 +, Luis R. Rodriguez wrote:
> > > > On T
On Fri, Apr 27, 2018 at 08:18:10PM -0700, Matthew Wilcox wrote:
> On Fri, Apr 27, 2018 at 05:15:26PM -0700, Luis R. Rodriguez wrote:
> > Some architectures do not define PAGE_KERNEL_RO, best we can do
> > for them is to provide a fallback onto PAGE_KERNEL. Remove the
> > h
On Tue, May 08, 2018 at 05:17:41PM -0700, Darrick J. Wong wrote:
> On Wed, May 09, 2018 at 12:03:28AM +0000, Luis R. Rodriguez wrote:
> > Groovy, thanks, let's not forget the xfs_repair respective fix :) let me
> > know
> > if you have any feedback on that.
>
On Mon, May 07, 2018 at 05:30:55PM -0700, Darrick J. Wong wrote:
> On Tue, May 01, 2018 at 05:45:12PM +0000, Luis R. Rodriguez wrote:
> > On Tue, May 01, 2018 at 10:23:19AM -0700, Darrick J. Wong wrote:
> > > On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wr
From: Andres Rodriguez
This should let us associate enum kdoc to these values.
While at it, kdocify the fw_opt.
Signed-off-by: Andres Rodriguez
Acked-by: Luis R. Rodriguez
[mcgrof: coding style fixes, merge kdoc with enum move]
Signed-off-by: Luis R. Rodriguez
---
drivers/base
From: Andres Rodriguez
The kernel-doc spec dictates a function name ends in ().
Signed-off-by: Andres Rodriguez
Acked-by: Randy Dunlap
Acked-by: Luis R. Rodriguez
[mcgrof: adjust since the wide API rename is not yet merged]
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_loader
This also sets the expecations for future fallback interfaces, even
if they are not exported.
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_loader/fallback.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/base/firmware_loader/fallback.c
b/drivers
firmware_loader/
directory later.
This also now recommends using firmwared [0] for folks left needing a uevent
handler in userspace for the sysfs firmware fallback mechanis given udev's
uevent firmware mechanism was ripped out a while ago.
[0] https://github.com/teg/firmwared
Signed-off-by: L
__read_mostly can easily be misused by folks, its not meant for
just read-only data. There are performance reasons for using it, but
we also don't provide any guidance about its use. Provide a bit more
guidance over it use.
Acked-by: Christoph Lameter
Signed-off-by: Luis R. Rodr
This will make it easier to track and easier to understand
what components and features are part of the FW_LOADER. There
are some components related to firmware which have *nothing* to
do with the FW_LOADER, souch as PREVENT_FIRMWARE_BUILD.
Signed-off-by: Luis R. Rodriguez
---
drivers/base
On Tue, May 08, 2018 at 08:39:30AM -0700, Randy Dunlap wrote:
> On 05/08/2018 04:23 AM, Matthew Wilcox wrote:
> > On Tue, May 08, 2018 at 09:28:14AM +0100, David Howells wrote:
> >> Randy Dunlap wrote:
> >>
> + * execute a critial path. We should be mindful and selective if its
> use.
>
From: Andres Rodriguez
This reduces the unnecessary spew when trying to load optional firmware:
"Direct firmware load for ... failed with error -2"
Signed-off-by: Andres Rodriguez
Acked-by: Kalle Valo
Signed-off-by: Luis R. Rodriguez
---
drivers/net/wireless/ath/ath10k/core.c | 2
enabled. So use that instead.
Signed-off-by: Andres Rodriguez
Acked-by: Kalle Valo
Signed-off-by: Luis R. Rodriguez
---
drivers/net/wireless/ath/ath10k/testmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/testmode.c
b/drivers/net/wireless
RN when
dealing with the fallback mechanism, we will soon, so just respect
its use consistently.
And even if you *don't* want to print always on failure, you may
want to print when debugging so enable dynamic debug print when
FW_OPT_NO_WARN is used.
Signed-off-by: Luis R. Rodriguez
---
drivers/
Fix a few typos, and clarify a few sentences.
Signed-off-by: Luis R. Rodriguez
---
Documentation/driver-api/firmware/fallback-mechanisms.rst | 5 +++--
Documentation/driver-api/firmware/firmware_cache.rst | 4 ++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a
. Rodriguez
[mcgrof: used the old API calls as the full rename is not done yet, and
add the caller for when FW_LOADER is disabled, enhance documentation ]
Signed-off-by: Luis R. Rodriguez
---
.../driver-api/firmware/request_firmware.rst | 5
drivers/base/firmware_loader/main.c | 27
It refers to a pending patch, but this was merged eons ago.
Signed-off-by: Luis R. Rodriguez
---
Documentation/dell_rbu.txt | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/dell_rbu.txt b/Documentation/dell_rbu.txt
index 0fdb6aa2704c..077fdc29a0d0 100644
--- a/Documentation
From: Andres Rodriguez
This is done since this call is now exposed through kernel-doc,
and since this also paves the way for different future types of
fallback mechanims.
Signed-off-by: Andres Rodriguez
Acked-by: Luis R. Rodriguez
[mcgrof: small coding style changes]
Signed-off-by: Luis R
_request_nowarn() to load firmware
ath10k: re-enable the firmware fallback mechanism for testmode
Luis R. Rodriguez (7):
firmware_loader: document firmware_sysfs_fallback()
firmware_loader: enhance Kconfig documentation over FW_LOADER
firmware_loader: move kconfig FW_LOADER ent
Clarify the provenance of the firmware loader firmware_class module name
and why we cannot rename the module in the future.
Signed-off-by: Luis R. Rodriguez
---
.../driver-api/firmware/fallback-mechanisms.rst | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a
On Tue, May 08, 2018 at 10:13:42AM -0600, Jonathan Corbet wrote:
> On Mon, 7 May 2018 06:35:36 -0300
> Mauro Carvalho Chehab wrote:
>
> > I decided to give a try with Sphinx last stable version
> > (1.17.4), and noticed several issues. The worse one was
> > with the networking book: a non-standa
On Thu, May 03, 2018 at 08:24:26PM -0400, Mimi Zohar wrote:
> On Fri, 2018-05-04 at 00:07 +0000, Luis R. Rodriguez wrote:
> > On Tue, May 01, 2018 at 09:48:20AM -0400, Mimi Zohar wrote:
> > > Allow LSMs and IMA to differentiate between signed regulatory.db and
&g
On Fri, May 04, 2018 at 07:54:28AM +0200, Ard Biesheuvel wrote:
> On 4 May 2018 at 01:29, Luis R. Rodriguez wrote:
> > On Sun, Apr 29, 2018 at 11:35:55AM +0200, Hans de Goede wrote:
> [...]
> >> diff --git a/Documentation/driver-api/firmware/request_firmware.rst
> >&
On Tue, May 08, 2018 at 03:38:05PM +, Luis R. Rodriguez wrote:
> On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote:
> > On Wed, Apr 25, 2018 at 10:55 AM, Luis R. Rodriguez
> > wrote:
> > > Android became the primary user of CONFIG_FW_LOADER_USER_HELPER_
changed accordingly,
> causing Sphinx errors.
>
> Change the location accordingly at the documentation files.
>
> While here, add a missing entry at request_firmware.rst for
> release_firmware() function.
>
> Fixes: 5d6d1ddd2730 ("firmware: move firmware loader into i
On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote:
> On Wed, Apr 25, 2018 at 10:55 AM, Luis R. Rodriguez wrote:
> > Android became the primary user of CONFIG_FW_LOADER_USER_HELPER_FALLBACK.
> >
> > It would be good for us to hear from Android folks if
1 - 100 of 1399 matches
Mail list logo
