Re: [PATCH 2/2] remoteproc: imx_rproc: support remote cores booted before Linux Kernel

2021-03-25 Thread Mathieu Poirier
On Fri, Mar 19, 2021 at 06:47:08PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Support remote cores booted before Linux Kernel booting. > > Add rsc_table to hold the resource table published by remote cores > Add attach hook Missing a period "." and a new line between the paragraphs. > A

Re: [PATCH 1/2] remoteproc: imx_rproc: enlarge IMX7D_RPROC_MEM_MAX

2021-03-25 Thread Mathieu Poirier
On Thu, Mar 25, 2021 at 05:00:42PM -0600, Mathieu Poirier wrote: > Hi Peng, > > On Fri, Mar 19, 2021 at 06:47:07PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > 8 is not enough when we need more, so enlarge IMX7D_RPROC_MEM_MAX to 32, > > and also ren

Re: [PATCH 1/2] remoteproc: imx_rproc: enlarge IMX7D_RPROC_MEM_MAX

2021-03-25 Thread Mathieu Poirier
Hi Peng, On Fri, Mar 19, 2021 at 06:47:07PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > 8 is not enough when we need more, so enlarge IMX7D_RPROC_MEM_MAX to 32, > and also rename it to IMX_RPROC_MEM_MAX which make more sense. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rp

Re: [PATCH v2 2/2] remoteproc: stm32: add capability to detach

2021-03-25 Thread Mathieu Poirier
On Tue, Mar 23, 2021 at 03:19:11PM -0600, Mathieu Poirier wrote: > Good day Arnaud, > > On Mon, Mar 22, 2021 at 10:26:51AM +0100, Arnaud Pouliquen wrote: > > From: Arnaud Pouliquen > > > > A mechanism similar to the shutdown mailbox signal is implemented to &g

Re: [PATCH 2/2] remoteproc: k3-r5: Extend support to R5F clusters on AM64x SoCs

2021-03-25 Thread Mathieu Poirier
On Thu, Mar 25, 2021 at 04:00:55PM -0500, Suman Anna wrote: > Hi Mathieu, > > On 3/25/21 12:30 PM, Mathieu Poirier wrote: > > Good morning, > > > > On Thu, Mar 18, 2021 at 04:58:42PM -0500, Suman Anna wrote: > >> The K3 AM64x SoC family has a revised R5F sub-

Re: [PATCH] remoteproc: pru: Fix firmware loading crashes on K3 SoCs

2021-03-25 Thread Mathieu Poirier
On Wed, 24 Mar 2021 at 11:09, Suman Anna wrote: > > On 3/23/21 6:20 PM, Mathieu Poirier wrote: > > On Mon, Mar 15, 2021 at 03:58:59PM -0500, Suman Anna wrote: > >> The K3 PRUs are 32-bit processors and in general have some limitations > >> in using the standard ARM

Re: [PATCH 2/2] remoteproc: k3-r5: Extend support to R5F clusters on AM64x SoCs

2021-03-25 Thread Mathieu Poirier
Good morning, On Thu, Mar 18, 2021 at 04:58:42PM -0500, Suman Anna wrote: > The K3 AM64x SoC family has a revised R5F sub-system and contains a > subset of the R5F clusters present on J721E SoCs. The K3 AM64x SoCs > only have two dual-core Arm R5F clusters/subsystems with 2 R5F cores > each presen

Re: [PATCH 2/2] remoteproc: k3-r5: Extend support to R5F clusters on AM64x SoCs

2021-03-24 Thread Mathieu Poirier
Good day Suman, On Thu, Mar 18, 2021 at 04:58:42PM -0500, Suman Anna wrote: > The K3 AM64x SoC family has a revised R5F sub-system and contains a > subset of the R5F clusters present on J721E SoCs. The K3 AM64x SoCs > only have two dual-core Arm R5F clusters/subsystems with 2 R5F cores > each pres

Re: [PATCH] remoteproc: pru: Fix firmware loading crashes on K3 SoCs

2021-03-23 Thread Mathieu Poirier
o Data RAMs as well for all K3 SoCs. > > Fixes: 1d39f4d19921 ("remoteproc: pru: Add support for various PRU cores on > K3 AM65x SoCs") > Signed-off-by: Suman Anna Probably a good idea to CC stable as well... Reviewed-by: Mathieu Poirier > --- > drivers/remoteproc/

Re: [PATCH v2 2/2] remoteproc: stm32: add capability to detach

2021-03-23 Thread Mathieu Poirier
r on what you mean by "clean". Usually it means zero'ing out but in this case it means a re-initialisation of the original values. > *table_sz = RSC_TBL_SIZE; > return (struct resource_table *)ddata->rsc_va; > } > @@ -607,6 +640,7 @@ static const struct rproc_ops st_rproc_ops = { > .start = stm32_rproc_start, > .stop = stm32_rproc_stop, > .attach = stm32_rproc_attach, > + .detach = stm32_rproc_detach, With the above: Reviewed-by: Mathieu Poirier > .kick = stm32_rproc_kick, > .load = rproc_elf_load_segments, > .parse_fw = stm32_rproc_parse_fw, > -- > 2.17.1 >

Re: [PATCH v4 09/19] coresight: etm4x: Move ETM to prohibited region for disable

2021-03-22 Thread Mathieu Poirier
On Thu, Feb 25, 2021 at 07:35:33PM +, Suzuki K Poulose wrote: > If the CPU implements Arm v8.4 Trace filter controls (FEAT_TRF), > move the ETM to trace prohibited region using TRFCR, while disabling. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Anshuman Khandual >

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-22 Thread Mathieu Poirier
), > > >> an write pointer (TRBPTR_EL1) and a limit pointer (TRBLIMITR_EL1). But > > >> the > > >> access to the trace buffer could be prohibited by a higher exception > > >> level > > >> (EL3 or EL2), indicated by TRBIDR_EL1.P. The TRBE

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-22 Thread Mathieu Poirier
2), indicated by TRBIDR_EL1.P. The TRBE can also generate a CPU > private interrupt (PPI) on address translation errors and when the buffer > is full. Overall implementation here is inspired from the Arm SPE driver. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Suzuki

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-19 Thread Mathieu Poirier
2), indicated by TRBIDR_EL1.P. The TRBE can also generate a CPU > private interrupt (PPI) on address translation errors and when the buffer > is full. Overall implementation here is inspired from the Arm SPE driver. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Suzuki

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-19 Thread Mathieu Poirier
On Fri, 19 Mar 2021 at 04:34, Suzuki K Poulose wrote: > > Hi Mathieu, > > > On 18 Mar 2021, at 18:08, Mathieu Poirier > > wrote: > > > > Good morning, > > > > On Thu, Feb 25, 2021 at 07:35:42PM +, Suzuki K Poulose wrote: > >> From: Ans

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-18 Thread Mathieu Poirier
tion level > (EL3 or EL2), indicated by TRBIDR_EL1.P. The TRBE can also generate a CPU > private interrupt (PPI) on address translation errors and when the buffer > is full. Overall implementation here is inspired from the Arm SPE driver. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc

Re: [PATCH v4 17/19] coresight: core: Add support for dedicated percpu sinks

2021-03-17 Thread Mathieu Poirier
; Build the path directly and skip connection scanning for such devices. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Suzuki K Poulose > Tested-by: Suzuki K Poulose > Reviewed-by: Suzuki K Poulose > Signed-off-by: Anshuman Khandual > [Moved the set/get percpu sink APIs f

Re: [PATCH v4 09/19] coresight: etm4x: Move ETM to prohibited region for disable

2021-03-17 Thread Mathieu Poirier
On Wed, Mar 17, 2021 at 10:44:51AM +, Suzuki K Poulose wrote: > Hi Mathieu > > On 3/16/21 7:30 PM, Mathieu Poirier wrote: > > On Thu, Feb 25, 2021 at 07:35:33PM +, Suzuki K Poulose wrote: > > > If the CPU implements Arm v8.4 Trace filter controls (FEAT_TRF), >

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-17 Thread Mathieu Poirier
On Mon, Mar 15, 2021 at 09:32:40PM +, Ben Levinsky wrote: > > > -Original Message- > From: Mathieu Poirier > Date: Monday, March 15, 2021 at 10:37 AM > To: Ben Levinsky > Cc: "devicet...@vger.kernel.org" , > "linux-remotep...@vger.kernel.

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-17 Thread Mathieu Poirier
[...] > > > +/* > > > + * zynqmp_r5_remoteproc_probe > > > + * > > > + * @pdev: domain platform device for R5 cluster > > > + * > > > + * called when driver is probed, for each R5 core specified in > DT, > > > + * setup as needed to do remot

Re: [PATCH v4 10/19] coresight: etm-perf: Allow an event to use different sinks

2021-03-16 Thread Mathieu Poirier
driver and matches the same subtype. Please note > that at anytime there can be only one ETM tracing the event. > > Adding support for different types of sinks for a single > event is complex and is not something that we expect > on a sane configuration. > > Cc: Mathieu

Re: [PATCH v4 09/19] coresight: etm4x: Move ETM to prohibited region for disable

2021-03-16 Thread Mathieu Poirier
On Thu, Feb 25, 2021 at 07:35:33PM +, Suzuki K Poulose wrote: > If the CPU implements Arm v8.4 Trace filter controls (FEAT_TRF), > move the ETM to trace prohibited region using TRFCR, while disabling. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Anshuman Khandual >

Re: [PATCH v4 08/19] arm64: kvm: Enable access to TRBE support for host

2021-03-16 Thread Mathieu Poirier
+++ > arch/arm64/kvm/hyp/nvhe/switch.c | 1 + > 7 files changed, 65 insertions(+), 4 deletions(-) > Acked-by: Mathieu Poirier > diff --git a/arch/arm64/include/asm/el2_setup.h > b/arch/arm64/include/asm/el2_setup.h > index d77d358f9395..bda918948471 1

Re: [PATCH v4 07/19] arm64: Add TRBE definitions

2021-03-16 Thread Mathieu Poirier
On Thu, Feb 25, 2021 at 07:35:31PM +, Suzuki K Poulose wrote: > From: Anshuman Khandual > > This adds TRBE related registers and corresponding feature macros. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Suzuki K Poulose > Reviewed-by: Suzuki K Poulose &

Re: [PATCH v4 02/19] perf: aux: Add CoreSight PMU buffer formats

2021-03-16 Thread Mathieu Poirier
format) > - RAW format (indicates the format of the source) > > The default value is CORESIGHT format for all the records > (i,e == 0). Add the RAW format for others that use > raw format. > > Cc: Peter Zijlstra > Cc: Mike Leach > Cc: Mathieu Poirier > Cc: Leo Yan

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-15 Thread Mathieu Poirier
On Thu, Mar 11, 2021 at 11:49:13PM +, Ben Levinsky wrote: > Hi Mathieu > > -Original Message- > From: Mathieu Poirier > Date: Tuesday, March 9, 2021 at 8:53 AM > To: Ben Levinsky > Cc: "devicet...@vger.kernel.org" , > "linux-remotep

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-15 Thread Mathieu Poirier
> > + > > +static void zynqmp_r5_cleanup_mbox(struct zynqmp_r5_rproc *z_rproc) > > +{ > > + mbox_free_channel(z_rproc->tx_chan); > > + mbox_free_channel(z_rproc->rx_chan); > > +} > > + > > +/** > > + * zynqmp_r5_probe - Probes ZynqMP R5 processor devi

Re: [PATCH v2] remoteproc: qcom_q6v5_mss: Validate p_filesz in ELF loader

2021-03-15 Thread Mathieu Poirier
quot;, > + i, fw_name); > + ret = -EINVAL; > + release_firmware(seg_fw); > + memunmap(ptr); > + goto release_firmware; > + } > + Reviewed-by: Mathieu Poirier > release_firmware(seg_fw); > } > > -- > 2.29.2 >

Re: [PATCH] remoteproc: qcom: wcnss: Fix race with iris probe

2021-03-15 Thread Mathieu Poirier
by: Bjorn Andersson > --- > drivers/remoteproc/qcom_wcnss.c | 52 > drivers/remoteproc/qcom_wcnss.h | 4 +- > drivers/remoteproc/qcom_wcnss_iris.c | 120 +-- > 3 files changed, 91 insertions(+), 85 deletions(-) Acked-by: Mathieu Poi

Re: [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing

2021-03-15 Thread Mathieu Poirier
t;dev.of_node, "firmware-name", > 1, &qproc->hexagon_mdt_image); > - if (ret < 0 && ret != -EINVAL) > + if (ret < 0 && ret != -EINVAL) { > + dev_err(&pdev->dev, "unable to read mpss firmware-name\n"); > goto free_rproc; > + } Reviewed-by: Mathieu Poirier > > platform_set_drvdata(pdev, qproc); > > -- > 2.29.2 >

Re: [PATCH 0/6] rpmsg: enable the use of the rpmsg_char device for the Virtio backend

2021-03-15 Thread Mathieu Poirier
++--- > include/linux/rpmsg.h | 3 +- > include/uapi/linux/rpmsg.h| 13 ++- > 6 files changed, 108 insertions(+), 13 deletions(-) Reviewed-by: Mathieu Poirier > > -- > 2.17.1 >

[PATCH v8 13/17] remoteproc: Properly deal with a kernel panic when attached

2021-03-12 Thread Mathieu Poirier
The panic handler operation of registered remote processors should also be called when remote processors have been attached to. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 6 +- 1 file changed, 5 insertions

[PATCH v8 16/17] remoteproc: Properly deal with a detach request when attached

2021-03-12 Thread Mathieu Poirier
This patch introduces the capability to detach a remote processor that has been attached to by the remoteproc core. For that to happen a rproc::ops::detach() operation needs to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_cdev.c

[PATCH v8 14/17] remoteproc: Properly deal with a start request when attached

2021-03-12 Thread Mathieu Poirier
This patch takes into account scenarios where a remote processor has been attached to when receiving a "start" command from sysfs. As with the case with the running state, the command can't be carried out if the remote processor is already in operation. Signed-off-by: Mathieu Po

[PATCH v8 15/17] remoteproc: Properly deal with a stop request when attached

2021-03-12 Thread Mathieu Poirier
Allow a remote processor that was started by another entity to be switched off by the remoteproc core. For that to happen a rproc::ops::stop() operation needs to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_cdev.c | 3

[PATCH v8 17/17] remoteproc: Refactor function rproc_cdev_release()

2021-03-12 Thread Mathieu Poirier
Refactor function rproc_cdev_release() to take into account the current state of the remote processor when choosing the state to transition to. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_cdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a

[PATCH v8 10/17] remoteproc: Introduce function rproc_detach()

2021-03-12 Thread Mathieu Poirier
Introduce function rproc_detach() to enable the remoteproc core to release the resources associated with a remote processor without stopping its operation. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 58

[PATCH v8 11/17] remoteproc: Properly deal with the resource table when detaching

2021-03-12 Thread Mathieu Poirier
: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- New for V8: - Checking return code for error in __rproc_datch(). --- drivers/remoteproc/remoteproc_core.c | 82 include/linux/remoteproc.h | 3 + 2 files changed, 85 insertions(+) diff --git a/drivers

[PATCH v8 12/17] remoteproc: Properly deal with the resource table when stopping

2021-03-12 Thread Mathieu Poirier
processor. From that point on the copy is used, as if the remote processor had been started by the remoteproc core. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen Reported-by: kernel test robot --- New for V8: - Removed variable @table_ptr as it served no purpose. --- drivers

[PATCH v8 09/17] remoteproc: Introduce function __rproc_detach()

2021-03-12 Thread Mathieu Poirier
te processor while the latter is kept operating. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 30 1 file changed, 30 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.

[PATCH v8 04/17] remoteproc: Properly represent the attached state

2021-03-12 Thread Mathieu Poirier
: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 20 +--- drivers/remoteproc/remoteproc_sysfs.c | 5 + include/linux/remoteproc.h| 2 -- 3 files changed, 2 insertions(+), 25 deletions(-) diff --git a

[PATCH v8 08/17] remoteproc: Add new detach() remoteproc operation

2021-03-12 Thread Mathieu Poirier
Add an new detach() operation in order to support scenarios where the remoteproc core is going away but the remote processor is kept operating. This could be the case when the system is rebooted or when the platform driver is removed. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan

[PATCH v8 07/17] remoteproc: stm32: Move memory parsing to rproc_ops

2021-03-12 Thread Mathieu Poirier
From: Arnaud POULIQUEN Some actions such as memory resources reallocation are needed when trying to reattach a co-processor. Use the prepare() operation for these actions. Co-developed-by: Mathieu Poirier Signed-off-by: Mathieu Poirier Signed-off-by: Arnaud POULIQUEN --- drivers/remoteproc

[PATCH v8 05/17] remoteproc: Add new get_loaded_rsc_table() to rproc_ops

2021-03-12 Thread Mathieu Poirier
Add a new get_loaded_rsc_table() operation in order to support scenarios where the remoteproc core has booted a remote processor and detaches from it. When re-attaching to the remote processor, the core needs to know where the resource table has been placed in memory. Signed-off-by: Mathieu

[PATCH v8 06/17] remoteproc: stm32: Move resource table setup to rproc_ops

2021-03-12 Thread Mathieu Poirier
be available at a later time than the platform driver's probe() function. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 141 +++ 1 file changed, 68 insertions(+), 73 deletions(-) diff --git a/drivers/remot

[PATCH v8 03/17] remoteproc: Add new RPROC_ATTACHED state

2021-03-12 Thread Mathieu Poirier
Add a new RPROC_ATTACHED state to take into account scenarios where the remoteproc core needs to attach to a remote processor that is booted by another entity. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_sysfs.c | 1

[PATCH v8 02/17] remoteproc: Rename function rproc_actuate()

2021-03-12 Thread Mathieu Poirier
Rename function rproc_actuate() to rproc_attach(). That way it is easy to understand that it does the opposite of rproc_detach(). Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 8 1 file changed, 4

[PATCH v8 01/17] remoteproc: Remove useless check in rproc_del()

2021-03-12 Thread Mathieu Poirier
when in fact it no longer exist. Invariably calling rproc_shutdown() is fine since it will return immediately if the remote processor has already been switched off. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 4

[PATCH v8 00/17] remoteproc: Add support for detaching a remote processor

2021-03-12 Thread Mathieu Poirier
rproc_ops Mathieu Poirier (16): remoteproc: Remove useless check in rproc_del() remoteproc: Rename function rproc_actuate() remoteproc: Add new RPROC_ATTACHED state remoteproc: Properly represent the attached state remoteproc: Add new get_loaded_rsc_table() to rproc_ops remoteproc

Re: [PATCH V13 00/10] remoteproc: imx_rproc: support iMX8MQ/M

2021-03-11 Thread Mathieu Poirier
On Thu, Mar 11, 2021 at 01:26:25AM +, Peng Fan (OSS) wrote: > Mathieu, > > > Subject: Re: [PATCH V13 00/10] remoteproc: imx_rproc: support iMX8MQ/M > > > > On Sat, Mar 06, 2021 at 07:24:15PM +0800, peng@oss.nxp.com wrote: > > > From: Peng Fan > > > > > > V13: > > > Add R-b tag from Rob

Re: [PATCH v7 12/17] remoteproc: Properly deal with the resource table when stopping

2021-03-11 Thread Mathieu Poirier
On Wed, Mar 10, 2021 at 05:53:04PM -0600, Bjorn Andersson wrote: > On Wed 10 Mar 15:10 CST 2021, Mathieu Poirier wrote: > > > When a remote processor that was attached to is stopped, special care > > must be taken to make sure the shutdown process is similar to what > >

[PATCH v7 05/17] remoteproc: Add new get_loaded_rsc_table() to rproc_ops

2021-03-10 Thread Mathieu Poirier
Add a new get_loaded_rsc_table() operation in order to support scenarios where the remoteproc core has booted a remote processor and detaches from it. When re-attaching to the remote processor, the core needs to know where the resource table has been placed in memory. Signed-off-by: Mathieu

[PATCH v7 17/17] remoteproc: Refactor function rproc_cdev_release()

2021-03-10 Thread Mathieu Poirier
Refactor function rproc_cdev_release() to take into account the current state of the remote processor when choosing the state to transition to. Signed-off-by: Mathieu Poirier --- New for V7: Keep the behavior of the shutdown operation in rproc_del() intact. --- drivers/remoteproc

[PATCH v7 16/17] remoteproc: Properly deal with a detach request when attached

2021-03-10 Thread Mathieu Poirier
This patch introduces the capability to detach a remote processor that has been attached to by the remoteproc core. For that to happen a rproc::ops::detach() operation needs to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_cdev.c

[PATCH v7 08/17] remoteproc: Add new detach() remoteproc operation

2021-03-10 Thread Mathieu Poirier
Add an new detach() operation in order to support scenarios where the remoteproc core is going away but the remote processor is kept operating. This could be the case when the system is rebooted or when the platform driver is removed. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan

[PATCH v7 04/17] remoteproc: Properly represent the attached state

2021-03-10 Thread Mathieu Poirier
: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 20 +--- drivers/remoteproc/remoteproc_sysfs.c | 5 + include/linux/remoteproc.h| 2 -- 3 files changed, 2 insertions(+), 25 deletions(-) diff --git a

[PATCH v7 15/17] remoteproc: Properly deal with a stop request when attached

2021-03-10 Thread Mathieu Poirier
Allow a remote processor that was started by another entity to be switched off by the remoteproc core. For that to happen a rproc::ops::stop() operation needs to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_cdev.c | 3

[PATCH v7 13/17] remoteproc: Properly deal with a kernel panic when attached

2021-03-10 Thread Mathieu Poirier
The panic handler operation of registered remote processors should also be called when remote processors have been attached to. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 6 +- 1 file changed, 5 insertions

[PATCH v7 12/17] remoteproc: Properly deal with the resource table when stopping

2021-03-10 Thread Mathieu Poirier
processor. From that point on the copy is used, as if the remote processor had been started by the remoteproc core. Signed-off-by: Mathieu Poirier --- New for V7: New Patch, used to be part of 11/16 in V6. --- drivers/remoteproc/remoteproc_core.c | 53 +++- 1 file changed, 52

[PATCH v7 14/17] remoteproc: Properly deal with a start request when attached

2021-03-10 Thread Mathieu Poirier
This patch takes into account scenarios where a remote processor has been attached to when receiving a "start" command from sysfs. As with the case with the running state, the command can't be carried out if the remote processor is already in operation. Signed-off-by: Mathieu Po

[PATCH v7 01/17] remoteproc: Remove useless check in rproc_del()

2021-03-10 Thread Mathieu Poirier
when in fact it no longer exist. Invariably calling rproc_shutdown() is fine since it will return immediately if the remote processor has already been switched off. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 4

[PATCH v7 09/17] remoteproc: Introduce function __rproc_detach()

2021-03-10 Thread Mathieu Poirier
te processor while the latter is kept operating. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 30 1 file changed, 30 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.

[PATCH v7 11/17] remoteproc: Properly deal with the resource table when detaching

2021-03-10 Thread Mathieu Poirier
: Mathieu Poirier --- New for V7: New Patch, used to be part of 11/16 in V6. --- drivers/remoteproc/remoteproc_core.c | 77 include/linux/remoteproc.h | 3 ++ 2 files changed, 80 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers

[PATCH v7 10/17] remoteproc: Introduce function rproc_detach()

2021-03-10 Thread Mathieu Poirier
Introduce function rproc_detach() to enable the remoteproc core to release the resources associated with a remote processor without stopping its operation. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 58

[PATCH v7 03/17] remoteproc: Add new RPROC_ATTACHED state

2021-03-10 Thread Mathieu Poirier
Add a new RPROC_ATTACHED state to take into account scenarios where the remoteproc core needs to attach to a remote processor that is booted by another entity. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_sysfs.c | 1

[PATCH v7 02/17] remoteproc: Rename function rproc_actuate()

2021-03-10 Thread Mathieu Poirier
Rename function rproc_actuate() to rproc_attach(). That way it is easy to understand that it does the opposite of rproc_detach(). Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 8 1 file changed, 4

[PATCH v7 07/17] remoteproc: stm32: Move memory parsing to rproc_ops

2021-03-10 Thread Mathieu Poirier
From: Arnaud POULIQUEN Some actions such as memory resources reallocation are needed when trying to reattach a co-processor. Use the prepare() operation for these actions. Co-developed-by: Mathieu Poirier Signed-off-by: Mathieu Poirier Signed-off-by: Arnaud POULIQUEN --- drivers/remoteproc

[PATCH v7 06/17] remoteproc: stm32: Move resource table setup to rproc_ops

2021-03-10 Thread Mathieu Poirier
be available at a later time than the platform driver's probe() function. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 141 +++ 1 file changed, 68 insertions(+), 73 deletions(-) diff --git a/drivers/remot

[PATCH v7 00/17] remoteproc: Add support for detaching a remote processor

2021-03-10 Thread Mathieu Poirier
(1): remoteproc: stm32: Move memory parsing to rproc_ops Mathieu Poirier (16): remoteproc: Remove useless check in rproc_del() remoteproc: Rename function rproc_actuate() remoteproc: Add new RPROC_ATTACHED state remoteproc: Properly represent the attached state remoteproc: Add new

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-09 Thread Mathieu Poirier
[...] > + > +/** > + * zynqmp_r5_probe - Probes ZynqMP R5 processor device node > + * this is called for each individual R5 core to > + * set up mailbox, Xilinx platform manager unique ID, > + * add to rproc core > + * > + * @pdev: domain platform

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-08 Thread Mathieu Poirier
On Tue, Feb 23, 2021 at 07:44:47AM -0800, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remoteproc driver, we can boot the R5 sub-system in two different > configurations - > * Split > * Lockstep > > The Xilinx R5 Remoteproc Driver boots the R

Re: [PATCH V13 00/10] remoteproc: imx_rproc: support iMX8MQ/M

2021-03-08 Thread Mathieu Poirier
On Sat, Mar 06, 2021 at 07:24:15PM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > V13: > Add R-b tag from Rob for patch 1. > Drop the reserved memory node from patch 2 per Rob's comment. > Mathieu, Bjorn > Only patch 2 not have R-b/A-b tag, but since Rob's only has a minor > commen

Re: [PATCH v5 13/16] rpmsg: char: introduce __rpmsg_chrdev_create_eptdev function

2021-03-05 Thread Mathieu Poirier
On Fri, Mar 05, 2021 at 11:46:47AM +0100, Arnaud POULIQUEN wrote: > > > On 3/4/21 7:55 PM, Mathieu Poirier wrote: > > On Fri, Feb 19, 2021 at 12:14:58PM +0100, Arnaud Pouliquen wrote: > >> Introduce the __rpmsg_chrdev_create_eptdev internal function that returns >

Re: [PATCH v5 15/16] rpmsg: char: no dynamic endpoint management for the default one

2021-03-05 Thread Mathieu Poirier
On Fri, Mar 05, 2021 at 12:09:37PM +0100, Arnaud POULIQUEN wrote: > > > On 3/4/21 7:40 PM, Mathieu Poirier wrote: > > There has to be a capital letter at the start of the title: > > > > rpmsg: char: No dynamic endpoint management for the default one > > &

Re: [PATCH v5 08/16] rpmsg: glink: add sendto and trysendto ops

2021-03-05 Thread Mathieu Poirier
[...] > >> } > >> > >> +static int qcom_glink_sendto(struct rpmsg_endpoint *ept, void *data, int > >> len, u32 dst) > >> +{ > >> + struct glink_channel *channel = to_glink_channel(ept); > >> + > >> + return __qcom_glink_send(channel, data, len, true); > >> +} > >> + > >> +static int qcom_gli

Re: [PATCH v5 08/16] rpmsg: glink: add sendto and trysendto ops

2021-03-04 Thread Mathieu Poirier
On Fri, Feb 19, 2021 at 12:14:53PM +0100, Arnaud Pouliquen wrote: > Implement the sendto ops to support the future rpmsg_char update for the > vitio backend support. Add a new line, otherwise it is very easy to read. > The use of sendto in rpmsg_char is needed as a destination address is > reques

Re: [PATCH v5 13/16] rpmsg: char: introduce __rpmsg_chrdev_create_eptdev function

2021-03-04 Thread Mathieu Poirier
On Fri, Feb 19, 2021 at 12:14:58PM +0100, Arnaud Pouliquen wrote: > Introduce the __rpmsg_chrdev_create_eptdev internal function that returns > the rpmsg_eptdev context structure. Add newlines between paragraphs. > This patch prepares the introduction of a RPMsg device for the > char device. the

Re: [PATCH v5 13/16] rpmsg: char: introduce __rpmsg_chrdev_create_eptdev function

2021-03-04 Thread Mathieu Poirier
On Fri, Feb 19, 2021 at 12:14:58PM +0100, Arnaud Pouliquen wrote: > Introduce the __rpmsg_chrdev_create_eptdev internal function that returns > the rpmsg_eptdev context structure. > This patch prepares the introduction of a RPMsg device for the > char device. the RPMsg device will need a reference

Re: [PATCH v5 16/16] rpmsg: char: return an error if device already open

2021-03-04 Thread Mathieu Poirier
On Fri, Feb 19, 2021 at 12:15:01PM +0100, Arnaud Pouliquen wrote: > The rpmsg_create_ept function is invoked when the device is opened. > As only one endpoint must be created per device. It is not possible to > open the same device twice. But there is nothing to prevent multi open. s/multi/multipl

Re: [PATCH v5 15/16] rpmsg: char: no dynamic endpoint management for the default one

2021-03-04 Thread Mathieu Poirier
There has to be a capital letter at the start of the title: rpmsg: char: No dynamic endpoint management for the default one Please fix for all the patches. On Fri, Feb 19, 2021 at 12:15:00PM +0100, Arnaud Pouliquen wrote: > Do not dynamically manage the default endpoint. The ept address must > n

Re: [PATCH v5 11/16] rpmsg: virtio: register the rpmsg_ctrl device

2021-03-03 Thread Mathieu Poirier
On Fri, Feb 19, 2021 at 12:14:56PM +0100, Arnaud Pouliquen wrote: > Instantiate the rpmsg_ioctl device on virtio RPMsg bus creation. s/rpmsg_ioctl/rpmsg_ctrl Now I understand what you meant in patch 05. > This provides the possibility to expose the RPMSG_CREATE_EPT_IOCTL > to create RPMsg chdev

Re: [PATCH v5 07/16] rpmsg: update rpmsg_chrdev_register_device function

2021-03-03 Thread Mathieu Poirier
On Fri, Feb 19, 2021 at 12:14:52PM +0100, Arnaud Pouliquen wrote: > As driver is now the rpmsg_ioctl, rename the function. > In addition, initialize the rpdev addresses to RPMSG_ADDR_ANY as not > defined. This patch works but the changelog needs a rework. The title reflects the essence of changes

Re: [PATCH v5 06/16] rpmsg: move the rpmsg control device from rpmsg_char to rpmsg_ctrl

2021-03-03 Thread Mathieu Poirier
On Wed, Mar 03, 2021 at 03:59:34PM +0100, Arnaud POULIQUEN wrote: > > > On 3/2/21 7:35 PM, Mathieu Poirier wrote: > > On Fri, Feb 19, 2021 at 12:14:51PM +0100, Arnaud Pouliquen wrote: > >> Move the code related to the rpmsg_ctrl char device to the new > >> rpm

Re: [PATCH v5 04/16] rpmsg: char: export eptdev create an destroy functions

2021-03-03 Thread Mathieu Poirier
On Wed, Mar 03, 2021 at 02:22:36PM +0100, Arnaud POULIQUEN wrote: > Hi Mathieu, > > On 3/2/21 6:57 PM, Mathieu Poirier wrote: > > Good morning, > > > > I have started to review this set - comments will be staggered over several > > days. > > > > On

Re: [PATCH v5 06/16] rpmsg: move the rpmsg control device from rpmsg_char to rpmsg_ctrl

2021-03-02 Thread Mathieu Poirier
On Fri, Feb 19, 2021 at 12:14:51PM +0100, Arnaud Pouliquen wrote: > Move the code related to the rpmsg_ctrl char device to the new > rpmsg_ctrl.c module. > Manage the dependency in the kconfig. > > Signed-off-by: Arnaud Pouliquen > --- > drivers/rpmsg/Kconfig | 9 ++ > drivers/rpmsg/Makef

Re: [PATCH v5 04/16] rpmsg: char: export eptdev create an destroy functions

2021-03-02 Thread Mathieu Poirier
with the rpmsg_ctrldev struct, > - rename and export the functions in rpmsg_char.h. > > Suggested-by: Mathieu Poirier > Signed-off-by: Arnaud Pouliquen > --- > drivers/rpmsg/rpmsg_char.c | 22 ++-- > drivers/rpmsg/rpmsg_char.h | 51 +++

Re: [PATCH v5 05/16] rpmsg: char: dissociate the control device from the rpmsg class

2021-03-02 Thread Mathieu Poirier
On Fri, Feb 19, 2021 at 12:14:50PM +0100, Arnaud Pouliquen wrote: > The RPMsg control device is a RPMsg device, it is already > referenced in the RPMsg bus. There is only an interest to > reference the ept char devices in the rpmsg class. > This patch prepares the code split of the control and end

Re: [PATCH 0/6] coresight: Patches for v5.12 (perf tools)

2021-03-02 Thread Mathieu Poirier
On Tue, Mar 02, 2021 at 01:24:27PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 02, 2021 at 02:23:14PM +, Mike Leach escreveu: > > On Tue, 2 Mar 2021 at 12:52, Arnaldo Carvalho de Melo > > wrote: > > > Em Wed, Feb 24, 2021 at 09:48:29AM -0700, Mathieu Poi

Re: [PATCH v6 00/16] remoteproc: Add support for detaching a remote processor

2021-03-01 Thread Mathieu Poirier
On Fri, Feb 26, 2021 at 05:40:49PM +0100, Arnaud POULIQUEN wrote: > Hi Mathieu, > > On 2/24/21 12:34 AM, Mathieu Poirier wrote: > > Following the work done here [1], this set provides support for the > > remoteproc core to release resources associated with a remote processor

Re: [PATCH v6 16/16] remoteproc: Refactor rproc delete and cdev release path

2021-03-01 Thread Mathieu Poirier
On Fri, Feb 26, 2021 at 05:23:45PM +0100, Arnaud POULIQUEN wrote: > > > On 2/24/21 12:35 AM, Mathieu Poirier wrote: > > Refactor function rproc_del() and rproc_cdev_release() to take > > into account the current state of the remote processor when choosing > >

Re: [PATCH v6 11/16] remoteproc: Properly deal with the resource table when attached

2021-03-01 Thread Mathieu Poirier
On Fri, Feb 26, 2021 at 05:21:15PM +0100, Arnaud POULIQUEN wrote: > > > On 2/24/21 12:35 AM, Mathieu Poirier wrote: > > If it is possible to detach the remote processor, keep an untouched > > copy of the resource table. That way we can start from the same > > resou

Re: [PATCH v6 05/16] remoteproc: Add new get_loaded_rsc_table() to rproc_ops

2021-03-01 Thread Mathieu Poirier
On Fri, Feb 26, 2021 at 05:14:36PM +0100, Arnaud POULIQUEN wrote: > Hi Mathieu, > Good morning, > On 2/24/21 12:35 AM, Mathieu Poirier wrote: > > Add a new get_loaded_rsc_table() operation in order to support > > scenarios where the remoteproc core has booted a remote proce

Re: [PATCH v4 09/10] coresight: syscfg: Add initial configfs support

2021-02-28 Thread Mathieu Poirier
On Sun, Feb 28, 2021 at 05:02:28PM -0700, Mathieu Poirier wrote: > On Thu, Jan 28, 2021 at 05:09:35PM +, Mike Leach wrote: > > Adds configfs subsystem and attributes to the configuration manager > > to enable the listing of loaded configurations and features. > > >

Re: [PATCH v4 09/10] coresight: syscfg: Add initial configfs support

2021-02-28 Thread Mathieu Poirier
On Thu, Jan 28, 2021 at 05:09:35PM +, Mike Leach wrote: > Adds configfs subsystem and attributes to the configuration manager > to enable the listing of loaded configurations and features. > > The default values of feature parameters can be accessed and altered > from these attributes to affec

Re: [PATCH v4 08/10] coresight: config: Add preloaded configurations

2021-02-28 Thread Mathieu Poirier
On Thu, Jan 28, 2021 at 05:09:34PM +, Mike Leach wrote: > Preload set of configurations. > > This patch creates a small set of preloaded configurations and features > that are available immediately after coresight has been initialised. > > The current set provides a strobing feature for ETMv4

Re: [PATCH v4 07/10] coresight: etm4x: Add complex configuration handlers to etmv4

2021-02-28 Thread Mathieu Poirier
On Thu, Jan 28, 2021 at 05:09:33PM +, Mike Leach wrote: > Adds in handlers to allow the ETMv4 to use the complex configuration > support. Features and configurations can be loaded and selected in the > device. > > Signed-off-by: Mike Leach > --- > drivers/hwtracing/coresight/Makefile

Re: [PATCH v4 02/10] coresight: syscfg: Add registration and feature loading for cs devices

2021-02-27 Thread Mathieu Poirier
On Fri, Feb 26, 2021 at 07:14:32PM +, Mike Leach wrote: > Hi Mathieu, > > On Fri, 19 Feb 2021 at 18:43, Mathieu Poirier > wrote: > > > > [...] > > > > > +/** > > > + * List entry for Coresight devices that are registered as suppo

Re: [PATCH v4 06/10] coresight: etm-perf: Update to activate selected configuration

2021-02-25 Thread Mathieu Poirier
On Thu, Jan 28, 2021 at 05:09:32PM +, Mike Leach wrote: > Add calls to activate the selected configuration as perf starts > and stops the tracing session. > > Signed-off-by: Mike Leach > --- > drivers/hwtracing/coresight/coresight-etm-perf.c | 14 +- > drivers/hwtracing/coresight

Re: [PATCH v4 05/10] coresight: syscfg: Add API to activate and enable configurations

2021-02-25 Thread Mathieu Poirier
[...] > > + > > +/** > > + * Mark a config descriptor as active. > > + * This will be seen when csdev devices are activated in the system. > > + * > > + * Selection by hash value - generated from the configuration name when it > > + * was loaded and added to the cs_etm/configurations file system f

Re: [PATCH v4 05/10] coresight: syscfg: Add API to activate and enable configurations

2021-02-25 Thread Mathieu Poirier
On Thu, Jan 28, 2021 at 05:09:31PM +, Mike Leach wrote: > Configurations are first activated, then when any coresight device is > enabled, the active configurations are checked and any matching > one is enabled. > > This patch provides the activation / enable API. > > Signed-off-by: Mike Leac

<    1   2   3   4   5   6   7   8   9   10   >