[PATCH BUGFIX RFC 2/2] Revert "bfq: calculate shallow depths at init time"

This reverts commit f0635b8a416e3b99dc6fd9ac3ce534764869d0c8. --- block/bfq-iosched.c | 117 +--- 1 file changed, 57 insertions(+), 60 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 8cc3032b66de..92214d58510c 100644 --- a/block/bf

[PATCH BUGFIX RFC 1/2] Revert "bfq-iosched: remove unused variable"

This reverts commit bd7d4ef6a4c9b3611fa487a0065bf042c71ce620. --- block/bfq-iosched.c | 15 --- block/bfq-iosched.h | 6 ++ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index cd307767a134..8cc3032b66de 100644 --- a/block

Re: [RFC PATCH 0/3] cgroup: fsio throttle controller

> Il giorno 18 gen 2019, alle ore 12:10, Andrea Righi > ha scritto: > > On Fri, Jan 18, 2019 at 12:04:17PM +0100, Paolo Valente wrote: >> >> >>> Il giorno 18 gen 2019, alle ore 11:31, Andrea Righi >>> ha scritto: >>> >>>

Re: [RFC PATCH 0/3] cgroup: fsio throttle controller

> Il giorno 18 gen 2019, alle ore 11:31, Andrea Righi > ha scritto: > > This is a redesign of my old cgroup-io-throttle controller: > https://lwn.net/Articles/330531/ > > I'm resuming this old patch to point out a problem that I think is still > not solved completely. > > = Problem = > > T

Re: [PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput

> Il giorno 7 dic 2018, alle ore 15:40, Jens Axboe ha scritto: > > On 12/7/18 3:01 AM, Paolo Valente wrote: >> >> >>> Il giorno 7 dic 2018, alle ore 03:23, Jens Axboe ha >>> scritto: >>> >>> On 12/6/18 11:18 AM, Paolo Valente wrote

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

> Il giorno 2 gen 2019, alle ore 17:03, Tejun Heo ha scritto: > > Hello, Paolo. > > On Sun, Dec 30, 2018 at 11:25:25AM +0100, Paolo Valente wrote: >> What's the benefit of throwing away months of work, on which we agreed >> before starting it, and that solve

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

> Il giorno 28 dic 2018, alle ore 00:41, Tejun Heo ha scritto: > > Hello, Paolo. > > On Sun, Dec 23, 2018 at 12:00:14PM +0100, Paolo Valente wrote: >> 4.21 is coming ... and the legacy proportional share interface will >> be gone with cfq. This will

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

> Il giorno 18 dic 2018, alle ore 18:22, Paolo Valente > ha scritto: > > > >> Il giorno 18 dic 2018, alle ore 17:41, Tejun Heo ha >> scritto: >> >> Hello, Paolo. >> >> On Tue, Dec 18, 2018 at 08:48:10AM +0100, Paolo Valente wrote:

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

> Il giorno 18 dic 2018, alle ore 18:22, Paolo Valente > ha scritto: > > > >> Il giorno 18 dic 2018, alle ore 17:41, Tejun Heo ha >> scritto: >> >> Hello, Paolo. >> >> On Tue, Dec 18, 2018 at 08:48:10AM +0100, Paolo Valente wrote:

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

> Il giorno 18 dic 2018, alle ore 17:41, Tejun Heo ha scritto: > > Hello, Paolo. > > On Tue, Dec 18, 2018 at 08:48:10AM +0100, Paolo Valente wrote: >> If Tejun cannot see any solution to his concern, then can we just >> switch to this extension, considering that &g

Re: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

[RESENDING BECAUSE BOUNCED] > Il giorno 10 dic 2018, alle ore 14:45, Angelo Ruocco > ha scritto: > > 2018-11-30 19:53 GMT+01:00, Paolo Valente : >> >> >>> Il giorno 30 nov 2018, alle ore 19:42, Tejun Heo ha >>> scritto: >>> >>&g

Re: [PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput

> Il giorno 7 dic 2018, alle ore 03:23, Jens Axboe ha scritto: > > On 12/6/18 11:18 AM, Paolo Valente wrote: >> Hi Jens, >> the first patch in this series fixes an error in the decrementing of >> the counter of the number of groups with pending I/O. This wrong

[PATCH BUGFIX 2/2] block, bfq: fix comments on __bfq_deactivate_entity

updates sched_data and service trees for the entity, so as to represent entity as inactive (which is only part of the steps needed for the deactivation of the entity). 2) The function must be invoked on every entity being deactivated. Signed-off-by: Paolo Valente --- block/bfq-wf2q.c | 11

[PATCH BUGFIX 1/2] block, bfq: fix decrement of num_active_groups

rrett Tested-by: Steven Barrett Tested-by: Lucjan Lucjanov Reviewed-by: Federico Motta Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 76 + block/bfq-iosched.h | 51 +-- block/bfq-wf2q.c| 5 +++- 3 fil

[PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput

making the above bug more difficult to find. Thanks, Paolo Paolo Valente (2): block, bfq: fix decrement of num_active_groups block, bfq: fix comments on __bfq_deactivate_entity block/bfq-iosched.c | 76 + block/bfq-iosched.h | 51

[PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io

fq default cgroup: make all functions of all cftypes be invoked block, throttle: allow sharing cgroup statistic files Paolo Valente (5): cgroup: add hook seq_show_cft with also the owning cftype as parameter block, cgroup: pass cftype to functions that need to use it block, bfq: use sta

[PATCH V2 06/10] cgroup: make all functions of all cftypes be invoked

one of those operations is requested, the respective function of all the cftypes linked together. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- kernel/cgroup/cgroup.c | 181 - 1 file changed, 132 insertions(+), 49 deletions(-) diff

[PATCH V2 01/10] cgroup: add hook seq_show_cft with also the owning cftype as parameter

first one. This commit adds an additional seq_show_cft hook that has as a formal parameter also the cftype that owns the function. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- include/linux/cgroup-defs.h | 3 ++- kernel/cgroup/cgroup.c | 15 +-- 2 files changed

[PATCH V2 02/10] block, cgroup: pass cftype to functions that need to use it

Signed-off-by: Paolo Valente --- block/bfq-cgroup.c | 54 -- block/blk-cgroup.c | 22 --- block/blk-throttle.c | 8 +++ include/linux/blk-cgroup.h | 10 + 4 files changed, 52 insertions(+), 42 deletions

[PATCH V2 05/10] block, bfq: align min and default weights with the old cfq default

From: Angelo Ruocco bfq exposes a cgroup attribute, weight, with the same meaning as that exposed by cfq. This commit changes bfq default and min weights to match the ones set by cfq (before legacy blk was removed). Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- block/bfq

[PATCH V2 04/10] cgroup: add owner name to cftypes

icitly set. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- include/linux/cgroup-defs.h | 2 ++ include/linux/cgroup.h | 13 + 2 files changed, 15 insertions(+) diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h index d659763c7221..6e31f478c6e1 10

[PATCH V2 03/10] cgroup: link cftypes of the same subsystem with the same name

op" operations. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente --- include/linux/cgroup-defs.h | 9 ++ kernel/cgroup/cgroup.c | 78 +++-- 2 files changed, 85 insertions(+), 2 deletions(-) diff --git a/include/linux/cgroup-defs.h

[PATCH V2 10/10] doc, bfq-iosched: make it consistent with the new cgroup interface

BFQ now shares interface files with CFQ, for the proportional-share policy. Make documentation consistent with that. Signed-off-by: Paolo Valente --- Documentation/block/bfq-iosched.txt | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a

[PATCH V2 07/10] block, bfq: use standard file names for the proportional-share policy

same subsystem). So, for bfq, we had to add the prefix "bfq" to the names of its cgroup files. This commit renames the cgroup files of the bfq scheduler as those exposed by cfq, and makes bfq willing to share these files with any other future policy. Signed-off-by: Angelo Ruocco Signe

[PATCH V2 09/10] doc, bfq-iosched: fix a few clerical errors

This commit fixes a few clerical errors in Documentation/block/bfq-iosched.txt. Signed-off-by: Paolo Valente --- Documentation/block/bfq-iosched.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/block/bfq-iosched.txt b/Documentation/block/bfq

[PATCH V2 08/10] block, throttle: allow sharing cgroup statistic files

From: Angelo Ruocco Some of the cgroup files defined in the throttle policy have the same meaning as those defined in the proportional share policy. This commit uses the new file sharing interface in cgroup to share these files. Signed-off-by: Angelo Ruocco Signed-off-by: Paolo Valente

Re: [PATCH] block: BFQ default for single queue devices

> Il giorno 05 ott 2018, alle ore 00:42, Bart Van Assche > ha scritto: > > On Thu, 2018-10-04 at 22:39 +0200, Paolo Valente wrote: >> No, kernel build is, for evident reasons, one of the workloads I cared >> most about. Actually, I tried to focus on all my main >

Re: [PATCH BUGFIX 0/3] three fixes for the function bfq_requests_merged

> Il giorno 31 mag 2018, alle ore 16:48, Jens Axboe ha > scritto: > > On 5/31/18 7:23 AM, Paolo Valente wrote: >> Hi Jens, >> this series fixes three bugs in bfq_requests_merged. In more detail: >> >> - two linked bugs, with the first (critical: wrong

[PATCH BUGFIX/IMPROVEMENTS 3/4] block, bfq: increase weight-raising duration for interactive apps

constantly weight-raised. To address this issue, this commit conservatively sets the upper limit for weight-raising duration to 25 seconds. Signed-off-by: Davide Sapienza Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions

[PATCH BUGFIX/IMPROVEMENTS 2/4] block, bfq: remove slow-system class

just confuse the class-detection mechanism, and, as we have verified experimentally, to cause BFQ to compute non-sensical weight-raising durations. This commit addresses this issue by removing the slow class and the class-detection mechanism. Signed-off-by: Paolo Valente --- block/bfq-iosched.c

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 14 mag 2018, alle ore 19:31, Jens Axboe ha > scritto: > > On 5/14/18 11:16 AM, Paolo Valente wrote: >> >> >>> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche >>> ha scritto: >>> >>> On Fri, 2018-05-04 at 19

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 10 mag 2018, alle ore 18:14, Bart Van Assche > ha scritto: > > On Fri, 2018-05-04 at 19:17 +0200, Paolo Valente wrote: >> When invoked for an I/O request rq, [ ... ] > > Tested-by: Bart Van Assche > > > Any decision for this fix, Jens? Thanks, Paolo

Re: bug in tag handling in blk-mq?

> Il giorno 09 mag 2018, alle ore 06:11, Mike Galbraith ha > scritto: > > On Tue, 2018-05-08 at 19:09 -0600, Jens Axboe wrote: >> >> Alright, I managed to reproduce it. What I think is happening is that >> BFQ is limiting the inflight case to something less than the wake >> batch for sbitmap,

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 12:01, Mike Galbraith ha > scritto: > > On Mon, 2018-05-07 at 11:27 +0200, Paolo Valente wrote: >> >> >> Where is the bug? > > Hm, seems potent pain-killers and C don't mix all that well. > I'll try to k

Re: bug in tag handling in blk-mq?

> Il giorno 07 mag 2018, alle ore 18:39, Jens Axboe ha > scritto: > > On 5/7/18 8:03 AM, Paolo Valente wrote: >> Hi Jens, Christoph, all, >> Mike Galbraith has been experiencing hangs, on blk_mq_get_tag, only >> with bfq [1]. Symptoms seem to clearly point to a

bug in tag handling in blk-mq?

Hi Jens, Christoph, all, Mike Galbraith has been experiencing hangs, on blk_mq_get_tag, only with bfq [1]. Symptoms seem to clearly point to a problem in I/O-tag handling, triggered by bfq because it limits the number of tags for async and sync write requests (in bfq_limit_depth). Fortunately, I

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 05:23, Mike Galbraith ha > scritto: > > On Mon, 2018-05-07 at 04:43 +0200, Mike Galbraith wrote: >> On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: >>> >>> I've attached a compressed patch (to avoid poss

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 07 mag 2018, alle ore 07:56, Mike Galbraith ha > scritto: > > On Sun, 2018-05-06 at 09:42 +0200, Paolo Valente wrote: >> >> diff --git a/block/bfq-mq-iosched.c b/block/bfq-mq-iosched.c >> index 118f319af7c0..6662efe29b69 100644 >> --- a/block

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 05 mag 2018, alle ore 16:56, Mike Galbraith ha > scritto: > > On Sat, 2018-05-05 at 12:39 +0200, Paolo Valente wrote: >> >> BTW, if you didn't run out of patience with this permanent issue yet, >> I was thinking of two o three changes to retry

Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

> Il giorno 05 mag 2018, alle ore 10:19, Mike Galbraith ha > scritto: > > On Fri, 2018-05-04 at 21:46 +0200, Mike Galbraith wrote: >> Tentatively, I suspect you've just fixed the nasty stalls I reported a >> while back. > > Oh well, so much for optimism. It took a lot, but just hung. Yep, i

[PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge

or merging, no lock needs to be grabbed any longer in the prepare_request hook, while the lock already taken to perform insertion or merging is used to preparare the request as well. Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 86 +++-- 1

Re: testing io.low limit for blk-throttle

> Il giorno 26 apr 2018, alle ore 20:32, Tejun Heo ha scritto: > > Hello, > > On Tue, Apr 24, 2018 at 02:12:51PM +0200, Paolo Valente wrote: >> +Tejun (I guess he might be interested in the results below) > > Our experiments didn't work out too well either.

Re: testing io.low limit for blk-throttle

> Il giorno 27 apr 2018, alle ore 05:27, Joseph Qi ha > scritto: > > Hi Paolo, > > On 18/4/27 01:27, Paolo Valente wrote: >> >> >>> Il giorno 25 apr 2018, alle ore 14:13, Joseph Qi ha >>> scritto: >>> >>> Hi Paolo, &g

Re: testing io.low limit for blk-throttle

> Il giorno 23 apr 2018, alle ore 11:01, Joseph Qi ha > scritto: > > > > On 18/4/23 15:35, Paolo Valente wrote: >> >> >>> Il giorno 23 apr 2018, alle ore 08:05, Joseph Qi ha >>> scritto: >>> >>> Hi Paolo, >> >

Re: usercopy whitelist woe in scsi_sense_cache

> Il giorno 20 apr 2018, alle ore 22:23, Kees Cook ha > scritto: > > On Thu, Apr 19, 2018 at 2:32 AM, Paolo Valente > wrote: >> I'm missing something here. When the request gets completed in the >> first place, the hook bfq_finish_requeue_request gets call

Re: usercopy whitelist woe in scsi_sense_cache

> Il giorno 18 apr 2018, alle ore 16:30, Jens Axboe ha > scritto: > > On 4/18/18 3:08 AM, Paolo Valente wrote: >> >> >>> Il giorno 18 apr 2018, alle ore 00:57, Jens Axboe ha >>> scritto: >>> >>> On 4/17/18 3:48 PM, Jens Axboe w

Re: [PATCH] blkcg: not hold blkcg lock when deactivating policy.

latter not protected by the queue lock as cfq? > Checked the bfq code, bfq seems never used blkcg lock derectly, and > update of blkg in the common code is protected by both queue and > blkcg locks, so IMHO this patch would not introduce any new problem > with bfq, even though bfq is not pro

Re: usercopy whitelist woe in scsi_sense_cache

> Il giorno 18 apr 2018, alle ore 00:57, Jens Axboe ha > scritto: > > On 4/17/18 3:48 PM, Jens Axboe wrote: >> On 4/17/18 3:47 PM, Kees Cook wrote: >>> On Tue, Apr 17, 2018 at 2:39 PM, Jens Axboe wrote: On 4/17/18 3:25 PM, Kees Cook wrote: > On Tue, Apr 17, 2018 at 1:46 PM, Kees Cook

Re: [PATCH] blk-mq: Clear out elevator private data

> Il giorno 17 apr 2018, alle ore 23:42, Kees Cook ha > scritto: > > Some elevators may not correctly check rq->rq_flags & RQF_ELVPRIV, and > may attempt to read rq->elv fields. When requests got reused, this > caused BFQ to think it already had a bfqq (rq->elv.priv[1]) allocated. Hi Kees, wh

Re: [PATCH] blkcg: not hold blkcg lock when deactivating policy.

> Il giorno 17 apr 2018, alle ore 09:10, Jiang Biao ha > scritto: > > As described in the comment of blkcg_activate_policy(), > *Update of each blkg is protected by both queue and blkcg locks so > that holding either lock and testing blkcg_policy_enabled() is > always enough for dereferencing

Re: General protection fault with use_blk_mq=1.

> Il giorno 29 mar 2018, alle ore 05:22, Jens Axboe ha > scritto: > > On 3/28/18 9:13 PM, Zephaniah E. Loss-Cutler-Hull wrote: >> On 03/28/2018 06:02 PM, Jens Axboe wrote: >>> On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote: I am not subscribed to any of the lists on the To list h

Re: General protection fault with use_blk_mq=1.

> Il giorno 29 mar 2018, alle ore 03:02, Jens Axboe ha > scritto: > > On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote: >> I am not subscribed to any of the lists on the To list here, please CC >> me on any replies. >> >> I am encountering a fairly consistent crash anywhere from 15 min

[PATCH BUGFIX] block, bfq: lower-bound the estimated peak rate to 1

. Adding and improving comments on the range of rates representable [1] https://www.spinics.net/lists/kernel/msg2739205.html Signed-off-by: Konstantin Khlebnikov Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 25 - block/bfq-iosched.h | 2 +- 2 files changed, 25

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 26 mar 2018, alle ore 12:28, Konstantin Khlebnikov > ha scritto: > > > > On 26.03.2018 11:01, Paolo Valente wrote: >>> Il giorno 21 mar 2018, alle ore 00:49, Paolo Valente >>> ha scritto: >>> >>> >>> &g

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 21 mar 2018, alle ore 00:49, Paolo Valente > ha scritto: > > > >> Il giorno 20 mar 2018, alle ore 15:41, Konstantin Khlebnikov >> ha scritto: >> >> On 20.03.2018 06:00, Paolo Valente wrote: >>>> Il giorno 19 mar 2018, alle

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 20 mar 2018, alle ore 15:41, Konstantin Khlebnikov > ha scritto: > > On 20.03.2018 06:00, Paolo Valente wrote: >>> Il giorno 19 mar 2018, alle ore 14:28, Konstantin Khlebnikov >>> ha scritto: >>> >>> On 19.03.2018 09:03, Paolo

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 19 mar 2018, alle ore 14:28, Konstantin Khlebnikov > ha scritto: > > On 19.03.2018 09:03, Paolo Valente wrote: >>> Il giorno 05 mar 2018, alle ore 04:48, Konstantin Khlebnikov >>> ha scritto: >>> >>> Rate should never overf

Re: [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1

> Il giorno 05 mar 2018, alle ore 04:48, Konstantin Khlebnikov > ha scritto: > > Rate should never overflow or become zero because it is used as divider. > This patch accumulates it with saturation. > > Signed-off-by: Konstantin Khlebnikov > --- > block/bfq-iosched.c |8 +--- > 1 file

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 24 feb 2018, alle ore 13:05, Ming Lei ha > scritto: > > On Sat, Feb 24, 2018 at 08:54:31AM +0100, Paolo Valente wrote: >> >> >>> Il giorno 23 feb 2018, alle ore 17:17, Ming Lei ha >>> scritto: >>> >>> Hi Paolo, >

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 23 feb 2018, alle ore 17:17, Ming Lei ha > scritto: > > Hi Paolo, > > On Fri, Feb 23, 2018 at 04:41:36PM +0100, Paolo Valente wrote: >> >> >>> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei ha >>> scritto: >>> >&g

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei ha > scritto: > > Hi Paolo, > > On Wed, Feb 07, 2018 at 10:19:20PM +0100, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' mak

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 10 feb 2018, alle ore 09:29, Oleksandr Natalenko > ha scritto: > > Hi. > > On pátek 9. února 2018 18:29:39 CET Mike Galbraith wrote: >> On Fri, 2018-02-09 at 14:21 +0100, Oleksandr Natalenko wrote: >>> In addition to this I think it should be worth considering CC'ing Greg >>> to p

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe ha > scritto: > > On 2/7/18 2:19 PM, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for

[PATCH BUGFIX V3] block, bfq: add requeue-request hook

ested-by: Mike Galbraith Signed-off-by: Paolo Valente Signed-off-by: Serena Ziviani --- V2: contains fix to bug reported in [2] V3: implements the improvement suggested in [3] [2] https://lkml.org/lkml/2018/2/5/599 [3] https://lkml.org/lkml/2018/2/7/532 b

Re: [PATCH BUGFIX V2 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 19:06, Jens Axboe ha > scritto: > > On 2/7/18 11:00 AM, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests fo

[PATCH BUGFIX V2 1/1] block, bfq: add requeue-request hook

ested-by: Mike Galbraith Signed-off-by: Paolo Valente Signed-off-by: Serena Ziviani --- block/bfq-iosched.c | 109 1 file changed, 84 insertions(+), 25 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 47e6ec7427c4..2

[PATCH BUGFIX V2 0/1] block, bfq: handle requeues of I/O requests

Hi, fixed version, after bug reports and fixes in [1]. Thanks, Paolo [1] https://lkml.org/lkml/2018/2/5/599 Paolo Valente (1): block, bfq: add requeue-request hook block/bfq-iosched.c | 109 1 file changed, 84 insertions(+), 25 deletions

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 16:50, Oleksandr Natalenko > ha scritto: > > Hi. > > 07.02.2018 12:27, Paolo Valente wrote: >> Hi Oleksandr, Holger, >> before I prepare a V2 candidate patch, could you please test my >> instrumentation patch too, w

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 12:03, Mike Galbraith ha > scritto: > > On Wed, 2018-02-07 at 11:27 +0100, Paolo Valente wrote: >> >> 2. Could you please turn that BUG_ON into: >> if (!(rq->rq_flags & RQF_ELVPRIV)) >> return; >> and see

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 11:15, Mike Galbraith ha > scritto: > > On Wed, 2018-02-07 at 10:45 +0100, Paolo Valente wrote: >> >>> Il giorno 07 feb 2018, alle ore 10:23, Mike Galbraith ha >>> scritto: >>> >>> On Wed, 2018-02-

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 19:35, Oleksandr Natalenko > ha scritto: > > Hi. > > 06.02.2018 15:50, Paolo Valente wrote: >> Could you please do a >> gdb /block/bfq-iosched.o # or vmlinux.o if bfq is builtin >> list *(bfq_finish_requeue_request+0x54) &

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 14:40, Holger Hoffstätte > ha scritto: > > > The plot thickens! > Yep, the culprit seems clearer, though ... > Just as I was about to post that I didn't have any problems - because > I didn't have any - I decided to do a second test, activated bfq on my >

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 15:07, Oleksandr Natalenko > ha scritto: > > Hi. > > 06.02.2018 14:46, Mike Galbraith wrote: >>> Sorry for the noise, but just to make it clear, are we talking about >>> "deadline" or "mq-deadline" now? >> mq-deadline. > > Okay, I've spent a little bit more

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 13:26, Paolo Valente > ha scritto: > > > >> Il giorno 06 feb 2018, alle ore 12:57, Mike Galbraith ha >> scritto: >> >> On Tue, 2018-02-06 at 10:38 +0100, Paolo Valente wrote: >>> >>> Hi Mike, &

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 12:57, Mike Galbraith ha > scritto: > > On Tue, 2018-02-06 at 10:38 +0100, Paolo Valente wrote: >> >> Hi Mike, >> as you can imagine, I didn't get any failure in my pre-submission >> tests on this patch. In a

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

> Il giorno 06 feb 2018, alle ore 08:56, Mike Galbraith ha > scritto: > > On Tue, 2018-02-06 at 08:44 +0100, Oleksandr Natalenko wrote: >> Hi, Paolo. >> >> I can confirm that this patch fixes cfdisk hang for me. I've also tried >> to trigger the issue Mike has encountered, but with no luck (

Re: v4.15 and I/O hang with BFQ

> Il giorno 30 gen 2018, alle ore 16:40, Paolo Valente > ha scritto: > > > >> Il giorno 30 gen 2018, alle ore 15:40, Ming Lei ha >> scritto: >> >> On Tue, Jan 30, 2018 at 03:30:28PM +0100, Oleksandr Natalenko wrote: >>> Hi. >>>

[PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

ueue_request hook of the active elevator is invoked for these requests, if set. This commit then addresses the above issue by properly implementing the hook requeue_request in BFQ. [1] https://marc.info/?l=linux-block&m=15127608676 Reported-by: Ivan Kozik Reported-by: Alban Browaeys Sign

[PATCH BUGFIX 0/1] block, bfq: handle requeues of I/O requests

the patch. This note is just to point out this unexpected fact (for me), in case it is not intentional. Thanks, Paolo Paolo Valente (1): block, bfq: add requeue-request hook block/bfq-iosched.c | 101 +++- 1 file changed, 76 insertions(+), 25

Re: v4.15 and I/O hang with BFQ

> Il giorno 30 gen 2018, alle ore 15:40, Ming Lei ha > scritto: > > On Tue, Jan 30, 2018 at 03:30:28PM +0100, Oleksandr Natalenko wrote: >> Hi. >> > ... >> systemd-udevd-271 [000] 4.311033: bfq_insert_requests: insert >> rq->0 >> systemd-udevd-271 [000] ...1 4.311037: blk

Re: [PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches

> Il giorno 13 gen 2018, alle ore 12:05, Paolo Valente > ha scritto: > > Hi Jens, > here are again the two pending patches you asked me to resend [1]. One > of them, fixing read-starvation problems, was accompanied by a cover > letter. I'm pasting the content

[PATCH BUGFIX/IMPROVEMENT 1/2] block, bfq: limit tags for writes and async I/O

[1] https://github.com/Algodev-github/S Tested-by: Oleksandr Natalenko Tested-by: Holger Hoffstätte Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 77 + block/bfq-iosched.h | 12 + 2 files changed, 89 insertions(+) diff --git a

[PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches

it somehow to the other schedulers. Thanks, Paolo [1] https://www.spinics.net/lists/linux-block/msg21586.html Paolo Valente (2): block, bfq: limit tags for writes and async I/O block, bfq: limit sectors served with interactive weight raising block/bfq-iosch

[PATCH BUGFIX/IMPROVEMENT 2/2] block, bfq: limit sectors served with interactive weight raising

the allowed weight-raising period finishes. Thus this early ending of weight-raising reduces the amount of time during which these applications cause the problems described above. Tested-by: Oleksandr Natalenko Tested-by: Holger Hoffstätte Signed-off-by: Paolo Valente --- block/bfq-iosched.c

Re: [PATCH IMPROVEMENT] block, bfq: limit sectors served with interactive weight raising

> Il giorno 12 gen 2018, alle ore 11:15, Holger Hoffstätte > ha scritto: > > On 01/12/18 06:58, Paolo Valente wrote: >> >> >>> Il giorno 28 dic 2017, alle ore 15:00, Holger Hoffstätte >>> ha scritto: >>> >>> >>>

Re: [PATCH IMPROVEMENT] block, bfq: limit sectors served with interactive weight raising

> Il giorno 28 dic 2017, alle ore 15:00, Holger Hoffstätte > ha scritto: > > > On 12/28/17 12:19, Paolo Valente wrote: > (snip half a tech report ;) > > So either this or the previous patch ("limit tags for writes and async I/O" > can lead to a hard,

[PATCH BUGFIX 0/1] bloc, bfq: fix of a bug introduced by my last patch

way to go. Thanks, Paolo Paolo Valente (1): block, bfq: compile group put for oom queue only if BFQ_GROUP_IOSCHED is set block/bfq-iosched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.15.1

[PATCH BUGFIX 1/1] block, bfq: compile group put for oom queue only if BFQ_GROUP_IOSCHED is set

o root group on exit") Reported-by: Jan Alexander Steffens Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index c56a495af2e8..93a97a7fe519 100644 --- a/block/bfq-iosch

Re: [PATCH BUGFIX V2 1/2] block, bfq: put async queues for root bfq groups too

> Il giorno 10 gen 2018, alle ore 02:41, Guoqing Jiang ha > scritto: > > > > On 01/09/2018 05:27 PM, Paolo Valente wrote: >> For each pair [device for which bfq is selected as I/O scheduler, >> group in blkio/io], bfq maintains a corresponding bfq group. Eac

Re: unify the interface of the proportional-share policy in blkio/io

> Il giorno 09 gen 2018, alle ore 20:53, Jens Axboe ha > scritto: > > On 1/9/18 12:52 PM, Tejun Heo wrote: >> Hello, Paolo. >> >> On Thu, Jan 04, 2018 at 08:00:02PM +0100, Paolo Valente wrote: >>> The solution for the second type of parameters

[PATCH BUGFIX V2 1/2] block, bfq: put async queues for root bfq groups too

root group. This commit fixes bfq_pd_offline so that the latter executes the above missing operations for a root group too. Reported-by: Holger Hoffstätte Reported-by: Guoqing Jiang Signed-off-by: Davide Ferrari Signed-off-by: Paolo Valente --- block/bfq-cgroup.c | 7 +-- 1 file changed, 5

[PATCH BUGFIX V2 0/2] block, bfq: fix two memory leaks related to cgroups

Paolo Valente (2): block, bfq: put async queues for root bfq groups too block, bfq: release oom-queue ref to root group on exit block/bfq-cgroup.c | 7 +-- block/bfq-iosched.c | 3 +++ 2 files changed, 8 insertions(+), 2 deletions(-) -- 2.15.1

[PATCH BUGFIX V2 2/2] block, bfq: release oom-queue ref to root group on exit

Ferrari Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index ea48b5c8f088..c56a495af2e8 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -5015,6 +5015,9 @@ static void bfq_exit_queue

[PATCH BUGFIX 1/2] block, bfq: put async queues for root bfq groups too

root group. This commit fixes bfq_pd_offline so that the latter executes the above missing operations for a root group too. Reported-by: Holger Hoffstätte Reported-by: Guoqing Jiang Signed-off-by: Davide Ferrari Signed-off-by: Paolo Valente --- block/bfq-cgroup.c | 7 +-- 1 file changed, 5

[PATCH BUGFIX 2/2] bfq-sq, bfq-mq: release oom-queue ref to root group on exit

Ferrari Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index ea48b5c8f088..c56a495af2e8 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -5015,6 +5015,9 @@ static void bfq_exit_queue

[PATCH BUGFIX 0/2] block, bfq: fix two memory leaks related to cgroups

Hi Jens, these two patches fix two related memory leaks, the first reported in [1], and the second found by ourselves while fixing the first. Thanks, Paolo [1] https://www.mail-archive.com/linux-block@vger.kernel.org/msg16258.html Paolo Valente (2): block, bfq: put async queues for root bfq

unify the interface of the proportional-share policy in blkio/io

Hi Tejun, Jens, all, the shares of storage resources are controlled through weights in the proportional-share policy of the blkio/io controllers of the cgroups subsystem. But, on blk-mq, this control doesn't work for any legacy application, service or tool. In a similar vein, in most of the inter

[PATCH IMPROVEMENT] block, bfq: limit sectors served with interactive weight raising

the allowed weight-raising period finishes. Thus this early ending of weight-raising reduces the amount of time during which these applications cause the problems described above. Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 81

[PATCH IMPROVEMENT/BUGFIX 0/1] block, bfq: address starvation caused by tag consumption

ulate limits, to counter starvation also in cases not covered in kyber_limit_depth. If this solution proves to be effective, I'm willing to port it somehow to the other schedulers. Thanks, Paolo Paolo Valente (1): block, bfq: limit tags for writes and async I/O block/bfq-iosc

[PATCH IMPROVEMENT/BUGFIX 1/1] block, bfq: limit tags for writes and async I/O

[1] https://github.com/Algodev-github/S Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 77 + block/bfq-iosched.h | 12 + 2 files changed, 89 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index e33c5c4c9856..6f

<    1   2   3   4   5   6   7   >