Splits rf69_set_crc_enabled(dev, enabled) into
rf69_enable_crc(dev) and rf69_disable_crc(dev).
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 22 --
drivers/staging/pi433/rf69.c | 18 ++
drivers/staging/pi433/rf69.h | 4 ++--
3
Renames variable thresholdDecrement in struct pi433_rx_cfg to
threshold_decrement to get rid of checkpatch.pl warning
"Avoid CamelCase: ".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 2 +-
drivers/staging/pi433/pi433_if.h | 2 +-
2 files changed, 2 insert
Renames the enum optionOnOff and its values optionOn, optionOff to enum
option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings:
"Avoid CamelCase: , , ".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 34 ++---
drivers/sta
Call rf69_set_data_mode with DATAMODUL_MODE value directly.
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 2 +-
drivers/staging/pi433/rf69.c | 15 ++-
drivers/staging/pi433/rf69.h | 2 +-
drivers/staging/pi433/rf69_enum.h | 6 --
4 files
Splits rf69_set_sync_enabled(dev, enabled) into
rf69_enable_sync(dev) and rf69_disable_sync(dev).
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 21 +++--
drivers/staging/pi433/rf69.c | 18 ++
drivers/staging/pi433/rf69.h | 4
Replaces the functions rf69_set_amplifier_1, _2, _3 with two
functions: rf69_enable_amplifier(dev, amp_mask) and
rf69_disable_amplifier(dev, amp_mask).
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 6 +++---
drivers/staging/pi433/rf69.c | 46
s now only used for
ioctl.
- Fix issue where GPIOs and device not being deallocated in
pi433_probe() if SET_CHECKED fails.
- Simon
---
Simon Sandström (11):
staging: pi433: Fix indentation in rf69_enum.h
staging: pi433: Capitalize constant definitions
stagin
Fixes checkpatch.pl warnings "Avoid CamelCase ".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 32 -
drivers/staging/pi433/rf69_registers.h | 44 +-
2 files changed, 38 insertions(+), 38 deletion
On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote:
>
> Hi Simon, hi Dan,
>
> if you both are of the same opinion, for me, it's fine, if we go with two
> functions.
>
> But I don't get the advantage, if we split approx. 10 functions, to get rid
> of enum optionOnOff.
>
> Keep in mind,
On Mon, Dec 04, 2017 at 09:22:06PM +0200, Marcus Wolf wrote:
>
>
> Am 04.12.2017 um 21:15 schrieb Dan Carpenter:
> >
> > That's a bad name, because it doesn't just enable it also disables.
> > Please split them.
> >
> > regards,
> > dan carpenter
> >
> >
>
> Same applies to all other stuff,
On Sun, Dec 03, 2017 at 06:49:40PM +0200, Marcus Wolf wrote:
>
> Hi Simon,
Hi,
>
> thanks for your effort.
>
> I have two questions:
> * According to my practical experiance, enums were always written in lower
> case. Does kernel style guide ask for upper case for enums?
Yes. From Documentation
Fixes checkpatch.pl warnings "Avoid CamelCase ".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 32 -
drivers/staging/pi433/rf69_registers.h | 44 +-
2 files changed, 38 insertions(+), 38 deletion
Renames the enum optionOnOff and its values optionOn, optionOff to enum
option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings:
"Avoid CamelCase: , , ".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 34 ++---
drivers/sta
Renames variable thresholdDecrement in struct pi433_rx_cfg to
threshold_decrement to get rid of checkpatch.pl warning
"Avoid CamelCase: ".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 2 +-
drivers/staging/pi433/pi433_if.h | 2 +-
2 files changed, 2 insert
Renames enum modShaping and its values to get rid of checkpatch.pl
warnings: "Avoid CamelCase: ".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 2 +-
drivers/staging/pi433/pi433_if.h | 2 +-
drivers/staging/pi433/rf69.c | 21 +++-
Basically just 's//\t/', to fix checkpatch.pl warnings:
"please, no spaces at the start of a line".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/rf69_enum.h | 207 +++---
1 file changed, 103 insertions(+), 104 deletions(-)
Renames enum dataMode and its values packet, continuous, continuousNoSync
to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes
checkpatch.pl warnings: "Avoid CamelCase: , ".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 2 +-
drivers/staging/pi
These patches fixes a bunch of code style issues in staging/pi433. The
first patch fixes indentation in rf69_enum.h and the rest of the patches
fixes CamelCase issues in all of staging/pi433.
In total the patches get rids of around 140 warnings generated by
checkpatch.pl.
- Simon
---
Simon
Fixes checkpatch.pl warning "Blank lines aren't necessary after an open
brace". Also adds braces to balance if-else statement.
Signed-off-by: Simon Sandström
---
drivers/staging/vt6656/power.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers
files. It was easier to write commit messages
when grouped on type of warning, so that's what I did :-)
- Simon
---
Simon Sandström (4):
staging: vt6656: Add spaces between operators
staging: vt6656: Remove unnecessary blank lines
staging: vt6656: Align function parameters
st
Use sizeof(variable) instead of sizeof(type) in memory allocations to
prevent problems if the variable type changes in the future.
Signed-off-by: Simon Sandström
---
drivers/staging/vt6656/main_usb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6656
Fixes checkpatch.pl warnings "spaces preferred around that ".
Signed-off-by: Simon Sandström
---
drivers/staging/vt6656/device.h | 2 +-
drivers/staging/vt6656/firmware.c | 2 +-
drivers/staging/vt6656/rf.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git
Fixes checkpatch.pl warnings "Alignment should match open parenthesis".
Signed-off-by: Simon Sandström
---
drivers/staging/vt6656/key.h | 2 +-
drivers/staging/vt6656/rf.c | 2 +-
drivers/staging/vt6656/usbpipe.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
di
On Thu, Feb 23, 2017 at 01:17:02AM -0500, Jeff King wrote:
> On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote:
>
> >
> > I don't know what happened, I used git for this, I don't use quilt for
> > "normal" patches accepted into my trees anymore, only for stable kernel
> > work.
> >
> > So
101 - 124 of 124 matches
Mail list logo