[PATCH 0/3 v2] Find pci root bridges by comparing HID from acpi_device_info, not acpi_device.

2012-10-12 Thread Tang Chen
plug_event_root() callback for it. These patches are based on Lu Yinghai's for-pci-root-bus-hotplug branch. Tang Chen (3): Introduce a new acpi to determine HID match. Do not use acpi_device to find pci root bridge in _init code. Check exit status of acpi_install_notify_handler() in

[PATCH 3/3 v2] Check exit status of acpi_install_notify_handler() in find_root_bridges().

2012-10-12 Thread Tang Chen
acpi_install_notify_handler() could fail. So check the exit status and give a better debug info. Signed-off-by: Tang Chen --- drivers/acpi/pci_root_hp.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/pci_root_hp.c b/drivers/acpi/pci_root_hp.c

[PATCH 1/3 v2] Introduce a new acpi to determine HID match.

2012-10-12 Thread Tang Chen
This introduce a new api to determine if a HID matches a list of IDs. Different from acpi_match_device_ids(), the new api gets HID from acpi_device_info struct. Signed-off-by: Tang Chen --- drivers/acpi/scan.c | 24 include/acpi/acpi_bus.h |2 ++ 2 files

[PATCH 2/3 v2] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Tang Chen
idges(). And further more, no handle_hotplug_event_root() notifier will be installed for them. This patch introduces a new api to find all root bridges in system by getting HID directly from ACPI namespace, not depending on acpi_device struct. Signed-off-by: Tang Chen Signed-off-by: Liu Jiang --- dr

[PATCH v2] Fix a hard coding style when determining if a device is a container.

2012-10-12 Thread Tang Chen
"ACPI0004","PNP0A05" and "PNP0A06" are all defined in array container_device_ids[], so use it, but not the hard coding style. Also, introduce a new api is_container_device() to determine if a device is a container device. Signed-off-by: Tang Chen Signed-off-by: Y

Re: [PATCH] Fix a hard coding style when determining if a device is a container.

2012-10-12 Thread Tang Chen
On 10/12/2012 06:10 PM, Yasuaki Ishimatsu wrote: > Hi Tang, > > 2012/10/12 15:55, Tang Chen wrote: >> "ACPI0004","PNP0A05" and "PNP0A06" are all defined in array >> container_device_ids[], so use it, but not the hard coding style. >

Re: [PATCH 2/3] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Tang Chen
On 10/12/2012 06:54 PM, Jiang Liu wrote: I have sent a similar patch to Yinghai before. For simplicity, we could use acpi_match_object_info_ids() instead of acpi_match_device_ids() directly. Hum, I must have missed it. :) Using acpi_match_object_info_ids() directly seems good. I'm just worry ab

Re: [PATCH 2/3] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Tang Chen
On 10/12/2012 06:36 PM, Jiang Liu wrote: On 2012-10-12 18:31, Tang Chen wrote: When the kernel is being initialized, and some hardwares are not added to system, there won't be acpi_device structs for these devices. But acpi_is_root_bridge() depends on acpi_device struct. As a result, al

Re: [PATCH 22/40] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-10-12 Thread Tang Chen
Hi Yinghai, When I was reviewing this patch, I found a little problem. Please refer to email: [PATCH 0/3] Find pci root bridges by comparing HID from acpi_device_info, not acpi_device. I could be wrong. :) If I didn't consider your idea correct, or you have a better solution, please let me kn

[PATCH 1/3] Introduce a new acpi to determine HID match.

2012-10-12 Thread Tang Chen
This introduce a new api to determine if a HID matches a list of IDs. Different from acpi_match_device_ids(), the new api gets HID from acpi_device_info struct. Signed-off-by: Tang Chen --- drivers/acpi/scan.c | 24 include/acpi/acpi_bus.h |2 ++ 2 files

[PATCH 3/3] Check exit status of acpi_install_notify_handler() in find_root_bridges().

2012-10-12 Thread Tang Chen
acpi_install_notify_handler() could fail. So check the exit status and give a better debug info. Signed-off-by: Tang Chen --- drivers/acpi/pci_root_hp.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/pci_root_hp.c b/drivers/acpi/pci_root_hp.c

[PATCH 2/3] Do not use acpi_device to find pci root bridge in _init code.

2012-10-12 Thread Tang Chen
idges(). And further more, no handle_hotplug_event_root() notifier will be installed for them. This patch introduces a new api to find all root bridges in system by getting HID directly from ACPI namespace, not depending on acpi_device struct. Signed-off-by: Tang Chen --- drivers/acpi/pci_root.c |

[PATCH 0/3] Find pci root bridges by comparing HID from acpi_device_info, not acpi_device.

2012-10-12 Thread Tang Chen
and register a handle_hotplug_event_root() callback for it. These patches are based on Lu Yinghai's for-pci-root-bus-hotplug branch. Tang Chen (3): Introduce a new acpi to determine HID match. Do not use acpi_device to find pci root bridge in _init code. Check exit status of acpi_install_notify_handler() in

[PATCH] Fix a hard coding style when determining if a device is a container.

2012-10-11 Thread Tang Chen
"ACPI0004","PNP0A05" and "PNP0A06" are all defined in array container_device_ids[], so use it, but not the hard coding style. Signed-off-by: Tang Chen --- drivers/acpi/container.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --gi

Re: [PATCH] Do not use cpu_to_node() to find an offlined cpu's node.

2012-10-09 Thread Tang Chen
Hi David, Thanks for reviewing this patch. :) On 10/09/2012 04:34 PM, Wen Congyang wrote: At 10/09/2012 02:21 PM, David Rientjes Wrote: On Mon, 8 Oct 2012, Tang Chen wrote: + /* If the cpu has been offlined, its nid was set to -1. */ + if (nid != -1) { NUMA_NO_NODE. Yes

Re: [PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-10-07 Thread Tang Chen
On 09/27/2012 05:19 PM, Tang Chen wrote: 1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which means the corresponding cpu has already dead. As a result, it won't be accessed in the for_each_online_cpu loop. So, we could change the if(cpu == dying) statement into a B

[PATCH] Do not use cpu_to_node() to find an offlined cpu's node.

2012-10-07 Thread Tang Chen
. Else, a online cpu on another node will be picked. Signed-off-by: Tang Chen --- kernel/sched/core.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 66b36ab..e76dce9 100644 --- a/kernel/sched/core.c

[tip:sched/urgent] sched: Ensure 'sched_domains_numa_levels' is safe to use in other functions

2012-10-05 Thread tip-bot for Tang Chen
Commit-ID: 5f7865f3e44db4c73fdc454fb2af40806212a7ca Gitweb: http://git.kernel.org/tip/5f7865f3e44db4c73fdc454fb2af40806212a7ca Author: Tang Chen AuthorDate: Tue, 25 Sep 2012 21:12:30 +0800 Committer: Ingo Molnar CommitDate: Fri, 5 Oct 2012 13:54:46 +0200 sched: Ensure

[PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-09-27 Thread Tang Chen
orker+0x70/0x70 [ 6155.452019] [] ? gs_change+0x13/0x13 Signed-off-by: Tang Chen Signed-off-by: Miao Xie --- arch/x86/kernel/cpu/mcheck/mce_intel.c | 34 +-- 1 files changed, 19 insertions(+), 15 deletions(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce_intel.c

[PATCH v2 1/2] Ensure sched_domains_numa_levels safe in other functions.

2012-09-25 Thread Tang Chen
it to iterate array sched_domains_numa_masks[][] in other functions. This patch set sched_domains_numa_levels to 0 before initializing array sched_domains_numa_masks[][], and reset it to 'level' when sched_domains_numa_masks[][] is fully initialized. Signed-off-by: Tang Chen Signed-off-by: W

Re: [PATCH] Update sched_domains_numa_masks when new cpus are onlined.

2012-09-25 Thread Tang Chen
Hi Peter~ I will make a v2 patch-set following your comments and resent it soon. :) Thanks. :) On 09/25/2012 07:50 PM, Peter Zijlstra wrote: On Tue, 2012-09-25 at 19:45 +0800, Tang Chen wrote: Let's have an example here. sched_init_numa() { ... // A loo

Re: [PATCH] Update sched_domains_numa_masks when new cpus are onlined.

2012-09-25 Thread Tang Chen
eturns, anyone uses sched_domains_numa_levels (which is 0) won't be wrong. I'm not sure if this is the best way to settle this problem. If you have a better idea, please tell me. Thanks. :) On 09/25/2012 06:33 PM, Peter Zijlstra wrote: On Tue, 2012-09-25 at 10:39 +0800, Tang Chen wrote: @@ -67

Re: [PATCH] Update sched_domains_numa_masks when new cpus are onlined.

2012-09-24 Thread Tang Chen
On 09/24/2012 05:57 PM, Srivatsa S. Bhat wrote: On 09/24/2012 03:08 PM, Peter Zijlstra wrote: + hotcpu_notifier(sched_domains_numa_masks_update, CPU_PRI_SCHED_ACTIVE); hotcpu_notifier(cpuset_cpu_active, CPU_PRI_CPUSET_ACTIVE); hotcpu_notifier(cpuset_cpu_inactive, CPU_PRI_

Re: [PATCH] Update sched_domains_numa_masks when new cpus are onlined.

2012-09-24 Thread Tang Chen
ed problem. And I get your address from the get_maintainer.pl script. On Tue, 2012-09-18 at 18:12 +0800, Tang Chen wrote: Once array sched_domains_numa_masks is defined, it is never updated. When a new cpu on a new node is onlined, Hmm, so there's hardware where you can boot with smal

Re: [PATCH] Update sched_domains_numa_masks when new cpus are onlined.

2012-09-23 Thread Tang Chen
Hi, Would you please help to review this patch ? Thanks. :) On 09/18/2012 06:12 PM, Tang Chen wrote: Once array sched_domains_numa_masks is defined, it is never updated. When a new cpu on a new node is onlined, the coincident member in sched_domains_numa_masks is not initialized, and all the

[PATCH] Update sched_domains_numa_masks when new cpus are onlined.

2012-09-18 Thread Tang Chen
sched_domains_numa_masks every time a new cpu is onlined or offlined. Signed-off-by: Tang Chen --- kernel/sched/core.c | 62 +++ 1 files changed, 62 insertions(+), 0 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index fbf1fd0

[BUG] Failed to online cpu on a hot-added NUMA node.

2012-09-10 Thread Tang Chen
Hi, When I hot add a node, all the cpus on it are offline. When I online one of them, I got the following error message. [ 762.759364] Call Trace: [ 762.759371] [] warn_slowpath_common+0x7f/0xc0 [ 762.759374] [] warn_slowpath_null+0x1a/0x20 [ 762.759377] [] init_sched_groups_power+0xcb/0x

Re: [RFC PATCH v2 10/16] ACPIHP: system device hotplug driver skeleton

2012-08-09 Thread Tang Chen
_drv_init() ? I am not sure if it is a good idea to move acpihp_slot_class definition and all related API to acpihp_enum module. Thanks again for your comments and patient. :) -- Best Regards, Tang chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC PATCH v2 10/16] ACPIHP: system device hotplug driver skeleton

2012-08-09 Thread Tang Chen
7;ll try to find out why. Thanks for your advice. :) > Will fix this issue in next version. > Regards! > Gerry > > On 2012-8-9 15:12, Tang Chen wrote: >> Hi Liu~ >> >> I compiled this driver as a module, acpihp_drv. And when I loaded this >> mo

Re: [RFC PATCH v2 10/16] ACPIHP: system device hotplug driver skeleton

2012-08-09 Thread Tang Chen
ata == NULL || > + acpihp_slot_attach_drv_data(slot, intf, (void *)drv_data)) { > + ACPIHP_DEBUG("fails to attach driver data for %s.\n", > + slot->name); > + acpihp_drv_remove_devices(slot); > + module_put(slot->sl

Re: [RFC PATCH 1/3] ACPIHP: introduce a framework for ACPI based system device hotplug

2012-08-02 Thread Tang Chen
:) > + kfree(name); > + } > + } > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(acpihp_register_slot); -- Best Regards, Tang chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

<    6   7   8   9   10   11