Re: [PATCH v4 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

2014-08-22 Thread Andreas Werner
On Thu, Aug 21, 2014 at 11:45:01AM -0700, Guenter Roeck wrote: > On Wed, Aug 13, 2014 at 10:40:37AM +0200, Andreas Werner wrote: > > Added driver to support the 14F021P00 BMC Hardware Monitoring. > > The BMC is a Board Management Controller including monitoring of the >

Re: [PATCH v4 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

2014-08-22 Thread Andreas Werner
On Thu, Aug 21, 2014 at 11:37:52AM -0700, Guenter Roeck wrote: > On Wed, Aug 13, 2014 at 10:40:37AM +0200, Andreas Werner wrote: > > Added driver to support the 14F021P00 BMC Hardware Monitoring. > > The BMC is a Board Management Controller including monitoring of the >

Re: [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-08-21 Thread Andreas Werner
On Thu, Aug 21, 2014 at 12:30:46PM +0100, Lee Jones wrote: > On Wed, 13 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the BMC. > > The BMC is a PIC Microntrol

[PATCH v4 2/4] drivers/watchdog/menf21bmc_wdt: introduce MEN 14F021P00 BMC Watchdog driver

2014-08-13 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Watchdog. The BMC is a Board Management Controller including watchdog functionality. Signed-off-by: Andreas Werner --- drivers/watchdog/Kconfig | 7 ++ drivers/watchdog/Makefile| 1 + drivers/watchdog/menf21bmc_wdt.c | 203

[PATCH v4 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

2014-08-13 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Hardware Monitoring. The BMC is a Board Management Controller including monitoring of the board voltages. Signed-off-by: Andreas Werner --- drivers/hwmon/Kconfig | 7 ++ drivers/hwmon/Makefile | 1 + drivers/hwmon

[PATCH v4 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-13 Thread Andreas Werner
Added driver to support the 14F021P00 BMC LEDs. The BMC is a Board Management Controller including four LEDs which can be switched on and off. Signed-off-by: Andreas Werner --- drivers/leds/Kconfig | 6 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-menf21bmc.c | 131

[PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-08-13 Thread Andreas Werner
communication to the device. The MFD driver currently supports the following features: - Watchdog - LEDs - Hwmon (voltage monitoring) Signed-off-by: Andreas Werner --- drivers/mfd/Kconfig | 12 + drivers/mfd/Makefile| 1 + drivers/mfd/menf21bmc.c | 132

[PATCH v4 0/4] Introduce MEN 14F021P BMC driver series

2014-08-13 Thread Andreas Werner
2: - changed i2c_smbus_read wrapper function to return both, value and error. - moved "leave production mode" from Watchdog driver to mfd core. - fixed some return values in the watchdog driver to return the original error value instead of -EIO. And

Re: [PATCH v3 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-11 Thread Andreas Werner
On Fri, Aug 08, 2014 at 04:36:55PM +0200, Wim Van Sebroeck wrote: > > On 08/08/2014 12:49 AM, Andreas Werner wrote: > > >On Wed, Jul 30, 2014 at 06:57:46AM -0700, Guenter Roeck wrote: > > >>On 07/30/2014 01:08 AM, Andreas Werner wrote: > > >>>On Tue, Jul 2

Re: [PATCH v3 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-07 Thread Andreas Werner
On Wed, Jul 30, 2014 at 06:57:46AM -0700, Guenter Roeck wrote: > On 07/30/2014 01:08 AM, Andreas Werner wrote: > >On Tue, Jul 29, 2014 at 02:47:08PM -0700, Guenter Roeck wrote: > >>On 07/29/2014 02:12 PM, Wim Van Sebroeck wrote: > >>>Hi Andreas, > >>>

Re: [REVERT][v3.16-rc7][STABLE] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

2014-07-30 Thread Julius Werner
Hi Joseph, > Julius, I was hoping to get your feedback, since you are the patch > author. Do you think gathering any additional data will help diagnose > this issue, or would it be best to continue with this revert request? As I understand it, this crash will disappear with Mathias' new rework f

Re: [PATCH v3 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-07-30 Thread Andreas Werner
On Tue, Jul 29, 2014 at 02:47:08PM -0700, Guenter Roeck wrote: > On 07/29/2014 02:12 PM, Wim Van Sebroeck wrote: > >Hi Andreas, > > > >>aOn Thu, Jul 24, 2014 at 03:00:09PM -0700, Bryan Wu wrote: > >>>On Thu, Jul 17, 2014 at 6:18 AM, Andreas Werner > >

Re: [PATCH v3 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-07-25 Thread Andreas Werner
aOn Thu, Jul 24, 2014 at 03:00:09PM -0700, Bryan Wu wrote: > On Thu, Jul 17, 2014 at 6:18 AM, Andreas Werner wrote: > > Added driver to support the 14F021P00 BMC LEDs. > > The BMC is a Board Management Controll include four LEDs which > > can be switched on and off. > &

Re: [PATCH v2 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-07-18 Thread Andreas Werner
On Wed, Jun 25, 2014 at 04:10:55PM -0700, Bryan Wu wrote: > On Tue, May 27, 2014 at 2:08 AM, Andreas Werner wrote: > > Added driver to support the 14F021P00 BMC LEDs. > > The BMC is a Board Management Controll include four LEDs which > > can be switched on and off. > >

Re: [PATCH] usb: xhci: Fix Set TR Dequeue Pointer cycle state for quirky xHCs

2014-07-17 Thread Julius Werner
> Hmm. Wouldn't it be safer to have a quirk for this, and only enable > the workaround if the Asmedia controller is detected? This code is so > complicated that it is difficult to see whether this could have a > harmful effect on controllers without the bug. Sorry for making it complicated, but it

Re: [PATCH v3 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-07-17 Thread Andreas Werner
On Thu, Jul 17, 2014 at 01:41:56PM +0100, Lee Jones wrote: > On Thu, 17 Jul 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the BMC. > > The BMC is a PIC Microntrol

[PATCH v3 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-07-17 Thread Andreas Werner
Added driver to support the 14F021P00 BMC LEDs. The BMC is a Board Management Controll include four LEDs which can be switched on and off. This driver use the I2C interface to the BMC using the menf21bmc MFD Core driver. Signed-off-by: Andreas Werner --- drivers/leds/Kconfig | 6

[PATCH v3 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-07-17 Thread Andreas Werner
communication to the device. The MFD driver currently supports the following features: - Watchdog - LEDs Signed-off-by: Andreas Werner --- drivers/mfd/Kconfig | 12 + drivers/mfd/Makefile| 1 + drivers/mfd/menf21bmc.c | 136 3

[PATCH v3 2/3] drivers/watchdog/menf21bmc_wdt: introduce MEN 14F021P00 BMC Watchdog driver

2014-07-17 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Watchdog. The BMC is a Board Management Controller including watchdog functionality. This driver use the I2C interface to the BMC using the menf21bmc MFD Core driver. Signed-off-by: Andreas Werner --- drivers/watchdog/Kconfig | 7 ++ drivers

[PATCH v3 0/3] Introduce MEN 14F021P BMC driver series

2014-07-17 Thread Andreas Werner
mfd core. - fixed some return values in the watchdog driver to return the original error value instead of -EIO. Andreas Werner (3): drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver drivers/watchdog/menf21bmc_wdt: introduce MEN 14F021P00 BMC Watchdog driver

Re: [PATCH 4/4] xhci: Allow xHCI drivers to be built as separate modules

2014-07-14 Thread Julius Werner
> Nope - since CONFIG_USB_XHCI_MVEBU can be 'y' or 'm' we need the ifneq > here (which matches against both) to ensure xhci-mvebu.o is built is > part of xhci-plat-hcd.o. Oh... does it make sense to have it tristate at all, then? Looks like was never really buildable as an independent module (and

Re: [PATCH v3 2/4] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-07-14 Thread Julius Werner
On Mon, Jul 14, 2014 at 5:49 AM, Vivek Gautam wrote: > The host controller by itself may sometimes need to handle PHY > and/or calibrate some of the PHY settings to get full support out > of the PHY controller. The PHY core provides a calibration > funtionality now to do so. > Therefore, facilitat

Re: [PATCH 4/4] xhci: Allow xHCI drivers to be built as separate modules

2014-07-10 Thread Julius Werner
> diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile > index af89a90..bafba71 100644 > --- a/drivers/usb/host/Makefile > +++ b/drivers/usb/host/Makefile > @@ -15,19 +15,19 @@ fhci-$(CONFIG_FHCI_DEBUG) += fhci-dbg.o > xhci-hcd-y := xhci.o xhci-mem.o > xhci-hcd-y += xhci-ring.o xhci

Re: [PATCH v2 3/4] usb: host: xhci-plat: Caibrate PHY post host reset

2014-07-09 Thread Julius Werner
On Wed, Jul 9, 2014 at 3:01 AM, Vivek Gautam wrote: > Some quirky PHYs may require to be calibrated post the host > controller initialization. > The USB 3.0 DRD PHY on Exynos5420/5800 systems, coming along with > Synopsys's DWC3 controller, is one such PHY which needs to be > calibrated post xhci'

Re: [PATCH v2 2/4] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-07-09 Thread Julius Werner
On Wed, Jul 9, 2014 at 3:01 AM, Vivek Gautam wrote: > The host controller by itself may sometimes need to handle PHY > and/or calibrate some of the PHY settings to get full support out > of the PHY controller. The PHY core provides a calibration > funtionality now to do so. > Therefore, facilitate

[PATCH] usb: xhci: Fix Set TR Dequeue Pointer cycle state for quirky xHCs

2014-07-08 Thread Julius Werner
ernels as old as 2.6.31 that contain the commit ae636747146ea97efa18e04576acd3416e2514f5 "USB: xhci: URB cancellation support." Cc: sta...@vger.kernel.org Signed-off-by: Julius Werner --- drivers/usb/host/xhci-ring.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(

Re: [PATCH v1 6/9] usb: xhci: Add NVIDIA Tegra XHCI host-controller driver

2014-06-20 Thread Julius Werner
> +static const struct hc_driver tegra_xhci_hc_driver = { > + .description = "tegra-xhci-hcd", > + .product_desc = "Tegra xHCI Host Controller", > + .hcd_priv_size =sizeof(struct xhci_hcd *), > + > + /* > +* generic hardware linkage > +

[PATCH v2] firmware: Add device tree binding for coreboot

2014-06-16 Thread Julius Werner
n can be seen at http://crosreview.com/203371, which will be submitted at a later point.) Change-Id: I97609d461d306f85851e5efc26c675ca1e2d7e9d Signed-off-by: Julius Werner --- .../devicetree/bindings/firmware/coreboot.txt | 32 ++ 1 file changed, 32 insertions(+) create

Re: [PATCH] firmware: Add device tree binding for coreboot

2014-06-16 Thread Julius Werner
On Mon, Jun 16, 2014 at 6:30 AM, Rob Herring wrote: > On Fri, Jun 13, 2014 at 4:58 PM, Julius Werner wrote: >>> This is just to export a fixed log to userspace (like a DMI table) or >>> the kernel will actually use the data in some way? Based on the link, >>>

Re: [PATCH] firmware: Add device tree binding for coreboot

2014-06-13 Thread Julius Werner
> This is just to export a fixed log to userspace (like a DMI table) or > the kernel will actually use the data in some way? Based on the link, > it looks like the former to me. I could imagine both. The link is an in-kernel driver that exposes a log through a sysfs node (in a way that has already

[PATCH] firmware: Add device tree binding for coreboot

2014-06-13 Thread Julius Werner
. (An example implementation can be seen at http://crosreview.com/203371, which will be submitted at a later point.) Signed-off-by: Julius Werner --- .../devicetree/bindings/firmware/coreboot.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644 Document

So l ös en Sie Ihr akutes Fin anzpr obl em

2014-06-12 Thread Saskia Werner
Wir wünschen Ihnen einen schönen guten Tag, ich habe eine gute Nachricht für Sie. Süd-amerikanische Banken drängen ins deutsche Kreditgeschäft, bspw. mit solchen Konditionen: Weniger als 3 Prozent Zinsen für Firmen und unter 3,5 Prozent für PrivatKredite. Auch bei laufenden Verpflichtungen und

Re: [PATCH 2/4] usb: host: xhci-plat: Add support to get PHYs

2014-06-09 Thread Julius Werner
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h > index 9ffecd5..453d89e 100644 > --- a/drivers/usb/host/xhci.h > +++ b/drivers/usb/host/xhci.h > @@ -1582,6 +1582,9 @@ struct xhci_hcd { > u32 port_status_u0; > /* Compliance Mode Timer Triggered every 2

Re: [PATCH v2 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-06-04 Thread Andreas Werner
oelektronik > > and on a few Box/Display Computer. > > > > Added MFD Core driver, supporting the I2C communication to the device. > > > > The MFD driver currently supports the following features: > > - Watchdog > > - LEDs > > > > S

Re: [PATCH 1/2] ARM: dts: Enable USB 3503 hub on exynos5250-snow

2014-06-02 Thread Julius Werner
> Ok, there was already a patch posted by you for this[1], which had > quite a much discussion > on it. > Would you like to give some pointers based on that ? > One that Olof had suggested was to use gpio-reset driver which is yet > to make to mainline. > But i think with that too we need to take c

Re: [PATCH v2 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-06-02 Thread Andreas Werner
On Wed, May 28, 2014 at 06:52:56AM -0700, Guenter Roeck wrote: > On 05/28/2014 06:29 AM, Guenter Roeck wrote: > >On 05/28/2014 04:51 AM, Andreas Werner wrote: > >>aOn Wed, May 28, 2014 at 09:24:05AM +0100, Lee Jones wrote: > >>>>>>The MEN 14F021P00

Re: [PATCH 1/2] ARM: dts: Enable USB 3503 hub on exynos5250-snow

2014-05-28 Thread Julius Werner
We originally tried using this driver on ChromiumOS and never got it to work reliably. IIRC the issue was that if the hub had already been initialized by firmware, the USB stack might enumerate it before the usb3503 driver is probed and then the later reset will silently disrupt that connection. (I

Re: [PATCH v2 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-05-28 Thread Andreas Werner
following features: > > > > - Watchdog > > > > - LEDs > > > > > > > > Signed-off-by: Andreas Werner > > > > --- > > > > drivers/mfd/Kconfig | 12 +++ > > > > drivers/mfd/Makefile

[PATCH v2 2/3] drivers/watchdog/menf21bmc_wd: introduce MEN 14F021P00 BMC Watchdog driver

2014-05-27 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Watchdog. The BMC is a Board Management Controller including watchdog functionality. This driver use the I2C interface to the BMC using the menf21bmc MFD Core driver. Signed-off-by: Andreas Werner --- drivers/watchdog/Kconfig| 7 ++ drivers

[PATCH v2 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-05-27 Thread Andreas Werner
Added driver to support the 14F021P00 BMC LEDs. The BMC is a Board Management Controll include four LEDs which can be switched on and off. This driver use the I2C interface to the BMC using the menf21bmc MFD Core driver. Signed-off-by: Andreas Werner --- drivers/leds/Kconfig | 6

[PATCH v2 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-05-27 Thread Andreas Werner
communication to the device. The MFD driver currently supports the following features: - Watchdog - LEDs Signed-off-by: Andreas Werner --- drivers/mfd/Kconfig | 12 +++ drivers/mfd/Makefile | 1 + drivers/mfd/menf21bmc.c | 220

[PATCH v2 0/3] Introduce MEN 14F02100 BMC driver series

2014-05-27 Thread Andreas Werner
. - moved "leave production mode" from Watchdog driver to mfd core. - fixed some return values in the watchdog driver to return the original error value instead of -EIO. Andreas Werner (3): drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver driver

Re: [PATCH 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-05-19 Thread Andreas Werner
aOn Mon, May 19, 2014 at 06:39:53PM +0100, Lee Jones wrote: > On Mon, 19 May 2014, Guenter Roeck wrote: > > > On 05/19/2014 05:43 AM, Andreas Werner wrote: > > >aOn Sat, May 17, 2014 at 08:47:42AM -0700, Guenter Roeck wrote: > > >>On 05/16/2014 09:37 AM, And

Re: [PATCH 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-05-19 Thread Andreas Werner
aOn Sat, May 17, 2014 at 08:47:42AM -0700, Guenter Roeck wrote: > On 05/16/2014 09:37 AM, Andreas Werner wrote: > >The MEN 14F021P00 Board Management Controller provides an > >I2C interface to the host to access the feature implemented in the BMC. > >The BMC is a PIC Micro

Re: [PATCH 2/3] drivers/watchdog/menf21bmc_wd: introduce MEN 14F021P00 BMC Watchdog driver

2014-05-19 Thread Andreas Werner
aOn Sat, May 17, 2014 at 08:57:27AM -0700, Guenter Roeck wrote: > On 05/16/2014 09:37 AM, Andreas Werner wrote: > >Added driver to support the 14F021P00 BMC Watchdog. > >The BMC is a Board Management Controller including watchdog functionality. > > > >This driver use t

[PATCH 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-05-16 Thread Andreas Werner
Added driver to support the 14F021P00 BMC LEDs. The BMC is a Board Management Controll include four LEDs which can be switched on and off. This driver use the I2C interface to the BMC using the menf21bmc MFD Core driver. Signed-off-by: Andreas Werner --- drivers/leds/Kconfig | 6

[PATCH 2/3] drivers/watchdog/menf21bmc_wd: introduce MEN 14F021P00 BMC Watchdog driver

2014-05-16 Thread Andreas Werner
Added driver to support the 14F021P00 BMC Watchdog. The BMC is a Board Management Controller including watchdog functionality. This driver use the I2C interface to the BMC using the menf21bmc MFD Core driver. Signed-off-by: Andreas Werner --- drivers/watchdog/Kconfig| 7 ++ drivers

[PATCH 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver

2014-05-16 Thread Andreas Werner
communication to the device. The MFD driver currently supports the following features: - Watchdog - LEDs Signed-off-by: Andreas Werner --- drivers/mfd/Kconfig | 12 +++ drivers/mfd/Makefile | 1 + drivers/mfd/menf21bmc.c | 193

[PATCH 0/3] Introduce MEN 14F021P00 Board Management Controller driver set

2014-05-16 Thread Andreas Werner
features which can be accessed using an I2C Host interface. Features supported in this Patchset: - Watchdog - LEDs The Patchset includes a MFD Core driver, Watchdog and LEDs driver. Andreas Werner (3): drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver drivers

Re: Question: hwmon: Adding addtitional sysfs entries

2014-05-13 Thread Andreas Werner
On Sat, May 10, 2014 at 08:32:40AM -0700, Guenter Roeck wrote: > On 05/10/2014 09:02 AM, Andreas Werner wrote: > >On Sat, May 10, 2014 at 05:32:13AM -0700, Guenter Roeck wrote: > >>On 05/10/2014 06:22 AM, Andreas Werner wrote: > >>>Hi, > >>>i am current

Re: Question: hwmon: Adding addtitional sysfs entries

2014-05-10 Thread Andreas Werner
On Sat, May 10, 2014 at 05:32:13AM -0700, Guenter Roeck wrote: > On 05/10/2014 06:22 AM, Andreas Werner wrote: > >Hi, > >i am currently working on an implemenation of my Board Management Controller > >(BMC). > > > >This Controller is a MCR assembled on almost all

Question: hwmon: Adding addtitional sysfs entries

2014-05-10 Thread Andreas Werner
Hi, i am currently working on an implemenation of my Board Management Controller (BMC). This Controller is a MCR assembled on almost all of our Compact PCI or Compact PCI Serial Cards as well as on some other CPU Boards. The BMC includes LED´s, Watchdog, Voltage Monitoring and some other featur

Re: [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f

2014-05-05 Thread Julius Werner
Hmmm... very odd. I unfortunately don't have a machine that can easily do S4 at hand, but I did test this on an IVB with XHCI_RESET_ON_RESUME in S3 (essentially the same code path), and I didn't run into any problems. How exactly does your machine fail on resume? Is it a kernel crash or just a han

mcb: review mcb irq patch

2014-05-04 Thread Andreas Werner
Reviewed-by: Andreas Werner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH v2] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Julius Werner
sting endpoints into account, and to force the value to 1 (meaning only EP0 is active) if no other endpoint is found. This patch implements that as a single step in the final check_bandwidth() call and removes the intermediary calculations from add_endpoint() and drop_endpoint(). Signed-off-by: Julius W

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Julius Werner
Okay, thanks, sounds good. I personally don't care that much about the stable backport. Let me respin this with a fixed commit message and the type change Felipe suggested. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.o

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-28 Thread Julius Werner
*bump* Sarah, Mathias, can we decide how to proceed with this? I think the section Alan quoted is a pretty good argument in favor of my interpretation (although of course this would not be the first time that two sections of a spec contradict each other). But more importantly, we have a case that

Re: [PATCH 1/5] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

2014-04-24 Thread Julius Werner
> You don't actually add the stable@ tag here, why not? > > You have read Documentation/stable_kernel_rules.txt for how stable > kernel trees work, so why not add the label here? Sorry... I actually didn't know about that file, I just added the "should be backported" line because I have seen that

Re: [PATCH] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

2014-04-15 Thread Julius Werner
+hdegoede > I tried to apply this patch on top of 3.15-rc1, but it fails because of the > streams support added to xhci_find_new_dequeue_state() > > After some manual editing the interesting parts of > xhci_find_new_dequeue_state() looks like this: > > @@ -577,46 +568,57 @@ void xhci_find_new_dequ

Re: [PATCH] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

2014-04-02 Thread Julius Werner
Hi Mathias, > The patch looks fine. Mathias is taking over for xHCI driver > maintainership in 3.15. He's currently handling queuing bug fix patches > for 3.14 while I finish queueing feature patches for 3.15. Mathias, > will you test and queue this up for 3.14? Did you pick this patch up anyw

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-01 Thread Julius Werner
> http://marc.info/?l=linux-usb&m=137158978503741&w=2 > > There's an xHCI spec ambiguity: Does the last valid context entry refer > to the last valid endpoint context in the *input* device context or the > *output* device context? > > The code currently assumes it refers to the input device contex

[PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-03-25 Thread Julius Werner
ld be backported to kernels as old as 2.6.31 that contain the commit f94e0186312b0fc39f41eed4e21836ed74b7efe1 "USB: xhci: Bandwidth allocation support". Signed-off-by: Julius Werner --- drivers/usb/host/xhci.c | 51 + 1 file changed, 18 in

[PATCH v2 2/2] usb: Make DELAY_INIT quirk wait 100ms between Get Configuration requests

2014-03-04 Thread Julius Werner
blems with these webcams. Signed-off-by: Julius Werner --- drivers/usb/core/config.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c index 8d72f0c..062967c 100644 --- a/drivers/usb/core/config.c +++ b/drivers/usb/core/config.c @@ -717

Re: [PATCH 2/2] usb: Make DELAY_INIT quirk wait 100ms between Get Configuration requests

2014-03-04 Thread Julius Werner
> What am I supposed to do with this line? :) > Oh damn, sorry, forgot to take that out on the second one. We have this really annoying commit hook that adds them automatically. v2 incoming... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to m

[PATCH 1/2] usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e

2014-03-04 Thread Julius Werner
ned-off-by: Julius Werner --- drivers/usb/core/quirks.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 8f37063..739ee8e 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -47,6 +47,10 @@ static const struct usb

[PATCH 2/2] usb: Make DELAY_INIT quirk wait 100ms between Get Configuration requests

2014-03-04 Thread Julius Werner
blems with these webcams. Change-Id: Ibf738426307fe8ef362768db2decc9bc2b30a930 Signed-off-by: Julius Werner --- drivers/usb/core/config.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c index 8d72f0c..062967c 100644 --- a/driver

[PATCH] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

2014-02-20 Thread Julius Werner
tain the commit ae636747146ea97efa18e04576acd3416e2514f5 "USB: xhci: URB cancellation support." Signed-off-by: Julius Werner --- drivers/usb/host/xhci-ring.c | 66 drivers/usb/host/xhci.c | 1 - drivers/usb/host/xhci.h | 2 -- 3 files changed, 30 insertions(

[PATCH] rtc: Add SMBus-only adapters support to rtc-rx8581

2014-01-14 Thread Andreas Werner
-ds1307 does. Tested on AMD G Series Platform (i2c-piix4 adapter driver). Signed-off-by: Andreas Werner --- drivers/rtc/rtc-rx8581.c | 81 1 file changed, 68 insertions(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-11 Thread Julius Werner
>> ...although, the spec says that it does not wait for the port resets >> to complete. As far as I can see re-issuing a warm reset and waiting >> is the only way to guarantee the core times the recovery. Presumably >> the portstatus debounce in hub_activate() mitigates this, but that >> 100ms is

Re: [PATCH v2] usb: core: Make sure usb_set_configuration(-1) cannot fail

2013-12-11 Thread Julius Werner
> Sorry for not getting back to this sooner. Ironically, it looks like > this change isn't needed any more, thanks to Thomas Pugliese's patch: > > http://marc.info/?l=linux-usb&m=13866180520&w=2 Yes... thanks for pointing it out, that would make this patch obsolete. I'll wait a few da

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-11 Thread Julius Werner
> I don't know what you mean by "fails". The system goes to sleep and > then later on wakes up, doesn't it? > > Do you mean that the Jetflash device gets disconnected when the system > wakes up? That's _supposed_ to happen under those circumstances. > When hub_activate() sees HUB_RESET_RESUME, al

Re: [PATCH RFC 2/4] xhci: Add quirk for DWC3-Exynos controller

2013-12-10 Thread Julius Werner
On Tue, Dec 10, 2013 at 2:55 AM, Vivek Gautam wrote: > The DWC3-exynos eXtensible host controller on Exynos5420 SoC > is quirky in a way that the PHY needs to be tuned to get it > working at SuperSpeed. > By default this PHY works as High-speed phy and therefore > detects even Super-speed devices

[PATCH v2] usb: core: Make sure usb_set_configuration(-1) cannot fail

2013-12-05 Thread Julius Werner
B device can always be marked as unconfigured (reclaiming its bandwidth) in the kernel, regardless of communication problems. This patch changes usb_set_configuration() to ignore all failures in the case where no new configuration is being set. Signed-off-by: Julius Werner --- drivers/usb/core/m

Re: [PATCH] usb: core: Abort deauthorization if unsetting configuration fails

2013-12-04 Thread Julius Werner
> Instead, how about changing usb_set_configuration() so that it will > never fail when the new config is -1? Except perhaps for -ENODEV > errors (the device has been disconnected), which > usb_deauthorize_device() could check for. Yes, that should work as well. It's really just one autoresume an

[PATCH] usb: core: Abort deauthorization if unsetting configuration fails

2013-12-03 Thread Julius Werner
res that usb_deauthorize_device() aborts when usb_set_configuration() fails, and the underlying status code (such as ENODEV) is returned to userspace. Signed-off-by: Julius Werner --- drivers/usb/core/hub.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/core/hub.c b

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-12-02 Thread Julius Werner
*ping* Is anyone still reading this or should I resubmit? Sorry for being annoying, just please let me know if this is already considered to get picked up at the next opportunity or if you've intentionally decided against it for now. I want to make sure it didn't fall through the cracks somewhere.

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-18 Thread Julius Werner
I'm not sure if it's worth it further looking into this for the SUSPENDED state (Sarah's post sounds like that shouldn't happen)... but at any rate, that would be orthogonal to my patch, right? I'm really only interested in the NOTATTACHED case, which solves a real issue on my system. Do you still

[PATCH v3] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received

2013-11-17 Thread Andreas Werner
function and add the read to pch_i2c_wait_for_check_xfer. If no ACK is received, the Message will be printed as a dbg message. Fixed print message to be a one liner so we can grep for the error message. Tested on Intel Atom E6xx and Eg20t Chipset. Signed-off-by: Andreas Werner --- Revision 2

Re: [PATCH v2] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received

2013-11-17 Thread Andreas Werner
On Sun, Nov 17, 2013 at 06:08:38PM +0100, Wolfram Sang wrote: > On Sun, Nov 17, 2013 at 05:53:29PM +0100, Andreas Werner wrote: > > On Sun, Nov 17, 2013 at 01:18:09PM +0100, Wolfram Sang wrote: > > > > > > > Is there another reason why pch_i2c_getack returned EP

Re: [PATCH v2] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received

2013-11-17 Thread Andreas Werner
On Sun, Nov 17, 2013 at 01:18:09PM +0100, Wolfram Sang wrote: > > > Is there another reason why pch_i2c_getack returned EPROTO? > > May be ENXIO was introduced later? > > Imperfect review :) > > > I think we can just replace the -EIO with -ENXIO or do you want to pick up > > the return > > vale

Re: [PATCH v2] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received

2013-11-17 Thread Andreas Werner
On Sun, Nov 17, 2013 at 12:08:46PM +0100, Wolfram Sang wrote: > On Sun, Nov 17, 2013 at 09:58:51AM +0100, Andreas Werner wrote: > > Revision 2: > > - delete the pch_err completly instead of changing to pch_dbg > > because there is already a pch_dbg at t

Re: Black screen with GMA500 driver on Atom E680 (invalid VBT signature)

2013-11-16 Thread Andreas Werner
On Thu, Nov 14, 2013 at 08:57:58PM +, One Thousand Gnomes wrote: > > but if you checkout the PCI table in the driver, there is the device > > and vendor ID mentioned, that means for me that the driver supports > > the Graphic core in E680. > > And after loading the driver, it will parse for $VB

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-14 Thread Andreas Werner
On Thu, Nov 14, 2013 at 05:39:52AM -0800, Joe Perches wrote: > On Wed, 2013-11-13 at 20:24 +0100, Marek Vasut wrote: > > > On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: > > > > > > That is because if you look at the only caller of this function, > > > > > > which is pch_i2c_wait_for_

Re: Black screen with GMA500 driver on Atom E680 (invalid VBT signature)

2013-11-14 Thread Andreas Werner
On Thu, Nov 14, 2013 at 01:52:09PM +, One Thousand Gnomes wrote: > > My question now is, is it a bug in the driver or in the VGA Bios? > > > > I´ve checked the VGA bios and did a hex dump but there is really no "$VBT" > > string. > > On an Atom Gen1 CPU with intel GMA500 Graphic there is the

Black screen with GMA500 driver on Atom E680 (invalid VBT signature)

2013-11-13 Thread Andreas Werner
I´ve a question about the GMA 500 driver (gma500_gfx) with an Intel Atom E680. Since the gma500 driver is in the Kernel, i get a black screen after loading the driver. The last message i can see are "Invalid VBT signature". I have check the driver file "intel_bios.c" and there the driver map the

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-13 Thread Andreas Werner
On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: > Dear Andreas Werner, > > > On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: > > > Dear Andreas Werner, > > > > > > > Using the i2c-eg20t driver and call i2cdetect or probe on th

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Andreas Werner
On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: > Dear Andreas Werner, > > > Using the i2c-eg20t driver and call i2cdetect or probe on the bus, > > the driver will print a lot of error messages if there was no ACK > > received. > > > > i2cdetect

[PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Andreas Werner
-eg20t driver, the table is not visible because the error messages destroy the table. Error message: pch_i2c_getack return -71 This patch prevent the driver to print the messages to syslog if debug is not set. Tested on Intel Atom E6xx and Eg20t Chipset. Signed-off-by: Andreas Werner --- drivers

[PATCH v2] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-07 Thread Julius Werner
port broken. Signed-off-by: Julius Werner --- drivers/usb/core/hub.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index e6b682c..0188056 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -4799,8 +4799,9

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-07 Thread Julius Werner
> I don't know either. But Sarah has said that ports can spontaneously > go into Compliance Mode for no apparent reason. If that can happen, > maybe it can happen while the port is in U3 and the device is > suspended. In such cases, though, you'd need to do a reset-resume > rather than a simple

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-06 Thread Julius Werner
> Who makes those calls, drivers? Any specific ones that you know need to be fixed? Well, the one I'm worried about is the one this patch is fixing, in hub_events(). I have seen this happen when having certain USB3 devices plugged into a host controller that always looses power on suspend-to-ram

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-11-06 Thread Julius Werner
*bump* Hi Sarah, is there anything else that needs to be resolved to pick this patch up? Looks like Matthias' recent LPM fixes are all in now so there should be no way this could cause any trouble? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-06 Thread Julius Werner
port broken. Also bumped the messages about this kind of reset failure from dev_dbg() to dev_warn() to make it easier to notice, since calling that function with a NOTATTACHED device would almost always be a bug Signed-off-by: Julius Werner --- drivers/usb/core/hub.c | 9 + 1 file changed

Re: [PATCH v2] X86: MM: Add PAT Type write-through in combination with mtrr

2013-11-03 Thread Andreas Werner
On Sun, Nov 03, 2013 at 09:44:46AM -0800, H. Peter Anvin wrote: > On 11/03/2013 04:02 AM, Andreas Werner wrote: > > > > Since marking IO Memory as cachable is not valid, WT is the > > best way for caching/bursting on MMIO Devices. > > > > Uh... WT *is* cachabl

[PATCH v2] X86: MM: Add PAT Type write-through in combination with mtrr

2013-11-03 Thread Andreas Werner
following combination: PAT=Write-Back + MTRR=Write-Through. Since marking IO Memory as cachable is not valid, WT is the best way for caching/bursting on MMIO Devices. Tested on - Intel (R) Atom E680 (Tunnel Creek) - Intel (R) Core(TM)2 Duo Signed-off-by: Andreas Werner --- arch/x86/mm/

Re: [PATCH] X86: MM: Add PAT Type write-through in combination with mtrr

2013-10-28 Thread Andreas Werner
On Mon, Oct 28, 2013 at 02:58:47PM +0100, Borislav Petkov wrote: > On Mon, Oct 28, 2013 at 01:03:58PM +0100, Andreas Werner wrote: > > > That doesn't mean you can return _PAGE_CACHE_WB for MTRR_TYPE_WRTHROUGH. > > > The correct thing to do, IMHO, would be to set the PW

Re: [PATCH] X86: MM: Add PAT Type write-through in combination with mtrr

2013-10-28 Thread Andreas Werner
On Mon, Oct 28, 2013 at 12:45:41PM +0100, Borislav Petkov wrote: > Drop Dave's stale mail address. > > On Mon, Oct 28, 2013 at 12:25:05PM +0100, Andreas Werner wrote: > > > but you end up doing > > > > > > PAT=Write-Back + MTRR=Write-Through = Effect

Re: [PATCH] X86: MM: Add PAT Type write-through in combination with mtrr

2013-10-28 Thread Andreas Werner
On Mon, Oct 28, 2013 at 11:57:31AM +0100, Borislav Petkov wrote: > On Mon, Oct 28, 2013 at 11:34:28AM +0100, Andreas Werner wrote: > > Yes the reads are only for packet data, the commands or configuration > > registers are mapped non cachable. > > > > I´ve tried WB, but

Re: [PATCH] X86: MM: Add PAT Type write-through in combination with mtrr

2013-10-28 Thread Andreas Werner
On Mon, Oct 28, 2013 at 11:51:01AM +0100, Ingo Molnar wrote: > > * Andreas Werner wrote: > > > On Mon, Oct 28, 2013 at 11:31:32AM +0100, Ingo Molnar wrote: > > > > > > * Borislav Petkov wrote: > > > > > > > On Mon, Oct 28, 2013 at 11:1

Re: [PATCH] X86: MM: Add PAT Type write-through in combination with mtrr

2013-10-28 Thread Andreas Werner
On Mon, Oct 28, 2013 at 11:31:32AM +0100, Ingo Molnar wrote: > > * Borislav Petkov wrote: > > > On Mon, Oct 28, 2013 at 11:17:49AM +0100, Ingo Molnar wrote: > > > > > And regular write-back cacheable isn't sufficient because the > > > CPU could do things like prefetch your range automatically?

<    1   2   3   4   5   6   >