> On Sat, May 19, 2007 at 11:14:10AM +0800, Eugene Teo wrote:
> > John W. Linville wrote:
>
> > >> done:
> > >> LEAVE();
> > >>
> > >> - skb->protocol = __constant_htons(0x0019); /*
> > >> ETH_P_80211_RAW */
> > >> -
> > >
> > > Except for this part...is this intentional?
On Sat, May 19, 2007 at 11:14:10AM +0800, Eugene Teo wrote:
> John W. Linville wrote:
> >> done:
> >> LEAVE();
> >>
> >> - skb->protocol = __constant_htons(0x0019); /* ETH_P_80211_RAW
> >> */
> >> -
> >
> > Except for this part...is this intentional?
>
> skb could have
On Sat, May 19, 2007 at 11:14:10AM +0800, Eugene Teo wrote:
John W. Linville wrote:
done:
LEAVE();
- skb-protocol = __constant_htons(0x0019); /* ETH_P_80211_RAW
*/
-
Except for this part...is this intentional?
skb could have been freed by then. And, in
quote sender=John W. Linville
On Sat, May 19, 2007 at 11:14:10AM +0800, Eugene Teo wrote:
John W. Linville wrote:
done:
LEAVE();
- skb-protocol = __constant_htons(0x0019); /*
ETH_P_80211_RAW */
-
Except for this part...is this intentional?
John W. Linville wrote:
> First, please send all wireless patches to
> [EMAIL PROTECTED], and be sure to CC me as well...thanks!
>
> On Sat, May 19, 2007 at 12:50:31AM +0800, Eugene Teo wrote:
>> libertas_upload_rx_packet() calls netif_rx() before returning, and it always
>> return 0.
>> Also
First, please send all wireless patches to
[EMAIL PROTECTED], and be sure to CC me as well...thanks!
On Sat, May 19, 2007 at 12:50:31AM +0800, Eugene Teo wrote:
> libertas_upload_rx_packet() calls netif_rx() before returning, and it always
> return 0.
> Also within libertas_upload_rx_packet(),
libertas_upload_rx_packet() calls netif_rx() before returning, and it always
return 0.
Also within libertas_upload_rx_packet(), it will initialize skb->protocol
anyways.
Spotted by the Coverity checker.
Signed-off-by: Eugene Teo <[EMAIL PROTECTED]>
diff --git
libertas_upload_rx_packet() calls netif_rx() before returning, and it always
return 0.
Also within libertas_upload_rx_packet(), it will initialize skb-protocol
anyways.
Spotted by the Coverity checker.
Signed-off-by: Eugene Teo [EMAIL PROTECTED]
diff --git a/drivers/net/wireless/libertas/rx.c
First, please send all wireless patches to
[EMAIL PROTECTED], and be sure to CC me as well...thanks!
On Sat, May 19, 2007 at 12:50:31AM +0800, Eugene Teo wrote:
libertas_upload_rx_packet() calls netif_rx() before returning, and it always
return 0.
Also within libertas_upload_rx_packet(), it
John W. Linville wrote:
First, please send all wireless patches to
[EMAIL PROTECTED], and be sure to CC me as well...thanks!
On Sat, May 19, 2007 at 12:50:31AM +0800, Eugene Teo wrote:
libertas_upload_rx_packet() calls netif_rx() before returning, and it always
return 0.
Also within
10 matches
Mail list logo
