Re: [PATCH] ASoC: pcm512x: Add support for data formats RJ and LJ

2020-11-12 Thread Peter Ujfalusi
Hi Kirill, On 12/11/2020 9.57, Kirill Marinushkin wrote: >> The set_fmt callback is there to set the bus format, it has nothing to >> do (in most cases) with the sample format (hw_params). Bus coding, clock >> source has nothing to do with hw_params. >> >> When you bind a link you will use set_fmt

Re: [PATCH] ASoC: pcm512x: Add support for data formats RJ and LJ

2020-11-11 Thread Kirill Marinushkin
Hello Peter, On 11/12/2020 08:41 AM, Peter Ujfalusi wrote: > Hi Kirill, > > On 11/11/2020 9.54, Kirill Marinushkin wrote: >> Hello Peter, >> >> than you for your review! >> >>> The bus format and >>> switch (pcm512x->fmt & SND_SOC_DAIFMT_MASTER_MASK) { >>> case SND_SOC_DAIFMT_CBS_

Re: [PATCH] ASoC: pcm512x: Add support for data formats RJ and LJ

2020-11-11 Thread Peter Ujfalusi
Hi Kirill, On 11/11/2020 9.54, Kirill Marinushkin wrote: > Hello Peter, > > than you for your review! > >> The bus format and >> >>> switch (pcm512x->fmt & SND_SOC_DAIFMT_MASTER_MASK) { >> >>> case SND_SOC_DAIFMT_CBS_CFS: >>> ret = regmap_update_bits(pcm512x->regmap, >> >> th

Re: [PATCH] ASoC: pcm512x: Add support for data formats RJ and LJ

2020-11-10 Thread Kirill Marinushkin
Hello Peter, than you for your review! > The bus format and > >> switch (pcm512x->fmt & SND_SOC_DAIFMT_MASTER_MASK) { > >> case SND_SOC_DAIFMT_CBS_CFS: >> ret = regmap_update_bits(pcm512x->regmap, > > the clock generation role should be set in pcm512x_set_fmt(), in that > w

Re: [PATCH] ASoC: pcm512x: Add support for data formats RJ and LJ

2020-11-09 Thread Peter Ujfalusi
On 09/11/2020 23.21, Kirill Marinushkin wrote: > Currently, pcm512x driver supports only I2S data format. > This commit adds RJ and LJ as well. > > I don't expect regression WRT existing sound cards, because: > > * default value in corresponding register of pcm512x codec is 0 == I2S > * exist

[PATCH] ASoC: pcm512x: Add support for data formats RJ and LJ

2020-11-09 Thread Kirill Marinushkin
Currently, pcm512x driver supports only I2S data format. This commit adds RJ and LJ as well. I don't expect regression WRT existing sound cards, because: * default value in corresponding register of pcm512x codec is 0 == I2S * existing in-tree sound cards with pcm512x codec are configured for I2