Re: [PATCH] context_tracking: Add comments on interface and internals

2013-01-16 Thread Frederic Weisbecker
2013/1/16 Namhyung Kim : > Hi Frederic, > > On Wed, 16 Jan 2013 13:32:57 +0100, Frederic Weisbecker wrote: >> This subsystem lacks many explanations on its purpose and >> design. Add these missing comments. >> >> v3: Fix the "hook" based naming as per Ingo's suggestion > [snip] >> +/** >> + * conte

Re: [PATCH] context_tracking: Add comments on interface and internals

2013-01-16 Thread Namhyung Kim
Hi Frederic, On Wed, 16 Jan 2013 13:32:57 +0100, Frederic Weisbecker wrote: > This subsystem lacks many explanations on its purpose and > design. Add these missing comments. > > v3: Fix the "hook" based naming as per Ingo's suggestion [snip] > +/** > + * context_tracking_task_switch - context swit

[PATCH] context_tracking: Add comments on interface and internals

2013-01-16 Thread Frederic Weisbecker
This subsystem lacks many explanations on its purpose and design. Add these missing comments. v3: Fix the "hook" based naming as per Ingo's suggestion Reported-by: Andrew Morton Signed-off-by: Frederic Weisbecker Cc: Alessio Igor Bogani Cc: Andrew Morton Cc: Chris Metcalf Cc: Christoph Lamet

Re: [PATCH] context_tracking: Add comments on interface and internals

2012-12-13 Thread Frederic Weisbecker
2012/12/14 Andrew Morton : > On Thu, 13 Dec 2012 23:50:23 +0100 > Frederic Weisbecker wrote: > >> > >> >> + * This call supports re-entrancy. >> > >> > Presumably the explanation for user_exit() applies here. >> >> Not sure what you mean here. > > It's unclear what it means to say "user_enter() su

Re: [PATCH] context_tracking: Add comments on interface and internals

2012-12-13 Thread Andrew Morton
On Thu, 13 Dec 2012 23:50:23 +0100 Frederic Weisbecker wrote: > > > >> + * This call supports re-entrancy. > > > > Presumably the explanation for user_exit() applies here. > > Not sure what you mean here. It's unclear what it means to say "user_enter() supports reentrancy". I mean, zillions of

Re: [PATCH] context_tracking: Add comments on interface and internals

2012-12-13 Thread Frederic Weisbecker
2012/12/13 Andrew Morton : > On Thu, 13 Dec 2012 21:57:05 +0100 > Frederic Weisbecker wrote: > >> This subsystem lacks many explanations on its purpose and >> design. Add these missing comments. > > Thanks, it helps. > >> --- a/kernel/context_tracking.c >> +++ b/kernel/context_tracking.c >> @@ -1,

Re: [PATCH] context_tracking: Add comments on interface and internals

2012-12-13 Thread Andrew Morton
On Thu, 13 Dec 2012 21:57:05 +0100 Frederic Weisbecker wrote: > This subsystem lacks many explanations on its purpose and > design. Add these missing comments. Thanks, it helps. > --- a/kernel/context_tracking.c > +++ b/kernel/context_tracking.c > @@ -1,3 +1,19 @@ > +/* > + * Context tracking:

[PATCH] context_tracking: Add comments on interface and internals

2012-12-13 Thread Frederic Weisbecker
This subsystem lacks many explanations on its purpose and design. Add these missing comments. Reported-by: Andrew Morton Signed-off-by: Frederic Weisbecker Cc: Gilad Ben-Yossef Cc: Thomas Gleixner Cc: Andrew Morton Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Steven Rostedt Cc: Peter Zijlstra