Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-28 Thread Jean Delvare
On Sun, 27 Sep 2015 19:58:11 +0200, Denys Vlasenko wrote: > On 09/27/2015 06:10 PM, Jean Delvare wrote: > > Looks good, however I think you should #include to > > avoid build failures in the future or on certain architectures. > > already includes > on any arch. Today it does. Tomorrow, who kn

Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-27 Thread Denys Vlasenko
On 09/27/2015 06:10 PM, Jean Delvare wrote: > Looks good, however I think you should #include to > avoid build failures in the future or on certain architectures. already includes on any arch. p4-clockmod.c builds only on x86 arch, it's Pentium 4 on demand clock modulation/speed scaling module

Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-27 Thread Jean Delvare
Hi Denys, On Sat, 26 Sep 2015 14:47:18 +0200, Denys Vlasenko wrote: > Straigntforward conversion from > int has_N44_O17_errata[NR_CPUS] > to > DECLARE_BITMAP(has_N44_O17_errata, NR_CPUS) > > Saves about 2 kbytes in bss for NR_CPUS=512. > > Signed-off-by: Denys Vlasenko > CC: Viresh Kuma

Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-26 Thread Viresh Kumar
On 26-09-15, 14:47, Denys Vlasenko wrote: > Straigntforward conversion from > int has_N44_O17_errata[NR_CPUS] > to > DECLARE_BITMAP(has_N44_O17_errata, NR_CPUS) > > Saves about 2 kbytes in bss for NR_CPUS=512. > > Signed-off-by: Denys Vlasenko > CC: Viresh Kumar > CC: Rafael J. Wysocki

[PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-26 Thread Denys Vlasenko
Straigntforward conversion from int has_N44_O17_errata[NR_CPUS] to DECLARE_BITMAP(has_N44_O17_errata, NR_CPUS) Saves about 2 kbytes in bss for NR_CPUS=512. Signed-off-by: Denys Vlasenko CC: Viresh Kumar CC: Rafael J. Wysocki CC: Ingo Molnar CC: Bartosz Golaszewski CC: H. Peter Anvin