Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-05-24 Thread Marek Vasut
On Thursday, May 08, 2014 at 03:30:25 PM, Herbert Xu wrote: > On Wed, Apr 30, 2014 at 03:17:54PM -0400, Milos Vyletel wrote: > > Coverity detected possible use of uninitialized pointer when printing > > info message during module load. While this is higly unlikely to cause > > any troubles simple c

Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-05-08 Thread Herbert Xu
On Wed, Apr 30, 2014 at 03:17:54PM -0400, Milos Vyletel wrote: > Coverity detected possible use of uninitialized pointer when printing info > message during module load. While this is higly unlikely to cause any troubles > simple change in sha1_ssse3_mod_init to make it look like sha256/512 init >

Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-05-06 Thread Pavel Machek
Hi! > Most likely yes but I wanted to keep sha1_ssse3_mod_init consistent > with sha256_ssse3_mod_init/sha512_ssse3_mod_init functions. > > > Reported-by: > > > Signed-off-by: Milos Vyletel > > > --- > > > arch/x86/crypto/sha1_ssse3_glue.c | 22 -- > > > 1 file changed, 12

Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-05-06 Thread Milos Vyletel
And this time in plain text... Most likely yes but I wanted to keep sha1_ssse3_mod_init consistent with sha256_ssse3_mod_init/sha512_ssse3_mod_init functions. Milos On Tue, May 6, 2014 at 4:28 AM, Pavel Machek wrote: > On Wed 2014-04-30 15:17:54, Milos Vyletel wrote: >> Coverity detected possib

Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-05-06 Thread Pavel Machek
On Wed 2014-04-30 15:17:54, Milos Vyletel wrote: > Coverity detected possible use of uninitialized pointer when printing info > message during module load. While this is higly unlikely to cause any troubles > simple change in sha1_ssse3_mod_init to make it look like sha256/512 init > function will

[PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-04-30 Thread Milos Vyletel
Coverity detected possible use of uninitialized pointer when printing info message during module load. While this is higly unlikely to cause any troubles simple change in sha1_ssse3_mod_init to make it look like sha256/512 init function will fix this. 260 6. Condition sha1_transform_asm, t