Re: [PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Mark yao
On 2015年05月08日 16:49, Tomasz Figa wrote: Hi Mark, Thanks for review. On Fri, May 8, 2015 at 5:40 PM, Mark yao wrote: @@ -233,6 +243,7 @@ static const struct vop_win_phy win23_data = { .nformats = ARRAY_SIZE(formats_234), .enable = VOP_REG(WIN2_CTRL0, 0x1, 0),

Re: [PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Tomasz Figa
Hi Mark, Thanks for review. On Fri, May 8, 2015 at 5:40 PM, Mark yao wrote: >> @@ -233,6 +243,7 @@ static const struct vop_win_phy win23_data = { >> .nformats = ARRAY_SIZE(formats_234), >> .enable = VOP_REG(WIN2_CTRL0, 0x1, 0), >> .format = VOP_REG(WIN2_CTRL0, 0x7, 1),

Re: [PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Mark yao
Hi Tomasz Thanks for the fix, but some register is wrong. On 2015年05月08日 16:16, Tomasz Figa wrote: VOP can support BGR formats in all windows thanks to red/blue swap option provided in WINx_CTRL0 registers. This patch enables support for ABGR, XBGR, BGR888 and BGR565 formats by

[PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Tomasz Figa
VOP can support BGR formats in all windows thanks to red/blue swap option provided in WINx_CTRL0 registers. This patch enables support for ABGR, XBGR, BGR888 and BGR565 formats by using this feature. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 33

[PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Tomasz Figa
VOP can support BGR formats in all windows thanks to red/blue swap option provided in WINx_CTRL0 registers. This patch enables support for ABGR, XBGR, BGR888 and BGR565 formats by using this feature. Signed-off-by: Tomasz Figa tf...@chromium.org ---

Re: [PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Mark yao
Hi Tomasz Thanks for the fix, but some register is wrong. On 2015年05月08日 16:16, Tomasz Figa wrote: VOP can support BGR formats in all windows thanks to red/blue swap option provided in WINx_CTRL0 registers. This patch enables support for ABGR, XBGR, BGR888 and BGR565 formats by

Re: [PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Tomasz Figa
Hi Mark, Thanks for review. On Fri, May 8, 2015 at 5:40 PM, Mark yao mark@rock-chips.com wrote: @@ -233,6 +243,7 @@ static const struct vop_win_phy win23_data = { .nformats = ARRAY_SIZE(formats_234), .enable = VOP_REG(WIN2_CTRL0, 0x1, 0), .format =

Re: [PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Mark yao
On 2015年05月08日 16:49, Tomasz Figa wrote: Hi Mark, Thanks for review. On Fri, May 8, 2015 at 5:40 PM, Mark yao mark@rock-chips.com wrote: @@ -233,6 +243,7 @@ static const struct vop_win_phy win23_data = { .nformats = ARRAY_SIZE(formats_234), .enable = VOP_REG(WIN2_CTRL0,