Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-04-23 Thread Stephen Boyd
Quoting Michael Turquette (2019-04-23 10:34:13) > On Mon, Apr 8, 2019 at 9:38 AM Jerome Brunet wrote: > > > > If removing .init() is important for you, I would prefer to help guys. That > > being said, we need a decent solution to some use case if this is going to > > work. > > > > I'll illustrate

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-04-23 Thread Michael Turquette
Hi Jerome, On Mon, Apr 8, 2019 at 9:38 AM Jerome Brunet wrote: > > On Fri, 2019-04-05 at 13:43 -0700, Stephen Boyd wrote: > > Quoting Michael Turquette (2019-04-05 08:43:40) > > > Hi Jerome, > > > > > > On Fri, Mar 29, 2019 at 3:58 PM Jerome Brunet > > > wrote: > > > > On Fri, 2019-03-29 at 15:

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-04-08 Thread Jerome Brunet
On Fri, 2019-04-05 at 13:43 -0700, Stephen Boyd wrote: > Quoting Michael Turquette (2019-04-05 08:43:40) > > Hi Jerome, > > > > On Fri, Mar 29, 2019 at 3:58 PM Jerome Brunet wrote: > > > On Fri, 2019-03-29 at 15:14 -0700, Stephen Boyd wrote: > > > > > > We actively discourage using init callbacks

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-04-05 Thread Stephen Boyd
Quoting Michael Turquette (2019-04-05 08:43:40) > Hi Jerome, > > On Fri, Mar 29, 2019 at 3:58 PM Jerome Brunet wrote: > > > > On Fri, 2019-03-29 at 15:14 -0700, Stephen Boyd wrote: > > > > > We actively discourage using init callbacks. Can you do this some > > > > > other > > > > > way? > > > >

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-04-05 Thread Michael Turquette
Hi Jerome, On Fri, Mar 29, 2019 at 3:58 PM Jerome Brunet wrote: > > On Fri, 2019-03-29 at 15:14 -0700, Stephen Boyd wrote: > > > > We actively discourage using init callbacks. Can you do this some other > > > > way? > > > > > > Yes I'm aware of that but init it the right place to do this. > > > T

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-04-05 Thread Jerome Brunet
On Fri, 2019-03-29 at 23:58 +0100, Jerome Brunet wrote: > On Fri, 2019-03-29 at 15:14 -0700, Stephen Boyd wrote: > > > > We actively discourage using init callbacks. Can you do this some other > > > > way? > > > > > > Yes I'm aware of that but init it the right place to do this. > > > To be clear,

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-03-29 Thread Jerome Brunet
On Fri, 2019-03-29 at 15:14 -0700, Stephen Boyd wrote: > > > We actively discourage using init callbacks. Can you do this some other > > > way? > > > > Yes I'm aware of that but init it the right place to do this. > > To be clear, this is not initializing the clock to some particular rate, the > >

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-03-29 Thread Stephen Boyd
Quoting Jerome Brunet (2019-03-26 00:53:15) > On Mon, 2019-03-25 at 10:10 -0700, Stephen Boyd wrote: > > Quoting Jerome Brunet (2019-03-25 04:11:57) > > > @@ -138,6 +129,27 @@ static int mpll_set_rate(struct clk_hw *hw, > > > return 0; > > > } > > > > > > +static void mpll_init(struct cl

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-03-26 Thread Jerome Brunet
On Mon, 2019-03-25 at 10:10 -0700, Stephen Boyd wrote: > Quoting Jerome Brunet (2019-03-25 04:11:57) > > @@ -138,6 +129,27 @@ static int mpll_set_rate(struct clk_hw *hw, > > return 0; > > } > > > > +static void mpll_init(struct clk_hw *hw) > > +{ > > + struct clk_regmap *clk = to_c

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-03-25 Thread Stephen Boyd
Quoting Jerome Brunet (2019-03-25 04:11:57) > @@ -138,6 +129,27 @@ static int mpll_set_rate(struct clk_hw *hw, > return 0; > } > > +static void mpll_init(struct clk_hw *hw) > +{ > + struct clk_regmap *clk = to_clk_regmap(hw); > + struct meson_clk_mpll_data *mpll = meson_clk_m

[PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-03-25 Thread Jerome Brunet
Until now (gx and axg), the mpll setting on boot (whatever the bootloader) was good enough generate a clean fractional division. It is not the case on the g12a. While moving away from the vendor u-boot, it was noticed the fractional part of the divider was no longer applied. Like on the pll, some