Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

2016-04-19 Thread Alexandre Courbot
On Mon, Apr 18, 2016 at 5:46 PM, Laxman Dewangan wrote: > Remove the file static device handle variable as this is just > required for prints. The required handle can be stored in > tegra_gpio_chip and hence it become redundancy. Small but still worthy change. "dev" in the file's global namespace

Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

2016-04-19 Thread Stephen Warren
On 04/18/2016 11:00 AM, Laxman Dewangan wrote: On Monday 18 April 2016 09:59 PM, Stephen Warren wrote: On 04/18/2016 02:46 AM, Laxman Dewangan wrote: Remove the file static device handle variable as this is just required for prints. The required handle can be stored in tegra_gpio_chip and henc

Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

2016-04-18 Thread Laxman Dewangan
On Monday 18 April 2016 09:59 PM, Stephen Warren wrote: On 04/18/2016 02:46 AM, Laxman Dewangan wrote: Remove the file static device handle variable as this is just required for prints. The required handle can be stored in tegra_gpio_chip and hence it become redundancy. This seems fine as far

Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

2016-04-18 Thread Stephen Warren
On 04/18/2016 02:46 AM, Laxman Dewangan wrote: Remove the file static device handle variable as this is just required for prints. The required handle can be stored in tegra_gpio_chip and hence it become redundancy. This seems fine as far as it goes, but if it's worth doing this, please move al

[PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

2016-04-18 Thread Laxman Dewangan
Remove the file static device handle variable as this is just required for prints. The required handle can be stored in tegra_gpio_chip and hence it become redundancy. Signed-off-by: Laxman Dewangan --- drivers/gpio/gpio-tegra.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff