On Wed, Jul 23, 2014 at 09:38:35PM +0200, Marek Vasut wrote:
> On Wednesday, July 23, 2014 at 08:52:12 PM, Corentin LABBE wrote:
> > Le 23/07/2014 17:51, Marek Vasut a écrit :
> > > On Wednesday, July 23, 2014 at 04:13:09 PM, Herbert Xu wrote:
> > >> On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek
On Wednesday, July 23, 2014 at 08:52:12 PM, Corentin LABBE wrote:
> Le 23/07/2014 17:51, Marek Vasut a écrit :
> > On Wednesday, July 23, 2014 at 04:13:09 PM, Herbert Xu wrote:
> >> On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek Vasut wrote:
> >>> On Wednesday, July 23, 2014 at 03:57:35 PM,
Le 23/07/2014 17:51, Marek Vasut a écrit :
> On Wednesday, July 23, 2014 at 04:13:09 PM, Herbert Xu wrote:
>> On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek Vasut wrote:
>>> On Wednesday, July 23, 2014 at 03:57:35 PM, Herbert Xu wrote:
On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut
On Wednesday, July 23, 2014 at 04:13:09 PM, Herbert Xu wrote:
> On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek Vasut wrote:
> > On Wednesday, July 23, 2014 at 03:57:35 PM, Herbert Xu wrote:
> > > On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut wrote:
> > > > > + }
> > > > > +#endif
> >
On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek Vasut wrote:
> On Wednesday, July 23, 2014 at 03:57:35 PM, Herbert Xu wrote:
> > On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut wrote:
> > > > + }
> > > > +#endif
> > > > +
> > > > +#ifdef CONFIG_CRYPTO_DEV_SUNXI_SS_MD5
> > > > +
On Wednesday, July 23, 2014 at 03:57:35 PM, Herbert Xu wrote:
> On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut wrote:
> > > + }
> > > +#endif
> > > +
> > > +#ifdef CONFIG_CRYPTO_DEV_SUNXI_SS_MD5
> > > + err = crypto_register_shash(_md5_alg);
> >
> > Do not use shash for such device. This
On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut wrote:
>
> > + }
> > +#endif
> > +
> > +#ifdef CONFIG_CRYPTO_DEV_SUNXI_SS_MD5
> > + err = crypto_register_shash(_md5_alg);
>
> Do not use shash for such device. This is clearly and ahash (and async in
> general) device. The rule of a
On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut wrote:
+ }
+#endif
+
+#ifdef CONFIG_CRYPTO_DEV_SUNXI_SS_MD5
+ err = crypto_register_shash(sunxi_md5_alg);
Do not use shash for such device. This is clearly and ahash (and async in
general) device. The rule of a thumb here is
On Wednesday, July 23, 2014 at 03:57:35 PM, Herbert Xu wrote:
On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut wrote:
+ }
+#endif
+
+#ifdef CONFIG_CRYPTO_DEV_SUNXI_SS_MD5
+ err = crypto_register_shash(sunxi_md5_alg);
Do not use shash for such device. This is clearly and
On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek Vasut wrote:
On Wednesday, July 23, 2014 at 03:57:35 PM, Herbert Xu wrote:
On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut wrote:
+ }
+#endif
+
+#ifdef CONFIG_CRYPTO_DEV_SUNXI_SS_MD5
+ err =
On Wednesday, July 23, 2014 at 04:13:09 PM, Herbert Xu wrote:
On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek Vasut wrote:
On Wednesday, July 23, 2014 at 03:57:35 PM, Herbert Xu wrote:
On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut wrote:
+ }
+#endif
+
+#ifdef
Le 23/07/2014 17:51, Marek Vasut a écrit :
On Wednesday, July 23, 2014 at 04:13:09 PM, Herbert Xu wrote:
On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek Vasut wrote:
On Wednesday, July 23, 2014 at 03:57:35 PM, Herbert Xu wrote:
On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut wrote:
+
On Wednesday, July 23, 2014 at 08:52:12 PM, Corentin LABBE wrote:
Le 23/07/2014 17:51, Marek Vasut a écrit :
On Wednesday, July 23, 2014 at 04:13:09 PM, Herbert Xu wrote:
On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek Vasut wrote:
On Wednesday, July 23, 2014 at 03:57:35 PM, Herbert Xu
On Wed, Jul 23, 2014 at 09:38:35PM +0200, Marek Vasut wrote:
On Wednesday, July 23, 2014 at 08:52:12 PM, Corentin LABBE wrote:
Le 23/07/2014 17:51, Marek Vasut a écrit :
On Wednesday, July 23, 2014 at 04:13:09 PM, Herbert Xu wrote:
On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek Vasut
On Sunday, May 25, 2014 at 01:58:39 PM, Corentin LABBE wrote:
[...]
> > This is one IP block and it provides 5 algorithms. Put it under one
> > config option please.
>
> I want to let the user choose what it want to be used. Someone could want
> only to accelerate md5 and to not use the PRNG.
Le 24/05/2014 14:00, Marek Vasut a écrit :
> On Thursday, May 22, 2014 at 05:09:56 PM, LABBE Corentin wrote:
>
> Do I have to repeat myself ? :)
No, sorry for the commit message, I begin to use git
Generally I agree all your remarks with some comments below.
>
>> Signed-off-by: LABBE Corentin
Le 24/05/2014 14:00, Marek Vasut a écrit :
On Thursday, May 22, 2014 at 05:09:56 PM, LABBE Corentin wrote:
Do I have to repeat myself ? :)
No, sorry for the commit message, I begin to use git
Generally I agree all your remarks with some comments below.
Signed-off-by: LABBE Corentin
On Sunday, May 25, 2014 at 01:58:39 PM, Corentin LABBE wrote:
[...]
This is one IP block and it provides 5 algorithms. Put it under one
config option please.
I want to let the user choose what it want to be used. Someone could want
only to accelerate md5 and to not use the PRNG. Lots of
On Friday, May 23, 2014 at 12:46:10 PM, Arnd Bergmann wrote:
> On Thursday 22 May 2014, Corentin LABBE wrote:
> > Le 22/05/2014 17:28, Arnd Bergmann a écrit :
> > > On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
> > >> Signed-off-by: LABBE Corentin
> > >
> > > My feeling is that this
On Thursday, May 22, 2014 at 05:09:56 PM, LABBE Corentin wrote:
Do I have to repeat myself ? :)
> Signed-off-by: LABBE Corentin
> ---
> drivers/crypto/Kconfig| 49 ++
> drivers/crypto/Makefile |1 +
> drivers/crypto/sunxi-ss.c | 1476
> +
On Thursday, May 22, 2014 at 05:09:56 PM, LABBE Corentin wrote:
Do I have to repeat myself ? :)
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com
---
drivers/crypto/Kconfig| 49 ++
drivers/crypto/Makefile |1 +
drivers/crypto/sunxi-ss.c | 1476
On Friday, May 23, 2014 at 12:46:10 PM, Arnd Bergmann wrote:
On Thursday 22 May 2014, Corentin LABBE wrote:
Le 22/05/2014 17:28, Arnd Bergmann a écrit :
On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com
My feeling is that
On Thursday 22 May 2014, Corentin LABBE wrote:
> Le 22/05/2014 17:28, Arnd Bergmann a écrit :
> > On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
> >> Signed-off-by: LABBE Corentin
> >
> > My feeling is that this should either be one driver that provides
> > all five algorithms
On Thursday 22 May 2014, Corentin LABBE wrote:
Le 22/05/2014 17:28, Arnd Bergmann a écrit :
On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com
My feeling is that this should either be one driver that provides
all five
Le 22/05/2014 17:28, Arnd Bergmann a écrit :
> On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
>> Signed-off-by: LABBE Corentin
>> ---
>> drivers/crypto/Kconfig| 49 ++
>> drivers/crypto/Makefile |1 +
>> drivers/crypto/sunxi-ss.c | 1476
>>
On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
> Signed-off-by: LABBE Corentin
> ---
> drivers/crypto/Kconfig| 49 ++
> drivers/crypto/Makefile |1 +
> drivers/crypto/sunxi-ss.c | 1476
> +
> 3 files changed, 1526 insertions(+)
>
Signed-off-by: LABBE Corentin
---
drivers/crypto/Kconfig| 49 ++
drivers/crypto/Makefile |1 +
drivers/crypto/sunxi-ss.c | 1476 +
3 files changed, 1526 insertions(+)
create mode 100644 drivers/crypto/sunxi-ss.c
diff --git
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com
---
drivers/crypto/Kconfig| 49 ++
drivers/crypto/Makefile |1 +
drivers/crypto/sunxi-ss.c | 1476 +
3 files changed, 1526 insertions(+)
create mode 100644 drivers/crypto/sunxi-ss.c
On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com
---
drivers/crypto/Kconfig| 49 ++
drivers/crypto/Makefile |1 +
drivers/crypto/sunxi-ss.c | 1476
+
3 files changed, 1526
Le 22/05/2014 17:28, Arnd Bergmann a écrit :
On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com
---
drivers/crypto/Kconfig| 49 ++
drivers/crypto/Makefile |1 +
drivers/crypto/sunxi-ss.c | 1476
30 matches
Mail list logo