Re: [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock

2020-05-28 Thread Chao Yu
On 2020/5/29 3:00, Jaegeuk Kim wrote: > On 05/28, Chao Yu wrote: >> On 2020/5/28 9:26, Jaegeuk Kim wrote: >>> On 05/28, Chao Yu wrote: On 2020/5/28 5:02, Jaegeuk Kim wrote: > On 05/27, Chao Yu wrote: >> meta inode page should be flushed under cp_lock, fix it. > > It doesn't mat

Re: [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock

2020-05-28 Thread Jaegeuk Kim
On 05/28, Chao Yu wrote: > On 2020/5/28 9:26, Jaegeuk Kim wrote: > > On 05/28, Chao Yu wrote: > >> On 2020/5/28 5:02, Jaegeuk Kim wrote: > >>> On 05/27, Chao Yu wrote: > meta inode page should be flushed under cp_lock, fix it. > >>> > >>> It doesn't matter for this case, yes? > >> > >> It's no

Re: [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock

2020-05-27 Thread Chao Yu
On 2020/5/28 9:26, Jaegeuk Kim wrote: > On 05/28, Chao Yu wrote: >> On 2020/5/28 5:02, Jaegeuk Kim wrote: >>> On 05/27, Chao Yu wrote: meta inode page should be flushed under cp_lock, fix it. >>> >>> It doesn't matter for this case, yes? >> >> It's not related to discard issue. > > I meant we

Re: [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock

2020-05-27 Thread Jaegeuk Kim
On 05/28, Chao Yu wrote: > On 2020/5/28 5:02, Jaegeuk Kim wrote: > > On 05/27, Chao Yu wrote: > >> meta inode page should be flushed under cp_lock, fix it. > > > > It doesn't matter for this case, yes? > > It's not related to discard issue. I meant we really need this or not. :P > > Now, I got

Re: [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock

2020-05-27 Thread Chao Yu
On 2020/5/28 5:02, Jaegeuk Kim wrote: > On 05/27, Chao Yu wrote: >> meta inode page should be flushed under cp_lock, fix it. > > It doesn't matter for this case, yes? It's not related to discard issue. Now, I got some progress, I can reproduce that bug occasionally. Thanks, > >> >> Signed-off

Re: [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock

2020-05-27 Thread Jaegeuk Kim
On 05/27, Chao Yu wrote: > meta inode page should be flushed under cp_lock, fix it. It doesn't matter for this case, yes? > > Signed-off-by: Chao Yu > --- > fs/f2fs/file.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index f7de2a1da528..0fcae4d9

[PATCH 3/3] f2fs: fix to cover meta flush with cp_lock

2020-05-27 Thread Chao Yu
meta inode page should be flushed under cp_lock, fix it. Signed-off-by: Chao Yu --- fs/f2fs/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index f7de2a1da528..0fcae4d90074 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -2260,7 +2260,9 @@ static