Re: [PATCH 3/5] virtio: Don't expose legacy net features when VIRTIO_NET_NO_LEGACY defined.

2015-02-15 Thread Rusty Russell
"Michael S. Tsirkin" writes: >> struct virtio_net_hdr hdr; >> __virtio16 num_buffers; /* Number of merged rx buffers */ >> }; >> +#else /* ... VIRTIO_NET_NO_LEGACY */ >> +/* >> + * This header comes first in the scatter-gather list. If you don't >> + * specify GSO or CSUM features, you

Re: [PATCH 3/5] virtio: Don't expose legacy net features when VIRTIO_NET_NO_LEGACY defined.

2015-02-15 Thread Michael S. Tsirkin
> struct virtio_net_hdr hdr; > __virtio16 num_buffers; /* Number of merged rx buffers */ > }; > +#else /* ... VIRTIO_NET_NO_LEGACY */ > +/* > + * This header comes first in the scatter-gather list. If you don't > + * specify GSO or CSUM features, you can simply ignore the header. > +

Re: [PATCH 3/5] virtio: Don't expose legacy net features when VIRTIO_NET_NO_LEGACY defined.

2015-02-15 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Sun, Feb 08, 2015 at 11:59:08AM +0100, Michael S. Tsirkin wrote: >> On Fri, Feb 06, 2015 at 03:36:54PM +1030, Rusty Russell wrote: >> > In particular, the virtio header always has the u16 num_buffers field. >> > We define a new 'struct virtio_net_modern_hdr' for t

Re: [PATCH 3/5] virtio: Don't expose legacy net features when VIRTIO_NET_NO_LEGACY defined.

2015-02-14 Thread Michael S. Tsirkin
On Sun, Feb 08, 2015 at 11:59:08AM +0100, Michael S. Tsirkin wrote: > On Fri, Feb 06, 2015 at 03:36:54PM +1030, Rusty Russell wrote: > > In particular, the virtio header always has the u16 num_buffers field. > > We define a new 'struct virtio_net_modern_hdr' for this (rather than > > simply calling

Re: [PATCH 3/5] virtio: Don't expose legacy net features when VIRTIO_NET_NO_LEGACY defined.

2015-02-10 Thread Rusty Russell
Rusty Russell writes: > "Michael S. Tsirkin" writes: >> On Fri, Feb 06, 2015 at 03:36:54PM +1030, Rusty Russell wrote: >>> In particular, the virtio header always has the u16 num_buffers field. >>> We define a new 'struct virtio_net_modern_hdr' for this (rather than >>> simply calling it 'struct

Re: [PATCH 3/5] virtio: Don't expose legacy net features when VIRTIO_NET_NO_LEGACY defined.

2015-02-08 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Fri, Feb 06, 2015 at 03:36:54PM +1030, Rusty Russell wrote: >> In particular, the virtio header always has the u16 num_buffers field. >> We define a new 'struct virtio_net_modern_hdr' for this (rather than >> simply calling it 'struct virtio_net_hdr', to avoid nas

Re: [PATCH 3/5] virtio: Don't expose legacy net features when VIRTIO_NET_NO_LEGACY defined.

2015-02-08 Thread Michael S. Tsirkin
On Fri, Feb 06, 2015 at 03:36:54PM +1030, Rusty Russell wrote: > In particular, the virtio header always has the u16 num_buffers field. > We define a new 'struct virtio_net_modern_hdr' for this (rather than > simply calling it 'struct virtio_net_hdr', to avoid nasty type errors > if some parts of a

[PATCH 3/5] virtio: Don't expose legacy net features when VIRTIO_NET_NO_LEGACY defined.

2015-02-05 Thread Rusty Russell
In particular, the virtio header always has the u16 num_buffers field. We define a new 'struct virtio_net_modern_hdr' for this (rather than simply calling it 'struct virtio_net_hdr', to avoid nasty type errors if some parts of a project define VIRTIO_NET_NO_LEGACY and some don't. Signed-off-by: Ru