Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-12-02 Thread Pavel Machek
Hi! > > This flag says "this is device where autorepeat makes sense". It does > > make sense for qwerty keyboard, it does not make sense for power > > button. There's nothing Linux specific here. > > If you follow that argument, you don't need the property at all. We know > whether something is b

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-12-02 Thread Mark Rutland
On Mon, Dec 02, 2013 at 11:54:42AM +, Pavel Machek wrote: > On Mon 2013-12-02 11:37:20, Mark Rutland wrote: > > On Sun, Nov 17, 2013 at 06:28:52PM +, Pavel Machek wrote: > > > > > > > > Thus I guess we should not use the name, which has the most adopters > > > > > in kernel (or out of kern

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-12-02 Thread Pavel Machek
On Mon 2013-12-02 11:37:20, Mark Rutland wrote: > On Sun, Nov 17, 2013 at 06:28:52PM +, Pavel Machek wrote: > > > > > > Thus I guess we should not use the name, which has the most adopters > > > > in kernel (or out of kernel). Instead the most fitting name should > > > > be used. Current sugge

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-12-02 Thread Mark Rutland
On Sun, Nov 17, 2013 at 06:28:52PM +, Pavel Machek wrote: > > > > Thus I guess we should not use the name, which has the most adopters > > > in kernel (or out of kernel). Instead the most fitting name should > > > be used. Current suggestions (taken from kernel) are: > > > > > > * <>,no-autor

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-17 Thread Sebastian Reichel
On Sun, Nov 17, 2013 at 07:28:45PM +0100, Pavel Machek wrote: > Hi! > > > > > I could find two boards using "gpio-matrix-keypad" in the mainline > > > > kernel and not a single instance of "linux,no-autorepeat": > > > > > > In things connected to GPIO, I don't expect the in-kernel > > > device tr

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-17 Thread Pavel Machek
Hi! > > > I could find two boards using "gpio-matrix-keypad" in the mainline > > > kernel and not a single instance of "linux,no-autorepeat": > > > > In things connected to GPIO, I don't expect the in-kernel > > device trees to be a good way so survey the usage of these > > bindings. Anyone doing

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-17 Thread Pavel Machek
> > Thus I guess we should not use the name, which has the most adopters > > in kernel (or out of kernel). Instead the most fitting name should > > be used. Current suggestions (taken from kernel) are: > > > > * <>,no-autorepeat > > * keypad,autorepeat > > * linux,keypad-no-autorepeat > > * linux

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-14 Thread Mark Rutland
On Wed, Nov 13, 2013 at 11:29:24PM +, Sebastian Reichel wrote: > Hi, > > On Wed, Nov 13, 2013 at 02:24:06PM +, Mark Rutland wrote: > > > Current suggestions (taken from kernel) are: > > > > > > * <>,no-autorepeat > > > * keypad,autorepeat > > > * linux,keypad-no-autorepeat > > > * linux,i

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-13 Thread Sebastian Reichel
Hi, On Wed, Nov 13, 2013 at 02:24:06PM +, Mark Rutland wrote: > > Current suggestions (taken from kernel) are: > > > > * <>,no-autorepeat > > * keypad,autorepeat > > * linux,keypad-no-autorepeat > > * linux,input-no-autorepeat > > * linux,no-autorepeat > > * autorepeat > > > > I do not reall

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-13 Thread Mark Rutland
On Tue, Nov 12, 2013 at 08:40:14PM +, Sebastian Reichel wrote: > On Tue, Nov 12, 2013 at 09:11:40PM +0100, Linus Walleij wrote: > > > I could find two boards using "gpio-matrix-keypad" in the mainline > > > kernel and not a single instance of "linux,no-autorepeat": > > > > In things connected

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-12 Thread Sebastian Reichel
On Tue, Nov 12, 2013 at 09:11:40PM +0100, Linus Walleij wrote: > > I could find two boards using "gpio-matrix-keypad" in the mainline > > kernel and not a single instance of "linux,no-autorepeat": > > In things connected to GPIO, I don't expect the in-kernel > device trees to be a good way so surv

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-12 Thread Linus Walleij
On Tue, Nov 12, 2013 at 9:05 PM, Sebastian Reichel wrote: > On Tue, Nov 12, 2013 at 06:06:49PM +0100, Linus Walleij wrote: >> So this binding is documented for GPIO keys in: >> Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt >> >> This is probably the most used binding as GPIO matr

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-12 Thread Sebastian Reichel
On Tue, Nov 12, 2013 at 06:06:49PM +0100, Linus Walleij wrote: > On Tue, Nov 12, 2013 at 4:30 PM, Sebastian Reichel wrote: > > On Tue, Nov 12, 2013 at 03:13:38PM +0100, Linus Walleij wrote: > > >> + plat->no_autorepeat = of_property_read_bool(np, > >> "linux,no-autorepeat"); > >> + plat-

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-12 Thread Linus Walleij
On Tue, Nov 12, 2013 at 4:30 PM, Sebastian Reichel wrote: > On Tue, Nov 12, 2013 at 03:13:38PM +0100, Linus Walleij wrote: >> + plat->no_autorepeat = of_property_read_bool(np, "linux,no-autorepeat"); >> + plat->enable_wakeup = of_property_read_bool(np, "linux,wakeup"); > > There is curren

Re: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-12 Thread Sebastian Reichel
Hi, On Tue, Nov 12, 2013 at 03:13:38PM +0100, Linus Walleij wrote: > + plat->no_autorepeat = of_property_read_bool(np, "linux,no-autorepeat"); > + plat->enable_wakeup = of_property_read_bool(np, "linux,wakeup"); There is currently discussion going on for the property name of autorepeat:

[PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree

2013-11-12 Thread Linus Walleij
Implement device tree probing for the tc3589x keypad driver. This is modeled on the STMPE keypad driver and tested on the Ux500 TVK1281618 UIB. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Fix rows/columns binding to read two u32's insead of two u8 /bits/ as noted by Mark Rutland. ---