[PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high packet delay/jitter

2013-07-15 Thread Paolo Valente
QFQ+ inherits from QFQ a design choice that may cause a high packet delay/jitter and a severe short-term unfairness. As QFQ, QFQ+ uses a special quantity, the system virtual time, to track the service provided by the ideal system it approximates. When a packet is dequeued, this quantity must be inc

[PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high packet delay/jitter

2013-07-15 Thread Paolo Valente
QFQ+ inherits from QFQ a design choice that may cause a high packet delay/jitter and a severe short-term unfairness. As QFQ, QFQ+ uses a special quantity, the system virtual time, to track the service provided by the ideal system it approximates. When a packet is dequeued, this quantity must be inc

Re: [PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high packet delay/jitter

2013-07-15 Thread Joe Perches
On Mon, 2013-07-15 at 20:01 +0200, Paolo Valente wrote: > QFQ+ inherits from QFQ a design choice that may cause a high packet > delay/jitter and a severe short-term unfairness. [] > diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c [] > @@ -189,6 +188,7 @@ struct qfq_sched { > struct qfq

Re: [PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high packet delay/jitter

2013-07-15 Thread Paolo Valente
Il 15/07/2013 20:12, Joe Perches ha scritto: On Mon, 2013-07-15 at 20:01 +0200, Paolo Valente wrote: QFQ+ inherits from QFQ a design choice that may cause a high packet delay/jitter and a severe short-term unfairness. [] diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c [] @@ -189,6 +18

Re: [PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high packet delay/jitter

2013-07-18 Thread David Miller
From: Paolo Valente Date: Tue, 16 Jul 2013 08:52:30 +0200 ... > This patch addresses this issue by just using the above > 'instantaneous' value of the weight sum, instead of the maximum > possible value, when updating the system virtual time. After the > instantaneous weight sum is decreased, Q