Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-24 Thread Lee Jones
On Tue, 24 Apr 2018, Geert Uytterhoeven wrote: > On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman wrote: > > On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote: > >> On Wed, 11 Apr 2018, Simon Horman wrote: > >> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote: > >> > > The doc

Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-24 Thread Geert Uytterhoeven
On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman wrote: > On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote: >> On Wed, 11 Apr 2018, Simon Horman wrote: >> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote: >> > > The documentation was wrong, gpiod_get_direction() returns 0/1 in

Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-24 Thread Simon Horman
On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote: > On Wed, 11 Apr 2018, Simon Horman wrote: > > > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote: > > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead > > > of the GPIOF_* flags. The docs were fixed wit

Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-16 Thread Lee Jones
On Wed, 11 Apr 2018, Simon Horman wrote: > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote: > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47 > > ("gpio: correct docs about return value o

Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-13 Thread Daniel Thompson
On Fri, Apr 13, 2018 at 06:08:24PM +0200, Daniel Vetter wrote: > On Wed, Apr 11, 2018 at 09:32:16AM +0200, Simon Horman wrote: > > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote: > > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead > > > of the GPIOF_* flags. T

Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-13 Thread Daniel Vetter
On Wed, Apr 11, 2018 at 09:32:16AM +0200, Simon Horman wrote: > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote: > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47 > > ("gpio: correct docs

Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-11 Thread Simon Horman
On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote: > The documentation was wrong, gpiod_get_direction() returns 0/1 instead > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47 > ("gpio: correct docs about return value of gpiod_get_direction"). Now, > fix this user (unt

[PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-10 Thread Wolfram Sang
The documentation was wrong, gpiod_get_direction() returns 0/1 instead of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47 ("gpio: correct docs about return value of gpiod_get_direction"). Now, fix this user (until a better, system-wide solution is in place). Signed-off-by: Wolfra