Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-20 Thread Joe Perches
On Thu, 2017-07-20 at 11:03 -0700, Linus Torvalds wrote: > On Thu, Jul 20, 2017 at 9:48 AM, Joe Perches wrote: > > > > Same general concept, but then an expectation would be > > relative paths for filename patterns. > > No, I actually think we really should require the filename patterns to > be

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-20 Thread Linus Torvalds
On Thu, Jul 20, 2017 at 9:48 AM, Joe Perches wrote: > > Same general concept, but then an expectation would be > relative paths for filename patterns. No, I actually think we really should require the filename patterns to be absolute, even if the MAINTAINERS file might be deep in the hierarchy.

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-20 Thread Joe Perches
On Thu, 2017-07-20 at 20:54 +1000, Michael Ellerman wrote: > Joe Perches writes: > > > On Wed, 2017-07-19 at 21:24 -0700, Linus Torvalds wrote: > > > On Wed, Jul 19, 2017 at 6:05 PM, Joe Perches wrote: > > > > > > > > Just for ease of manipulation and not breaking the script much, > > > > I'd s

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-20 Thread Michael Ellerman
Joe Perches writes: > On Wed, 2017-07-19 at 21:24 -0700, Linus Torvalds wrote: >> On Wed, Jul 19, 2017 at 6:05 PM, Joe Perches wrote: >> > >> > Just for ease of manipulation and not breaking the script much, >> > I'd suggest just having a MAINTAINERS directory and stuffing >> > each of the sect

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Linus Torvalds
On Wed, Jul 19, 2017 at 9:43 PM, Joe Perches wrote: > > As a concept I think individual files would be better. > But maybe grouping by subsystem instead of by letter. Yes. Grouped by subsystem would be nice. And maybe we could start with just a few bigger groups, and split them as people step on

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Linus Torvalds
On Wed, Jul 19, 2017 at 9:36 PM, Theodore Ts'o wrote: >> >> Maybe we can just do the prefix thing and just do 26 files A-Z >> instead? Or maybe go by first word (so all the ARM things would go in >> one place?) > > Is that really going to help with merge conflicts? It might help keep > things mor

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Joe Perches
On Wed, 2017-07-19 at 21:24 -0700, Linus Torvalds wrote: > On Wed, Jul 19, 2017 at 6:05 PM, Joe Perches wrote: > > > > Just for ease of manipulation and not breaking the script much, > > I'd suggest just having a MAINTAINERS directory and stuffing > > each of the sections into separate files. > >

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Theodore Ts'o
On Wed, Jul 19, 2017 at 09:24:13PM -0700, Linus Torvalds wrote: > So I don't mind the idea of just making MAINTAINERS a directory, but I > don't think we want to so far as to make one file per entry. That's > what, 1500+ files tiny files or so? Seems a bit excessive. > > Maybe we can just do the p

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Linus Torvalds
On Wed, Jul 19, 2017 at 6:05 PM, Joe Perches wrote: > > Just for ease of manipulation and not breaking the script much, > I'd suggest just having a MAINTAINERS directory and stuffing > each of the sections into separate files. > > The script would only need to add $ cat MAINTAINERS/* as input. So

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Joe Perches
On Wed, 2017-07-19 at 18:05 -0700, Joe Perches wrote: > On Wed, 2017-07-19 at 17:08 -0700, Linus Torvalds wrote: > > (b) we could split this thing up some sane way. > > > > Anybody got any ideas? [] > Just for ease of manipulation and not breaking the script much, > I'd suggest just having a MAIN

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Joe Perches
On Wed, 2017-07-19 at 17:08 -0700, Linus Torvalds wrote: > I can easily just look at the reject and fix it, but I don't really > want to. Why? Because I hate the MAINTAINERS file. > > It's the most painful file for merging too, because everybody touches > it - kind of like the old "one single Kcon

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Randy Dunlap
On 07/19/2017 05:53 PM, Linus Torvalds wrote: > On Wed, Jul 19, 2017 at 5:35 PM, Linus Torvalds > wrote: >> >> Your mailer is crap, and destroys utf-8 characters. In particular: >> >> -M: Michał Mirosław > > Using pseudo-MIME-encoding, that was actually (before my cut-and-paste > mangl

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Linus Torvalds
On Wed, Jul 19, 2017 at 5:35 PM, Linus Torvalds wrote: > > Your mailer is crap, and destroys utf-8 characters. In particular: > > -M: Michał Mirosław Using pseudo-MIME-encoding, that was actually (before my cut-and-paste mangled it even more): Micha=c3=85=c2=82 Miros=c3=85=c2=82aw

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Linus Torvalds
On Wed, Jul 19, 2017 at 5:26 PM, Linus Torvalds wrote: > On Wed, Jul 19, 2017 at 5:19 PM, Randy Dunlap wrote: >> >> Must be small and stupid. It applies cleanly for me. >> Do you have changes that are not pushed out publicly? > > Nope, my private tree matches the public one. Oh, I see it. Your

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Linus Torvalds
On Wed, Jul 19, 2017 at 5:19 PM, Randy Dunlap wrote: > > Must be small and stupid. It applies cleanly for me. > Do you have changes that are not pushed out publicly? Nope, my private tree matches the public one. The failure happens at the chunk for line 5086, fwiw. You don't seem to have used

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Randy Dunlap
On 07/19/2017 05:08 PM, Linus Torvalds wrote: > On Wed, Jul 19, 2017 at 2:44 PM, Andrew Morton > wrote: >> >> Linus, can you please grab this? > > Ugh. It doesn't apply cleanly. Probably for some really small stupid reason. Must be small and stupid. It applies cleanly for me. Do you have change

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Randy Dunlap
On 07/19/2017 05:08 PM, Linus Torvalds wrote: > On Wed, Jul 19, 2017 at 2:44 PM, Andrew Morton > wrote: >> >> Linus, can you please grab this? > > Ugh. It doesn't apply cleanly. Probably for some really small stupid reason. > > I can easily just look at the reject and fix it, but I don't really

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Linus Torvalds
On Wed, Jul 19, 2017 at 5:08 PM, Linus Torvalds wrote: > > I'm throwing out _one_ idea: split it up by the main F: line, so that > maintainership information ends up being hierarchical like the Kconfig > files. Teach "get_maintainer.pl" to just do "find . -name > MAINTAINERS" instead? For a more

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Linus Torvalds
On Wed, Jul 19, 2017 at 2:44 PM, Andrew Morton wrote: > > Linus, can you please grab this? Ugh. It doesn't apply cleanly. Probably for some really small stupid reason. I can easily just look at the reject and fix it, but I don't really want to. Why? Because I hate the MAINTAINERS file. It's the

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Joe Perches
On Wed, 2017-07-19 at 14:40 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix major alphabetic errors. No attempt to fix items that all begin > with the same word (like ARM, BROADCOM, DRM, EDAC, FREESCALE, INTEL, > OMAP, PCI, SAMSUNG, TI, USB, etc.). [] > -APPARMOR SECURITY MODULE > -M:

Re: [PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Andrew Morton
On Wed, 19 Jul 2017 14:40:20 -0700 Randy Dunlap wrote: > Fix major alphabetic errors. No attempt to fix items that all begin > with the same word (like ARM, BROADCOM, DRM, EDAC, FREESCALE, INTEL, > OMAP, PCI, SAMSUNG, TI, USB, etc.). > > (diffstat +/- is different by one line because TI KEYSTONE

[PATCH RESEND v4] MAINTAINERS: fix lots of alphabetic ordering

2017-07-19 Thread Randy Dunlap
From: Randy Dunlap Fix major alphabetic errors. No attempt to fix items that all begin with the same word (like ARM, BROADCOM, DRM, EDAC, FREESCALE, INTEL, OMAP, PCI, SAMSUNG, TI, USB, etc.). (diffstat +/- is different by one line because TI KEYSTONE MULTICORE had 2 blank lines after it.) Signe