Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-25 Thread Vivek Gautam
Hi, On Fri, Apr 25, 2014 at 1:27 PM, Tushar Behera wrote: > On 04/14/2014 08:07 PM, Sylwester Nawrocki wrote: >> On 08/04/14 16:36, Vivek Gautam wrote: >>> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt >>> b/Documentation/devicetree/bindings/phy/samsung-phy.txt >>> index 28

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-25 Thread Tushar Behera
On 04/14/2014 08:07 PM, Sylwester Nawrocki wrote: > On 08/04/14 16:36, Vivek Gautam wrote: >> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt >> b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> index 28f9edb..6d99ba9 100644 >> --- a/Documentation/devicetree/bindings/ph

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-21 Thread Vivek Gautam
Hi Jingoo, On Tue, Apr 22, 2014 at 7:48 AM, Jingoo Han wrote: > On Wednesday, April 16, 2014 11:49 PM, Vivek Gautam wrote: >> On Wed, Apr 16, 2014 at 7:14 PM, Tomasz Figa wrote: >> > On 15.04.2014 08:09, Vivek Gautam wrote: >> >> On Thu, Apr 10, 2014 at 5:09 PM, Vivek Gautam wrote: >> >>> On We

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-21 Thread Jingoo Han
On Wednesday, April 16, 2014 11:49 PM, Vivek Gautam wrote: > On Wed, Apr 16, 2014 at 7:14 PM, Tomasz Figa wrote: > > On 15.04.2014 08:09, Vivek Gautam wrote: > >> On Thu, Apr 10, 2014 at 5:09 PM, Vivek Gautam wrote: > >>> On Wed, Apr 9, 2014 at 7:03 PM, Tomasz Figa wrote: > On 09.04.2014 13:

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-16 Thread Vivek Gautam
Hi, On Wed, Apr 16, 2014 at 7:14 PM, Tomasz Figa wrote: > Hi Vivek, > > > On 15.04.2014 08:09, Vivek Gautam wrote: >> >> Hi Tomasz, >> >> >> On Thu, Apr 10, 2014 at 5:09 PM, Vivek Gautam >> wrote: >>> >>> On Wed, Apr 9, 2014 at 7:03 PM, Tomasz Figa wrote: On 09.04.2014 13:49, Vivek G

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-16 Thread Tomasz Figa
Hi Vivek, On 15.04.2014 08:09, Vivek Gautam wrote: Hi Tomasz, On Thu, Apr 10, 2014 at 5:09 PM, Vivek Gautam wrote: On Wed, Apr 9, 2014 at 7:03 PM, Tomasz Figa wrote: On 09.04.2014 13:49, Vivek Gautam wrote: Hi, On Wed, Apr 9, 2014 at 4:36 PM, Tomasz Figa wrote: Hi Vivek, Please see

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-15 Thread Kishon Vijay Abraham I
Hi, On Monday 14 April 2014 07:19 PM, Tomasz Figa wrote: > On 14.04.2014 15:40, Vivek Gautam wrote: >> On Mon, Apr 14, 2014 at 6:56 PM, Kishon Vijay Abraham I >> wrote: >>> >>> >>> On Monday 14 April 2014 06:50 PM, Vivek Gautam wrote: On Mon, Apr 14, 2014 at 6:29 PM, Kishon Vijay Abraham I

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi Tomasz, On Thu, Apr 10, 2014 at 5:09 PM, Vivek Gautam wrote: > On Wed, Apr 9, 2014 at 7:03 PM, Tomasz Figa wrote: >> On 09.04.2014 13:49, Vivek Gautam wrote: >>> >>> Hi, >>> >>> >>> On Wed, Apr 9, 2014 at 4:36 PM, Tomasz Figa wrote: Hi Vivek, Please see my comments inlin

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi, On Mon, Apr 14, 2014 at 8:07 PM, Sylwester Nawrocki wrote: > On 08/04/14 16:36, Vivek Gautam wrote: >> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt >> b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> index 28f9edb..6d99ba9 100644 >> --- a/Documentation/device

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi Sylwester, On Mon, Apr 14, 2014 at 7:51 PM, Sylwester Nawrocki wrote: > On 14/04/14 15:49, Vivek Gautam wrote: >> True, we don't have a scope of instantiating this driver using old >> platform device and >> old legacy board files. >> So we don't need this check then, right ? > > I think it ca

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Sylwester Nawrocki
On 08/04/14 16:36, Vivek Gautam wrote: > diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt > b/Documentation/devicetree/bindings/phy/samsung-phy.txt > index 28f9edb..6d99ba9 100644 > --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt > +++ b/Documentation/devicetree/bindi

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Sylwester Nawrocki
On 14/04/14 15:49, Vivek Gautam wrote: > True, we don't have a scope of instantiating this driver using old > platform device and > old legacy board files. > So we don't need this check then, right ? I think it can be dropped. At least IMHO there is no point to increase size of the module with an

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Tomasz Figa
On 14.04.2014 15:40, Vivek Gautam wrote: On Mon, Apr 14, 2014 at 6:56 PM, Kishon Vijay Abraham I wrote: On Monday 14 April 2014 06:50 PM, Vivek Gautam wrote: On Mon, Apr 14, 2014 at 6:29 PM, Kishon Vijay Abraham I wrote: On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: Hi, On Mon

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi, On Mon, Apr 14, 2014 at 7:14 PM, Tomasz Figa wrote: > On 14.04.2014 15:05, Kishon Vijay Abraham I wrote: >> >> >> >> On Monday 14 April 2014 05:35 PM, Vivek Gautam wrote: >>> >>> Hi Kishon, >>> >>> >>> On Mon, Apr 14, 2014 at 5:24 PM, Kishon Vijay Abraham I >>> wrote: Hi, >>>

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
On Mon, Apr 14, 2014 at 7:10 PM, Vivek Gautam wrote: Just correcting mail-ids for Mark and Dong with the latest ones (earlier ones got bounced back) > On Mon, Apr 14, 2014 at 6:56 PM, Kishon Vijay Abraham I wrote: >> >> >> On Monday 14 April 2014 06:50 PM, Vivek Gautam wrote: >>> On Mon, Apr 14

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Tomasz Figa
On 14.04.2014 15:05, Kishon Vijay Abraham I wrote: On Monday 14 April 2014 05:35 PM, Vivek Gautam wrote: Hi Kishon, On Mon, Apr 14, 2014 at 5:24 PM, Kishon Vijay Abraham I wrote: Hi, On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: Hi Vivek, Please see my comments inline. On 08.

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
On Mon, Apr 14, 2014 at 6:56 PM, Kishon Vijay Abraham I wrote: > > > On Monday 14 April 2014 06:50 PM, Vivek Gautam wrote: >> On Mon, Apr 14, 2014 at 6:29 PM, Kishon Vijay Abraham I >> wrote: >>> >>> >>> On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: Hi, On Mon, Apr 14

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
On Monday 14 April 2014 06:50 PM, Vivek Gautam wrote: > On Mon, Apr 14, 2014 at 6:29 PM, Kishon Vijay Abraham I wrote: >> >> >> On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: >>> Hi, >>> >>> >>> On Mon, Apr 14, 2014 at 5:57 PM, Kishon Vijay Abraham I >>> wrote: Hi, On Tue

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
On Mon, Apr 14, 2014 at 6:29 PM, Kishon Vijay Abraham I wrote: > > > On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: >> Hi, >> >> >> On Mon, Apr 14, 2014 at 5:57 PM, Kishon Vijay Abraham I >> wrote: >>> Hi, >>> >>> On Tuesday 08 April 2014 08:06 PM, Vivek Gautam wrote: Add a new drive

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
On Monday 14 April 2014 05:35 PM, Vivek Gautam wrote: > Hi Kishon, > > > On Mon, Apr 14, 2014 at 5:24 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: >>> Hi Vivek, >>> >>> Please see my comments inline. >>> >>> On 08.04.2014 16:36, Vivek G

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: > Hi, > > > On Mon, Apr 14, 2014 at 5:57 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 08 April 2014 08:06 PM, Vivek Gautam wrote: >>> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >>> The new driver uses the g

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi, On Mon, Apr 14, 2014 at 5:57 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 08 April 2014 08:06 PM, Vivek Gautam wrote: >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will interact >> with DWC3 controller presen

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
Hi, On Tuesday 08 April 2014 08:06 PM, Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > Thereby, removing old phy-samsung-usb3 driver a

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi Kishon, On Mon, Apr 14, 2014 at 5:24 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: >> Hi Vivek, >> >> Please see my comments inline. >> >> On 08.04.2014 16:36, Vivek Gautam wrote: >>> Add a new driver for the USB 3.0 PHY on Exynos5 series

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
Hi, On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: > Hi Vivek, > > Please see my comments inline. > > On 08.04.2014 16:36, Vivek Gautam wrote: >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will interact >> with DW

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-10 Thread Vivek Gautam
On Wed, Apr 9, 2014 at 7:03 PM, Tomasz Figa wrote: > On 09.04.2014 13:49, Vivek Gautam wrote: >> >> Hi, >> >> >> On Wed, Apr 9, 2014 at 4:36 PM, Tomasz Figa wrote: >>> >>> Hi Vivek, >>> >>> Please see my comments inline. >>> >>> >>> On 08.04.2014 16:36, Vivek Gautam wrote: Add a ne

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-09 Thread Tomasz Figa
On 09.04.2014 13:49, Vivek Gautam wrote: Hi, On Wed, Apr 9, 2014 at 4:36 PM, Tomasz Figa wrote: Hi Vivek, Please see my comments inline. On 08.04.2014 16:36, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-09 Thread Vivek Gautam
Hi, On Wed, Apr 9, 2014 at 4:36 PM, Tomasz Figa wrote: > Hi Vivek, > > Please see my comments inline. > > > On 08.04.2014 16:36, Vivek Gautam wrote: >> >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will interact >> with DW

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-09 Thread Tomasz Figa
Hi Vivek, Please see my comments inline. On 08.04.2014 16:36, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. Thereby, removing old phy-sam

[PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-08 Thread Vivek Gautam
Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. Thereby, removing old phy-samsung-usb3 driver and related code used untill now which was based on usb/phy framework