Re: [PATCH V6 06/12] perf tools: remove unnecessary callchain validation

2013-07-17 Thread Adrian Hunter
On 16/07/13 15:05, Jiri Olsa wrote: > On Tue, Jul 16, 2013 at 09:38:12AM +0300, Adrian Hunter wrote: > > SNIP > >> } >> } >> >> -static int perf_session__preprocess_sample(struct perf_session *session, >> - union perf_event *event, struct >> perf_sam

Re: [PATCH V6 06/12] perf tools: remove unnecessary callchain validation

2013-07-16 Thread Jiri Olsa
On Tue, Jul 16, 2013 at 09:38:12AM +0300, Adrian Hunter wrote: SNIP > } > } > > -static int perf_session__preprocess_sample(struct perf_session *session, > -union perf_event *event, struct > perf_sample *sample) > -{ > - if (event->header.type

[PATCH V6 06/12] perf tools: remove unnecessary callchain validation

2013-07-15 Thread Adrian Hunter
Now that the sample parsing correctly checks data sizes there is no reason for it to be done again for callchains. Signed-off-by: Adrian Hunter --- tools/perf/util/callchain.c | 8 tools/perf/util/callchain.h | 5 - tools/perf/util/session.c | 20 3 files ch