Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Jesper Dangaard Brouer
On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote: > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > > Co-developed-by: Jesper Dangaard Brouer > > > Co-developed-by: Matteo Croce > > > Signed-off-by: Ilias

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Ilias Apalodimas
On Fri, Apr 09, 2021 at 12:29:29PM -0700, Jakub Kicinski wrote: > On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote: > > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > > > Co-developed-by: Jesper Dangaard

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote: > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > > Co-developed-by: Jesper Dangaard Brouer > > > Co-developed-by: Matteo Croce > > > Signed-off-by: Ilias

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Ilias Apalodimas
On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > Co-developed-by: Jesper Dangaard Brouer > > Co-developed-by: Matteo Croce > > Signed-off-by: Ilias Apalodimas > > Checkpatch says we need sign-offs from all authors. >

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Jakub Kicinski
On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > Co-developed-by: Jesper Dangaard Brouer > Co-developed-by: Matteo Croce > Signed-off-by: Ilias Apalodimas Checkpatch says we need sign-offs from all authors. Especially you since you're posting.

[PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-02 Thread Matteo Croce
From: Ilias Apalodimas Up to now several high speed NICs have custom mechanisms of recycling the allocated memory they use for their payloads. Our page_pool API already has recycling capabilities that are always used when we are running in 'XDP mode'. So let's tweak the API and the kernel