Re: [PATCH v2 2/2] net: phy: adin: implement cable-test support

2020-10-23 Thread Andrew Lunn
On Thu, Oct 22, 2020 at 10:45:51AM +0300, Alexandru Ardelean wrote: > The ADIN1300/ADIN1200 support cable diagnostics using TDR. > > The cable fault detection is automatically run on all four pairs looking at > all combinations of pair faults by first putting the PHY in standby (clear > the LINK_E

Re: [PATCH v2 2/2] net: phy: adin: implement cable-test support

2020-10-23 Thread Alexandru Ardelean
On Fri, Oct 23, 2020 at 3:02 AM Jakub Kicinski wrote: > > On Thu, 22 Oct 2020 10:45:51 +0300 Alexandru Ardelean wrote: > > The ADIN1300/ADIN1200 support cable diagnostics using TDR. > > > > The cable fault detection is automatically run on all four pairs looking at > > all combinations of pair fau

Re: [PATCH v2 2/2] net: phy: adin: implement cable-test support

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 10:45:51 +0300 Alexandru Ardelean wrote: > The ADIN1300/ADIN1200 support cable diagnostics using TDR. > > The cable fault detection is automatically run on all four pairs looking at > all combinations of pair faults by first putting the PHY in standby (clear > the LINK_EN bit,

[PATCH v2 2/2] net: phy: adin: implement cable-test support

2020-10-22 Thread Alexandru Ardelean
The ADIN1300/ADIN1200 support cable diagnostics using TDR. The cable fault detection is automatically run on all four pairs looking at all combinations of pair faults by first putting the PHY in standby (clear the LINK_EN bit, PHY_CTRL_3 register, Address 0x0017) and then enabling the diagnostic c