From: Yazen Ghannam
Print the fields in the IA32/X64 Processor Error Info Structure.
Based on UEFI 2.7 Table 256. IA32/X64 Processor Error Information
Structure.
Signed-off-by: Yazen Ghannam
---
Link:
https://lkml.kernel.org/r/20180223200333.6410-4-yazen.ghan...@amd.com
v1->v2:
* Add paranthe
On Mon, Feb 26, 2018 at 01:38:59PM -0600, Yazen Ghannam wrote:
> From: Yazen Ghannam
>
> Print the fields in the IA32/X64 Processor Error Info Structure.
>
> Based on UEFI 2.7 Table 256. IA32/X64 Processor Error Information
> Structure.
>
> Signed-off-by: Yazen Ghannam
> ---
> Link:
> https://
> -Original Message-
> From: Borislav Petkov [mailto:b...@suse.de]
> Sent: Tuesday, February 27, 2018 9:26 AM
> To: Ghannam, Yazen
> Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
> ard.biesheu...@linaro.org; x...@kernel.org
> Subject: Re: [PATCH v2 3/8]
On Tue, Feb 27, 2018 at 03:25:06PM +, Ghannam, Yazen wrote:
> This is the same as the other CPER code.
Dude, turn on brain!
So if it is in the other CPER code, we should copy it, no matter how
dumb it is?!?
> Also, the spec allows platform-defined GUIDs. So we should always print this
> even
> -Original Message-
> From: Borislav Petkov [mailto:b...@suse.de]
> Sent: Tuesday, February 27, 2018 12:04 PM
> To: Ghannam, Yazen
> Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
> ard.biesheu...@linaro.org; x...@kernel.org
> Subject: Re: [PATCH v2
On Tue, Feb 27, 2018 at 05:46:54PM +, Ghannam, Yazen wrote:
> I think there's value in following the conventions in a subsystem.
"conventions in a subsystem" my ass. That's brainless copy-pasting.
It was added by
f6edea77c8c8 ("ACPI, APEI, CPER: Cleanup CPER memory error output format")
and
> -Original Message-
> From: Borislav Petkov [mailto:b...@suse.de]
> Sent: Tuesday, February 27, 2018 1:03 PM
> To: Ghannam, Yazen
> Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
> ard.biesheu...@linaro.org; x...@kernel.org
> Subject: Re: [PATCH v2 3/8]
On Tue, Feb 27, 2018 at 06:40:13PM +, Ghannam, Yazen wrote:
> Code readability.
Bullshit!
You can't tell me this:
snprintf(newpfx, sizeof(newpfx), "%s ", pfx);
is less readable than:
snprintf(newpfx, sizeof(newpfx), "%s%s", pfx, INDENT_SP);
> 1) No one except debug and HW
: Re: [PATCH v2 3/8] efi: Decode IA32/X64 Processor Error Info
> Structure
>
...
> > 1) No one except debug and HW design folks, who will eventually get a
> > report from a user.
>
> Hahahha, yeah right.
>
> The only people who get those reports are the maintainers of
On Tue, Feb 27, 2018 at 09:32:18PM +, Ghannam, Yazen wrote:
> Not much more readable. It's still vague and confusing to a user and devoid
> of any real info so an expert can't help. And now the information is printed
> arbitrarily, so someone needs to read the source to figure out what it reall
10 matches
Mail list logo
