Re: [RESEND PATCH v3 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

> +static int ec_command(struct cros_ec_dev *ec_dev, int version, int command, > + uint8_t *outdata, int outsize, uint8_t *indata, > + int insize) > +{ int is a very odd type to use for sizes that cannot be negative, especially given all your callers use

Re: [RESEND PATCH v3 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

> +static int ec_command(struct cros_ec_dev *ec_dev, int version, int command, > + uint8_t *outdata, int outsize, uint8_t *indata, > + int insize) > +{ int is a very odd type to use for sizes that cannot be negative, especially given all your callers use

Re: [RESEND PATCH v3 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

Hi Sameer, [auto build test WARNING on v4.5-rc6] [also build test WARNING on next-20160302] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

Re: [RESEND PATCH v3 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

Hi Sameer, [auto build test WARNING on v4.5-rc6] [also build test WARNING on next-20160302] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

[RESEND PATCH v3 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

From: Sameer Nanda This driver exposes the charger functionality in the PD EC to userspace. Signed-off-by: Tomeu Vizoso Cc: Sameer Nanda Cc: Benson Leung Cc: Shawn Nematbakhsh ---

[RESEND PATCH v3 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

From: Sameer Nanda This driver exposes the charger functionality in the PD EC to userspace. Signed-off-by: Tomeu Vizoso Cc: Sameer Nanda Cc: Benson Leung Cc: Shawn Nematbakhsh --- Changes in v3: - Use do_div so it builds on 32bit (suggested by 0-day kbuild bot). - Remove sysfs attributes