On Mon, 10 Feb 2014 16:54:16 -0500 Johannes Weiner wrote:
> How about this: we allow disabling the log message, but print the line
> of the disabling call so it's clear who dunnit. To make sure valuable
> info is not missing in bug reports, add counters for the two events in
> /proc/vmstat.
>
>
iginal motivation for this change.
>
> Yes, somewhat. It is a compromise. You can see my concern here?
How about this: we allow disabling the log message, but print the line
of the disabling call so it's clear who dunnit. To make sure valuable
info is not missing in bug reports, add co
el@vger.kernel.org
> Subject: Re: [patch] drop_caches: add some documentation and info
> message
>
> On Fri, 7 Feb 2014 16:26:01 -0500 Johannes Weiner
> wrote:
>
> > On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
> > > On Fri, 7 Feb 2014 13:13:32 -0500 Joh
On Fri, 7 Feb 2014 16:26:01 -0500 Johannes Weiner wrote:
> On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
> > On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner
> > wrote:
> >
> > > @@ -63,6 +64,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int
> > > write,
> > >
ould it be better to print this after the operation
> > has completed?
>
> It would make more sense grammatically :-) Either way is fine with me,
> updated below to inform after the fact.
>
> ---
> From: Dave Hansen
> Date: Fri, 12 Oct 2012 14:30:54 +0200
> Subject: [p
On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
> On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner wrote:
>
> > @@ -63,6 +64,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int
> > write,
> > iterate_supers(drop_pagecache_sb, NULL);
> > if (s
On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner wrote:
> @@ -63,6 +64,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
> iterate_supers(drop_pagecache_sb, NULL);
> if (sysctl_drop_caches & 2)
> drop_slab();
> +
time, so there are some minor concerns besides
grammatical correctness, too :)
Thanks for updating the patch.
---
From: Dave Hansen
Date: Fri, 12 Oct 2012 14:30:54 +0200
Subject: [patch] drop_caches: add some documentation and info message
Dropping caches is a very drastic and disruptive
pdated below to inform after the fact.
---
From: Dave Hansen
Date: Fri, 12 Oct 2012 14:30:54 +0200
Subject: [patch] drop_caches: add some documentation and info message
There is plenty of anecdotal evidence and a load of blog posts
suggesting that using "drop_caches" periodically keeps your
On 02/07/2014 12:40 PM, Johannes Weiner wrote:
@@ -59,6 +60,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
if (ret)
return ret;
if (write) {
+ printk_ratelimited(KERN_INFO "%s (%d): dropped kernel caches:
%d\n",
+
From: Dave Hansen
There is plenty of anecdotal evidence and a load of blog posts
suggesting that using "drop_caches" periodically keeps your system
running in "tip top shape". Perhaps adding some kernel documentation
will increase the amount of accurate data on its use.
If we are not shrinking
11 matches
Mail list logo
