Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

2020-09-29 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

2020-09-22 Thread Christoph Hellwig
On Tue, Sep 22, 2020 at 03:47:40PM +, Tianxianting wrote: > Finally, it applied:) > Thanks again for all your kindly guides to me. Thanks a lot for the patch!

RE: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

2020-09-22 Thread Tianxianting
; linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null On Tue, Sep 22, 2020 at 07:57:05AM -0700, Keith Busch wrote: > The commit subject is a too long. We should really try to keep these > to > 50 characters or less. &g

RE: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

2020-09-22 Thread Tianxianting
...@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null On Tue, Sep 22, 2020 at 03:27:27PM +, Tianxianting wrote: > Thank you Keith, Christoph, > So I don't need to send v3 patch? No, it is all fine.

Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

2020-09-22 Thread Christoph Hellwig
On Tue, Sep 22, 2020 at 03:27:27PM +, Tianxianting wrote: > Thank you Keith, Christoph, > So I don't need to send v3 patch? No, it is all fine. I've already applied it locally.

Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

2020-09-22 Thread Christoph Hellwig
On Tue, Sep 22, 2020 at 07:57:05AM -0700, Keith Busch wrote: > The commit subject is a too long. We should really try to keep these to > 50 characters or less. > > nvme-pci: fix NULL req in completion handler > > Otherwise, looks fine. > > Reviewed-by: Keith Busch Yes. I was about to apply

Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

2020-09-22 Thread Keith Busch
The commit subject is a too long. We should really try to keep these to 50 characters or less. nvme-pci: fix NULL req in completion handler Otherwise, looks fine. Reviewed-by: Keith Busch

[PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

2020-09-22 Thread Xianting Tian
Currently, we use nvmeq->q_depth as the upper limit for a valid tag in nvme_handle_cqe(), it is not correct. Because the available tag number is recorded in tagset, which is not equal to nvmeq->q_depth. The nvme driver registers interrupts for queues before initializing the tagset, because it