Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-06 Thread Michal Hocko
On Wed 05-07-17 14:18:49, Andrew Morton wrote: > On Wed, 5 Jul 2017 20:28:49 +0200 Michal Hocko wrote: > > > "mm: enlarge stack guard gap" has introduced a regression in some rust > > and Java environments which are trying to implement their own stack > > guard page. They are

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-06 Thread Michal Hocko
On Wed 05-07-17 14:18:49, Andrew Morton wrote: > On Wed, 5 Jul 2017 20:28:49 +0200 Michal Hocko wrote: > > > "mm: enlarge stack guard gap" has introduced a regression in some rust > > and Java environments which are trying to implement their own stack > > guard page. They are punching a new

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 2:18 PM, Andrew Morton wrote: > On Wed, 5 Jul 2017 20:28:49 +0200 Michal Hocko wrote: >>> >> Fixes: d4d2d35e6ef9 ("mm: larger stack guard gap, between vmas") > > That should be 1be7107fbe18, yes? Good catch. I assume the

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 2:18 PM, Andrew Morton wrote: > On Wed, 5 Jul 2017 20:28:49 +0200 Michal Hocko wrote: >>> >> Fixes: d4d2d35e6ef9 ("mm: larger stack guard gap, between vmas") > > That should be 1be7107fbe18, yes? Good catch. I assume the d4d2d35e6ef9 is one of the stable backport

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Andrew Morton
On Wed, 5 Jul 2017 20:28:49 +0200 Michal Hocko wrote: > "mm: enlarge stack guard gap" has introduced a regression in some rust > and Java environments which are trying to implement their own stack > guard page. They are punching a new MAP_FIXED mapping inside the > existing

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Andrew Morton
On Wed, 5 Jul 2017 20:28:49 +0200 Michal Hocko wrote: > "mm: enlarge stack guard gap" has introduced a regression in some rust > and Java environments which are trying to implement their own stack > guard page. They are punching a new MAP_FIXED mapping inside the > existing stack Vma. > > This

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Willy Tarreau
On Wed, Jul 05, 2017 at 12:15:05PM -0700, Linus Torvalds wrote: > On Wed, Jul 5, 2017 at 11:53 AM, Michal Hocko wrote: > > > > That would lead to conflicts when backporting to stable trees though > > which is quite annoying as well and arguably slightly more annoying than > >

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Willy Tarreau
On Wed, Jul 05, 2017 at 12:15:05PM -0700, Linus Torvalds wrote: > On Wed, Jul 5, 2017 at 11:53 AM, Michal Hocko wrote: > > > > That would lead to conflicts when backporting to stable trees though > > which is quite annoying as well and arguably slightly more annoying than > > resolving this in

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 11:53 AM, Michal Hocko wrote: > > That would lead to conflicts when backporting to stable trees though > which is quite annoying as well and arguably slightly more annoying than > resolving this in mmotm. I can help to rebase Oleg's patch on top of > mine

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 11:53 AM, Michal Hocko wrote: > > That would lead to conflicts when backporting to stable trees though > which is quite annoying as well and arguably slightly more annoying than > resolving this in mmotm. I can help to rebase Oleg's patch on top of > mine which is not a

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Michal Hocko
On Wed 05-07-17 20:53:02, Michal Hocko wrote: > On Wed 05-07-17 11:35:51, Linus Torvalds wrote: > > On Wed, Jul 5, 2017 at 11:28 AM, Michal Hocko wrote: > > > > > > Dohh, that was on mmotm which has a clean up by Oleg which reorganizes > > > the code a bit. This is on top of

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Michal Hocko
On Wed 05-07-17 20:53:02, Michal Hocko wrote: > On Wed 05-07-17 11:35:51, Linus Torvalds wrote: > > On Wed, Jul 5, 2017 at 11:28 AM, Michal Hocko wrote: > > > > > > Dohh, that was on mmotm which has a clean up by Oleg which reorganizes > > > the code a bit. This is on top of the current master >

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Michal Hocko
On Wed 05-07-17 11:35:51, Linus Torvalds wrote: > On Wed, Jul 5, 2017 at 11:28 AM, Michal Hocko wrote: > > > > Dohh, that was on mmotm which has a clean up by Oleg which reorganizes > > the code a bit. This is on top of the current master > > Oh, ok. I think I know which patch

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Michal Hocko
On Wed 05-07-17 11:35:51, Linus Torvalds wrote: > On Wed, Jul 5, 2017 at 11:28 AM, Michal Hocko wrote: > > > > Dohh, that was on mmotm which has a clean up by Oleg which reorganizes > > the code a bit. This is on top of the current master > > Oh, ok. I think I know which patch from Oleg you're

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 11:28 AM, Michal Hocko wrote: > > Dohh, that was on mmotm which has a clean up by Oleg which reorganizes > the code a bit. This is on top of the current master Oh, ok. I think I know which patch from Oleg you're talking about. Since I do want that patch

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 11:28 AM, Michal Hocko wrote: > > Dohh, that was on mmotm which has a clean up by Oleg which reorganizes > the code a bit. This is on top of the current master Oh, ok. I think I know which patch from Oleg you're talking about. Since I do want that patch too, and since I'd

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Michal Hocko
On Wed 05-07-17 10:43:27, Linus Torvalds wrote: > On Wed, Jul 5, 2017 at 9:56 AM, Michal Hocko wrote: > > > > "mm: enlarge stack guard gap" has introduced a regression in some rust > > and Java environments which are trying to implement their own stack > > guard page. They are

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Michal Hocko
On Wed 05-07-17 10:43:27, Linus Torvalds wrote: > On Wed, Jul 5, 2017 at 9:56 AM, Michal Hocko wrote: > > > > "mm: enlarge stack guard gap" has introduced a regression in some rust > > and Java environments which are trying to implement their own stack > > guard page. They are punching a new

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 9:56 AM, Michal Hocko wrote: > > "mm: enlarge stack guard gap" has introduced a regression in some rust > and Java environments which are trying to implement their own stack > guard page. They are punching a new MAP_FIXED mapping inside the > existing

Re: [PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 9:56 AM, Michal Hocko wrote: > > "mm: enlarge stack guard gap" has introduced a regression in some rust > and Java environments which are trying to implement their own stack > guard page. They are punching a new MAP_FIXED mapping inside the > existing stack Vma. Hmm. What

[PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Michal Hocko
From: Michal Hocko "mm: enlarge stack guard gap" has introduced a regression in some rust and Java environments which are trying to implement their own stack guard page. They are punching a new MAP_FIXED mapping inside the existing stack Vma. This will confuse

[PATCH] mm: mm, mmap: do not blow on PROT_NONE MAP_FIXED holes in the stack

2017-07-05 Thread Michal Hocko
From: Michal Hocko "mm: enlarge stack guard gap" has introduced a regression in some rust and Java environments which are trying to implement their own stack guard page. They are punching a new MAP_FIXED mapping inside the existing stack Vma. This will confuse expand_{downwards,upwards} into