Re: [PATCH 03/22] kvm: mmu: Init / Uninit the TDP MMU

2020-09-30 Thread Ben Gardon
On Wed, Sep 30, 2020 at 10:39 AM Paolo Bonzini wrote: > > On 30/09/20 18:57, Sean Christopherson wrote: > >> + > >> +static bool __read_mostly tdp_mmu_enabled = true; > >> +module_param_named(tdp_mmu, tdp_mmu_enabled, bool, 0644); > > This param should not exist until the TDP MMU is fully

Re: [PATCH 03/22] kvm: mmu: Init / Uninit the TDP MMU

2020-09-30 Thread Ben Gardon
On Tue, Sep 29, 2020 at 10:35 PM Sean Christopherson wrote: > > Nit on all the shortlogs, can you use "KVM: x86/mmu" instead of "kvm: mmu"? Will do. > > On Fri, Sep 25, 2020 at 02:22:43PM -0700, Ben Gardon wrote: > > diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c > > new

Re: [PATCH 03/22] kvm: mmu: Init / Uninit the TDP MMU

2020-09-30 Thread Paolo Bonzini
On 30/09/20 18:57, Sean Christopherson wrote: >> + >> +static bool __read_mostly tdp_mmu_enabled = true; >> +module_param_named(tdp_mmu, tdp_mmu_enabled, bool, 0644); > This param should not exist until the TDP MMU is fully functional, e.g. > running > KVM against "kvm: mmu: Support zapping SPTEs

Re: [PATCH 03/22] kvm: mmu: Init / Uninit the TDP MMU

2020-09-30 Thread Sean Christopherson
On Fri, Sep 25, 2020 at 02:22:43PM -0700, Ben Gardon wrote: > diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c > new file mode 100644 > index 0..8241e18c111e6 > --- /dev/null > +++ b/arch/x86/kvm/mmu/tdp_mmu.c > @@ -0,0 +1,34 @@ > +/* SPDX-License-Identifier:

Re: [PATCH 03/22] kvm: mmu: Init / Uninit the TDP MMU

2020-09-29 Thread Sean Christopherson
Nit on all the shortlogs, can you use "KVM: x86/mmu" instead of "kvm: mmu"? On Fri, Sep 25, 2020 at 02:22:43PM -0700, Ben Gardon wrote: > diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c > new file mode 100644 > index 0..8241e18c111e6 > --- /dev/null > +++

Re: [PATCH 03/22] kvm: mmu: Init / Uninit the TDP MMU

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > +static bool __read_mostly tdp_mmu_enabled = true; > +module_param_named(tdp_mmu, tdp_mmu_enabled, bool, 0644); > + This would need some custom callbacks to avoid the warning in is_tdp_mmu_enabled(). Paolo

[PATCH 03/22] kvm: mmu: Init / Uninit the TDP MMU

2020-09-25 Thread Ben Gardon
The TDP MMU offers an alternative mode of operation to the x86 shadow paging based MMU, optimized for running an L1 guest with TDP. The TDP MMU will require new fields that need to be initialized and torn down. Add hooks into the existing KVM MMU initialization process to do that initialization /