Re: [PATCH 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-29 Thread Azael Avalos
Hi Darren, 2016-08-28 10:56 GMT-06:00 Darren Hart : > On Tue, Aug 16, 2016 at 12:06:16PM -0600, Azael Avalos wrote: >> Currently the success/error checking logic is intermixed, making the >> code a bit cumbersome to understand. >> >> This patch changes the affected functions to first check for err

Re: [PATCH 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-28 Thread Darren Hart
On Tue, Aug 16, 2016 at 12:06:16PM -0600, Azael Avalos wrote: > Currently the success/error checking logic is intermixed, making the > code a bit cumbersome to understand. > > This patch changes the affected functions to first check for errors > and take appropriate actions, then check for the sup

[PATCH 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-16 Thread Azael Avalos
Currently the success/error checking logic is intermixed, making the code a bit cumbersome to understand. This patch changes the affected functions to first check for errors and take appropriate actions, then check for the supported features. This patch also separates the error check from the acp