Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-11 Thread Joe Perches
On Wed, 2018-04-11 at 07:39 +0100, Al Viro wrote: > Shit happens... > > Al, fully expecting to discover having made something spectacularly bonehead > 2 minutes after sending a patch out - happens often enough. I've done that. Again, no worries.

Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-11 Thread Joe Perches
On Wed, 2018-04-11 at 07:39 +0100, Al Viro wrote: > Shit happens... > > Al, fully expecting to discover having made something spectacularly bonehead > 2 minutes after sending a patch out - happens often enough. I've done that. Again, no worries.

Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-11 Thread Al Viro
On Tue, Apr 10, 2018 at 11:15:28PM -0700, Joe Perches wrote: > On Tue, 2018-04-10 at 17:51 -0700, Kees Cook wrote: > > On Tue, Apr 10, 2018 at 5:33 PM, Al Viro wrote: > > > On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote: > > > > As part of the effort to

Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-11 Thread Al Viro
On Tue, Apr 10, 2018 at 11:15:28PM -0700, Joe Perches wrote: > On Tue, 2018-04-10 at 17:51 -0700, Kees Cook wrote: > > On Tue, Apr 10, 2018 at 5:33 PM, Al Viro wrote: > > > On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote: > > > > As part of the effort to remove VLAs from the

Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-11 Thread Joe Perches
On Tue, 2018-04-10 at 17:51 -0700, Kees Cook wrote: > On Tue, Apr 10, 2018 at 5:33 PM, Al Viro wrote: > > On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote: > > > As part of the effort to remove VLAs from the kernel[1], this changes > > > the allocation of the

Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-11 Thread Joe Perches
On Tue, 2018-04-10 at 17:51 -0700, Kees Cook wrote: > On Tue, Apr 10, 2018 at 5:33 PM, Al Viro wrote: > > On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote: > > > As part of the effort to remove VLAs from the kernel[1], this changes > > > the allocation of the bhs and pages arrays from

Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-10 Thread Kees Cook
On Tue, Apr 10, 2018 at 5:33 PM, Al Viro wrote: > On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote: >> As part of the effort to remove VLAs from the kernel[1], this changes >> the allocation of the bhs and pages arrays from being on the stack to being >>

Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-10 Thread Kees Cook
On Tue, Apr 10, 2018 at 5:33 PM, Al Viro wrote: > On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote: >> As part of the effort to remove VLAs from the kernel[1], this changes >> the allocation of the bhs and pages arrays from being on the stack to being >> kcalloc()ed. This also allows

Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-10 Thread Al Viro
On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote: > As part of the effort to remove VLAs from the kernel[1], this changes > the allocation of the bhs and pages arrays from being on the stack to being > kcalloc()ed. This also allows for the removal of the explicit zeroing > of bhs. > >

Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-10 Thread Al Viro
On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote: > As part of the effort to remove VLAs from the kernel[1], this changes > the allocation of the bhs and pages arrays from being on the stack to being > kcalloc()ed. This also allows for the removal of the explicit zeroing > of bhs. > >

[PATCH v3] isofs compress: Remove VLA usage

2018-04-10 Thread Kyle Spiers
As part of the effort to remove VLAs from the kernel[1], this changes the allocation of the bhs and pages arrays from being on the stack to being kcalloc()ed. This also allows for the removal of the explicit zeroing of bhs. https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Kyle Spiers

[PATCH v3] isofs compress: Remove VLA usage

2018-04-10 Thread Kyle Spiers
As part of the effort to remove VLAs from the kernel[1], this changes the allocation of the bhs and pages arrays from being on the stack to being kcalloc()ed. This also allows for the removal of the explicit zeroing of bhs. https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Kyle Spiers --- Fixed