Re: [Skiboot] [PATCH] opal/hmi: Wakeup the cpu before reading core_fir

2018-08-23 Thread Vaibhav Jain
Thanks for reviewing this patch Nick Nicholas Piggin writes: > > Would it be feasible to enumerate the ranges of scoms that require > special wakeup and check for those in xscom_read/write, and warn if > spwkup was not set? > I think that might be racy (Vaidy please correct if I am wrong) as a co

Re: [Skiboot] [PATCH] opal/hmi: Wakeup the cpu before reading core_fir

2018-08-20 Thread Nicholas Piggin
On Mon, 20 Aug 2018 19:36:05 +0530 Vaibhav Jain wrote: > When stop state 5 is enabled, reading the core_fir during an HMI can > result in a xscom read error with xscom_read() returning the > OPAL_XSCOM_PARTIAL_GOOD error code and core_fir value of all FFs. At > present this return error code is n