RE: [PATCH 1/3] gpio: sch: Consolidate similar algorithms

2014-09-23 Thread Chang, Rebecca Swee Fun
nt: 18 September, 2014 7:17 PM > > > To: Chang, Rebecca Swee Fun > > > Cc: Linus Walleij; linux-g...@vger.kernel.org; > > > linux-kernel@vger.kernel.org > > > Subject: Re: [PATCH 1/3] gpio: sch: Consolidate similar algorithms > > > > > >

Re: [PATCH 1/3] gpio: sch: Consolidate similar algorithms

2014-09-24 Thread 'Mika Westerberg'
On Wed, Sep 24, 2014 at 12:55:07AM +, Chang, Rebecca Swee Fun wrote: > > > The register values are required when it comes to IRQ handling. By > > > passing in the registers values, we can make full use of the > > > algorithms without introducing extra/similar algorithms to compute > > > other r

Re: [PATCH 1/3] gpio: sch: Consolidate similar algorithms

2014-09-18 Thread Mika Westerberg
On Wed, Sep 17, 2014 at 04:49:03PM +0800, Chang Rebecca Swee Fun wrote: > Consolidating similar algorithms into common functions to make > GPIO SCH simpler and manageable. > > Signed-off-by: Chang Rebecca Swee Fun > --- > drivers/gpio/gpio-sch.c | 95 > ++--

RE: [PATCH 1/3] gpio: sch: Consolidate similar algorithms

2014-09-21 Thread Chang, Rebecca Swee Fun
Replied inline. :) > -Original Message- > From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com] > Sent: 18 September, 2014 7:17 PM > To: Chang, Rebecca Swee Fun > Cc: Linus Walleij; linux-g...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PA

Re: [PATCH 1/3] gpio: sch: Consolidate similar algorithms

2014-09-22 Thread 'Mika Westerberg'
> > Cc: Linus Walleij; linux-g...@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH 1/3] gpio: sch: Consolidate similar algorithms > > > > On Wed, Sep 17, 2014 at 04:49:03PM +0800, Chang Rebecca Swee Fun wrote: > > > Consolidating similar algo

RE: [PATCH 1/3] gpio: sch: Consolidate similar algorithms

2014-09-25 Thread Chang, Rebecca Swee Fun
> -Original Message- > From: 'Mika Westerberg' [mailto:mika.westerb...@linux.intel.com] > Sent: 24 September, 2014 5:51 PM > To: Chang, Rebecca Swee Fun > Cc: Linus Walleij; linux-g...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/3] gp