Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-22 Thread Edward Chron
On Wed, Aug 21, 2019 at 12:19 AM David Rientjes wrote: > > On Wed, 21 Aug 2019, Michal Hocko wrote: > > > > vm.oom_dump_tasks is pretty useful, however, so it's curious why you > > > haven't left it enabled :/ > > > > Because it generates a lot of output potentially. Think of a workload > > with

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-22 Thread Edward Chron
On Thu, Aug 22, 2019 at 12:09 AM Michal Hocko wrote: > > On Wed 21-08-19 15:25:13, Edward Chron wrote: > > On Tue, Aug 20, 2019 at 8:25 PM David Rientjes wrote: > > > > > > On Tue, 20 Aug 2019, Edward Chron wrote: > > > > > > > For an OOM event: print oom_score_adj value for the OOM Killed

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-22 Thread Edward Chron
On Thu, Aug 22, 2019 at 12:21 AM Michal Hocko wrote: > > On Wed 21-08-19 16:12:08, Edward Chron wrote: > [...] > > Additionally (which you know, but mentioning for reference) the OOM > > output used to look like this: > > > > Nov 14 15:23:48 oldserver kernel: [337631.991218] Out of memory: Kill >

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-22 Thread Edward Chron
On Thu, Aug 22, 2019 at 12:15 AM Michal Hocko wrote: > > On Wed 21-08-19 15:22:07, Edward Chron wrote: > > On Wed, Aug 21, 2019 at 12:19 AM David Rientjes wrote: > > > > > > On Wed, 21 Aug 2019, Michal Hocko wrote: > > > > > > > > vm.oom_dump_tasks is pretty useful, however, so it's curious why

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-22 Thread Michal Hocko
On Wed 21-08-19 16:12:08, Edward Chron wrote: [...] > Additionally (which you know, but mentioning for reference) the OOM > output used to look like this: > > Nov 14 15:23:48 oldserver kernel: [337631.991218] Out of memory: Kill > process 19961 (python) score 17 or sacrifice child > Nov 14

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-22 Thread Michal Hocko
On Wed 21-08-19 15:22:07, Edward Chron wrote: > On Wed, Aug 21, 2019 at 12:19 AM David Rientjes wrote: > > > > On Wed, 21 Aug 2019, Michal Hocko wrote: > > > > > > vm.oom_dump_tasks is pretty useful, however, so it's curious why you > > > > haven't left it enabled :/ > > > > > > Because it

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-22 Thread Michal Hocko
On Wed 21-08-19 15:25:13, Edward Chron wrote: > On Tue, Aug 20, 2019 at 8:25 PM David Rientjes wrote: > > > > On Tue, 20 Aug 2019, Edward Chron wrote: > > > > > For an OOM event: print oom_score_adj value for the OOM Killed process to > > > document what the oom score adjust value was at the time

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-21 Thread Edward Chron
On Wed, Aug 21, 2019 at 12:47 AM Michal Hocko wrote: > > On Wed 21-08-19 00:19:37, David Rientjes wrote: > > On Wed, 21 Aug 2019, Michal Hocko wrote: > > > > > > vm.oom_dump_tasks is pretty useful, however, so it's curious why you > > > > haven't left it enabled :/ > > > > > > Because it

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-21 Thread Edward Chron
On Tue, Aug 20, 2019 at 8:25 PM David Rientjes wrote: > > On Tue, 20 Aug 2019, Edward Chron wrote: > > > For an OOM event: print oom_score_adj value for the OOM Killed process to > > document what the oom score adjust value was at the time the process was > > OOM Killed. The adjustment value can

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-21 Thread Edward Chron
On Wed, Aug 21, 2019 at 12:19 AM David Rientjes wrote: > > On Wed, 21 Aug 2019, Michal Hocko wrote: > > > > vm.oom_dump_tasks is pretty useful, however, so it's curious why you > > > haven't left it enabled :/ > > > > Because it generates a lot of output potentially. Think of a workload > > with

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-21 Thread Edward Chron
Good point, I can post this with your correction. I will add your Acked-by: David Rientjes I am adding your Acked-by to the revised patch as this is what Michal asked me to do (so I assume that is what I should do). Should I post as a separate fix again or simply post here? I'll post here and

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-21 Thread Michal Hocko
On Wed 21-08-19 00:19:37, David Rientjes wrote: > On Wed, 21 Aug 2019, Michal Hocko wrote: > > > > vm.oom_dump_tasks is pretty useful, however, so it's curious why you > > > haven't left it enabled :/ > > > > Because it generates a lot of output potentially. Think of a workload > > with too

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-21 Thread David Rientjes
On Wed, 21 Aug 2019, Michal Hocko wrote: > > vm.oom_dump_tasks is pretty useful, however, so it's curious why you > > haven't left it enabled :/ > > Because it generates a lot of output potentially. Think of a workload > with too many tasks which is not uncommon. Probably better to always

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-21 Thread Michal Hocko
On Tue 20-08-19 20:25:32, David Rientjes wrote: > On Tue, 20 Aug 2019, Edward Chron wrote: > > > For an OOM event: print oom_score_adj value for the OOM Killed process to > > document what the oom score adjust value was at the time the process was > > OOM Killed. The adjustment value can be set

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-20 Thread David Rientjes
On Tue, 20 Aug 2019, Edward Chron wrote: > For an OOM event: print oom_score_adj value for the OOM Killed process to > document what the oom score adjust value was at the time the process was > OOM Killed. The adjustment value can be set by user code and it affects > the resulting oom_score so it